Github user hekonsek closed the pull request at:
https://github.com/apache/qpid-proton/pull/65
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user hekonsek commented on the pull request:
https://github.com/apache/qpid-proton/pull/65#issuecomment-206744093
Done :) .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/65#issuecomment-206491900
@hekonsek could you close this pull request now, as it is no longer for
consideration.
---
If your project is set up for it, you can reply to this email and have
Github user hekonsek commented on the pull request:
https://github.com/apache/qpid-proton/pull/65#issuecomment-202500451
Hi,
Actually as vertx-proton API seems to favored over a messenger API, then
feel free to ignore this pull request. We will be using vertx-proton anyway.
Github user ssorj commented on the pull request:
https://github.com/apache/qpid-proton/pull/65#issuecomment-184352363
In previous discussion on APIs and bindings, we have said that we'd like to
use the language-native URL facilities if feasible.
---
If your project is set up for it,
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/65#issuecomment-184349901
I think that @alanconway has a good point.
Looking at the C implementation of the url decoder it doesn't seem to
expand the % escapes for the path, but as
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/65#issuecomment-184320477
I hadn't got round to looking at this closely but was likely just going to
apply it if nothing obvious came up, and probably wouldnt have considered the
above.
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/65#issuecomment-184307353
The problem is that the addresses used by proton are modelled on URLs, and
those characters are not safe in a URL path:
From RFC 1738 specification:
GitHub user hekonsek opened a pull request:
https://github.com/apache/qpid-proton/pull/65
Schema parsing should not be so greedy
Hi,
Current address schema parser doesn't work if `://` string is included in a
path. The reasons to include `://` in a path are as follows:
