Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote:
The tests are now running again, but a couple of the URL tests still seem
to be failing on the CI job:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/
They are all failing with:
Not a valid port number or service name: 'amqps'
Could this be a configuration problem on the CI machine, i.e. missing an
'amqps' entry in /etc/services? Can I get access to the CI machine to
poke around and see what's up?
The URL code uses socket.getservbyname() to look up service names. Is
there a more portable way to do it?
Cheers,
Alan.
As mentioned in my other post about a timeline for dropping Java6 support,
they seem to work on Java8 (havent tried Java7).
Robbie
On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote:
My bad, didn't run the java tests. Will fix ASAP and then give myself a
flogging.
On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote:
This seems to have broken the Java test runs:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/
On 19 September 2014 22:00, acon...@apache.org wrote:
Author: aconway
Date: Fri Sep 19 21:00:50 2014
New Revision: 1626329
URL: http://svn.apache.org/r1626329
Log:
PROTON-693: Python Url class to wrap C function pni_parse_url
It was pointed out that pni_parse_url is an internal function and the
interface
is not suitable for public API.
Rewrote the URL parser as a proper swigable C API pn_url_*. This gets
rid
of the
need for previous swig insanity and is cleaner all round.
Internally still uses the pni_parse_url parser, we can clean that up
later.
Added:
qpid/proton/trunk/proton-c/include/proton/url.h
qpid/proton/trunk/proton-c/src/url.c
Modified:
qpid/proton/trunk/proton-c/CMakeLists.txt
qpid/proton/trunk/proton-c/bindings/perl/perl.i
qpid/proton/trunk/proton-c/bindings/php/php.i
qpid/proton/trunk/proton-c/bindings/python/cproton.i
qpid/proton/trunk/proton-c/bindings/python/proton.py
qpid/proton/trunk/proton-c/bindings/ruby/ruby.i
qpid/proton/trunk/proton-c/include/proton/cproton.i
qpid/proton/trunk/tests/python/proton_tests/url.py
Modified: qpid/proton/trunk/proton-c/CMakeLists.txt
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/CMakeLists.txt (original)
+++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50 2014
@@ -270,6 +270,7 @@ set (qpid-proton-core
src/object/iterator.c
src/util.c
+ src/url.c
src/error.c
src/buffer.c
src/parser.c
Modified: qpid/proton/trunk/proton-c/bindings/perl/perl.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/perl/perl.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/perl/perl.i (original)
+++ qpid/proton/trunk/proton-c/bindings/perl/perl.i Fri Sep 19 21:00:50
2014
@@ -8,6 +8,7 @@
#include proton/messenger.h
#include proton/ssl.h
#include proton/driver_extras.h
+#include proton/url.h
%}
%include cstring.i
Modified: qpid/proton/trunk/proton-c/bindings/php/php.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/php/php.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/php/php.i (original)
+++ qpid/proton/trunk/proton-c/bindings/php/php.i Fri Sep 19 21:00:50
2014
@@ -29,6 +29,7 @@
%header %{
/* Include the headers needed by the code in this wrapper file */
#include proton/types.h
+#include proton/url.h
#include proton/message.h
#include proton/driver.h
#include proton/driver_extras.h
Modified: qpid/proton/trunk/proton-c/bindings/python/cproton.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/python/cproton.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/python/cproton.i (original)
+++ qpid/proton/trunk/proton-c/bindings/python/cproton.i Fri Sep 19
21:00:50 2014
@@ -23,6 +23,7 @@
#include winsock2.h
#endif
#include proton/engine.h
+#include proton/url.h
#include proton/message.h
#include proton/sasl.h
#include proton/driver.h
@@ -280,41 +281,4 @@ int pn_ssl_get_peer_hostname(pn_ssl_t *s
}
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote:
On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote:
The tests are now running again, but a couple of the URL tests still seem
to be failing on the CI job:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/
They are all failing with:
Not a valid port number or service name: 'amqps'
Could this be a configuration problem on the CI machine, i.e. missing an
'amqps' entry in /etc/services? Can I get access to the CI machine to
poke around and see what's up?
Almost certainly no, only the core maintainers are allowed shell access as
far as I've seen. You can ask on bui...@apache.org for those with access to
check things out and report back and see what happens.
I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For
giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the
tests, which failed, and it indeed has no amqp[s] entry in /etc/services
file so that could well be it.
The URL code uses socket.getservbyname() to look up service names. Is
there a more portable way to do it?
No idea I'm afraid.
Cheers,
Alan.
As mentioned in my other post about a timeline for dropping Java6
support,
they seem to work on Java8 (havent tried Java7).
Robbie
On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote:
My bad, didn't run the java tests. Will fix ASAP and then give myself a
flogging.
On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote:
This seems to have broken the Java test runs:
https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/
On 19 September 2014 22:00, acon...@apache.org wrote:
Author: aconway
Date: Fri Sep 19 21:00:50 2014
New Revision: 1626329
URL: http://svn.apache.org/r1626329
Log:
PROTON-693: Python Url class to wrap C function pni_parse_url
It was pointed out that pni_parse_url is an internal function and
the
interface
is not suitable for public API.
Rewrote the URL parser as a proper swigable C API pn_url_*. This
gets
rid
of the
need for previous swig insanity and is cleaner all round.
Internally still uses the pni_parse_url parser, we can clean that
up
later.
Added:
qpid/proton/trunk/proton-c/include/proton/url.h
qpid/proton/trunk/proton-c/src/url.c
Modified:
qpid/proton/trunk/proton-c/CMakeLists.txt
qpid/proton/trunk/proton-c/bindings/perl/perl.i
qpid/proton/trunk/proton-c/bindings/php/php.i
qpid/proton/trunk/proton-c/bindings/python/cproton.i
qpid/proton/trunk/proton-c/bindings/python/proton.py
qpid/proton/trunk/proton-c/bindings/ruby/ruby.i
qpid/proton/trunk/proton-c/include/proton/cproton.i
qpid/proton/trunk/tests/python/proton_tests/url.py
Modified: qpid/proton/trunk/proton-c/CMakeLists.txt
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/CMakeLists.txt (original)
+++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50
2014
@@ -270,6 +270,7 @@ set (qpid-proton-core
src/object/iterator.c
src/util.c
+ src/url.c
src/error.c
src/buffer.c
src/parser.c
Modified: qpid/proton/trunk/proton-c/bindings/perl/perl.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/perl/perl.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/perl/perl.i (original)
+++ qpid/proton/trunk/proton-c/bindings/perl/perl.i Fri Sep 19
21:00:50
2014
@@ -8,6 +8,7 @@
#include proton/messenger.h
#include proton/ssl.h
#include proton/driver_extras.h
+#include proton/url.h
%}
%include cstring.i
Modified: qpid/proton/trunk/proton-c/bindings/php/php.i
URL:
http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/php/php.i?rev=1626329r1=1626328r2=1626329view=diff
==
--- qpid/proton/trunk/proton-c/bindings/php/php.i (original)
+++ qpid/proton/trunk/proton-c/bindings/php/php.i Fri Sep 19
21:00:50
2014
@@ -29,6 +29,7 @@
%header %{
/* Include the headers needed by the code in this wrapper file */
#include proton/types.h
+#include proton/url.h
#include proton/message.h
#include proton/driver.h
#include proton/driver_extras.h
Modified:
[jira] [Created] (PROTON-698) ClassCastException occurs when testing equality of Binary instance against a different type of Object
Robbie Gemmell created PROTON-698: - Summary: ClassCastException occurs when testing equality of Binary instance against a different type of Object Key: PROTON-698 URL: https://issues.apache.org/jira/browse/PROTON-698 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.7 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.8 If you call equals on a Binary instance with another type of Object, a ClassCastException results because Binary#equals(..) does an unchecked cast. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-698) ClassCastException occurs when testing equality of Binary instance against a different type of Object
[ https://issues.apache.org/jira/browse/PROTON-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147941#comment-14147941 ] ASF subversion and git services commented on PROTON-698: Commit 1627570 from [~gemmellr] in branch 'proton/trunk' [ https://svn.apache.org/r1627570 ] PROTON-698: return false if given object class differs, and shortcut equality of the object with itself ClassCastException occurs when testing equality of Binary instance against a different type of Object - Key: PROTON-698 URL: https://issues.apache.org/jira/browse/PROTON-698 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.7 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.8 If you call equals on a Binary instance with another type of Object, a ClassCastException results because Binary#equals(..) does an unchecked cast. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-698) ClassCastException occurs when testing equality of Binary instance against a different type of Object
[ https://issues.apache.org/jira/browse/PROTON-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-698. --- Resolution: Fixed ClassCastException occurs when testing equality of Binary instance against a different type of Object - Key: PROTON-698 URL: https://issues.apache.org/jira/browse/PROTON-698 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.7 Reporter: Robbie Gemmell Assignee: Robbie Gemmell Fix For: 0.8 If you call equals on a Binary instance with another type of Object, a ClassCastException results because Binary#equals(..) does an unchecked cast. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i qpid/proton/trunk/proton-c/bindings/python/cproton.i qpid/proton/trunk/proton-c/bindings/python/proton.py qpid/proton/trunk/proton-c/bindings/ruby/ruby.i qpid/proton/trunk/proton-c/include/proton/cproton.i qpid/proton/trunk/tests/python/proton_tests/url.py Modified: qpid/proton/trunk/proton-c/CMakeLists.txt URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff == --- qpid/proton/trunk/proton-c/CMakeLists.txt (original) +++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50 2014 @@ -270,6 +270,7 @@ set (qpid-proton-core src/object/iterator.c src/util.c + src/url.c src/error.c src/buffer.c src/parser.c Modified: qpid/proton/trunk/proton-c/bindings/perl/perl.i URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/bindings/perl/perl.i?rev=1626329r1=1626328r2=1626329view=diff == --- qpid/proton/trunk/proton-c/bindings/perl/perl.i (original) +++ qpid/proton/trunk/proton-c/bindings/perl/perl.i Fri Sep 19 21:00:50 2014 @@ -8,6 +8,7 @@ #include proton/messenger.h #include proton/ssl.h #include proton/driver_extras.h +#include proton/url.h %} %include cstring.i
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
Failing in a different way now, the overall run of the python tests bombs out. I see the same thing locally, where it was working when I made the commit immediately before yours :) https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/683/console Running org.apache.qpid.proton.JythonTest Sep 25, 2014 6:03:44 PM org.apache.qpid.proton.JythonTest test INFO: About to call Jython test script: '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test' with '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python' added to Jython path Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.714 sec FAILURE! test(org.apache.qpid.proton.JythonTest) Time elapsed: 7.675 sec FAILURE! java.lang.AssertionError: Caught PyException on invocation number 2: Traceback (most recent call last): File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 597, in module h.scan(m) File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 587, in scan if not (child in self.scanned or child in objects): TypeError: object of type 'object' has no len() with message: null at org.junit.Assert.fail(Assert.java:93) at org.apache.qpid.proton.JythonTest.runTestOnce(JythonTest.java:120) at org.apache.qpid.proton.JythonTest.test(JythonTest.java:95) On 25 September 2014 18:59, Alan Conway acon...@redhat.com wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i
[jira] [Updated] (PROTON-660) Fix openssl.c build on windows
[ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bozo Dragojevic updated PROTON-660: --- Attachment: (was: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch) Fix openssl.c build on windows -- Key: PROTON-660 URL: https://issues.apache.org/jira/browse/PROTON-660 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows 7, VS2013 Reporter: Bozo Dragojevic Attachments: 25_openssl_fix_for_windows_CMakeLists.patch, 25_openssl_fix_for_windows_data.h.patch, 25_openssl_fix_for_windows_platform.h.patch Compiled openssl-1.0.1i from source Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-660) Fix openssl.c build on windows
[ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bozo Dragojevic updated PROTON-660: --- Attachment: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch The proposed patch that fixes openssl build by mostly just reshuffling include file order Fix openssl.c build on windows -- Key: PROTON-660 URL: https://issues.apache.org/jira/browse/PROTON-660 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows 7, VS2013 Reporter: Bozo Dragojevic Attachments: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch, 25_openssl_fix_for_windows_CMakeLists.patch, 25_openssl_fix_for_windows_data.h.patch, 25_openssl_fix_for_windows_platform.h.patch Compiled openssl-1.0.1i from source Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Updated] (PROTON-660) Fix openssl.c build on windows
Can somebody help me with the reviewboard, please? I wanted to stuff this patch to reviewboard, but it gets rejected with: The specified diff file could not be parsed. Line 19: No valid separator after the filename was found in the diff header I selected repository 'qpid' I uploaded the patch below I selected base directory /proton/trunk (I have also tried /qpid/proton/trunk with same effect) fwiw, I'm doing this from a mac using chrome Bozzo On 25. 09. 14 20:44, Bozo Dragojevic (JIRA) wrote: [ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bozo Dragojevic updated PROTON-660: --- Attachment: (was: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch) Fix openssl.c build on windows -- Key: PROTON-660 URL: https://issues.apache.org/jira/browse/PROTON-660 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows 7, VS2013 Reporter: Bozo Dragojevic Attachments: 25_openssl_fix_for_windows_CMakeLists.patch, 25_openssl_fix_for_windows_data.h.patch, 25_openssl_fix_for_windows_platform.h.patch Compiled openssl-1.0.1i from source Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Updated] (PROTON-660) Fix openssl.c build on windows
As a workaround, I've applied the patch to a svn checkout and uploaded svn diff. That works, but is a bit clumsy... Bozzo On 25. 09. 14 20:50, Bozo Dragojevic wrote: Can somebody help me with the reviewboard, please? I wanted to stuff this patch to reviewboard, but it gets rejected with: The specified diff file could not be parsed. Line 19: No valid separator after the filename was found in the diff header I selected repository 'qpid' I uploaded the patch below I selected base directory /proton/trunk (I have also tried /qpid/proton/trunk with same effect) fwiw, I'm doing this from a mac using chrome Bozzo On 25. 09. 14 20:44, Bozo Dragojevic (JIRA) wrote: [ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bozo Dragojevic updated PROTON-660: --- Attachment: (was: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch) Fix openssl.c build on windows -- Key: PROTON-660 URL: https://issues.apache.org/jira/browse/PROTON-660 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows 7, VS2013 Reporter: Bozo Dragojevic Attachments: 25_openssl_fix_for_windows_CMakeLists.patch, 25_openssl_fix_for_windows_data.h.patch, 25_openssl_fix_for_windows_platform.h.patch Compiled openssl-1.0.1i from source Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
Hum, CI is still broken. https://builds.apache.org/job/Qpid-proton-j/org.apache.qpid $proton-tests/683/testReport/org.apache.qpid.proton/JythonTest/test/ Somehow my trivial re-org of the URL tests in python has caused the entire Jython test harness to explode in flight. It works fine on my box in python and Jython, and it works on CI in regular python - so maybe another Java 6 issue? Will I lose my mind if I try to install Java 6 on Fedora and get proton to use it? On Thu, 2014-09-25 at 13:59 -0400, Alan Conway wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i qpid/proton/trunk/proton-c/bindings/python/cproton.i qpid/proton/trunk/proton-c/bindings/python/proton.py qpid/proton/trunk/proton-c/bindings/ruby/ruby.i qpid/proton/trunk/proton-c/include/proton/cproton.i qpid/proton/trunk/tests/python/proton_tests/url.py Modified: qpid/proton/trunk/proton-c/CMakeLists.txt URL: http://svn.apache.org/viewvc/qpid/proton/trunk/proton-c/CMakeLists.txt?rev=1626329r1=1626328r2=1626329view=diff == --- qpid/proton/trunk/proton-c/CMakeLists.txt (original) +++ qpid/proton/trunk/proton-c/CMakeLists.txt Fri Sep 19 21:00:50 2014 @@ -270,6 +270,7 @@ set (qpid-proton-core src/object/iterator.c src/util.c + src/url.c src/error.c src/buffer.c src/parser.c
[jira] [Commented] (PROTON-660) Fix openssl.c build on windows
[ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148148#comment-14148148 ] Bozo Dragojevic commented on PROTON-660: https://reviews.apache.org/r/26050/ Fix openssl.c build on windows -- Key: PROTON-660 URL: https://issues.apache.org/jira/browse/PROTON-660 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows 7, VS2013 Reporter: Bozo Dragojevic Attachments: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch, 25_openssl_fix_for_windows_CMakeLists.patch, 25_openssl_fix_for_windows_data.h.patch, 25_openssl_fix_for_windows_platform.h.patch Compiled openssl-1.0.1i from source Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-699) Messenger installed examples send,recv do not compile
Chuck Rolke created PROTON-699: -- Summary: Messenger installed examples send,recv do not compile Key: PROTON-699 URL: https://issues.apache.org/jira/browse/PROTON-699 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.7 Environment: Windows and Linux Reporter: Chuck Rolke The cmake packaging of the install directory install/proton/examples/messenger collapses the files from /pncompat/internal into /pncompat. Folder /pncompat/internal is absent. Compiles fails since the sources use '#include internal/getopt.h' and the file is not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-699) Messenger installed examples send,recv do not compile
[ https://issues.apache.org/jira/browse/PROTON-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148169#comment-14148169 ] ASF subversion and git services commented on PROTON-699: Commit 1627595 from c...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1627595 ] PROTON-699: Messenger installed examples send,recv do not compile. Keep pncompat internal folder structure. Messenger installed examples send,recv do not compile - Key: PROTON-699 URL: https://issues.apache.org/jira/browse/PROTON-699 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.7 Environment: Windows and Linux Reporter: Chuck Rolke The cmake packaging of the install directory install/proton/examples/messenger collapses the files from /pncompat/internal into /pncompat. Folder /pncompat/internal is absent. Compiles fails since the sources use '#include internal/getopt.h' and the file is not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-699) Messenger installed examples send,recv do not compile
[ https://issues.apache.org/jira/browse/PROTON-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke resolved PROTON-699. Resolution: Fixed Fix Version/s: 0.8 Trivial fix in top level cmake. Messenger installed examples send,recv do not compile - Key: PROTON-699 URL: https://issues.apache.org/jira/browse/PROTON-699 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.7 Environment: Windows and Linux Reporter: Chuck Rolke Fix For: 0.8 The cmake packaging of the install directory install/proton/examples/messenger collapses the files from /pncompat/internal into /pncompat. Folder /pncompat/internal is absent. Compiles fails since the sources use '#include internal/getopt.h' and the file is not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
This is also failing for me when I run the entire mvn install (after a mvn clean).. it's not just on the CI for me On Sep 25, 2014, at 2:20 PM, Robbie Gemmell robbie.gemm...@gmail.com wrote: Failing in a different way now, the overall run of the python tests bombs out. I see the same thing locally, where it was working when I made the commit immediately before yours :) https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/683/console Running org.apache.qpid.proton.JythonTest Sep 25, 2014 6:03:44 PM org.apache.qpid.proton.JythonTest test INFO: About to call Jython test script: '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test' with '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python' added to Jython path Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.714 sec FAILURE! test(org.apache.qpid.proton.JythonTest) Time elapsed: 7.675 sec FAILURE! java.lang.AssertionError: Caught PyException on invocation number 2: Traceback (most recent call last): File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 597, in module h.scan(m) File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 587, in scan if not (child in self.scanned or child in objects): TypeError: object of type 'object' has no len() with message: null at org.junit.Assert.fail(Assert.java:93) at org.apache.qpid.proton.JythonTest.runTestOnce(JythonTest.java:120) at org.apache.qpid.proton.JythonTest.test(JythonTest.java:95) On 25 September 2014 18:59, Alan Conway acon...@redhat.com wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i qpid/proton/trunk/proton-c/bindings/python/cproton.i
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
On Thu, 2014-09-25 at 19:20 +0100, Robbie Gemmell wrote: Failing in a different way now, the overall run of the python tests bombs out. I see the same thing locally, where it was working when I made the commit immediately before yours :) r1627621 | aconway | 2014-09-25 15:40:22 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to not explode under jython. Turns out the proton test harness blows up when run under jython if you import socket in a test module. Works fine under real python. Go figure. https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/683/console Running org.apache.qpid.proton.JythonTest Sep 25, 2014 6:03:44 PM org.apache.qpid.proton.JythonTest test INFO: About to call Jython test script: '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test' with '/home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python' added to Jython path Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 7.714 sec FAILURE! test(org.apache.qpid.proton.JythonTest) Time elapsed: 7.675 sec FAILURE! java.lang.AssertionError: Caught PyException on invocation number 2: Traceback (most recent call last): File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 597, in module h.scan(m) File /home/jenkins/jenkins-slave/workspace/Qpid-proton-j/trunk/tests/python/proton-test, line 587, in scan if not (child in self.scanned or child in objects): TypeError: object of type 'object' has no len() with message: null at org.junit.Assert.fail(Assert.java:93) at org.apache.qpid.proton.JythonTest.runTestOnce(JythonTest.java:120) at org.apache.qpid.proton.JythonTest.test(JythonTest.java:95) On 25 September 2014 18:59, Alan Conway acon...@redhat.com wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API.
[jira] [Created] (PROTON-700) small performance improvement from inling one fn.
michael goulish created PROTON-700: -- Summary: small performance improvement from inling one fn. Key: PROTON-700 URL: https://issues.apache.org/jira/browse/PROTON-700 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: michael goulish Assignee: michael goulish Priority: Minor inlining the internal function pn_data_node() improves speed somewhere between 2.6% and 6%, depending on architecture. This is based on testing I did with two C-based clients written at the engine interface level. The higher 6% figure was seen on a more modern machine with recent Intel processors, the lower figure was seen on an older box with AMD processors. But the effect is real: after 5- repetition before the change 50 after, T-test indicates odds of this happening by chance is 2.0e-18 . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-700) small performance improvement from inling one fn.
[ https://issues.apache.org/jira/browse/PROTON-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14148234#comment-14148234 ] ASF subversion and git services commented on PROTON-700: Commit 1627642 from [~mgoulish] in branch 'proton/trunk' [ https://svn.apache.org/r1627642 ] PROTON-700 : small performance improvement from inlining pn_data_node(). This is a very popular function. improvement on newer box was 6% , on older box 2.6% t-test after 50 reps before after says odd of the 2.6% figure happening by chance is 2.0e-18 . small performance improvement from inling one fn. - Key: PROTON-700 URL: https://issues.apache.org/jira/browse/PROTON-700 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: michael goulish Assignee: michael goulish Priority: Minor inlining the internal function pn_data_node() improves speed somewhere between 2.6% and 6%, depending on architecture. This is based on testing I did with two C-based clients written at the engine interface level. The higher 6% figure was seen on a more modern machine with recent Intel processors, the lower figure was seen on an older box with AMD processors. But the effect is real: after 5- repetition before the change 50 after, T-test indicates odds of this happening by chance is 2.0e-18 . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-660) Fix openssl.c build on windows
[ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-660: --- Assignee: Andrew Stitcher Fix openssl.c build on windows -- Key: PROTON-660 URL: https://issues.apache.org/jira/browse/PROTON-660 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows 7, VS2013 Reporter: Bozo Dragojevic Assignee: Andrew Stitcher Attachments: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch, 25_openssl_fix_for_windows_CMakeLists.patch, 25_openssl_fix_for_windows_data.h.patch, 25_openssl_fix_for_windows_platform.h.patch Compiled openssl-1.0.1i from source Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-660) Fix openssl.c build on windows
[ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-660: --- Fix Version/s: 0.8 Fix openssl.c build on windows -- Key: PROTON-660 URL: https://issues.apache.org/jira/browse/PROTON-660 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Environment: Windows 7, VS2013 Reporter: Bozo Dragojevic Assignee: Andrew Stitcher Fix For: 0.8 Attachments: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch, 25_openssl_fix_for_windows_CMakeLists.patch, 25_openssl_fix_for_windows_data.h.patch, 25_openssl_fix_for_windows_platform.h.patch Compiled openssl-1.0.1i from source Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: svn commit: r1626329 - in /qpid/proton/trunk: proton-c/ proton-c/bindings/perl/ proton-c/bindings/php/ proton-c/bindings/python/ proton-c/bindings/ruby/ proton-c/include/proton/ proton-c/src/ test
Sorry, I had gone out by the time you mailed. I wasn't clear in my earlier mail in that the local test I did was just in my normal env using Java8, not the old one I dug out using Java 6. Installing an old version of Java is easy enough though. I see you have fixed it and it wasnt related to the Java version in the end anyway :) Robbie On 25 September 2014 19:58, Alan Conway acon...@redhat.com wrote: Hum, CI is still broken. https://builds.apache.org/job/Qpid-proton-j/org.apache.qpid $proton-tests/683/testReport/org.apache.qpid.proton/JythonTest/test/ Somehow my trivial re-org of the URL tests in python has caused the entire Jython test harness to explode in flight. It works fine on my box in python and Jython, and it works on CI in regular python - so maybe another Java 6 issue? Will I lose my mind if I try to install Java 6 on Fedora and get proton to use it? On Thu, 2014-09-25 at 13:59 -0400, Alan Conway wrote: On Thu, 2014-09-25 at 15:59 +0100, Robbie Gemmell wrote: On 25 September 2014 15:00, Alan Conway acon...@redhat.com wrote: On Wed, 2014-09-24 at 12:19 +0100, Robbie Gemmell wrote: The tests are now running again, but a couple of the URL tests still seem to be failing on the CI job: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/lastBuild/org.apache.qpid$proton-tests/testReport/ They are all failing with: Not a valid port number or service name: 'amqps' Could this be a configuration problem on the CI machine, i.e. missing an 'amqps' entry in /etc/services? Can I get access to the CI machine to poke around and see what's up? Almost certainly no, only the core maintainers are allowed shell access as far as I've seen. You can ask on bui...@apache.org for those with access to check things out and report back and see what happens. I think the CI instances will be running Ubuntu 12.04 or 14.04 LTS. For giggles, I dug out an old Ubuntu VM with Java 6 on it and tried the tests, which failed, and it indeed has no amqp[s] entry in /etc/services file so that could well be it. Thanks for checking that out! I have hacked the tests to skip tests for 'amqps' if it is not recognized. Poke me if there are still failures. r1627577 | aconway | 2014-09-25 13:59:17 -0400 (Thu, 25 Sep 2014) | 5 lines NO-JIRA: Fix URL test to skip 'amqps' tests if 'amqps' is not recognized as a service name. On some older Ubuntu with Java 6, 'amqps' is not recognized as a service name so skip those tests in that case. The URL code uses socket.getservbyname() to look up service names. Is there a more portable way to do it? No idea I'm afraid. Cheers, Alan. As mentioned in my other post about a timeline for dropping Java6 support, they seem to work on Java8 (havent tried Java7). Robbie On 22 September 2014 21:14, Alan Conway acon...@redhat.com wrote: My bad, didn't run the java tests. Will fix ASAP and then give myself a flogging. On Mon, 2014-09-22 at 19:50 +0100, Robbie Gemmell wrote: This seems to have broken the Java test runs: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/664/ On 19 September 2014 22:00, acon...@apache.org wrote: Author: aconway Date: Fri Sep 19 21:00:50 2014 New Revision: 1626329 URL: http://svn.apache.org/r1626329 Log: PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. Added: qpid/proton/trunk/proton-c/include/proton/url.h qpid/proton/trunk/proton-c/src/url.c Modified: qpid/proton/trunk/proton-c/CMakeLists.txt qpid/proton/trunk/proton-c/bindings/perl/perl.i qpid/proton/trunk/proton-c/bindings/php/php.i qpid/proton/trunk/proton-c/bindings/python/cproton.i qpid/proton/trunk/proton-c/bindings/python/proton.py qpid/proton/trunk/proton-c/bindings/ruby/ruby.i qpid/proton/trunk/proton-c/include/proton/cproton.i qpid/proton/trunk/tests/python/proton_tests/url.py Modified: qpid/proton/trunk/proton-c/CMakeLists.txt URL:
