[jira] [Commented] (PROTON-343) Add a pluggable Proton logging layer

2013-08-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743875#comment-13743875
 ] 

ASF subversion and git services commented on PROTON-343:


Commit 1515455 from [~philharveyonline] in branch 'proton/trunk'
[ https://svn.apache.org/r1515455 ]

PROTON-343: Removed proton-logging module and its usages (all of which are 
functionally insignificant),
so that the upcoming Proton 0.5 release does not contain this 
not-yet-prime-time module.

> Add a pluggable Proton logging layer
> 
>
> Key: PROTON-343
> URL: https://issues.apache.org/jira/browse/PROTON-343
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c, proton-j
>Reporter: Philip Harvey
>Assignee: Philip Harvey
> Attachments: 
> 0001-PROTON-343-sketched-out-the-Java-parts-of-the-propos.patch
>
>
> Applications that use Proton sometimes want Proton to produce logging.
> Goals
> 
> * Proton should provide a default logging implementation.
> * It should be easy for Proton client code to provide custom logging 
> implementation, e.g. one that uses the same third party logging framework as 
> their application code.
> * Proton should not have a compile-time dependency on a third party logging 
> framework
> * Proton's log output is considered to be part of its public interface.  
> Therefore, in the spirit of Proton's cross-language consistency goals, this 
> output should be consistent between proton-c and proton-j.
> * The goals that general-purpose logging frameworks try to meet - 
> performance, ease of use etc - also apply.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-408) [proton-c] Windows build does not put "d" suffix on debug file names

2013-08-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744116#comment-13744116
 ] 

ASF subversion and git services commented on PROTON-408:


Commit 1515559 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1515559 ]

PROTON-408: [proton-c] Windows build does not put "d" suffix on debug file names

> [proton-c] Windows build does not put "d" suffix on debug file names
> 
>
> Key: PROTON-408
> URL: https://issues.apache.org/jira/browse/PROTON-408
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
> Environment: Windows
>Reporter: Chuck Rolke
>
> Visual Studio projects by default put a "d" suffix on debug version file 
> names. This lets you have qpid-proton.dll and qpid-protond.dll in the same 
> directory making the files easier to integrate with user projects. Cmake 
> provides trivially easy support for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-407) [proton-c] Windows install does not install .lib nor .pdb files

2013-08-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744258#comment-13744258
 ] 

ASF subversion and git services commented on PROTON-407:


Commit 1515614 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1515614 ]

PROTON-407: [proton-c] Windows install does not install .lib nor .pdb files
This patch installs the .lib file(s) to the /bin directory.

> [proton-c] Windows install does not install .lib nor .pdb files
> ---
>
> Key: PROTON-407
> URL: https://issues.apache.org/jira/browse/PROTON-407
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
> Environment: Windows 
>Reporter: Chuck Rolke
>
> In current trunk building the INSTALL project in VS2010 does not place the 
> qpid-proton.lib, qpid-proton.pdb files into the install area. Consequently 
> consumers using an installed kit are unable to link to the qpid-proton 
> library.
> In a dev environment the files are available in the build area as expected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-406) Cmake build fails to find Ruby vendor location on some platforms

2013-08-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744916#comment-13744916
 ] 

ASF subversion and git services commented on PROTON-406:


Commit 1515795 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1515795 ]

PROTON-406: Fix installing the Ruby bindings.

Previously it checked for RUBY_VENDORLIB_DIR as provided by Cmake. But
this variable is not provided by older versions of CMake. Additionally,
older versions of Ruby did not provide a vendorlibdir. In those cases,
the behavior is to now get the Ruby sitearch dir instead.

> Cmake build fails to find Ruby vendor location on some platforms
> 
>
> Key: PROTON-406
> URL: https://issues.apache.org/jira/browse/PROTON-406
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>Priority: Critical
>
> Some versions of Cmake fail to provide the needed variables, such as 
> RUBY_VENDORLIB_DIR. In those cases, the Cmake file for Ruby needs to 
> determine the path itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-389) Messenger asserts if it receives a RELEASED disposition

2013-08-20 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13745102#comment-13745102
 ] 

ASF subversion and git services commented on PROTON-389:


Commit 1515860 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1515860 ]

PROTON-389: added all dispositions to switch statement

> Messenger asserts if it receives a RELEASED disposition
> ---
>
> Key: PROTON-389
> URL: https://issues.apache.org/jira/browse/PROTON-389
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
>Reporter: Ted Ross
>Priority: Blocker
> Fix For: 0.5
>
>
> If messenger receives a disposition update with RELEASED state, it throws an 
> assertion.
> python: .../proton/proton-c/src/messenger/store.c:295: disp2status: Assertion 
> `0' failed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-368) Calling pn_messenger_put with a message with no address causes a segmentation fault

2013-08-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746052#comment-13746052
 ] 

ASF subversion and git services commented on PROTON-368:


Commit 1516161 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1516161 ]

Added simple smoke tests for the bindings. Encountered numerous issues
along the way and fixed as appropriate, including:
  - added tracker return values for ruby put/get
  - fixed ruby accept/reject to omit the tracker arg
  - fixed a deprecation warning in the perl binding
  - added disposition calls for php (PROTON-365)
  - added incoming/outgoing window properties for php
  - fixed put of messages without an address (PROTON-368)
  - added C level inspection method for messages to allow consistent
printing of messages across bindings

> Calling pn_messenger_put with a message with no address causes a segmentation 
> fault
> ---
>
> Key: PROTON-368
> URL: https://issues.apache.org/jira/browse/PROTON-368
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.4
>Reporter: Darryl L. Pierce
>
> In the Ruby bindings, if a Qpid::Proton::Message object is created but not 
> given an address, and is then passed to Qpid::Proton::Messenger.put, the 
> underlying C code blows up on the missing address.
> Specifically at the line:
> bq.  pn_link_t *sender = pn_messenger_target(messenger, address);
> It should instead check that the address is set and, if not, fail earlier 
> than this point.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-365) PHP bindings are missing the disposition API calls

2013-08-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746051#comment-13746051
 ] 

ASF subversion and git services commented on PROTON-365:


Commit 1516161 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1516161 ]

Added simple smoke tests for the bindings. Encountered numerous issues
along the way and fixed as appropriate, including:
  - added tracker return values for ruby put/get
  - fixed ruby accept/reject to omit the tracker arg
  - fixed a deprecation warning in the perl binding
  - added disposition calls for php (PROTON-365)
  - added incoming/outgoing window properties for php
  - fixed put of messages without an address (PROTON-368)
  - added C level inspection method for messages to allow consistent
printing of messages across bindings

> PHP bindings are missing the disposition API calls
> --
>
> Key: PROTON-365
> URL: https://issues.apache.org/jira/browse/PROTON-365
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
>Reporter: Ken Giusti
>Priority: Blocker
> Fix For: 0.5
>
>
> pn_messenger_accept(messenger, tracker, 0);
> pn_messenger_reject(messenger, tracker, 0);  etc, have not been added to the 
> bindings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-336) pn_messenger_put does not clear PN_OVERFLOW error after expanding its buffer

2013-08-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746122#comment-13746122
 ] 

ASF subversion and git services commented on PROTON-336:


Commit 1516184 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1516184 ]

don't set an error for PN_OVERFLOW, this fixes PROTON-336, also fixed error 
accessors to be consistent

> pn_messenger_put does not clear PN_OVERFLOW error after expanding its buffer
> 
>
> Key: PROTON-336
> URL: https://issues.apache.org/jira/browse/PROTON-336
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.3
>Reporter: Rob Percival
>
> In pn_messenger_put, the buffer is initialised to an array of 1024 bytes. It 
> then tries to encode the message and if it won't fit, a PN_OVERFLOW error 
> occurs (against the message). The buffer is then doubled in size and it 
> retries encoding. However, the PN_OVERFLOW error is not cleared. This means 
> that after pn_messenger_put returns successfully, calling pn_message_errno 
> will report that a PN_OVERFLOW error occurred. The error message, 
> unhelpfully, is "data error: (null)".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-405) [proton-c] Windows install fails to find proton-api.jar file

2013-08-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746508#comment-13746508
 ] 

ASF subversion and git services commented on PROTON-405:


Commit 1516194 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1516194 ]

PROTON-405: Windows install can't find jar files.
This patch adds a cmake option to skip building/installing jars.

> [proton-c] Windows install fails to find proton-api.jar file
> 
>
> Key: PROTON-405
> URL: https://issues.apache.org/jira/browse/PROTON-405
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
> Environment: Windows install
>Reporter: Chuck Rolke
>
> The install script is looking for file
> 4>  CMake Error at proton-j/proton-api/cmake_install.cmake:31 (FILE):
> 4>file INSTALL cannot find
> 4>"D:/Users/crolke/svn/proton/build/proton-j/proton-api/proton-api.jar".
> but the actual file is versioned
>  Directory of D:\Users\chug\svn\proton\build\proton-j\proton-api
> 08/17/2013  10:04 AM   120,690 proton-api-0.5.jar

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-397) Need an example using the proton-j Messenger and Message API

2013-08-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747472#comment-13747472
 ] 

ASF subversion and git services commented on PROTON-397:


Commit 1516433 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1516433 ]

PROTON-397: added example contributed by Marc Berkowitz

> Need an example using the proton-j Messenger and Message API
> 
>
> Key: PROTON-397
> URL: https://issues.apache.org/jira/browse/PROTON-397
> Project: Qpid Proton
>  Issue Type: Wish
>  Components: proton-j
>Affects Versions: 0.4, 0.5
>Reporter: Marc Berkowitz
>  Labels: example, test
> Attachments: proton-397.tar.gz
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Need a java counterpart to proton/examples/messenger/py,
>  with a pair of simple java commaind-line programs that send and receive 
> messages. Fixed bug PROTON-257 does not show how to use interface Messenger.
> I have a simple version, closely based on examples/messenger/py, which I can 
> contribute,

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-58) NullPointerException on receiver.recv(...)

2013-08-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747644#comment-13747644
 ] 

ASF subversion and git services commented on PROTON-58:
---

Commit 1516508 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1516508 ]

PROTON-58: throw illegal state instead of NPE

> NullPointerException on receiver.recv(...)
> --
>
> Key: PROTON-58
> URL: https://issues.apache.org/jira/browse/PROTON-58
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Reporter: Hiram Chirino
>Assignee: Keith Wall
>  Labels: api
>
> Caused by: java.lang.NullPointerException
>   at 
> org.apache.qpid.proton.engine.impl.ReceiverImpl.recv(ReceiverImpl.java:73)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-412) pkg-config has wrong configuration

2013-08-26 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750490#comment-13750490
 ] 

ASF subversion and git services commented on PROTON-412:


Commit 1517673 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1517673 ]

PROTON-412: Fix the include and lib directories in libqpid-proton.pc

If the paths aren't passed in from the command line as absolute then
prepends them with CMAKE_INSTALL_PREFIX before generated the package
config file.

> pkg-config has wrong configuration
> --
>
> Key: PROTON-412
> URL: https://issues.apache.org/jira/browse/PROTON-412
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
>Reporter: Darryl L. Pierce
>
> Description of problem:
> From /usr/lib64/pkgconfig/libqpid-proton.pc -
> prefix=/usr
> exec_prefix=/usr
> libdir=/usr/usr/lib64
> includedir=/usr/usr/include
> Note that prefix and exec_prefix are correct but libdir and includedir don't 
> make any sense.
> This might be an issue with the upstream package or the rpm packaging 
> process. It looks like there is an extraneous /usr/ in the way that libdir 
> and indlucedir are constructed.
> Version-Release number of selected component (if applicable):
> 0.4-3
> How reproducible:
> 100%
> Steps to Reproduce:
> 1. yum install qpid-proton-c-devel
> 2.
> 3.
> Actual results:
> As description
> Expected results:
> File extract above should be:
> prefix=/usr
> exec_prefix=/usr
> libdir=/usr/lib64
> includedir=/usr/include
> Additional info:

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-414) Perl Messenger does not return a tracker on put

2013-08-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755102#comment-13755102
 ] 

ASF subversion and git services commented on PROTON-414:


Commit 1519078 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1519078 ]

PROTON-414: Perl Messenger returns outgoing tracker on put.

> Perl Messenger does not return a tracker on put
> ---
>
> Key: PROTON-414
> URL: https://issues.apache.org/jira/browse/PROTON-414
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> The method currently returns no value. It should return the tracker in order 
> to stay consistent with other bindings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-415) Perl Messenger does not return a tracker on get

2013-08-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755132#comment-13755132
 ] 

ASF subversion and git services commented on PROTON-415:


Commit 1519085 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1519085 ]

PROTON-415: Perl Messenger returns incoming tracker on get.

> Perl Messenger does not return a tracker on get
> ---
>
> Key: PROTON-415
> URL: https://issues.apache.org/jira/browse/PROTON-415
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> The method currently returns nothing, but should return the tracker value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-414) Perl Messenger does not return a tracker on put

2013-08-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755137#comment-13755137
 ] 

ASF subversion and git services commented on PROTON-414:


Commit 1519086 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1519086 ]

NO-JIRA: Added ChangeLog entries for PROTON-414 and PROTON-415.

> Perl Messenger does not return a tracker on put
> ---
>
> Key: PROTON-414
> URL: https://issues.apache.org/jira/browse/PROTON-414
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> The method currently returns no value. It should return the tracker in order 
> to stay consistent with other bindings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-415) Perl Messenger does not return a tracker on get

2013-08-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755138#comment-13755138
 ] 

ASF subversion and git services commented on PROTON-415:


Commit 1519086 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1519086 ]

NO-JIRA: Added ChangeLog entries for PROTON-414 and PROTON-415.

> Perl Messenger does not return a tracker on get
> ---
>
> Key: PROTON-415
> URL: https://issues.apache.org/jira/browse/PROTON-415
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> The method currently returns nothing, but should return the tracker value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-385) Perl Message class should expose an Body property.

2013-09-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758202#comment-13758202
 ] 

ASF subversion and git services commented on PROTON-385:


Commit 1520110 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1520110 ]

PROTON-385: Added a note to the ChangeLog for the Perl Message body field

> Perl Message class should expose an Body property.
> --
>
> Key: PROTON-385
> URL: https://issues.apache.org/jira/browse/PROTON-385
> Project: Qpid Proton
>  Issue Type: Improvement
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> Such a property should be added to expose this underlying feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-385) Perl Message class should expose an Body property.

2013-09-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758199#comment-13758199
 ] 

ASF subversion and git services commented on PROTON-385:


Commit 1520109 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1520109 ]

PROTON-385: Added the body property to Perl Message class.

Added the preencode and postdecode methods to Message, with appropriate
calls from Messenger, to encode and decode the body itself.

The send.pl and recv.pl examples now use the body type, with send.pl
sending random values as an example for using the body field.

> Perl Message class should expose an Body property.
> --
>
> Key: PROTON-385
> URL: https://issues.apache.org/jira/browse/PROTON-385
> Project: Qpid Proton
>  Issue Type: Improvement
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> Such a property should be added to expose this underlying feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-382) Perl Message class should expose a Properties attribute

2013-09-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759337#comment-13759337
 ] 

ASF subversion and git services commented on PROTON-382:


Commit 1520389 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1520389 ]

PROTON-382: Added properties field to the Perl Message class.

Added the set_property and get_property methods to assign and fetch
individual values. Added unit test for validating the APIs.

> Perl Message class should expose a Properties attribute
> ---
>
> Key: PROTON-382
> URL: https://issues.apache.org/jira/browse/PROTON-382
> Project: Qpid Proton
>  Issue Type: Improvement
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> Such a property should be added to expose this underlying feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-383) Perl Message class should expose an Annotations property.

2013-09-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13760218#comment-13760218
 ] 

ASF subversion and git services commented on PROTON-383:


Commit 1520574 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1520574 ]

PROTON-383: Adds annotations to the Perl Message class.

> Perl Message class should expose an Annotations property.
> -
>
> Key: PROTON-383
> URL: https://issues.apache.org/jira/browse/PROTON-383
> Project: Qpid Proton
>  Issue Type: Improvement
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> Such a property should be added to expose this underlying feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-384) Perl Message class should expose an Instructions property.

2013-09-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13760284#comment-13760284
 ] 

ASF subversion and git services commented on PROTON-384:


Commit 1520609 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1520609 ]

PROTON-384: Added instructions to the Perl Message class.

> Perl Message class should expose an Instructions property.
> --
>
> Key: PROTON-384
> URL: https://issues.apache.org/jira/browse/PROTON-384
> Project: Qpid Proton
>  Issue Type: Improvement
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> Such a property should be added to expose this underlying feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-413) [proton-c] Cmake install does not produce package files that work on windows

2013-09-12 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765674#comment-13765674
 ] 

ASF subversion and git services commented on PROTON-413:


Commit 1522678 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1522678 ]

PROTON-413: Support for finding an installed proton that works on windows
Use in conjunction with commit associated with QPID-5103.
1. In proton: cmake -DCMAKE_INSTALL_PREFIX=P:/install ...
2.devenv proton.sln /build "Debug|Win32" /project INSTALL
3. In qpid:   cmake -DPROTON_ROOT=P:/install ...
4.devenv qpid-cpp.sln /build "Debug|Win32 /project INSTALL

> [proton-c] Cmake install does not produce package files that work on windows
> 
>
> Key: PROTON-413
> URL: https://issues.apache.org/jira/browse/PROTON-413
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
> Environment: Windows
>Reporter: Chuck Rolke
> Attachments: proton-413-01.patch
>
>
> Installed proton relies on pkg-config to export the library's location to 
> consuming projects like Qpid. This doesn't play well on Windows where 
> pkg-config is not standard.
> It would be relatively easy to install export files that enable proton to be 
> located with find_package(). This feature could be installed in addition to 
> the pkg-config files and either could be used to find proton.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-386) Provide Perl post, fetch and mailserver examples

2013-09-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770801#comment-13770801
 ] 

ASF subversion and git services commented on PROTON-386:


Commit 1524422 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1524422 ]

PROTON-386: Provide a Perl mail server example application

Created the server.pl and client.pl applications.

> Provide Perl post, fetch and mailserver examples
> 
>
> Key: PROTON-386
> URL: https://issues.apache.org/jira/browse/PROTON-386
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> Provide examples, in Perl, that are feature similar to those in the same 
> example in Python.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-427) settle does not match accept/reject for ruby

2013-09-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776587#comment-13776587
 ] 

ASF subversion and git services commented on PROTON-427:


Commit 1525959 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1525959 ]

PROTON-427: Removed the flag argument from Messenger.settle

Made the API more consistent with the accept and reject methods.

> settle does not match accept/reject for ruby
> 
>
> Key: PROTON-427
> URL: https://issues.apache.org/jira/browse/PROTON-427
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Gordon Sim
>Assignee: Darryl L. Pierce
>
> In 0.4 the ruby versions of accept()/reject() and settle() all took a tracker 
> and flags (and both were required)
> In 0.5 this was changed for accept/reject. Only one argument could be passed, 
> the tracker, and it was optional. However settle remains the same as before 
> which seems inconsistent. (Of course changing it now would break the API 
> again between 0.5 and the next release).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-424) Memory Leak in Proton Messenger Send / Recv

2013-09-26 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778876#comment-13778876
 ] 

ASF subversion and git services commented on PROTON-424:


Commit 1526554 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1526554 ]

PROTON-424: fixed memory leak when freeing non stopped messengers

> Memory Leak in Proton Messenger Send / Recv
> ---
>
> Key: PROTON-424
> URL: https://issues.apache.org/jira/browse/PROTON-424
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
> Environment: Linux
>Reporter: Frank Quinn
> Attachments: qpid_messenger_leak_repro.c
>
>
> Hi Folks,
> I have encountered what looks like a memory leak in messenger if someone 
> could verify?
> I have attached some code which runs under valgrind --leak-check=full to 
> produce the following output.
> Can anyone verify if there is a way to clean this up or is this a leak in 
> proton-c 0.5?
> Cheers,
> Frank
> ==21663== Memcheck, a memory error detector
> ==21663== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al.
> ==21663== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info
> ==21663== Command: ./qpid_messenger_leak_repro
> ==21663==
> Waiting on recv
> ==21663==
> ==21663== HEAP SUMMARY:
> ==21663== in use at exit: 376,057 bytes in 3,417 blocks
> ==21663==   total heap usage: 4,110 allocs, 693 frees, 763,143 bytes allocated
> ==21663==
> ==21663== 142,153 (2,776 direct, 139,377 indirect) bytes in 1 blocks are 
> definitely lost in loss record 996 of 997
> ==21663==at 0x4A0887C: malloc (vg_replace_malloc.c:270)
> ==21663==by 0x4C232CF: pn_new (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C336AD: pn_connection (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C421EC: pn_messenger_connection (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C424DC: pn_messenger_tsync (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C42695: pn_messenger_sync (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C44301: pn_messenger_recv (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x400C43: qpidListenerThread (qpid_messenger_leak_repro.c:18)
> ==21663==by 0x3702407D14: start_thread (pthread_create.c:308)
> ==21663==by 0x37020F253C: clone (clone.S:114)
> ==21663==
> ==21663== 142,168 (2,776 direct, 139,392 indirect) bytes in 1 blocks are 
> definitely lost in loss record 997 of 997
> ==21663==at 0x4A0887C: malloc (vg_replace_malloc.c:270)
> ==21663==by 0x4C232CF: pn_new (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C336AD: pn_connection (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C421EC: pn_messenger_connection (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C42F48: pn_messenger_resolve (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C4310B: pn_messenger_link (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C4333C: pn_messenger_target (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x4C43DDE: pn_messenger_put (in 
> /home/fquinn/lib/qpid-proton-0.5/lib64/libqpid-proton.so.2.0.0)
> ==21663==by 0x400D40: main (qpid_messenger_leak_repro.c:79)
> ==21663==
> ==21663== LEAK SUMMARY:
> ==21663==definitely lost: 5,552 bytes in 2 blocks
> ==21663==indirectly lost: 278,769 bytes in 388 blocks
> ==21663==  possibly lost: 0 bytes in 0 blocks
> ==21663==still reachable: 91,736 bytes in 3,027 blocks
> ==21663== suppressed: 0 bytes in 0 blocks
> ==21663== Reachable blocks (those to which a pointer was found) are not shown.
> ==21663== To see them, rerun with: --leak-check=full --show-reachable=yes
> ==21663==
> ==21663== For counts of detected and suppressed errors, rerun with: -v
> ==21663== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 2 from 2)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-430) cmake install package files created at wrong time and place

2013-09-26 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779199#comment-13779199
 ] 

ASF subversion and git services commented on PROTON-430:


Commit 1526673 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1526673 ]

PROTON-430: cmake files written to wrong place(s)
Add white space to make file names more visible

> cmake install package files created at wrong time and place
> ---
>
> Key: PROTON-430
> URL: https://issues.apache.org/jira/browse/PROTON-430
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
> Environment: cmake
>Reporter: Chuck Rolke
>
> some files installed to 'lib/' and not to ${INSTALL_LIB_DIR}
> file proton-config-version.cmake written to ${LIB_INSTALL_DIR} at cmake 
> time.This file is better written to ${CMAKE_CURRENT_BINARY_DIR} and installed 
> at make-install time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links

2013-09-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781780#comment-13781780
 ] 

ASF subversion and git services commented on PROTON-200:


Commit 1527535 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1527535 ]

Modified the engine to track how much credit is drained vs used. This should 
simplify PROTON-200.

> [Proton-c] Credit distribution by messenger is not balanced across all links
> 
>
> Key: PROTON-200
> URL: https://issues.apache.org/jira/browse/PROTON-200
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.3
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Attachments: proton-200.patch, upstream-credit.patch
>
>
> The method used to distribute credit to receiving links may lead to 
> starvation when the number of receiving links is > the available credit.
> The distribution algorithm always starts with the same link - see 
> messenger.c::pn_messenger_flow()



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-375) Engine does not indicate when a link has completed draining.

2013-09-30 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781840#comment-13781840
 ] 

ASF subversion and git services commented on PROTON-375:


Commit 1527576 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1527576 ]

PROTON-375: added pn_link_draining/Receiver.draining()

> Engine does not indicate when a link has completed draining.
> 
>
> Key: PROTON-375
> URL: https://issues.apache.org/jira/browse/PROTON-375
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c, proton-j
>Affects Versions: 0.4
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>
> The engine API provides the pn_link_drain() method, which allows the 
> application to force the peer to drain its credit.
> The engine API does not provide a way for the application to know when the 
> remote has completed draining.  At least there needs to be a way to find out 
> when the remote credit value has been exhausted.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-342) installing into custom location doesn't work nicely (and is not properly documented)

2013-10-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783015#comment-13783015
 ] 

ASF subversion and git services commented on PROTON-342:


Commit 1528112 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1528112 ]

PROTON-342: Added a note to README about using DESTDIR.

Also includes a link to explain how its meant to be used.

> installing into custom location doesn't work nicely (and is not properly 
> documented)
> 
>
> Key: PROTON-342
> URL: https://issues.apache.org/jira/browse/PROTON-342
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
>Reporter: Gordon Sim
>Assignee: Darryl L. Pierce
>
> The README suggests setting -DCMAKE_INSTALL_PREFIX when running cmake, it 
> does not mention setting DESTDIR when invoking make install.
> If you don't set the DESTDIR on make install it will honour the 
> CMAKE_INSTALL_PREFIX for some parts of the installation (e.g. header files, 
> native libraries, pkg-config file etc) but the python bindings (and I assume 
> other bindings) will still install in the standard location which will fail 
> if you are not running as root.
> However if you set DESTDIR then this alters the location of the headers, 
> libraries and pkg-config , which now install into 
> $DESTDIR/$CMAKE_INSTALL_PREFIX and the pkg-config file no longer has the 
> correct include or library paths in it. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-342) installing into custom location doesn't work nicely (and is not properly documented)

2013-10-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783141#comment-13783141
 ] 

ASF subversion and git services commented on PROTON-342:


Commit 1528152 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1528152 ]

PROTON-342: Updated the README with text from gsims re: DESTDIR.

> installing into custom location doesn't work nicely (and is not properly 
> documented)
> 
>
> Key: PROTON-342
> URL: https://issues.apache.org/jira/browse/PROTON-342
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
>Reporter: Gordon Sim
>Assignee: Darryl L. Pierce
>
> The README suggests setting -DCMAKE_INSTALL_PREFIX when running cmake, it 
> does not mention setting DESTDIR when invoking make install.
> If you don't set the DESTDIR on make install it will honour the 
> CMAKE_INSTALL_PREFIX for some parts of the installation (e.g. header files, 
> native libraries, pkg-config file etc) but the python bindings (and I assume 
> other bindings) will still install in the standard location which will fail 
> if you are not running as root.
> However if you set DESTDIR then this alters the location of the headers, 
> libraries and pkg-config , which now install into 
> $DESTDIR/$CMAKE_INSTALL_PREFIX and the pkg-config file no longer has the 
> correct include or library paths in it. 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-431) Ruby integration test have incorrect failure messages

2013-10-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783357#comment-13783357
 ] 

ASF subversion and git services commented on PROTON-431:


Commit 1528218 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1528218 ]

PROTON-431: Fixed the Ruby spec tests.

They weren't updated with the changes to the Messenger.accept and
Messenger.settle API changes.

> Ruby integration test have incorrect failure messages
> -
>
> Key: PROTON-431
> URL: https://issues.apache.org/jira/browse/PROTON-431
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> The test current returns the value of the incoming and outgoing messenger 
> queues. But the assert library wants either a text message or a Proc object, 
> not a Fixnum. So the test suite consistently fails even when the actual test 
> succeeded.
> Additionally, there are changes in the APIs that are causing the spec tests 
> to fail as well.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-273) Fix disabled ruby test "can have nil content"

2013-10-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783355#comment-13783355
 ] 

ASF subversion and git services commented on PROTON-273:


Commit 1528216 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1528216 ]

PROTON-273: Removed the content Rspec test for Ruby.

Since the body of the message is accessed by the body property and not
by content, this test is no longer necessary.

Changed example apps to use body instead of content.

> Fix disabled ruby test "can have nil content"
> -
>
> Key: PROTON-273
> URL: https://issues.apache.org/jira/browse/PROTON-273
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Alan Conway
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> This test: 
> proton-c/bindings/ruby/spec/qpid/proton/message_spec.rb:404:  xit "can 
> have nil content" do
> has been disabled by replacing "it" with "xit". The test  is failing, fix the 
> cause and re-enable.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-431) Ruby integration test have incorrect failure messages

2013-10-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783356#comment-13783356
 ] 

ASF subversion and git services commented on PROTON-431:


Commit 1528217 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1528217 ]

PROTON-431: Fixed the assertions in the Ruby unit tests.

> Ruby integration test have incorrect failure messages
> -
>
> Key: PROTON-431
> URL: https://issues.apache.org/jira/browse/PROTON-431
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> The test current returns the value of the incoming and outgoing messenger 
> queues. But the assert library wants either a text message or a Proc object, 
> not a Fixnum. So the test suite consistently fails even when the actual test 
> succeeded.
> Additionally, there are changes in the APIs that are causing the spec tests 
> to fail as well.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-440) MessengerImpl tests fail on OSX

2013-10-12 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793284#comment-13793284
 ] 

ASF subversion and git services commented on PROTON-440:


Commit 1531508 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1531508 ]

PROTON-440: fix from hiram

> MessengerImpl tests fail on OSX
> ---
>
> Key: PROTON-440
> URL: https://issues.apache.org/jira/browse/PROTON-440
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Reporter: Hiram Chirino
> Fix For: 0.6
>
> Attachments: PROTON-440.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links

2013-10-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795407#comment-13795407
 ] 

ASF subversion and git services commented on PROTON-200:


Commit 1532452 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1532452 ]

PROTON-200: modified messenger's credit distribution algorithm to cope with 
credit scarce scenarios

> [Proton-c] Credit distribution by messenger is not balanced across all links
> 
>
> Key: PROTON-200
> URL: https://issues.apache.org/jira/browse/PROTON-200
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.3
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Attachments: proton-200.patch, upstream-credit.patch
>
>
> The method used to distribute credit to receiving links may lead to 
> starvation when the number of receiving links is > the available credit.
> The distribution algorithm always starts with the same link - see 
> messenger.c::pn_messenger_flow()



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-440) MessengerImpl tests fail on OSX

2013-10-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795411#comment-13795411
 ] 

ASF subversion and git services commented on PROTON-440:


Commit 1532453 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1532453 ]

PROTON-440: removed accidental println

> MessengerImpl tests fail on OSX
> ---
>
> Key: PROTON-440
> URL: https://issues.apache.org/jira/browse/PROTON-440
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Reporter: Hiram Chirino
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
> Attachments: PROTON-440.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links

2013-10-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796674#comment-13796674
 ] 

ASF subversion and git services commented on PROTON-200:


Commit 1532733 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1532733 ]

PROTON-200: removed usage of try except finally with

> [Proton-c] Credit distribution by messenger is not balanced across all links
> 
>
> Key: PROTON-200
> URL: https://issues.apache.org/jira/browse/PROTON-200
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.3
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Attachments: proton-200.patch, upstream-credit.patch
>
>
> The method used to distribute credit to receiving links may lead to 
> starvation when the number of receiving links is > the available credit.
> The distribution algorithm always starts with the same link - see 
> messenger.c::pn_messenger_flow()



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-443) update hawt-dispatch dependency version

2013-10-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800578#comment-13800578
 ] 

ASF subversion and git services commented on PROTON-443:


Commit 1534116 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1534116 ]

PROTON-443: updated hawtdispatch version

> update hawt-dispatch dependency version
> ---
>
> Key: PROTON-443
> URL: https://issues.apache.org/jira/browse/PROTON-443
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-j
>Reporter: Robbie Gemmell
>Priority: Blocker
> Fix For: 0.6
>
>
> PROTON-440 made some seemingly unrelated change to the proton-hawtdispatch 
> module dependencies, as below.
> The snapshot now being used must be updated to a release version before 
> Proton 0.6 can be shipped.
> {noformat}
> --- qpid/proton/trunk/proton-j/contrib/proton-hawtdispatch/pom.xml
> 2013/10/12 07:06:05 1531507
> +++ qpid/proton/trunk/proton-j/contrib/proton-hawtdispatch/pom.xml
> 2013/10/12 07:06:45 1531508
> @@ -29,7 +29,7 @@
>  
>
>  1.9
> -1.12
> +1.18-SNAPSHOT
>
>  
>
> @@ -51,6 +51,15 @@
>provided
>  
>
> +  
> +  
> +
> +  com.fusesource.m2.snapshot
> +  
> http://repo.fusesource.com/nexus/content/repositories/snapshots/
> +  false
> +  true
> +
> +  
>  
> 
>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-432) seg fault when handling error

2013-10-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800603#comment-13800603
 ] 

ASF subversion and git services commented on PROTON-432:


Commit 1534130 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1534130 ]

PROTON-432: switched pn_condition_t to use pn_string_t, this fixes the seg fault

> seg fault when handling error
> -
>
> Key: PROTON-432
> URL: https://issues.apache.org/jira/browse/PROTON-432
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Gordon Sim
>Assignee: Rafael H. Schloming
>Priority: Blocker
> Fix For: 0.6
>
>
> {noformat}
> $ ./proton-c/examples/messenger/c/send -a 
> amqp://gordon:gordon@localhost/my-queue
> Connected to localhost:5672
> -> SASL
> [0x18b8320:0] -> @sasl-init(65) [mechanism=:PLAIN, 
> initial-response=b"\x00gordon\x00gordon"]
> <- SASL
> [0x18b8320:0] <- @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS, :PLAIN, :AMQPLAIN]]
> [0x18b8320:0] <- @sasl-outcome(68) [code=0]
> -> AMQP
> [0x18b08d0:0] -> @open(16) 
> [container-id="8133b412-5ca8-4359-be9f-e236b87d3528", hostname="localhost"]
> [0x18b08d0:0] -> @begin(17) [next-outgoing-id=0, incoming-window=2147483647, 
> outgoing-window=1]
> [0x18b08d0:0] -> @attach(18) [name="sender-xxx", handle=0, role=false, 
> snd-settle-mode=2, rcv-settle-mode=0, source=@source(40) [address="my-queue", 
> durable=0, timeout=0, dynamic=false], target=@target(41) [address="my-queue", 
> durable=0, timeout=0, dynamic=false], initial-delivery-count=0]
> <- AMQP
> [0x18b08d0:0] <- @open(16) [container-id="rabbit@GRS-T520", 
> idle-time-out=60, properties={:copyright="Copyright (C) 2007-2013 VMware, 
> Inc.", :information="Licensed under the MPL.  See http://www.rabbitmq.com/";, 
> :platform="Erlang/OTP", :product="RabbitMQ", :version="3.1.3"}]
> [0x18b08d0:0] <- @open(16) [container-id="rabbit@GRS-T520", 
> idle-time-out=60, properties={:copyright="Copyright (C) 2007-2013 VMware, 
> Inc.", :information="Licensed under the MPL.  See http://www.rabbitmq.com/";, 
> :platform="Erlang/OTP", :product="RabbitMQ", :version="3.1.3"}]
> Segmentation fault (core dumped)
> {noformat}
> #0  0x7f799b10c0e0 in pn_data_rewind () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #1  0x7f799b11555f in pn_do_close () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #2  0x7f799b111554 in pn_dispatch_frame () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #3  0x7f799b1116e7 in pn_dispatcher_input () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #4  0x7f799b1169ee in pn_input_read_amqp () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #5  0x7f799b114855 in transport_consume () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #6  0x7f799b1185e2 in pn_transport_process () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #7  0x7f799b1204fb in pn_connector_process () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #8  0x7f799b11e420 in pn_messenger_tsync () from 
> /home/gordon/projects/proton/build/proton-c/libqpid-proton.so.2
> #9  0x004010f3 in main ()



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-278) Messenger - allow the application to control the use of the message reply-to field.

2013-10-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800737#comment-13800737
 ] 

ASF subversion and git services commented on PROTON-278:


Commit 1534224 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1534224 ]

PROTON-278: fixed reply-to expansion to not expand unset reply-to addresses

> Messenger - allow the application to control the use of the message reply-to 
> field.
> ---
>
> Key: PROTON-278
> URL: https://issues.apache.org/jira/browse/PROTON-278
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.4
>Reporter: Ken Giusti
>Assignee: Rafael H. Schloming
>Priority: Critical
>  Labels: reply-to
> Fix For: 0.6
>
>
> Currently, messenger always sets the reply-to field in a sent message.
> This should be changed to allow the application to set the reply-to field 
> only when a reply is desired.  Messenger should be changed to not 
> unconditionally set this field.
> In order to set this field in the case of a client that has not established a 
> subscription, the client needs to be able to query messenger for the proper 
> value of the reply-to address.  A new api would need to be created for this.  
> Proposal:
> int pn_messenger_set_reply( pn_messenger_t *msgr,  pn_message_t *msg )
> Set the proper reply-to address in msg.  msg would need to have its "to" 
> address configured in order for this method to succeed.
> At least, I think the value for the reply-to may depend on the 'to' 
> address... I may be wrong about that
> Opinions?



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-442) Running swig generates "Warning(451): Setting a const char * variable may leak memory."

2013-10-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800823#comment-13800823
 ] 

ASF subversion and git services commented on PROTON-442:


Commit 1534282 from [~fadams] in branch 'proton/trunk'
[ https://svn.apache.org/r1534282 ]

JIRA: PROTON-442 PROTON-442: When building proton I get Warning Setting a const 
char * variable may leak memory. should really strive for a clean build.

> Running swig generates "Warning(451): Setting a const char * variable may 
> leak memory."
> ---
>
> Key: PROTON-442
> URL: https://issues.apache.org/jira/browse/PROTON-442
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Fraser Adams
>Priority: Minor
>
> When building proton after doing cmake .. the make process is quite "noisy" 
> generating a number of warnings that ought to be corrected.
> One such warning is:
> "Warning(451): Setting a const char * variable may leak memory."
> This relates to the "const char *bytes;" in the pn_delivery_tag_t struct in 
> engine.h
> The swig documentation in http://www.swig.org/Doc1.3/Warnings.html suggests 
> how to suppress this warning (due to the way the code works I believe that 
> it's safe to suppress this case) by doing:
> %warnfilter(451) pn_delivery_tag_t;
> in the various python.i, perl.i etc.
> I've make the changes locally and this indeed works.
> I'll put together a review board request.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-442) Running swig generates "Warning(451): Setting a const char * variable may leak memory."

2013-10-21 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13800822#comment-13800822
 ] 

ASF subversion and git services commented on PROTON-442:


Commit 1534282 from [~fadams] in branch 'proton/trunk'
[ https://svn.apache.org/r1534282 ]

JIRA: PROTON-442 PROTON-442: When building proton I get Warning Setting a const 
char * variable may leak memory. should really strive for a clean build.

> Running swig generates "Warning(451): Setting a const char * variable may 
> leak memory."
> ---
>
> Key: PROTON-442
> URL: https://issues.apache.org/jira/browse/PROTON-442
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Fraser Adams
>Priority: Minor
>
> When building proton after doing cmake .. the make process is quite "noisy" 
> generating a number of warnings that ought to be corrected.
> One such warning is:
> "Warning(451): Setting a const char * variable may leak memory."
> This relates to the "const char *bytes;" in the pn_delivery_tag_t struct in 
> engine.h
> The swig documentation in http://www.swig.org/Doc1.3/Warnings.html suggests 
> how to suppress this warning (due to the way the code works I believe that 
> it's safe to suppress this case) by doing:
> %warnfilter(451) pn_delivery_tag_t;
> in the various python.i, perl.i etc.
> I've make the changes locally and this indeed works.
> I'll put together a review board request.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-428) proton-hawtdispatch drops data when more than 512 bytes are read from the socket

2013-10-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804307#comment-13804307
 ] 

ASF subversion and git services commented on PROTON-428:


Commit 1535409 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1535409 ]

PROTON-428: applied patch from bozo

> proton-hawtdispatch drops data when more than 512 bytes are read from the 
> socket
> 
>
> Key: PROTON-428
> URL: https://issues.apache.org/jira/browse/PROTON-428
> Project: Qpid Proton
>  Issue Type: Bug
>Reporter: Bozo Dragojevic
> Fix For: 0.6
>
> Attachments: 
> 0001-PROTON-428-proton-hawtdispatch-drops-data-when-more-.patch
>
>
> hawtdispatch AmqpTransport calls protons Transport.input() just once and 
> assumes all data was consumed



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-393) messenger needs a way to reset the error

2013-10-24 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804395#comment-13804395
 ] 

ASF subversion and git services commented on PROTON-393:


Commit 1535439 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1535439 ]

PROTON-393: applied (modified) patch from Bozo

> messenger needs a way to reset the error
> 
>
> Key: PROTON-393
> URL: https://issues.apache.org/jira/browse/PROTON-393
> Project: Qpid Proton
>  Issue Type: Bug
>Reporter: Bozo Dragojevic
>Assignee: Rafael H. Schloming
> Fix For: 0.5
>
>
> m = Messenger()
> m.recv(-1) # error no active sources
> m.subscribe(valid_address) # fails because messenger is in error state



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-446) [SSL] when certificate validation fails, the connection is not cleanly closed.

2013-11-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811400#comment-13811400
 ] 

ASF subversion and git services commented on PROTON-446:


Commit 1537972 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1537972 ]

PROTON-446: manually set the proper shutdown state on SSL failure

> [SSL] when certificate validation fails, the connection is not cleanly closed.
> --
>
> Key: PROTON-446
> URL: https://issues.apache.org/jira/browse/PROTON-446
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Ken Giusti
>Priority: Minor
>
> Should a connection setup fail due to a certificate validation failure, the 
> output side of the connection I/O never indicates an error has occurred.
> The input side of the connection properly returns PN_ERR on a read attempt.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-260) Messenger Documentation

2013-11-01 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811436#comment-13811436
 ] 

ASF subversion and git services commented on PROTON-260:


Commit 1537984 from [~mgoulish] in branch 'proton/trunk'
[ https://svn.apache.org/r1537984 ]

PROTON-260  new text for python API doc.

> Messenger Documentation
> ---
>
> Key: PROTON-260
> URL: https://issues.apache.org/jira/browse/PROTON-260
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: michael goulish
>Assignee: michael goulish
>
> Write documentation for the Proton Messenger interface, to include:
>   introduction
>   API explanations
>   theory of operation
>   example programs
>   programming idioms
>   tutorials
>   quickstarts
>   troubleshooting
> Documents should use MarkDown markup language.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-302) Messenger does not verify the hostname in the peer's SSL certificate.

2013-11-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813952#comment-13813952
 ] 

ASF subversion and git services commented on PROTON-302:


Commit 1539013 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1539013 ]

PROTON-302: added negative testing for messenger ssl; added proper validation 
of messenger credentials; fixed the java work queue and transport work queue 
implementation; added the missing Delivery.clear() method to proton-j

> Messenger does not verify the hostname in the peer's SSL certificate.
> -
>
> Key: PROTON-302
> URL: https://issues.apache.org/jira/browse/PROTON-302
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.6
>
>
> When Messenger is configured to use SSL, and a CA database is provided (via 
> set_trusted_certificates), messenger fails to check that the 
> CommonName/Subject Alternate Name provided in the peer's certificate.  
> Currently, it merely validates that the certificate is signed correctly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-302) Messenger does not verify the hostname in the peer's SSL certificate.

2013-11-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815024#comment-13815024
 ] 

ASF subversion and git services commented on PROTON-302:


Commit 1539393 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1539393 ]

PROTON-302: added clear method to JNIDelivery

> Messenger does not verify the hostname in the peer's SSL certificate.
> -
>
> Key: PROTON-302
> URL: https://issues.apache.org/jira/browse/PROTON-302
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Blocker
> Fix For: 0.6
>
>
> When Messenger is configured to use SSL, and a CA database is provided (via 
> set_trusted_certificates), messenger fails to check that the 
> CommonName/Subject Alternate Name provided in the peer's certificate.  
> Currently, it merely validates that the certificate is signed correctly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-448) Ruby bindings need to have their set calls updated to properly map values to pn_data_t*

2013-11-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815163#comment-13815163
 ] 

ASF subversion and git services commented on PROTON-448:


Commit 1539430 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1539430 ]

PROTON-448: Added support for Data encode/decode to Ruby Swig.

> Ruby bindings need to have their set calls updated to properly map values to 
> pn_data_t*
> ---
>
> Key: PROTON-448
> URL: https://issues.apache.org/jira/browse/PROTON-448
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> When using the APIs in Qpid::Proton::Data I'm seeing:
> irb(main):001:0> require 'qpid_proton'
> => true
> irb(main):002:0> data = Qpid::Proton::Data.new
> => #
> irb(main):003:0> data.ubyte = 3
> value=3
> TypeError: Expected argument 0 of type pn_data_t *, but got Fixnum 16
>   in SWIG method 'pn_data_put_ubyte'
>   from 
> /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in
>  `pn_data_put_ubyte'
>   from 
> /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in
>  `ubyte='
>   from (irb):3
>   from /usr/bin/irb:12:in `'



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-448) Ruby bindings need to have their set calls updated to properly map values to pn_data_t*

2013-11-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815167#comment-13815167
 ] 

ASF subversion and git services commented on PROTON-448:


Commit 1539431 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1539431 ]

PROTON-448: Added missed ChangeLog entry

> Ruby bindings need to have their set calls updated to properly map values to 
> pn_data_t*
> ---
>
> Key: PROTON-448
> URL: https://issues.apache.org/jira/browse/PROTON-448
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> When using the APIs in Qpid::Proton::Data I'm seeing:
> irb(main):001:0> require 'qpid_proton'
> => true
> irb(main):002:0> data = Qpid::Proton::Data.new
> => #
> irb(main):003:0> data.ubyte = 3
> value=3
> TypeError: Expected argument 0 of type pn_data_t *, but got Fixnum 16
>   in SWIG method 'pn_data_put_ubyte'
>   from 
> /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in
>  `pn_data_put_ubyte'
>   from 
> /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in
>  `ubyte='
>   from (irb):3
>   from /usr/bin/irb:12:in `'



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-448) Ruby bindings need to have their set calls updated to properly map values to pn_data_t*

2013-11-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815994#comment-13815994
 ] 

ASF subversion and git services commented on PROTON-448:


Commit 1539656 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1539656 ]

PROTON-448: Backing out the Ruby data change.

Seems it's having a separate problem with strings not properly encoding.
The tests started to fail, so I'll pull this until I can fix them.

> Ruby bindings need to have their set calls updated to properly map values to 
> pn_data_t*
> ---
>
> Key: PROTON-448
> URL: https://issues.apache.org/jira/browse/PROTON-448
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> When using the APIs in Qpid::Proton::Data I'm seeing:
> irb(main):001:0> require 'qpid_proton'
> => true
> irb(main):002:0> data = Qpid::Proton::Data.new
> => #
> irb(main):003:0> data.ubyte = 3
> value=3
> TypeError: Expected argument 0 of type pn_data_t *, but got Fixnum 16
>   in SWIG method 'pn_data_put_ubyte'
>   from 
> /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in
>  `pn_data_put_ubyte'
>   from 
> /home/mcpierce/Programming/Proton/proton-c/bindings/ruby/lib/qpid_proton/data.rb:437:in
>  `ubyte='
>   from (irb):3
>   from /usr/bin/irb:12:in `'



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-444) Java Messenger needs internal store.

2013-11-08 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817398#comment-13817398
 ] 

ASF subversion and git services commented on PROTON-444:


Commit 1540104 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1540104 ]

PROTON-444: port internal store from C implementation

> Java Messenger needs internal store.
> 
>
> Key: PROTON-444
> URL: https://issues.apache.org/jira/browse/PROTON-444
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-j
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.6
>
>
> The credit distribution algorithm used in the C implementation of Messenger 
> leverages that implementation's use of an internal store to track pending 
> send requests for a given link.
> The Java implementation of Messenger does not yet have a similar store. In 
> order to port PROTON-200 to the Java implementation of Messenger, a store 
> needs to be implemented.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-450) Rspec tests should NOT use the default port for listening

2013-11-12 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820174#comment-13820174
 ] 

ASF subversion and git services commented on PROTON-450:


Commit 1541098 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1541098 ]

PROTON-450: Use random ports for Ruby Rspec tests.

The ports used are randomly chosen above 5700, to avoid interference
from a running Qpid broker.

> Rspec tests should NOT use the default port for listening
> -
>
> Key: PROTON-450
> URL: https://issues.apache.org/jira/browse/PROTON-450
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> By using the default port number, the tests will fail if there's a broker or 
> other piece of code that's using the default port. Also a hung test can 
> interfere with other tests and cause them to fail as well.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-449) Unit tests fail if proton is built without OpenSSL.

2013-11-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824291#comment-13824291
 ] 

ASF subversion and git services commented on PROTON-449:


Commit 1542435 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1542435 ]

PROTON-449: skip SSL tests if no SSL libraries available.

> Unit tests fail if proton is built without OpenSSL.
> ---
>
> Key: PROTON-449
> URL: https://issues.apache.org/jira/browse/PROTON-449
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Minor
>
> If the build environment does _not_ have OpenSSL, then the SSL module is not 
> built, which is expected.
> However, some of the python unit tests that require SSL still run, and cause 
> the unit tests to fail.
> These tests should be skipped when the SSL module is not built.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-453) OpenSSL libraries are not Valgrind clean

2013-11-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825483#comment-13825483
 ] 

ASF subversion and git services commented on PROTON-453:


Commit 1543085 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1543085 ]

PROTON-453: add missing valgrind suppressions

> OpenSSL libraries are not Valgrind clean
> 
>
> Key: PROTON-453
> URL: https://issues.apache.org/jira/browse/PROTON-453
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Trivial
> Fix For: 0.6
>
>
> OpenSSL will trigger errors under Valgrind.  This is expected, as OpenSSL 
> uses uninitialized memory to increase its randomness.
> http://www.openssl.org/support/faq.html#PROG14
> These errors can be suppressed by using a Valgrind suppression file.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-452) Ruby API doesn't have pn_messenger_interrupt()

2013-11-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825644#comment-13825644
 ] 

ASF subversion and git services commented on PROTON-452:


Commit 1543112 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1543112 ]

PROTON-452: Expose the Messenger interrupt method in Ruby.

Exposed the method in Qpid::Proton::Messenger. Also provided the
Qpid::Proton::Error::InterruptedError type that is thrown when
necessary.

> Ruby API doesn't have pn_messenger_interrupt()
> --
>
> Key: PROTON-452
> URL: https://issues.apache.org/jira/browse/PROTON-452
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: michael goulish
>Assignee: Darryl L. Pierce
>
> It looks like the Ruby binding doesn't cover the new-ish C function  
> pn_messenger_interrupt().



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-453) OpenSSL libraries are not Valgrind clean

2013-11-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826089#comment-13826089
 ] 

ASF subversion and git services commented on PROTON-453:


Commit 1543292 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1543292 ]

PROTON-453: add valgrind suppression for older libraries

> OpenSSL libraries are not Valgrind clean
> 
>
> Key: PROTON-453
> URL: https://issues.apache.org/jira/browse/PROTON-453
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Trivial
> Fix For: 0.6
>
>
> OpenSSL will trigger errors under Valgrind.  This is expected, as OpenSSL 
> uses uninitialized memory to increase its randomness.
> http://www.openssl.org/support/faq.html#PROG14
> These errors can be suppressed by using a Valgrind suppression file.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-457) Expose the Messenger interrupt method in Perl

2013-11-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826653#comment-13826653
 ] 

ASF subversion and git services commented on PROTON-457:


Commit 1543481 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1543481 ]

PROTON-457: Exposed the interrupt method of Messenger in Perl.

> Expose the Messenger interrupt method in Perl
> -
>
> Key: PROTON-457
> URL: https://issues.apache.org/jira/browse/PROTON-457
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> Similar to PROTON-452, Perl does not currently expose the interrupt method in 
> its Messenger type.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-454) ruby binding omits pn_messenger_route interface

2013-11-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826873#comment-13826873
 ] 

ASF subversion and git services commented on PROTON-454:


Commit 1543550 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1543550 ]

PROTON-454: Added the route method to Ruby's Messenger class.

> ruby binding omits pn_messenger_route interface
> ---
>
> Key: PROTON-454
> URL: https://issues.apache.org/jira/browse/PROTON-454
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: michael goulish
>Assignee: Darryl L. Pierce
>
> The Ruby binding does not implement the pn_messenger_route() function.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-455) Ruby interface omits pn_messenger_rewrite()

2013-11-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826915#comment-13826915
 ] 

ASF subversion and git services commented on PROTON-455:


Commit 1543565 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1543565 ]

PROTON-455: Added rewrite method to Ruby Messenger class.

> Ruby interface omits pn_messenger_rewrite()
> ---
>
> Key: PROTON-455
> URL: https://issues.apache.org/jira/browse/PROTON-455
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: michael goulish
>
> The Ruby binding does not implement the pn_messenger_rewrite() fn.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-456) Ruby binding does not implement password attr

2013-11-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13826994#comment-13826994
 ] 

ASF subversion and git services commented on PROTON-456:


Commit 1543595 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1543595 ]

PROTON-456: Added password property to Ruby Messenger class.

> Ruby binding does not implement password attr
> -
>
> Key: PROTON-456
> URL: https://issues.apache.org/jira/browse/PROTON-456
> Project: Qpid Proton
>  Issue Type: Bug
>Reporter: michael goulish
>Assignee: Darryl L. Pierce
>
> Password attribute isn't in Ruby binding yet.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-466) Driver - Optimization causes hangs in cleanly closed connections

2013-11-26 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832705#comment-13832705
 ] 

ASF subversion and git services commented on PROTON-466:


Commit 1545697 from [~tedross] in branch 'proton/trunk'
[ https://svn.apache.org/r1545697 ]

PROTON-466 - driver fix.

> Driver - Optimization causes hangs in cleanly closed connections
> 
>
> Key: PROTON-466
> URL: https://issues.apache.org/jira/browse/PROTON-466
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ted Ross
>Assignee: Ted Ross
>Priority: Blocker
> Fix For: 0.6
>
> Attachments: PROTON-446.patch
>
>
> Related to https://issues.apache.org/jira/browse/QPID-4853
> Often, when a connection is cleanly closed, the connection-close handshake 
> completes but the connector is never closed.  All that is needed is for one 
> more connector_process cycle, but the connector never again appears in the 
> work list.
> There is an optimization in the connector processor that says "if the socket 
> has accepted all of the current data for send, clear the SEL_WR flag".  The 
> problem is that when the data-for-send is the last data to be sent on the 
> connection, the connector is never again processed and hangs, using resources 
> and keeping the socket from fully closing.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-439) Support for dynamic reply-to address in Messenger

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836526#comment-13836526
 ] 

ASF subversion and git services commented on PROTON-439:


Commit 1547022 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547022 ]

initial stab at PROTON-439

> Support for dynamic reply-to address in Messenger
> -
>
> Key: PROTON-439
> URL: https://issues.apache.org/jira/browse/PROTON-439
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ted Ross
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
>
> Messenger has no support for creating dynamic receivers for reply-to 
> addresses.  Please refer to the following email thread for prior discussion 
> on the topic.
> http://qpid.2158936.n2.nabble.com/Proton-Messenger-and-the-Request-Response-pattern-tp7586653.html



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-439) Support for dynamic reply-to address in Messenger

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836536#comment-13836536
 ] 

ASF subversion and git services commented on PROTON-439:


Commit 1547025 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547025 ]

fixes for PROTON-439

> Support for dynamic reply-to address in Messenger
> -
>
> Key: PROTON-439
> URL: https://issues.apache.org/jira/browse/PROTON-439
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ted Ross
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
>
> Messenger has no support for creating dynamic receivers for reply-to 
> addresses.  Please refer to the following email thread for prior discussion 
> on the topic.
> http://qpid.2158936.n2.nabble.com/Proton-Messenger-and-the-Request-Response-pattern-tp7586653.html



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-290) Allow querying of unsent messages by tracker

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836539#comment-13836539
 ] 

ASF subversion and git services commented on PROTON-290:


Commit 1547027 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547027 ]

PROTON-290: applied updated patch from Bozo

> Allow querying of unsent messages by tracker
> 
>
> Key: PROTON-290
> URL: https://issues.apache.org/jira/browse/PROTON-290
> Project: Qpid Proton
>  Issue Type: New Feature
>Reporter: Bozo Dragojevic
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
> Attachments: 
> 0001-PROTON-290-add-a-test-and-more-explicit-logic.patch, 
> 0001-PROTON-393-check-if-delivery-is-still-buffered-by-pr.patch
>
>
> messenger.status(tracker) returns PENDING until the message is either
> accepted or rejected by the recipient.
> Allow distinguishing between buffered locally and transmitted messages.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-290) Allow querying of unsent messages by tracker

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836557#comment-13836557
 ] 

ASF subversion and git services commented on PROTON-290:


Commit 1547036 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547036 ]

PROTON-290: skip buffered tests for java

> Allow querying of unsent messages by tracker
> 
>
> Key: PROTON-290
> URL: https://issues.apache.org/jira/browse/PROTON-290
> Project: Qpid Proton
>  Issue Type: New Feature
>Reporter: Bozo Dragojevic
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
> Attachments: 
> 0001-PROTON-290-add-a-test-and-more-explicit-logic.patch, 
> 0001-PROTON-393-check-if-delivery-is-still-buffered-by-pr.patch
>
>
> messenger.status(tracker) returns PENDING until the message is either
> accepted or rejected by the recipient.
> Allow distinguishing between buffered locally and transmitted messages.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-418) data error interface should match other error APIs (probably should review all error accessors)

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836558#comment-13836558
 ] 

ASF subversion and git services commented on PROTON-418:


Commit 1547038 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547038 ]

PROTON-418: fixed data error interface to match other APIs

> data error interface should match other error APIs (probably should review 
> all error accessors)
> ---
>
> Key: PROTON-418
> URL: https://issues.apache.org/jira/browse/PROTON-418
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Rafael H. Schloming
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
>




--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-439) Support for dynamic reply-to address in Messenger

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836609#comment-13836609
 ] 

ASF subversion and git services commented on PROTON-439:


Commit 1547063 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547063 ]

PROTON-439: properly format subscription address

> Support for dynamic reply-to address in Messenger
> -
>
> Key: PROTON-439
> URL: https://issues.apache.org/jira/browse/PROTON-439
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ted Ross
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
>
> Messenger has no support for creating dynamic receivers for reply-to 
> addresses.  Please refer to the following email thread for prior discussion 
> on the topic.
> http://qpid.2158936.n2.nabble.com/Proton-Messenger-and-the-Request-Response-pattern-tp7586653.html



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-463) Perl should provide incoming and outgoing trackers

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836617#comment-13836617
 ] 

ASF subversion and git services commented on PROTON-463:


Commit 1547067 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547067 ]

PROTON-463: Updated ChangeLog for Perl

> Perl should provide incoming and outgoing trackers
> --
>
> Key: PROTON-463
> URL: https://issues.apache.org/jira/browse/PROTON-463
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> Currently the Perl bindings do not expose this functionality.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-463) Perl should provide incoming and outgoing trackers

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836613#comment-13836613
 ] 

ASF subversion and git services commented on PROTON-463:


Commit 1547066 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547066 ]

PROTON-463: Add Tracker class to Perl bindings

> Perl should provide incoming and outgoing trackers
> --
>
> Key: PROTON-463
> URL: https://issues.apache.org/jira/browse/PROTON-463
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> Currently the Perl bindings do not expose this functionality.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-463) Perl should provide incoming and outgoing trackers

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836631#comment-13836631
 ] 

ASF subversion and git services commented on PROTON-463:


Commit 1547072 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547072 ]

PROTON-463: Fixed the Perl incoming tracker method name.

Renamed it to "get_incoming_tracker" to make the "get_outgoing_tracker"
method.

> Perl should provide incoming and outgoing trackers
> --
>
> Key: PROTON-463
> URL: https://issues.apache.org/jira/browse/PROTON-463
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> Currently the Perl bindings do not expose this functionality.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-439) Support for dynamic reply-to address in Messenger

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836665#comment-13836665
 ] 

ASF subversion and git services commented on PROTON-439:


Commit 1547089 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547089 ]

PROTON-439: don't substitute remode addresses that are already absolute

> Support for dynamic reply-to address in Messenger
> -
>
> Key: PROTON-439
> URL: https://issues.apache.org/jira/browse/PROTON-439
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ted Ross
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
>
> Messenger has no support for creating dynamic receivers for reply-to 
> addresses.  Please refer to the following email thread for prior discussion 
> on the topic.
> http://qpid.2158936.n2.nabble.com/Proton-Messenger-and-the-Request-Response-pattern-tp7586653.html



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-439) Support for dynamic reply-to address in Messenger

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836676#comment-13836676
 ] 

ASF subversion and git services commented on PROTON-439:


Commit 1547100 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547100 ]

PROTON-439: remove spurious slash for absolute addresses

> Support for dynamic reply-to address in Messenger
> -
>
> Key: PROTON-439
> URL: https://issues.apache.org/jira/browse/PROTON-439
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ted Ross
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
>
> Messenger has no support for creating dynamic receivers for reply-to 
> addresses.  Please refer to the following email thread for prior discussion 
> on the topic.
> http://qpid.2158936.n2.nabble.com/Proton-Messenger-and-the-Request-Response-pattern-tp7586653.html



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-458) Perl should die on negative return values

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836808#comment-13836808
 ] 

ASF subversion and git services commented on PROTON-458:


Commit 1547155 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547155 ]

PROTON-458: Perl Messenger now dies on error conditions.

Added the qpid::proton::check_for_errors() method that takes the return
code of a method and dies if the value is an error.

> Perl should die on negative return values
> -
>
> Key: PROTON-458
> URL: https://issues.apache.org/jira/browse/PROTON-458
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> Currently there is no wrapper function that checks for error return codes and 
> calls die on error conditions.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-473) Windows driver.c matching fixes

2013-12-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837184#comment-13837184
 ] 

ASF subversion and git services commented on PROTON-473:


Commit 1547254 from cliffjan...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547254 ]

PROTON-473: apply posix/driver.c fixes to windows version

> Windows driver.c matching fixes
> ---
>
> Key: PROTON-473
> URL: https://issues.apache.org/jira/browse/PROTON-473
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.6
> Environment: Windows
>Reporter: Cliff Jansen
>Assignee: Cliff Jansen
> Fix For: 0.6
>
>
> Apply recent Posix driver fixes to the Windows version.  PROTON-302, 
> PROTON-403, PROTON-466.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links

2013-12-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838055#comment-13838055
 ] 

ASF subversion and git services commented on PROTON-200:


Commit 1547534 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1547534 ]

PROTON-200: Java implementation of credit scheduler

> [Proton-c] Credit distribution by messenger is not balanced across all links
> 
>
> Key: PROTON-200
> URL: https://issues.apache.org/jira/browse/PROTON-200
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-j
>Affects Versions: 0.3
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.6
>
> Attachments: proton-200.patch, upstream-credit.patch
>
>
> The method used to distribute credit to receiving links may lead to 
> starvation when the number of receiving links is > the available credit.
> The distribution algorithm always starts with the same link - see 
> messenger.c::pn_messenger_flow()



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-445) Binding installation ignores prefix

2013-12-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838151#comment-13838151
 ] 

ASF subversion and git services commented on PROTON-445:


Commit 1547577 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547577 ]

PROTON-445: Python install now honors CMAKE_INSTALL_PREFIX

The language bindings will now honor this prefix, both the default value
and a user-specified value.

Developers can override it, though, by specifying PYTHON_INSTALL_PREFIX
at the command line as well. This will allow for installing the Python
bindings to a different directory if so desired.

> Binding installation ignores prefix
> ---
>
> Key: PROTON-445
> URL: https://issues.apache.org/jira/browse/PROTON-445
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Justin Ross
> Attachments: what-a-mess.txt
>
>
> It allows you *prepend* to the install prefix, but it gives you no way afaict 
> to actually change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you 
> try to get your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace 
> /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from 
> CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a 
> mechanism for staged installs (packaging systems use this), and it cannot 
> function correctly as an override for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding 
> install honor CMAKE_INSTALL_PREFIX.  Let the developer be responsible for 
> choosing the right location for his or her distribution.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-445) Binding installation ignores prefix

2013-12-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838153#comment-13838153
 ] 

ASF subversion and git services commented on PROTON-445:


Commit 1547578 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547578 ]

PROTON-445: Perl install now honors CMAKE_INSTALL_PREFIX

The language bindings will now honor this prefix, both the default
value and a user-specified value.

Developers can override it, though, by specifying PERL_INSTALL_PREFIX
at the command line as well. This will allow for installing the Perl
bindings to a different directory if so desired.

Also updated the installation pieces in CMake to simplify it.

> Binding installation ignores prefix
> ---
>
> Key: PROTON-445
> URL: https://issues.apache.org/jira/browse/PROTON-445
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Justin Ross
> Attachments: what-a-mess.txt
>
>
> It allows you *prepend* to the install prefix, but it gives you no way afaict 
> to actually change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you 
> try to get your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace 
> /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from 
> CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a 
> mechanism for staged installs (packaging systems use this), and it cannot 
> function correctly as an override for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding 
> install honor CMAKE_INSTALL_PREFIX.  Let the developer be responsible for 
> choosing the right location for his or her distribution.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-464) Interpolate CMAKE_INSTALL_PREFIX into Ruby install directory.

2013-12-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838154#comment-13838154
 ] 

ASF subversion and git services commented on PROTON-464:


Commit 1547579 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547579 ]

PROTON-464: Install Ruby bindings to install prefix if specified.

If the user provides a CMAKE_INSTALL_PREFIX on the command line, then
that directory is used to install the Ruby language bindings. If no
install prefix is specified then the Ruby bindings honor the directory
specified by the Ruby VM itself.

> Interpolate CMAKE_INSTALL_PREFIX into Ruby install directory.
> -
>
> Key: PROTON-464
> URL: https://issues.apache.org/jira/browse/PROTON-464
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> By checking the 'prefix' value from RbConfig::CONFIG, we can then take the 
> sitearch and sitelib paths and substitute that prefix value for what's given 
> by thye user with CMAKE_INSTALL_PREFIX.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-445) Binding installation ignores prefix

2013-12-03 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838226#comment-13838226
 ] 

ASF subversion and git services commented on PROTON-445:


Commit 1547597 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547597 ]

PROTON-445: PHP install now honors the install prefix.

If the install prefix is not "/usr" then the INI directory is placed
below it. This is to accomodate a system install as opposed to a
developer install.

> Binding installation ignores prefix
> ---
>
> Key: PROTON-445
> URL: https://issues.apache.org/jira/browse/PROTON-445
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Justin Ross
> Fix For: 0.6
>
> Attachments: what-a-mess.txt
>
>
> It allows you *prepend* to the install prefix, but it gives you no way afaict 
> to actually change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you 
> try to get your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace 
> /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from 
> CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a 
> mechanism for staged installs (packaging systems use this), and it cannot 
> function correctly as an override for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding 
> install honor CMAKE_INSTALL_PREFIX.  Let the developer be responsible for 
> choosing the right location for his or her distribution.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-200) Credit distribution by messenger is not balanced across all links

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838902#comment-13838902
 ] 

ASF subversion and git services commented on PROTON-200:


Commit 1547797 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1547797 ]

PROTON-200: use setTcpNoDelay instead of JDK7 only StandardSocketOptions

> Credit distribution by messenger is not balanced across all links
> -
>
> Key: PROTON-200
> URL: https://issues.apache.org/jira/browse/PROTON-200
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c, proton-j
>Affects Versions: 0.3
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.6
>
> Attachments: proton-200.patch, upstream-credit.patch
>
>
> The method used to distribute credit to receiving links may lead to 
> starvation when the number of receiving links is > the available credit.
> The distribution algorithm always starts with the same link - see 
> messenger.c::pn_messenger_flow()



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-343) Add a pluggable Proton logging layer

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839005#comment-13839005
 ] 

ASF subversion and git services commented on PROTON-343:


Commit 1547827 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1547827 ]

PROTON-343: added logging callback for proton-c

> Add a pluggable Proton logging layer
> 
>
> Key: PROTON-343
> URL: https://issues.apache.org/jira/browse/PROTON-343
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c, proton-j
>Reporter: Philip Harvey
>Assignee: Philip Harvey
> Fix For: 0.6
>
> Attachments: 
> 0001-PROTON-343-sketched-out-the-Java-parts-of-the-propos.patch
>
>
> Applications that use Proton sometimes want Proton to produce logging.
> Goals
> 
> * Proton should provide a default logging implementation.
> * It should be easy for Proton client code to provide custom logging 
> implementation, e.g. one that uses the same third party logging framework as 
> their application code.
> * Proton should not have a compile-time dependency on a third party logging 
> framework
> * Proton's log output is considered to be part of its public interface.  
> Therefore, in the spirit of Proton's cross-language consistency goals, this 
> output should be consistent between proton-c and proton-j.
> * The goals that general-purpose logging frameworks try to meet - 
> performance, ease of use etc - also apply.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-459) Perl binding omits pn_messenger_route interface

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839006#comment-13839006
 ] 

ASF subversion and git services commented on PROTON-459:


Commit 1547828 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547828 ]

PROTON-459: Added the route method to the Perl Messenger class.

> Perl binding omits pn_messenger_route interface
> ---
>
> Key: PROTON-459
> URL: https://issues.apache.org/jira/browse/PROTON-459
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>
> The Perl bindings do not expose the Messenger route function.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-460) Perl interface omits pn_messenger_rewrite()

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839007#comment-13839007
 ] 

ASF subversion and git services commented on PROTON-460:


Commit 1547829 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547829 ]

PROTON-460: Added the rewrite method to the Perl Messenger class.

> Perl interface omits pn_messenger_rewrite()
> ---
>
> Key: PROTON-460
> URL: https://issues.apache.org/jira/browse/PROTON-460
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>
> The Perl bindings do not expose the Messenger write function.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-464) Interpolate CMAKE_INSTALL_PREFIX into Ruby install directory.

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839014#comment-13839014
 ] 

ASF subversion and git services commented on PROTON-464:


Commit 1547832 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547832 ]

Revert "PROTON-464: Install Ruby bindings to install prefix if specified."

This reverts commit 4e15cc304f71b4e6506053bd1a51fffeff1a4190.

> Interpolate CMAKE_INSTALL_PREFIX into Ruby install directory.
> -
>
> Key: PROTON-464
> URL: https://issues.apache.org/jira/browse/PROTON-464
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> By checking the 'prefix' value from RbConfig::CONFIG, we can then take the 
> sitearch and sitelib paths and substitute that prefix value for what's given 
> by thye user with CMAKE_INSTALL_PREFIX.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-445) Binding installation ignores prefix

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839013#comment-13839013
 ] 

ASF subversion and git services commented on PROTON-445:


Commit 1547831 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547831 ]

Revert "PROTON-445: PHP install now honors the install prefix."

This reverts commit 395e4e3d3892639db126d7d8011c784f5aaae381.

> Binding installation ignores prefix
> ---
>
> Key: PROTON-445
> URL: https://issues.apache.org/jira/browse/PROTON-445
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Justin Ross
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
> Attachments: what-a-mess.txt
>
>
> It allows you *prepend* to the install prefix, but it gives you no way afaict 
> to actually change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you 
> try to get your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace 
> /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from 
> CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a 
> mechanism for staged installs (packaging systems use this), and it cannot 
> function correctly as an override for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding 
> install honor CMAKE_INSTALL_PREFIX.  Let the developer be responsible for 
> choosing the right location for his or her distribution.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-445) Binding installation ignores prefix

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839015#comment-13839015
 ] 

ASF subversion and git services commented on PROTON-445:


Commit 1547833 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547833 ]

Revert "PROTON-445: Perl install now honors CMAKE_INSTALL_PREFIX"

This reverts commit 17a0b3b5cb46301e40b2082f6c5316a0876422c1.

> Binding installation ignores prefix
> ---
>
> Key: PROTON-445
> URL: https://issues.apache.org/jira/browse/PROTON-445
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Justin Ross
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
> Attachments: what-a-mess.txt
>
>
> It allows you *prepend* to the install prefix, but it gives you no way afaict 
> to actually change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you 
> try to get your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace 
> /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from 
> CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a 
> mechanism for staged installs (packaging systems use this), and it cannot 
> function correctly as an override for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding 
> install honor CMAKE_INSTALL_PREFIX.  Let the developer be responsible for 
> choosing the right location for his or her distribution.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-445) Binding installation ignores prefix

2013-12-04 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13839016#comment-13839016
 ] 

ASF subversion and git services commented on PROTON-445:


Commit 1547834 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1547834 ]

Revert "PROTON-445: Python install now honors CMAKE_INSTALL_PREFIX"

This reverts commit e9557788a0098de4d6ec3e201fb0f53596e211c7.

> Binding installation ignores prefix
> ---
>
> Key: PROTON-445
> URL: https://issues.apache.org/jira/browse/PROTON-445
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Justin Ross
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
> Attachments: what-a-mess.txt
>
>
> It allows you *prepend* to the install prefix, but it gives you no way afaict 
> to actually change the prefix.
> This is the opposite of nice.  If you set a prefix for your build *and* you 
> try to get your bindings slotted in with them, via DESTDIR, you get this:
> # cmake -DCMAKE_INSTALL_PREFIX:PATH=/opt/myplace 
> /var/tmp/jross/baker/proton/source
> # make install DESTDIR=/opt/myplace
> /opt/myplace/usr/lib/python/*python files*
> /opt/myplace/opt/myplace/lib/*c files*
> ^^ Note "/opt/myplace/opt/myplace", the first from DESTDIR, the second from 
> CMAKE_INSTALL_PREFIX
> What it is doing now is simply abuse of DESTDIR.  DESTDIR is intended to be a 
> mechanism for staged installs (packaging systems use this), and it cannot 
> function correctly as an override for prefix.
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> My proposed solution to this is to stop this madness: make the binding 
> install honor CMAKE_INSTALL_PREFIX.  Let the developer be responsible for 
> choosing the right location for his or her distribution.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-343) Add a pluggable Proton logging layer

2013-12-05 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840063#comment-13840063
 ] 

ASF subversion and git services commented on PROTON-343:


Commit 1548123 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1548123 ]

PROTON-343: added transport context

> Add a pluggable Proton logging layer
> 
>
> Key: PROTON-343
> URL: https://issues.apache.org/jira/browse/PROTON-343
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c, proton-j
>Reporter: Philip Harvey
>Assignee: Philip Harvey
> Fix For: 0.6
>
> Attachments: 
> 0001-PROTON-343-sketched-out-the-Java-parts-of-the-propos.patch
>
>
> Applications that use Proton sometimes want Proton to produce logging.
> Goals
> 
> * Proton should provide a default logging implementation.
> * It should be easy for Proton client code to provide custom logging 
> implementation, e.g. one that uses the same third party logging framework as 
> their application code.
> * Proton should not have a compile-time dependency on a third party logging 
> framework
> * Proton's log output is considered to be part of its public interface.  
> Therefore, in the spirit of Proton's cross-language consistency goals, this 
> output should be consistent between proton-c and proton-j.
> * The goals that general-purpose logging frameworks try to meet - 
> performance, ease of use etc - also apply.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-260) Messenger Documentation

2013-12-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841461#comment-13841461
 ] 

ASF subversion and git services commented on PROTON-260:


Commit 1548607 from [~mgoulish] in branch 'proton/trunk'
[ https://svn.apache.org/r1548607 ]

PROTON-260   Improve API rdoc comments for Ruby.

> Messenger Documentation
> ---
>
> Key: PROTON-260
> URL: https://issues.apache.org/jira/browse/PROTON-260
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: michael goulish
>Assignee: michael goulish
>
> Write documentation for the Proton Messenger interface, to include:
>   introduction
>   API explanations
>   theory of operation
>   example programs
>   programming idioms
>   tutorials
>   quickstarts
>   troubleshooting
> Documents should use MarkDown markup language.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (PROTON-475) [python] Proton wrapper API's use of time values is inconsistent

2013-12-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843380#comment-13843380
 ] 

ASF subversion and git services commented on PROTON-475:


Commit 1549639 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1549639 ]

PROTON-475: use seconds-based timeout values

> [python] Proton wrapper API's use of time values is inconsistent
> 
>
> Key: PROTON-475
> URL: https://issues.apache.org/jira/browse/PROTON-475
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.6
>
>
> The precision used for timeout values in the Python API is inconsistent.  In 
> some case (messenger's timeout for example), timeouts are expressed in 
> seconds using a float.   In other cases, (driver wait(), etc), timeouts are 
> expressed in milliseconds.
> To be consistent with the Python time module, we should be expressing timeout 
> values as seconds using a float.  
> There should be no change to the AMQP timestamp type, of course, which is 
> defined as milliseconds since unix epoch.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-477) [python] Proton wrapper API does not enforce SASL or SSL singleton pattern

2013-12-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847566#comment-13847566
 ] 

ASF subversion and git services commented on PROTON-477:


Commit 1550748 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1550748 ]

PROTON-477: Enforce SASL and SSL singletons, fix minor errors flushed out by 
Pylint

> [python] Proton wrapper API does not enforce SASL or SSL singleton pattern
> --
>
> Key: PROTON-477
> URL: https://issues.apache.org/jira/browse/PROTON-477
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
> Fix For: 0.6
>
>
> The engine's object model defines a 1-to-1 relationship between a Transport 
> object at its associated SSL and SASL configurations.  The python wrapper did 
> not enforce this - it allowed the creation of multiple distinct python 
> objects for SASL and SSL per one Transport instance.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-478) status not updated for settled deliveries

2013-12-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851761#comment-13851761
 ] 

ASF subversion and git services commented on PROTON-478:


Commit 1551950 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1551950 ]

PROTON-478: added an explicit SETTLED status

> status not updated for settled deliveries
> -
>
> Key: PROTON-478
> URL: https://issues.apache.org/jira/browse/PROTON-478
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.6
>Reporter: Rafael H. Schloming
>Assignee: Rafael H. Schloming
>
> Messenger does not indicate any status change when deliveries are settled at 
> the receiver with no explicit delivery state.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-479) Expose Settled status in Ruby bindings.

2013-12-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851849#comment-13851849
 ] 

ASF subversion and git services commented on PROTON-479:


Commit 1551983 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1551983 ]

PROTON-479: Added PENDING status to Ruby Trackers

> Expose Settled status in Ruby bindings.
> ---
>
> Key: PROTON-479
> URL: https://issues.apache.org/jira/browse/PROTON-479
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-480) Expose Settled status in Perl bindings.

2013-12-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851850#comment-13851850
 ] 

ASF subversion and git services commented on PROTON-480:


Commit 1551984 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1551984 ]

PROTON-480: Added Tracker status values to Perl bindings.

> Expose Settled status in Perl bindings.
> ---
>
> Key: PROTON-480
> URL: https://issues.apache.org/jira/browse/PROTON-480
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-479) Expose Settled status in Ruby bindings.

2013-12-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851868#comment-13851868
 ] 

ASF subversion and git services commented on PROTON-479:


Commit 1552000 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1552000 ]

PROTON-479: Fixed typo in status

> Expose Settled status in Ruby bindings.
> ---
>
> Key: PROTON-479
> URL: https://issues.apache.org/jira/browse/PROTON-479
> Project: Qpid Proton
>  Issue Type: Improvement
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-481) [python] link name is not available

2013-12-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852160#comment-13852160
 ] 

ASF subversion and git services commented on PROTON-481:


Commit 1552098 from [~kgiusti] in branch 'proton/trunk'
[ https://svn.apache.org/r1552098 ]

PROTON-481: add accessor for link name

> [python] link name is not available
> ---
>
> Key: PROTON-481
> URL: https://issues.apache.org/jira/browse/PROTON-481
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c, proton-j
>Affects Versions: 0.5
>Reporter: Ken Giusti
>Assignee: Ken Giusti
>Priority: Trivial
> Fix For: 0.6
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-439) Support for dynamic reply-to address in Messenger

2013-12-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852551#comment-13852551
 ] 

ASF subversion and git services commented on PROTON-439:


Commit 1552218 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1552218 ]

fixed braino in PROTON-439

> Support for dynamic reply-to address in Messenger
> -
>
> Key: PROTON-439
> URL: https://issues.apache.org/jira/browse/PROTON-439
> Project: Qpid Proton
>  Issue Type: New Feature
>  Components: proton-c
>Affects Versions: 0.5
>Reporter: Ted Ross
>Assignee: Rafael H. Schloming
> Fix For: 0.6
>
>
> Messenger has no support for creating dynamic receivers for reply-to 
> addresses.  Please refer to the following email thread for prior discussion 
> on the topic.
> http://qpid.2158936.n2.nabble.com/Proton-Messenger-and-the-Request-Response-pattern-tp7586653.html



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-420) Warnings Presented When Using Strict Compiler Flags

2013-12-18 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852566#comment-13852566
 ] 

ASF subversion and git services commented on PROTON-420:


Commit 1552221 from r...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1552221 ]

PROTON-420: added error.h portion of patch

> Warnings Presented When Using Strict Compiler Flags
> ---
>
> Key: PROTON-420
> URL: https://issues.apache.org/jira/browse/PROTON-420
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Affects Versions: 0.5
> Environment: GCC 4.4.7
>Reporter: Frank Quinn
> Attachments: 
> FIX-Warnings-Presented-When-Using-Strict-Compiler-Flags-PROTON-420.patch
>
>
> Hi Folks,
> In our project, we currently use the following compiler flags for gcc (tested 
> in version 4.4.7):
> -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wstrict-prototypes 
> -Werror
> Unfortunately this causes problems in recent versions of proton as its 
> headers produce some warnings of their own. The ones we have spotted can be 
> recreated using the following code:
> #include 
> #include 
> int main(){}
> Compiled with:
> $ gcc -Wall -Wdeclaration-after-statement -Wmissing-prototypes 
> -Wstrict-prototypes -Werror -I./qpid-proton-0.5/proton-c/include/ test.c -o 
> test
> cc1: warnings being treated as errors
> In file included from test.c:1:
> ./qpid-proton-0.5/proton-c/include/proton/error.h:46: error: function 
> declaration isn’t a prototype
> In file included from test.c:2:
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:458:29: error: "/*" 
> within comment
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:466:40: error: "/*" 
> within comment
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:470:32: error: "/*" 
> within comment
> ./qpid-proton-0.5/proton-c/include/proton/messenger.h:475:34: error: "/*" 
> within comment
> test.c:4: error: function declaration isn’t a prototype
> The first one can be resolved by changing pn_error() to pn_error(void) and 
> the others can be fixed simply by adding some spacing. We typically just hack 
> our local copies for testing, but we figured it may be better to get this 
> into the main code stream if you guys can find the time to put it in.
> Cheers,
> Frank 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (PROTON-482) Ruby bindings install to vendorarchdir rather than vendorlibdir

2013-12-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853013#comment-13853013
 ] 

ASF subversion and git services commented on PROTON-482:


Commit 1552341 from [~mcpierce] in branch 'proton/trunk'
[ https://svn.apache.org/r1552341 ]

PROTON-482: Fix the Ruby install directory.

Use vendorarchdir rather than vendorlibdir.

> Ruby bindings install to vendorarchdir rather than vendorlibdir
> ---
>
> Key: PROTON-482
> URL: https://issues.apache.org/jira/browse/PROTON-482
> Project: Qpid Proton
>  Issue Type: Bug
>  Components: proton-c
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.6
>
>
> The vendorarchdir is the proper location on Ruby (1.8.7+) for platform 
> specific code, like the Ruby bindings. If this isn't found (Ruby 1.8.6) then 
> sitearchdir should be used.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


  1   2   3   4   5   6   7   8   9   10   >