[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...

2015-07-17 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/47#issuecomment-122437243 Ok. :+1. Ship it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...

2015-07-17 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/47#issuecomment-122435936 Changes look reasonable to me. Faster sudoless docker builds would be cool. You dropped the PYTHON_DIRS bit which was for tox to locate the various Python

[GitHub] qpid-proton pull request: Run the python-tox-test under Jenkins ...

2015-07-09 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/44 Run the python-tox-test under Jenkins Travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton travis Alternatively you can

[GitHub] qpid-proton pull request: PROTON-931: proton-j expose detached sta...

2015-07-03 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/41 PROTON-931: proton-j expose detached state of Link The Link detached state is required to assess when a LINK_REMOTE_DETACHED event is received as to whether or not it was as a result

[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes

2015-05-11 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/25#issuecomment-100819482 @dcristoloveanu you don't appear to have pushed the updated commits for this PR - could you also `git pull --rebase` from master and then squash into a single commit

[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...

2015-05-06 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-99380746 @dcristoloveanu I'd be happy to merge these changes in for you as it is certainly better for the library not to segfault if a malloc fails. However, I do wonder

[GitHub] qpid-proton pull request: NO-JIRA: improvements to export.sh

2015-05-06 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/28 NO-JIRA: improvements to export.sh + allow specific tag to be specified as cmdline arg + confirm the tag exists before proceeding + use the version.txt from that tag as the tar prefix

[GitHub] qpid-proton pull request: NO-JIRA: improvements to export.sh

2015-05-06 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/28#issuecomment-99431533 Removed by 81c2110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] qpid-proton pull request: proton-c: minor code fixes

2015-04-29 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/26 proton-c: minor code fixes Prevent pn_data_vfill from peeking at memory outside the intended bounds and fix a few minor -Wextra warnings about incomplete struct initialisation You can merge

[GitHub] qpid-proton pull request: proton-c: minor code fixes

2015-04-29 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/26#issuecomment-97600613 ![build passing](https://travis-ci.org/dnwe/qpid-proton.svg) https://travis-ci.org/dnwe/qpid-proton/builds/60601702 --- If your project is set up for it, you

[GitHub] qpid-proton pull request: Fixes for Mac OS X

2015-04-27 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96820535 @rhs readily reproducible, [output from 20 runs](https://gist.github.com/dnwe/76c504f2a3067b32b904) and [python trace bz2](https://dl.dropboxusercontent.com/u

[GitHub] qpid-proton pull request: Fixes for Mac OS X

2015-04-27 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96717495 @rhs I believe you originally wrote the SelectableMessengerTest, could you take a look at change and confirm if this is an acceptable change in the test behaviour

[GitHub] qpid-proton pull request: Fixes for Mac OS X

2015-04-27 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/23 Fixes for Mac OS X 1. default to building universal binaries so the various language bindings can link against the system libraries out of the box 2. small fix to SelectableMessengerTest

[GitHub] qpid-proton pull request: Fixes for Mac OS X

2015-04-27 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96722982 fixes-for-mac: ![build passing](https://travis-ci.org/dnwe/qpid-proton.svg?branch=fixes-for-mac) --- If your project is set up for it, you can reply to this email

[GitHub] qpid-proton pull request: NO-JIRA: README improvements

2015-04-24 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/22 NO-JIRA: README improvements * remove out-of-date product information from the README and include the more current information from the website * add a new INSTALL file to contain

[GitHub] qpid-proton pull request: NO-JIRA: README improvements

2015-04-24 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/22#issuecomment-95931032 I've sent these off to be further reviewed by a few people round here to see if I can determine further improvements., Have merged them in as-is for now as I believe

[GitHub] qpid-proton pull request: PROTON-853: stop erroneous attach being ...

2015-04-22 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/21#issuecomment-95147399 +1 from me, not seen any issues in our FV after applying these commits + PROTON-850 --- If your project is set up for it, you can reply to this email and have your

[GitHub] qpid-proton pull request: PROTON-853: stop erroneous attach being ...

2015-04-21 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/21#issuecomment-94719493 @gemmellr sure, just pulling in this PR now and will run some scenarios through it --- If your project is set up for it, you can reply to this email and have your

[GitHub] qpid-proton pull request: PROTON-843: Java should match C for idle...

2015-04-02 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/15 PROTON-843: Java should match C for idle timeout As discussed on the mailing list. Currently proton-j advertises a provided local idle timeout value as-is, whereas proton-c will halve

[GitHub] qpid-proton pull request: PROTON-844: police handle-max in proton-...

2015-04-02 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/16 PROTON-844: police handle-max in proton-j * when receiving an attach with a handle handle-max, the connection should be closed * when attempting to allocate a new local handle when

[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar

2015-03-30 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/14#issuecomment-87664489 @rhs as we've not announced 0.9 on the website yet, it might be worth re-creating the 0.9 release tar using the updated export.sh and re-uploading it? --- If your

[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar

2015-03-30 Thread dnwe
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/14#issuecomment-87685628 *technically* we wouldn't have a name clash because of the .tgz -- .tar.gz renaming, so people would only notice if they browsed the mirror filesystems and saw both

[GitHub] qpid-proton pull request: PROTON-834: further UTF-8 encoder fixes

2015-03-16 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/13 PROTON-834: further UTF-8 encoder fixes After commit c65e897 it turned out there were still some issues with strings containing a codepoint 0xDBFF which was being incorrectly treated

[GitHub] qpid-proton pull request: PROTON-576: modified UTF-8 encoder fixes

2015-03-04 Thread dnwe
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/10 PROTON-576: modified UTF-8 encoder fixes Commit 5069bb6 applied a modified version of a patch I submitted, to ensure that the UTF-8 encoder (and UTF-8 byte length calculator) would cope