[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/47#issuecomment-122437243 Ok. :+1. Ship it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: NO-JIRA: Change travis configuration to ...
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/47#issuecomment-122435936 Changes look reasonable to me. Faster sudoless docker builds would be cool. You dropped the PYTHON_DIRS bit which was for tox to locate the various Python interps. With the new format do we still get coverage on all the pythons? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Run the python-tox-test under Jenkins ...
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/44 Run the python-tox-test under Jenkins Travis You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton travis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit d2e4b0bce27a663366cd6cdfb107893b930a15fa Author: Kenneth Giusti kgiu...@apache.org Date: 2015-07-08T18:55:20Z NO-JIRA: update jenkins scripts to run python-tox-test if possible commit 17946939e4e5ab8dbc282237b3a961178176dfa3 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-07-08T19:12:07Z NO-JIRA: update travis to support the tox suite --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: PROTON-931: proton-j expose detached sta...
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/41 PROTON-931: proton-j expose detached state of Link The Link detached state is required to assess when a LINK_REMOTE_DETACHED event is received as to whether or not it was as a result of a local detach or the remote end detaching or closing the link. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton proton-931 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit dcc09f153e0f02b8f9895d76e652b0adf6bb5f76 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-07-03T15:24:36Z PROTON-931: proton-j expose detached state of Link The Link detached state is required to assess when a LINK_REMOTE_DETACHED event is received as to whether or not it was as a result of a local detach or the remote end detaching or closing the link. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/25#issuecomment-100819482 @dcristoloveanu you don't appear to have pushed the updated commits for this PR - could you also `git pull --rebase` from master and then squash into a single commit with the updates --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-99380746 @dcristoloveanu I'd be happy to merge these changes in for you as it is certainly better for the library not to segfault if a malloc fails. However, I do wonder if there are numerous places where these methods are currently called and expected to always be non-NULL. For example, `pn_buffer` allocations are used liberally and rarely checked for validity before being used, so unless I'm mistaken, it seems like we will just push the segfault up the call chain? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: NO-JIRA: improvements to export.sh
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/28 NO-JIRA: improvements to export.sh + allow specific tag to be specified as cmdline arg + confirm the tag exists before proceeding + use the version.txt from that tag as the tar prefix folder + re-run the version.sh script before packaging to ensure the correct version is set + add .gitattributes to exclude .gitignore files from the exported tar Closes #28 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fix-export-script Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit a90e2b1c04dd8a03d240b83ed9b67c3f7611a66c Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-05-06T11:03:58Z NO-JIRA: improvements to export.sh + allow specific tag to be specified as cmdline arg + confirm the tag exists before proceeding + use the version.txt from that tag as the tar prefix folder + re-run the version.sh script before packaging to ensure the correct version is set + add .gitattributes to exclude .gitignore files from the exported tar Closes #28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: NO-JIRA: improvements to export.sh
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/28#issuecomment-99431533 Removed by 81c2110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: proton-c: minor code fixes
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/26 proton-c: minor code fixes Prevent pn_data_vfill from peeking at memory outside the intended bounds and fix a few minor -Wextra warnings about incomplete struct initialisation You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton minor-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 4cfebeb02b8ab1da5cb98fa52bf0bca50903d4c9 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-29T16:09:29Z NO-JIRA: prevent out-of-bounds memory access commit 83d9d2b545a1084813625049940fa47384173afc Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-29T18:04:32Z NO-JIRA: define pn_io_inspect as NULL commit ab83859058a23de93116a6544b1de4789470715b Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-29T18:06:46Z NO-JIRA: struct initialisation warning fixes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: proton-c: minor code fixes
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/26#issuecomment-97600613  https://travis-ci.org/dnwe/qpid-proton/builds/60601702 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96820535 @rhs readily reproducible, [output from 20 runs](https://gist.github.com/dnwe/76c504f2a3067b32b904) and [python trace bz2](https://dl.dropboxusercontent.com/u/951543/trace.log.bz2) from a single run of the four tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96717495 @rhs I believe you originally wrote the SelectableMessengerTest, could you take a look at change and confirm if this is an acceptable change in the test behaviour? It wasn't clear to me if you were intending to validate that a single call to Pump#pump would always result in at least one message being flowed into incoming? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/23 Fixes for Mac OS X 1. default to building universal binaries so the various language bindings can link against the system libraries out of the box 2. small fix to SelectableMessengerTest as it was regularly failing on Mac builds. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fixes-for-mac Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 2a120b8d401c6931f46757717e9883e4f8c41ebb Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-27T14:41:55Z NO-JIRA: default to universal binaries on Mac OS X The system-installed Perl, Python etc. are all built as universal binaries on Mac and so we need to build libqpid-proton to similarly contain both architectures. This allows the bindings to link successfully. commit c07377c780cb70153e5c1f9136e69fcbbbcfa5a2 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-27T15:28:33Z NO-JIRA: fix SelectableMessengerTest on Mac The SelectableMessengerTest was failing intermittently on Mac builds, Modify the test slightly to be more resilient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fixes for Mac OS X
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/23#issuecomment-96722982 fixes-for-mac:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: NO-JIRA: README improvements
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/22 NO-JIRA: README improvements * remove out-of-date product information from the README and include the more current information from the website * add a new INSTALL file to contain the build and install instructions from the existing README * move all development and testing related info from that to the DEVELOPERS file * better explain how to run the various test suites and how they work across proton-c and proton-j in the developers file * other misc improvements across the contents of the files * rename DEVELOPERS and INSTALL to have .md suffixes for better rendering on GitHub * add a symlink from README -- README.md for better landing page rendering on GitHub You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton improve-readmes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit b532cf25756424c840047ad039b5c43eeb864046 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-24T11:14:17Z NO-JIRA: README improvements * remove out-of-date product information from the README and include the more current information from the website * add a new INSTALL file to contain the build and install instructions from the existing README * move all development and testing related info from that to the DEVELOPERS file * better explain how to run the various test suites and how they work across proton-c and proton-j in the developers file * other misc improvements across the contents of the files * rename DEVELOPERS and INSTALL to have .md suffixes for better rendering on GitHub * add a symlink from README -- README.md for better landing page rendering on GitHub --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: NO-JIRA: README improvements
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/22#issuecomment-95931032 I've sent these off to be further reviewed by a few people round here to see if I can determine further improvements., Have merged them in as-is for now as I believe they're a decent first pass at improving what we currently had. @mcpierce fyi, this will require an update to the rpm qpid-proton.spec to account for the new file extension of `README.md` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: PROTON-853: stop erroneous attach being ...
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/21#issuecomment-95147399 +1 from me, not seen any issues in our FV after applying these commits + PROTON-850 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: PROTON-853: stop erroneous attach being ...
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/21#issuecomment-94719493 @gemmellr sure, just pulling in this PR now and will run some scenarios through it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: PROTON-843: Java should match C for idle...
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/15 PROTON-843: Java should match C for idle timeout As discussed on the mailing list. Currently proton-j advertises a provided local idle timeout value as-is, whereas proton-c will halve it before sending it to the remote side. The two implementations should match in behaviour. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fix-proton-843 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit 0b439c16e72560d575bce67e5a4300d1ea89ef52 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-02T17:47:14Z PROTON-843: Java should match C for idle timeout As discussed on the mailing list. Currently proton-j advertises a provided local idle timeout value as-is, whereas proton-c will halve it before sending it to the remote side. The two implementations should match in behaviour. Closes #15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: PROTON-844: police handle-max in proton-...
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/16 PROTON-844: police handle-max in proton-j * when receiving an attach with a handle handle-max, the connection should be closed * when attempting to allocate a new local handle when handle-max are already in-use should throw an Exception * the default of 1024 handle-max is quite small when proton-c appears to default to 4294967295 - increase it more modestly to 65536 Closes #16 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fix-proton-844 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit f937ccd04a99575cb44ec4108908d155e9f3a101 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-04-02T17:59:27Z PROTON-844: police handle-max in proton-j * when receiving an attach with a handle handle-max, the connection should be closed * when attempting to allocate a new local handle when handle-max are already in-use should throw an Exception * the default of 1024 handle-max is quite small when proton-c appears to default to 4294967295 - increase it more modestly to 65536 Closes #16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/14#issuecomment-87664489 @rhs as we've not announced 0.9 on the website yet, it might be worth re-creating the 0.9 release tar using the updated export.sh and re-uploading it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: NO-JIRA: export.sh creates pax-based tar
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/14#issuecomment-87685628 *technically* we wouldn't have a name clash because of the .tgz -- .tar.gz renaming, so people would only notice if they browsed the mirror filesystems and saw both a .tgz and a .tar.gz But, you're right, it might be worth pushing it out as qpid-proton-0.9.1.tar.gz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: PROTON-834: further UTF-8 encoder fixes
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/13 PROTON-834: further UTF-8 encoder fixes After commit c65e897 it turned out there were still some issues with strings containing a codepoint 0xDBFF which was being incorrectly treated as a surrogate pair in the calculateUTF8Length method. Fixed this up and added some more test coverage. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fix-proton-834 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit dc52650e7de53ef5fe294b9066620b4698c30a94 Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-03-16T12:18:20Z PROTON-834: further UTF-8 encoder fixes After commit c65e897 it turned out there were still some issues with strings containing a codepoint 0xDBFF which was being incorrectly treated as a surrogate pair in the calculateUTF8Length method. Fixed this up and added some more test coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: PROTON-576: modified UTF-8 encoder fixes
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/10 PROTON-576: modified UTF-8 encoder fixes Commit 5069bb6 applied a modified version of a patch I submitted, to ensure that the UTF-8 encoder (and UTF-8 byte length calculator) would cope with surrogate pairs. This commit fixes an issue with three byte characters in the = 0x range being incorrectly detected as invalid four byte surrogates. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fix-proton-576 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 6ed99b97164d1bdb463b3bdbfc0507e0e603949e Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-03-04T16:21:46Z PROTON-576: modified UTF-8 encoder fixes Commit 5069bb6 applied a modified version of a patch I submitted, to ensure that the UTF-8 encoder (and UTF-8 byte length calculator) would cope with surrogate pairs. This commit fixes an issue with three byte characters in the = 0x range being incorrectly detected as invalid four byte surrogates. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
