Re: Why 2 space indentations??

Well, since you brought it up, Ken Readability is exactly why I have always used this rule: if a scope does not close on the same line it opens on, then you can look straight down from the open to see the close. People learn The Other Style { } from books that originally used it to conserve

Re: Why 2 space indentations??

+1. I've also wondered why this one codebase was written with 2-space indentation. My editors are all set up for 4-spaces so doing any work in this code is a pain. I'm in favor of converting all of it to comply with the 4-space convention. -Ted On 03/14/2013 09:18 AM, Ken Giusti wrote: Not

Re: nagle algorithm

+1 It would be good to make this configurable, but in the absence of configurability, we should turn Nagle off by default. -Ted On 03/14/2013 03:25 PM, Rafael Schloming wrote: I think in most of the other network code at qpid we tend to disable nagle as you suggest, so I expect it would make

[jira] [Commented] (PROTON-215) Add tests to verify AMQP 1.0 type support for all language bindings

[ https://issues.apache.org/jira/browse/PROTON-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603366#comment-13603366 ] Alan Conway commented on PROTON-215: We also need Perl tests. > Add t

Re: tracker concept

Yes! I'd love to give it a whack. Right after I kill a pesky SEV1 bug I'm working on - Original Message - Can you post the code for the scenario you describe? --Rafael On Wed, Mar 13, 2013 at 11:19 AM, Michael Goulish wrote: > What would you think about having a call to pn_messen

Fwd: Build failed in Jenkins: Qpid-proton-c #34

FYI - I'm looking into this. - Forwarded Message - > From: "Apache Jenkins Server" > To: notificati...@qpid.apache.org > Sent: Thursday, March 14, 2013 10:38:17 PM > Subject: Build failed in Jenkins: Qpid-proton-c #34 > > See > >

Re: new doc on message disposition

On 03/14/2013 04:39 PM, Michael Goulish wrote: Checked in at trunk/docs/messenger/message_disposition.md This one has it all ! Windows! Trackers! The joy of message acceptance and the crushing disappointment of message rejection! Flash animation! Soundtrack featuring local indie rock

Re: new doc on message disposition

Just had a read through and it looks good overall. A few minor comments in no particular order: - The note at the end about rejected messages is not quite right. Rejection does imply that the rejecting recipient will never be able to deal with that message. The spec actually includes another dis

Re: new doc on message disposition

Excellent points, thanks ! - Original Message - Just had a read through and it looks good overall. A few minor comments in no particular order: - The note at the end about rejected messages is not quite right. Rejection does imply that the rejecting recipient will never be able to de

Re: new doc on message disposition

Thanks! I will answer these questions in next version. - Original Message - On 03/14/2013 04:39 PM, Michael Goulish wrote: > > Checked in at > > trunk/docs/messenger/message_disposition.md > > This one has it all ! > Windows! Trackers! The joy of message acceptance > and the crus

Re: Why 2 space indentations??

I'm feeling a bit guilty about this one because I suspect it was my indentation-related review comments on some of Ken's recent soak test work that may have been the catalyst for this thread. We've got a few options about what to do, each bringing their own special kind of pain. I would be in fav

Re: Yet Another communication improvement suggestion

Thank you for all your replies. I was pleased by the positive response so I think it is worth setting something up. Here is my revised proposal. I believe this process will significantly increase visibility for all the project stakeholders with minimal effort. === Proposed status updates proces