[
https://issues.apache.org/jira/browse/PROTON-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574519#comment-14574519
]
ASF subversion and git services commented on PROTON-895:
Commit
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31842854
--- Diff: proton-c/bindings/cpp/README.md ---
@@ -0,0 +1,24 @@
+# C++ binding for proton.
+
+This is a C++ wrapper for the proton reactor
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31840954
--- Diff: examples/cpp/example_test.py ---
@@ -0,0 +1,105 @@
+#
--- End diff --
No, it is a test script that runs the C++ examples and
Gordon Sim created PROTON-901:
-
Summary: No constants defined for Termins.expiry_policy
Key: PROTON-901
URL: https://issues.apache.org/jira/browse/PROTON-901
Project: Qpid Proton
Issue Type: Bug
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31834366
--- Diff: proton-c/bindings/CMakeLists.txt ---
@@ -109,6 +109,11 @@ if (EMSCRIPTEN_FOUND)
set (DEFAULT_JAVASCRIPT ON)
endif
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31842778
--- Diff: proton-c/bindings/CMakeLists.txt ---
@@ -109,6 +109,11 @@ if (EMSCRIPTEN_FOUND)
set (DEFAULT_JAVASCRIPT ON)
endif
[
https://issues.apache.org/jira/browse/PROTON-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575095#comment-14575095
]
ASF subversion and git services commented on PROTON-901:
Commit
[
https://issues.apache.org/jira/browse/PROTON-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gordon Sim resolved PROTON-901.
---
Resolution: Fixed
No constants defined for Termins.expiry_policy
[
https://issues.apache.org/jira/browse/PROTON-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575172#comment-14575172
]
ASF subversion and git services commented on PROTON-895:
Commit
[
https://issues.apache.org/jira/browse/PROTON-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575077#comment-14575077
]
ASF subversion and git services commented on PROTON-865:
Commit
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844356
--- Diff: CMakeLists.txt ---
@@ -20,16 +20,15 @@ cmake_minimum_required (VERSION 2.6)
project (Proton C)
+# Enable C++ now for
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109421363
Another general point (I can't exactly see where to attach it in the
changes):
As well as using a class hierarchy to get callbacks, we should think about
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844888
--- Diff: proton-c/bindings/CMakeLists.txt ---
@@ -109,6 +109,11 @@ if (EMSCRIPTEN_FOUND)
set (DEFAULT_JAVASCRIPT ON)
endif
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109423155
There are a number of places in the API where the API has something like:
`void setXXX(const char* bytes, size_t size);` this isn't very C++ like -
in fact it
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109426860
On Fri, 2015-06-05 at 13:05 -0700, Andrew Stitcher wrote:
There are a number of places in the API where the API has something
like:
void
Github user astitcher commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844585
--- Diff: proton-c/bindings/cpp/include/proton/cpp/Acceptor.h ---
@@ -0,0 +1,50 @@
+#ifndef PROTON_CPP_ACCEPTOR_H
+#define PROTON_CPP_ACCEPTOR_H
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109412800
On Fri, 2015-06-05 at 11:13 -0700, Andrew Stitcher wrote:
Some overall comments (from a not yet thorough) read through:
I really don't like using set/get
Github user alanconway commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/35#discussion_r31844238
--- Diff: proton-c/bindings/cpp/include/proton/cpp/Acceptor.h ---
@@ -0,0 +1,50 @@
+#ifndef PROTON_CPP_ACCEPTOR_H
+#define
[
https://issues.apache.org/jira/browse/PROTON-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gordon Sim updated PROTON-901:
--
Summary: No constants defined for Terminus.expiry_policy (was: No
constants defined for
I think this has been discussed before, but is there a consensus on
what C++ version we want to target for the C++ binding? C++03 is old
and smelly. C++11 is better, C++14 better still and afaik any compiler
that does 11 will do 14. So the sensible choices would seem to be:
1. Smelly C++03 code
Github user alanconway commented on the pull request:
https://github.com/apache/qpid-proton/pull/35#issuecomment-109413137
On Fri, 2015-06-05 at 10:37 -0700, Andrew Stitcher wrote:
There seem to be a couple of extraneous go example files that have
snuck into this PR
â
21 matches
Mail list logo
