Re: Engine API naming

2012-12-20 Thread Rafael Schloming
On Tue, Dec 18, 2012 at 3:21 PM, Justin Ross wrote:Types > >>> pn_disposition_t >>> >>> Existing C name:pn_disposition_t >>> Proposed C name: >>> Existing Java name: DeliveryState >>> Proposed Java name: Disposition >>> >>> DeliveryState vs. Disposition. A good example

Re: Engine API naming

2012-12-20 Thread Justin Ross
On Thu, 20 Dec 2012, Rafael Schloming wrote: On Tue, Dec 18, 2012 at 2:58 PM, Justin Ross wrote: On Fri, 14 Dec 2012, Rafael Schloming wrote: On Thu, Dec 13, 2012 at 5:37 PM, Justin wrote: I've found the whole process of proposing API review dispiriting. You can, of course, take it o

Re: Engine API naming

2012-12-20 Thread Rafael Schloming
On Tue, Dec 18, 2012 at 2:58 PM, Justin Ross wrote: > On Fri, 14 Dec 2012, Rafael Schloming wrote: > > On Thu, Dec 13, 2012 at 5:37 PM, Justin wrote: >> >> I've found the whole process of proposing API review dispiriting. You >>> can, of course, take it or leave it. I in no way wish to claim

Re: Engine API naming

2012-12-18 Thread Justin Ross
Comments below. On Fri, 14 Dec 2012, Rafael Schloming wrote: On Thu, Dec 13, 2012 at 5:37 PM, Justin wrote: API usability is important and deserves attention. Take, for instance, DeliveryState versus Disposition. That only serves to confuse people. It's a difference that has no content.

Re: Engine API naming

2012-12-18 Thread Justin Ross
On Fri, 14 Dec 2012, Rafael Schloming wrote: On Thu, Dec 13, 2012 at 5:37 PM, Justin wrote: I've found the whole process of proposing API review dispiriting. You can, of course, take it or leave it. I in no way wish to claim I have better choices. I only wish to point out things that might

Re: Engine API naming

2012-12-18 Thread Justin Ross
On Fri, 14 Dec 2012, Rob Godfrey wrote: On 14 December 2012 01:02, Weston M. Price wrote: On things such as bitmaps vs. enums, I think that's just a language convention thing... I don't see a huge need to make such things identical. Naming is something that should be aligned between APIs

Re: Engine API naming

2012-12-18 Thread Justin Ross
On Fri, 14 Dec 2012, Rob Godfrey wrote: A couple of comments... On 13 December 2012 23:37, Justin wrote: API usability is important and deserves attention. pn_link_drain Existing C name:pn_link_drain Proposed C name:pn_link_rescind_credit Existing Java name: Re

Re: Engine API naming

2012-12-14 Thread Rafael Schloming
On Thu, Dec 13, 2012 at 5:37 PM, Justin wrote: > API usability is important and deserves attention. > > Take, for instance, DeliveryState versus Disposition. That only serves to > confuse people. It's a difference that has no content. I also think > link.drained and link.offered are very uncl

Re: Engine API naming

2012-12-14 Thread Rafael Schloming
On Thu, Dec 13, 2012 at 5:37 PM, Justin wrote: > I've found the whole process of proposing API review dispiriting. You > can, of course, take it or leave it. I in no way wish to claim I have > better choices. I only wish to point out things that might deserve more > deliberation. > Can you pl

Re: Engine API naming

2012-12-13 Thread Weston M. Price
On Dec 13, 2012, at 7:23 PM, Rob Godfrey wrote: > On 14 December 2012 01:02, Weston M. Price wrote: > >> >> On Dec 13, 2012, at 6:22 PM, Rob Godfrey wrote: >> >>> A couple of comments... >>> >>> On 13 December 2012 23:37, Justin wrote: >>> API usability is important and deserves att

Re: Engine API naming

2012-12-13 Thread Rob Godfrey
On 14 December 2012 01:02, Weston M. Price wrote: > > On Dec 13, 2012, at 6:22 PM, Rob Godfrey wrote: > > > A couple of comments... > > > > On 13 December 2012 23:37, Justin wrote: > > > >> API usability is important and deserves attention. > >> > >> > > > > > > > >> > >> pn_link_drain > >> >

Re: Engine API naming

2012-12-13 Thread Weston M. Price
On Dec 13, 2012, at 6:22 PM, Rob Godfrey wrote: > A couple of comments... > > On 13 December 2012 23:37, Justin wrote: > >> API usability is important and deserves attention. >> >> > > > >> >> pn_link_drain >> >>Existing C name:pn_link_drain >>Proposed C name:pn_link_r

Re: Engine API naming

2012-12-13 Thread Rob Godfrey
A couple of comments... On 13 December 2012 23:37, Justin wrote: > API usability is important and deserves attention. > > > > pn_link_drain > > Existing C name:pn_link_drain > Proposed C name:pn_link_rescind_credit > Existing Java name: Receiver.drain > Proposed Java

Re: Engine API naming

2012-12-13 Thread Weston M. Price
Nice suggestions actually. I think some of the discrepancy has to do with the difference between languages and the idioms that have long been fossilized int the different naming conventions. Again, all suggestions on proposed look good to me. Regards, -W On Dec 13, 2012, at 5:37 PM, Justin