[Prototype-core] Re: readAttribute() differences IE and Firefox

2008-02-13 Thread Tobie Langel
Great jobs guys... unit tests would make it even better! Best, Tobie On Feb 13, 12:22 am, John-David Dalton [EMAIL PROTECTED] wrote: http://dev.rubyonrails.org/ticket/11092 updated the ticket with an alternative fix which works for everything except child elements with duplicate id's.

[Prototype-core] unit test stalling: enumerable.html

2008-02-13 Thread Dr Nic
On trunk, on both firefox and safari, the testEachSlice method in enumerable.html is stalling (seemingly indefinitely). Is reproducible by anyone else? I ran it via rake test_units and by loading the html directly into browsers. --~--~-~--~~~---~--~~ You received

[Prototype-core] Re: unit test stalling: enumerable.html

2008-02-13 Thread Tobie Langel
Have you rebuilt Prototype ? Best, Tobie On Feb 13, 12:04 pm, Dr Nic [EMAIL PROTECTED] wrote: On trunk, on both firefox and safari, the testEachSlice method in enumerable.html is stalling (seemingly indefinitely). Is reproducible by anyone else? I ran it via rake test_units and by loading

[Prototype-core] Re: unit test stalling: enumerable.html

2008-02-13 Thread Tobie Langel
afaik, rake test_units doesn't run rake dist before. Use rake test instead, which auto builds Prototype each time. Best, Tobie On Feb 13, 12:14 pm, Tobie Langel [EMAIL PROTECTED] wrote: Have you rebuilt Prototype ? Best, Tobie On Feb 13, 12:04 pm, Dr Nic [EMAIL PROTECTED] wrote: On

[Prototype-core] Re: unit test stalling: enumerable.html

2008-02-13 Thread Dr Nic
Ah, thx again. On Feb 13, 9:21 pm, Tobie Langel [EMAIL PROTECTED] wrote: afaik, rake test_units doesn't run rake dist before. Use rake test instead, which auto builds Prototype each time. Best, Tobie On Feb 13, 12:14 pm, Tobie Langel [EMAIL PROTECTED] wrote: Have you rebuilt

[Prototype-core] Re: readAttribute() differences IE and Firefox

2008-02-13 Thread John-David Dalton
A two parter: 1) Would that mean t modifying he dom.html unit test to test for this? 2) I ran the unit test with prototype 1.6.0.2 downloaded from prototypejs.org and in each browser diff tests fail. Does this mean that there are issues with the current code base that are still needing to be

[Prototype-core] Re: readAttribute() differences IE and Firefox

2008-02-13 Thread John-David Dalton
I suspect the unit tests are tailered for the current revision in svn.. time for me to dload rails... or manually compile me some js. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to

[Prototype-core] Re: readAttribute() differences IE and Firefox

2008-02-13 Thread Tobie Langel
1) yes, well, at least, adding the necessary code and maybe html. 2) make sure you build Prototype before running the tests (use rake dist or run the tests from rake using rake test which auto build Prototype). Currently all tests pass in all supported browsers except a coouple of known issues

[Prototype-core] Re: readAttribute() differences IE and Firefox

2008-02-13 Thread John-David Dalton
Rock! Updated the ticket, passes the dom.html unit test with flying colors. Also added a modified unit test that contains tests for this ticket. The files of importance are ie_attrib_patch.diff dom.html http://dev.rubyonrails.org/ticket/11092