On 8/7/07, Andrew Dupont [EMAIL PROTECTED] wrote:
No - that'd be incorrect in both cases. Semicolons are needed when a
line is ended with the closing brace of a function literal or object
literal, but not when a line is ended with the closing brace of a
control structure.
Agreed, but at
Thanx :),
Mislav what you saw as semi colons after conditionals was probably a
trick of the eyes (though the first patch may have had one as a typo)
with code like this: http://pastie.caboo.se/85947
As to semi colons after things like:
var foo = function(){
alert('foobar');
};
This example
by the way jdalton = John-David Dalton
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group,
Looks OK. How does the rest of the core team feel about this?
Do we need semicolons after:
1. conditional blocks,
2. function definitions (not function literals)?
Thanks,
- Mislav
On 8/6/07, jdalton [EMAIL PROTECTED] wrote:
Repatched per Mislavs request:
No - that'd be incorrect in both cases. Semicolons are needed when a
line is ended with the closing brace of a function literal or object
literal, but not when a line is ended with the closing brace of a
control structure.
Cheers,
Andrew
On Aug 7, 1:09 pm, Mislav Marohnić [EMAIL PROTECTED]
Repatched per Mislavs request:
http://dev.rubyonrails.org/ticket/9140
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To
On 7/29/07, FOX [EMAIL PROTECTED] wrote:
95% of the code has a correct declaration ended with ;
What is the problem adding next thirty semicolons?
Here is a semicolon that gives us the creeps, for instance:
function(foo) { return foo * 2; }
Our general rule is no semicolons in one-liner
Might I suggest that if valid Javascript isn't accepted by the
packer, the problem is with the packer, not the source? Have you
looked into patching the packer?
TAG
On Jul 29, 2007, at 10:50 AM, FOX wrote:
Hi,
I patched latest prototype.js 1.5.1.1
My version can be compressed to 40kB
I added a ticket + patch file
http://dev.rubyonrails.org/ticket/9140
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To
ProtoPacked 2.16 has every major Prototype release formatted to work
with compressors,
It's great.
I have not made a patch because I get the feeling most of the core dev
cares little about this.
95% of the code has a correct declaration ended with ;
What is the problem adding next thirty
I just made an ant task that does this. The only difference is that
I'm using shrink safe.
On Jul 29, 10:20 am, jdalton [EMAIL PROTECTED] wrote:
ProtoPacked 2.16 has every major Prototype release formatted to work
with compressors,
I have not made a patch because I get the feeling most of the
11 matches
Mail list logo
