[Prototype-core] Re: Cross-browser Event.simulateMouse [bump via kangax]
Yes there might be a better/more complete possibility, and someone might do it in the future I think I'd rather see an incremental fix now; AND wait for someone to write an even better version later. Perhaps once this patch is in, someone else will look at it You could be that someone ;) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cross-browser Event.simulateMouse [bump via kangax]
The reason I'm not too keen on adding this two unit tests is two- folds: First I think it belongs in Prototype core, secondly, I'm in the process of rewriting a good deal of unit_tests so I really don't think it's a good time to add features to it. I'd rather strengthen it as much as possible beforehand. Best, Tobie On Feb 4, 1:19 pm, Nic Williams [EMAIL PROTECTED] wrote: Heh. If I am, then I'll be that person some time in the future :) I'm trying to work on unittest; which just happens to co-share a repo + mailing list with prototype :) On 2/4/08, Nick Stakenburg [EMAIL PROTECTED] wrote: Yes there might be a better/more complete possibility, and someone might do it in the future I think I'd rather see an incremental fix now; AND wait for someone to write an even better version later. Perhaps once this patch is in, someone else will look at it You could be that someone ;) -- Dr Nic Williamshttp://drnicacademy.com- Ruby/Rails training/dev around the worldhttp://drnicwilliams.com- Ruby/Rails/Javascript/Web2.0 (skype) nicwilliams (p) +61 412 002 126 / +61 7 3113 3033 (mail) PO Box 583 Ashgrove 4060 QLD Aus --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cross-browser Event.simulateMouse [bump via kangax]
I don't have a timeframe for this unfortunately. And yes, the API will change quite a bit as we'd like to map it more closely to ruby's Test::Unit implementation. I'm not far enough into refactoring to know how backward-compatible this rewrite will be. Will make sure to let you know as soon as I have more info. Best, Tobie On Feb 4, 3:03 pm, Nic Williams [EMAIL PROTECTED] wrote: What's your timeframe for finishing this? Will its API change much? I started doing screencasts of how to use unittest today for peepcode. If this patch is not useful, then it suggests the current Event.simulateMouse code should be removed as part of the refactoring. Force people to go looking for a tested, known working library to perform the simulations rather than attempt to use known non-working code? On 2/4/08, Tobie Langel [EMAIL PROTECTED] wrote: The reason I'm not too keen on adding this two unit tests is two- folds: First I think it belongs in Prototype core, secondly, I'm in the process of rewriting a good deal of unit_tests so I really don't think it's a good time to add features to it. I'd rather strengthen it as much as possible beforehand. Best, Tobie On Feb 4, 1:19 pm, Nic Williams [EMAIL PROTECTED] wrote: Heh. If I am, then I'll be that person some time in the future :) I'm trying to work on unittest; which just happens to co-share a repo + mailing list with prototype :) On 2/4/08, Nick Stakenburg [EMAIL PROTECTED] wrote: Yes there might be a better/more complete possibility, and someone might do it in the future I think I'd rather see an incremental fix now; AND wait for someone to write an even better version later. Perhaps once this patch is in, someone else will look at it You could be that someone ;) -- Dr Nic Williamshttp://drnicacademy.com-Ruby/Rails training/dev around the worldhttp://drnicwilliams.com-Ruby/Rails/Javascript/Web2.0 (skype) nicwilliams (p) +61 412 002 126 / +61 7 3113 3033 (mail) PO Box 583 Ashgrove 4060 QLD Aus -- Dr Nic Williamshttp://drnicacademy.com- Ruby/Rails training/dev around the worldhttp://drnicwilliams.com- Ruby/Rails/Javascript/Web2.0 (skype) nicwilliams (p) +61 412 002 126 / +61 7 3113 3033 (mail) PO Box 583 Ashgrove 4060 QLD Aus --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Adding Prototype.Revision
Based on Mislavs function here's on that also handles special cases
like _rc1.
function vnum(vstring) {
var v = vstring.replace(/_.*|\./g, '');
v = parseInt(v + '0'.times(4-v.length));
return vstring.indexOf('_') -1 ? v-1 : v;
}
vnum('1.6.0') vnum('1.6.0_rc1') //- true
vnum('1.6.0') //- 1600
vnum('1.6.0.2') //- 1602
vnum('1.6.0_rc1') //- 1599
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---
[Prototype-core] Re: Cross-browser Event.simulateMouse [bump via kangax]
I'll re-read your response again later, but at first glance it looks like a long-winded way of saying no... :) Yes there might be a better/more complete possibility, and someone might do it in the future, but this patch looks better than what we have, and exists now. That seems like a good thing. Or perhaps the experimental event simulations can be included, but in a separate file. But either way, if the experimental code isn't good enough, perhaps it should be removed then? I think I'd rather see an incremental fix now; AND wait for someone to write an even better version later. Nic On 2/4/08, Tobie Langel [EMAIL PROTECTED] wrote: Hi Nic, I'd love to see this included directly in Prototype to allow for Event.fire and Element#fire to trigger DOM events (and not only custom ones). This would imply researching on how to trigger keyboard events (I know YUI has a working implementation, for example), and providing a simple wrapper around events like blur, focus and submit. Any thoughts or proposed implementation on this is welcomed. Best, Tobie On Feb 4, 7:51 am, Dr Nic [EMAIL PROTECTED] wrote: Since the existing Event.simulateMouse code is labelled experimental, then this code with its suite of tests must be an improvement worth patching in? Even if it retains its experimental label, it will be an enhancement/bug fix patch for existing code. Whilst the ticket is categorised script.aculo.us, it could be repatch against the prototype versions of unittest.js and the patch resubmitted if it will be accepted. Nic On Feb 4, 4:48 pm, Dr Nic [EMAIL PROTECTED] wrote: [posted by kangax in Nov 07 with no responses at the time] Hello team, I recently needed a cross-browser simulateMouse support for some of our tests in Prototype UI and stumbled upon certain limitations in current implementation. Event.simulateMouse is marked as Firefox-only and experimental. Turning it into a somewhat robust solution will definitely benefit other modules' test suits (notable autocompleter and IPE which rely on mouse events quite heavily). Thomas mentioned that any patches and tests are very appreciated, considering that as of now there are NO specific unit tests for this wonderful method. Here's a fresh patchhttp://dev.rubyonrails.org/ticket/10170andunit testshttp://dev.rubyonrails.org/attachment/ticket/10170/simulatemouse_test... (FF2+, IE6+, Opera 9+, Safari 3 all pass happily). Would be nice to know about Safari 2 as well. The coverage is not as complete as I would want it to be, but it's a good start and is better than nothing. My question is: What are the chances of applying it to the current version or would it rather make sense to bake it into a 2.0? best, kangax -- Dr Nic Williams http://drnicacademy.com - Ruby/Rails training/dev around the world http://drnicwilliams.com - Ruby/Rails/Javascript/Web2.0 (skype) nicwilliams (p) +61 412 002 126 / +61 7 3113 3033 (mail) PO Box 583 Ashgrove 4060 QLD Aus --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Cross-browser Event.simulateMouse [bump via kangax]
What's your timeframe for finishing this? Will its API change much? I started doing screencasts of how to use unittest today for peepcode. If this patch is not useful, then it suggests the current Event.simulateMouse code should be removed as part of the refactoring. Force people to go looking for a tested, known working library to perform the simulations rather than attempt to use known non-working code? On 2/4/08, Tobie Langel [EMAIL PROTECTED] wrote: The reason I'm not too keen on adding this two unit tests is two- folds: First I think it belongs in Prototype core, secondly, I'm in the process of rewriting a good deal of unit_tests so I really don't think it's a good time to add features to it. I'd rather strengthen it as much as possible beforehand. Best, Tobie On Feb 4, 1:19 pm, Nic Williams [EMAIL PROTECTED] wrote: Heh. If I am, then I'll be that person some time in the future :) I'm trying to work on unittest; which just happens to co-share a repo + mailing list with prototype :) On 2/4/08, Nick Stakenburg [EMAIL PROTECTED] wrote: Yes there might be a better/more complete possibility, and someone might do it in the future I think I'd rather see an incremental fix now; AND wait for someone to write an even better version later. Perhaps once this patch is in, someone else will look at it You could be that someone ;) -- Dr Nic Williamshttp://drnicacademy.com- Ruby/Rails training/dev around the worldhttp://drnicwilliams.com- Ruby/Rails/Javascript/Web2.0 (skype) nicwilliams (p) +61 412 002 126 / +61 7 3113 3033 (mail) PO Box 583 Ashgrove 4060 QLD Aus -- Dr Nic Williams http://drnicacademy.com - Ruby/Rails training/dev around the world http://drnicwilliams.com - Ruby/Rails/Javascript/Web2.0 (skype) nicwilliams (p) +61 412 002 126 / +61 7 3113 3033 (mail) PO Box 583 Ashgrove 4060 QLD Aus --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
