Great jobs guys... unit tests would make it even better!
Best,
Tobie
On Feb 13, 12:22 am, John-David Dalton [EMAIL PROTECTED]
wrote:
http://dev.rubyonrails.org/ticket/11092
updated the ticket with an alternative fix which works for everything
except
child elements with duplicate id's.
A two parter:
1) Would that mean t modifying he dom.html unit test to test for this?
2) I ran the unit test with prototype 1.6.0.2 downloaded from
prototypejs.org and in each browser diff tests fail.
Does this mean that there are issues with the current code base that
are still needing to be
I suspect the unit tests are tailered for the current revision in
svn..
time for me to dload rails... or manually compile me some js.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to
1) yes, well, at least, adding the necessary code and maybe html.
2) make sure you build Prototype before running the tests (use rake
dist or run the tests from rake using rake test which auto build
Prototype). Currently all tests pass in all supported browsers except
a coouple of known issues
Rock!
Updated the ticket, passes the dom.html unit test with flying colors.
Also added a modified unit test that contains tests for this ticket.
The files of importance are
ie_attrib_patch.diff
dom.html
http://dev.rubyonrails.org/ticket/11092
i will ass ^ $
no need to go looping
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send
this patch doesn't solve the issue entirely
if you have a child element with the id=parentNode
and the parent element tries element.parentNode it will return the
child with the id parentNode.
bummer.
--~--~-~--~~~---~--~~
You received this message because you are
http://dev.rubyonrails.org/ticket/11092
updated the ticket with an alternative fix which works for everything
except
child elements with duplicate id's.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype:
woopsie *add, and ticket updated thanks Ken!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group,
John-David Dalton wrote:
ticket + patch for the bug:
http://dev.rubyonrails.org/ticket/11092
Spiffy use of clone. Won't the line /name|id/.test(name) catch
attributes such as myid? Would ['name', 'id'].include(name) be
better? Or you could just add ^ and $.
- Ken
ticket + patch for the bug:
http://dev.rubyonrails.org/ticket/11092
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core group.
To post to this group, send email to prototype-core@googlegroups.com
To
No I take that back, I think identity is susceptible to the same
problem.
On Feb 12, 12:42 pm, Doctuh [EMAIL PROTECTED] wrote:
Something I forgot to add: using the .identify() method on the form
avoids this problem entirely.
--~--~-~--~~~---~--~~
You received
You may be better treating id as a property (or, elem.id) vs.
attribute.
'id' isn't a member of the attributes object in FF; which, I'd assume,
has at least some influence on getAttribute (maybe not).
- Jon L.
On Feb 12, 1:16 pm, Ken Snyder [EMAIL PROTECTED] wrote:
Doctuh wrote:
...
form
Something I forgot to add: using the .identify() method on the form
avoids this problem entirely.
On Feb 12, 12:37 pm, Doctuh [EMAIL PROTECTED] wrote:
My first post. This is to document a tricky thing I found while using
Element.readAttribute() on a form. This post is to help the next
person
14 matches
Mail list logo
