[Prototype-core] Re: :not() selector bugs

2007-10-16 Thread [EMAIL PROTECTED]
I fixed the fix. I'm not sure how to make a properly formatted diff though. the issue was |(?=\s)|(?=:) needed to be (?=(\s|:)) http://dev.rubyonrails.org/attachment/ticket/9696/selector.diff?format=txt --~--~-~--~~~---~--~~ You received this message because

[Prototype-core] Re: :not() selector bugs

2007-09-26 Thread Mislav Marohnić
On 9/26/07, Wiktor Ihárosi [EMAIL PROTECTED] wrote: Should I create a ticket in trac? Yeah, it would be best if you attached a diff to that ticket that adds some failing tests to the current unit test suite for selector module. --~--~-~--~~~---~--~~ You

[Prototype-core] Re: :not() selector bugs

2007-09-26 Thread Andrew Dupont
The CSS2 and CSS3 specs disagree on this, annoyingly enough. [1] I'd originally written :not to throw an exception on selectors with more than one token, but then I saw the conflicting definitions and relented. All the other major libraries seem to allow this confusing syntax. Not being able to

[Prototype-core] Re: :not() selector bugs

2007-09-26 Thread Ihárosi Wiktor
Andrew Dupont wrote: Not being able to use the descendant combinator after a :not clause, however, is a bug. Wiktor, feel free to report it; I'll try to fix it before 1.6 final. Thx Andrew! Here is the ticket with the attached diff: http://dev.rubyonrails.org/ticket/9696