As the subject says, if the object, passed to the isHash function is
null, IE6 will throw an exception. This simple diff fixes the problem:
http://pastie.caboo.se/192906
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google
I can't reproduce this.
Best,
Tobie
On May 7, 12:03 pm, Viktor Kojouharov [EMAIL PROTECTED] wrote:
As the subject says, if the object, passed to the isHash function is
null, IE6 will throw an exception. This simple diff fixes the problem:
http://pastie.caboo.se/192906
Hi again,
Added some tests:
http://github.com/sstephenson/prototype/commit/1204b07b0645390e5718be98d3c58b6f5e9b41cf
All pass in IE6.
Best,
Tobie
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Prototype: Core
Hi again,
Try testing it in IE(6) with this:
Object.isHash(document.createEventObject().recordset)
On May 7, 1:16 pm, Viktor Kojouharov [EMAIL PROTECTED] wrote:
I can't reproduce it with 'regular' nulls, but it fails every time, if
I pass it event.recordset. I don't know what that event
Please open a bug report for this (http://prototypejs.org/contribute)
and submit a failing test case.
Thank you.
Tobie
On May 7, 12:49 pm, Viktor Kojouharov [EMAIL PROTECTED] wrote:
That was just to illustrate the problem. I'm not actually calling
document.createEventObject. I'm calling
will do. but I can't run the test right now, since rake fails with the
following error:
** Execute package
rake aborted!
Don't know how to build task 'clean_package_source'
I'm not a ruby user, and I've no idea how to fix this. This happens on
a fresh clone.
On May 7, 2:00 pm, Tobie Langel
Patches here:
http://github.com/jdalton/prototype/commit/723c26518392d838cf9ec368eddfba0c1874bac1
and
http://github.com/jdalton/prototype/commit/8eaae75066531993eba13df5eb1469016435843b
they need unit tests though :)
--~--~-~--~~~---~--~~
You received this message
John,
I don't think it's a good idea to give buttons full Form.Element
interface. While enable/disable would work correctly, getValue/
setValue would yield unexpected results. Giving buttons a method which
doesn't work as documented could be unintuitive, imho.
- kangax
On May 7, 10:42 am,
i'm from cartagena Colombia(south america)
i'm learning prototype, i have a little problem using Ajax.Updater. i
have this code in html page :
head
script src=prototype.js language=javascript type=text/
javascript /script
meta http-equiv=Content-Type content=text/html; charset=utf-8 /
Patched to work with getValue, setValue.
http://github.com/jdalton/prototype/commit/3b03b76660bc29ba5d8a6ef4e06c99c8faded107
Unit tests:
http://github.com/jdalton/prototype/commit/101d23d64aba2c0c459c97fa684a9079a7beb140
--~--~-~--~~~---~--~~
You received this
Hi,
Please adress hel request questions to this mailing list:
http://groups.google.com/group/rubyonrails-spinoffs
As this one is reserved for development purposes.
Thanks,
Tobie
On May 7, 6:58 pm, halflopez [EMAIL PROTECTED] wrote:
i'm from cartagena Colombia(south america)
i'm
That's not quite what I was talking about : )
How about just extending buttons with enable/disable and serialize?
(and i.e. keeping getValue/setValue logic consistent)
Are there other ones that would make sense?
- kangax
On May 7, 12:27 pm, John-David Dalton [EMAIL PROTECTED]
wrote:
Patched to
The getValue and setValue, use the Form.Element.Serializers anyway.
So when I added serialization it adds the getValue and setValue.
The browser sees the innerHTML of the button element as its value so
this is consistent.
- JDD
--~--~-~--~~~---~--~~
You received
13 matches
Mail list logo
