I'm not sure what you mean exactly. If you mean that the patched version
1.5.1 looks like a working fix, I would agree.
However, on the original tests I sent you, I don't see a memory increase on
refresh, but on closing the window none of that reserved memory is
released.
If you were referring
On Begin Test: 22MB
prototype_1_5_1_1 ( as available for download )
Ten 10MiB Windows Open: 109MB
Ten windows after all closed: 105MB
prototype_1_5_1_1 ( with patch ):
Ten 10MiB Windows Open: 109MB
Ten windows after all closed: 48MB
Same main window, once more:
Ten 10MiB Windows Open: 109MB
Thanks for the tests Geoff,
I have uploaded them here: http://protolific.net/memory_leak_testcase.zip
I patched the Prototyep 1.5.1 file.
There is a second file named _prototype_1_5_1.js which is my latest
git version compiles (so it is really 1.6.0.2+ with the patch in it
is as well.
I still
Patch addresses the memory leak:
http://github.com/jdalton/prototype/commit/0353246ac2ad439260905799798f0069d9a7d0ca
Patch addresses other issues with escapeHTML and unescapeHTML:
http://github.com/jdalton/prototype/commit/6010a300c39b0c66394706e9edb8b110b5932d9e
Unit tests for the patch:
Ah, I missed the hold on to all references on page unload part : )
John, wouldn't it make sense to null the references in
purgeListeners function (since it's already attached to unload)?
- kangax
On May 2, 6:30 pm, John-David Dalton [EMAIL PROTECTED]
wrote:
Patch addresses the memory
I was wondering if some of the code I saw in the upcoming 1.6.0.3
milestone might have addressed this. I should have mentioned that,
apologies.
The tentative fix I outlined above doesn't seem to leak; the original
leak was *very* obvious due to the number of nested frames in the
child window
