[Prototype-core] Re: Opera 9.5 and document.viewport
It's good to see Opera is trying to be more like the other browsers. But we'll still have to add backwards compatibility for the older version. Luckily version targetting in Opera is easy since later version all have window.opera.version(). I've added a patch to the ticket using it to fix the problem. -- Nick Stakenburg On 6 mrt, 06:07, Matthew <[EMAIL PROTECTED]> wrote: > The relevant code in version 1.6.0.2 is: > > dimensions[d] = (B.WebKit && !document.evaluate) ? self['inner' + D] : > (B.Opera) ? document.body['client' + D] : > document.documentElement['client' + D]; > > Here Opera 9.5 in strict mode behaves just like Firefox and IE 6 in > strict mode, so the above code will not work. Under Opera 9.5 strict, > the current code will return the height of the body, not the viewport. > But in Opera 6 to 9, document.body.clientHeight is always the height > of the viewport, so a generic browser check won't suffice. > > So to summarize, viewport.getDimensions() is broken under Opera 9.5 > strict but works fine in Opera 9.5 quirks, which is the opposite of > what one would expect. I know Opera 9.5 is a beta, but surely its new > behavior is intentional. > > -- > Matthew Leverton --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Opera 9.5 and document.viewport
done: http://dev.rubyonrails.org/ticket/11302#preview On Mar 6, 10:08 pm, kangax <[EMAIL PROTECTED]> wrote: > Could someone create a ticket for this? > Thanks. > > - kangax > > On Mar 6, 2:56 am, "artemy tregoubenko" <[EMAIL PROTECTED]> > wrote: > > > I can confirm this. Found it some time ago and decided to wait till release. > > > On 3/6/08, Matthew <[EMAIL PROTECTED]> wrote: > > > > The relevant code in version 1.6.0.2 is: > > > > dimensions[d] = (B.WebKit && !document.evaluate) ? self['inner' + D] : > > > (B.Opera) ? document.body['client' + D] : > > > document.documentElement['client' + D]; > > > > Here Opera 9.5 in strict mode behaves just like Firefox and IE 6 in > > > strict mode, so the above code will not work. Under Opera 9.5 strict, > > > the current code will return the height of the body, not the viewport. > > > But in Opera 6 to 9, document.body.clientHeight is always the height > > > of the viewport, so a generic browser check won't suffice. > > > > So to summarize, viewport.getDimensions() is broken under Opera 9.5 > > > strict but works fine in Opera 9.5 quirks, which is the opposite of > > > what one would expect. I know Opera 9.5 is a beta, but surely its new > > > behavior is intentional. > > > > -- > > > Matthew Leverton > > > -- > > arty (http://arty.name) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Opera 9.5 and document.viewport
Could someone create a ticket for this? Thanks. - kangax On Mar 6, 2:56 am, "artemy tregoubenko" <[EMAIL PROTECTED]> wrote: > I can confirm this. Found it some time ago and decided to wait till release. > > On 3/6/08, Matthew <[EMAIL PROTECTED]> wrote: > > > > > > > The relevant code in version 1.6.0.2 is: > > > dimensions[d] = (B.WebKit && !document.evaluate) ? self['inner' + D] : > > (B.Opera) ? document.body['client' + D] : > > document.documentElement['client' + D]; > > > Here Opera 9.5 in strict mode behaves just like Firefox and IE 6 in > > strict mode, so the above code will not work. Under Opera 9.5 strict, > > the current code will return the height of the body, not the viewport. > > But in Opera 6 to 9, document.body.clientHeight is always the height > > of the viewport, so a generic browser check won't suffice. > > > So to summarize, viewport.getDimensions() is broken under Opera 9.5 > > strict but works fine in Opera 9.5 quirks, which is the opposite of > > what one would expect. I know Opera 9.5 is a beta, but surely its new > > behavior is intentional. > > > -- > > Matthew Leverton > > -- > arty (http://arty.name) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---
[Prototype-core] Re: Opera 9.5 and document.viewport
I can confirm this. Found it some time ago and decided to wait till release. On 3/6/08, Matthew <[EMAIL PROTECTED]> wrote: > > The relevant code in version 1.6.0.2 is: > > dimensions[d] = (B.WebKit && !document.evaluate) ? self['inner' + D] : > (B.Opera) ? document.body['client' + D] : > document.documentElement['client' + D]; > > Here Opera 9.5 in strict mode behaves just like Firefox and IE 6 in > strict mode, so the above code will not work. Under Opera 9.5 strict, > the current code will return the height of the body, not the viewport. > But in Opera 6 to 9, document.body.clientHeight is always the height > of the viewport, so a generic browser check won't suffice. > > So to summarize, viewport.getDimensions() is broken under Opera 9.5 > strict but works fine in Opera 9.5 quirks, which is the opposite of > what one would expect. I know Opera 9.5 is a beta, but surely its new > behavior is intentional. > > > -- > Matthew Leverton > > > -- arty ( http://arty.name ) --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~--~~~~--~~--~--~---