[Proto-Scripty] Re: Problem with Prototype 1.6.1 (& solved)
It solved my problem, again.
Thanks!
On 14 oct, 09:20, Julius Seporaitis wrote:
> Garfieldius, thanks :)
>
> svens0n82, I've later found that function 'descendant' also needs similar
> fix. Around line 3597 in prototype.js I've changed:
>
> h.concat(results, node.getElementsByTagName('*'));
>
> into
>
> if(typeof node == 'string') { node = $(node); }
> h.concat(results, node.getElementsByTagName('*'));
>
> On Wed, Oct 14, 2009 at 10:59 AM, svens0...@googlemail.com <
>
> svens0...@googlemail.com> wrote:
>
> > Hi,
>
> > i have the same issue with the error but your solution doesnt work for
> > me. Error keeps the same.
>
> > Any more ideas?
>
> > On 12 Okt., 23:16, Julius Šėporaitis wrote:
> > > Hi,
>
> > > just wanted to post a quick note for those who maybe had problems like
> > > mine:
>
> > > - Prototype v.1.6.1
> > > - Firefox 3.5
> > > - JS Error: root.querySelectorAll is not a function (about line 3299
> > > in prototype.js)
>
> > > This started to happen on Magento checkout pages, where the Accordion
> > > is and I don't know if this is a prototype bug or not, so - I don't
> > > know why and when this happens, but on my situation initially - the
> > > root variable is a string so it passes the initial check (root = root
> > > || document) causing problems later. :) Here's a solution.
>
> > > in the prototype.js prepend this line (~3299):
>
> > > results = $A(root.querySelectorAll(e)).map(Element.extend);
>
> > > so it looks like this:
>
> > > if(typeof root == string) root = $(root);
> > > results = $A(root.querySelectorAll(e)).map(Element.extend);
>
> > > I hope this gets helpful to someone.
>
> > > Cheers,
> > > Julius Seporaitis
>
> --
> Cheers,
> Julius Šėporaitis
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Prototype & script.aculo.us" group.
To post to this group, send email to prototype-scriptaculous@googlegroups.com
To unsubscribe from this group, send email to
prototype-scriptaculous+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/prototype-scriptaculous?hl=en
-~--~~~~--~~--~--~---
[Proto-Scripty] Re: Problem with Prototype 1.6.1 (& solved)
Thank you very much. I had the same problem and your fix did work. Cheers :-) On 12 oct, 22:16, Julius Šėporaitis wrote: > Hi, > > just wanted to post a quick note for those who maybe had problems like > mine: > > - Prototype v.1.6.1 > - Firefox 3.5 > - JS Error: root.querySelectorAllis not a function (about line 3299 > in prototype.js) > > This started to happen on Magento checkout pages, where the Accordion > is and I don't know if this is a prototype bug or not, so - I don't > know why and when this happens, but on my situation initially - the > root variable is a string so it passes the initial check (root = root > || document) causing problems later. :) Here's a solution. > > in the prototype.js prepend this line (~3299): > > results = $A(root.querySelectorAll(e)).map(Element.extend); > > so it looks like this: > > if(typeof root == string) root = $(root); > results = $A(root.querySelectorAll(e)).map(Element.extend); > > I hope this gets helpful to someone. > > Cheers, > Julius Seporaitis --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype & script.aculo.us" group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~--~~~~--~~--~--~---
[Proto-Scripty] Re: Problem with Prototype 1.6.1 (& solved)
Garfieldius, thanks :)
svens0n82, I've later found that function 'descendant' also needs similar
fix. Around line 3597 in prototype.js I've changed:
h.concat(results, node.getElementsByTagName('*'));
into
if(typeof node == 'string') { node = $(node); }
h.concat(results, node.getElementsByTagName('*'));
On Wed, Oct 14, 2009 at 10:59 AM, svens0...@googlemail.com <
svens0...@googlemail.com> wrote:
>
> Hi,
>
> i have the same issue with the error but your solution doesnt work for
> me. Error keeps the same.
>
> Any more ideas?
>
>
> On 12 Okt., 23:16, Julius Šėporaitis wrote:
> > Hi,
> >
> > just wanted to post a quick note for those who maybe had problems like
> > mine:
> >
> > - Prototype v.1.6.1
> > - Firefox 3.5
> > - JS Error: root.querySelectorAll is not a function (about line 3299
> > in prototype.js)
> >
> > This started to happen on Magento checkout pages, where the Accordion
> > is and I don't know if this is a prototype bug or not, so - I don't
> > know why and when this happens, but on my situation initially - the
> > root variable is a string so it passes the initial check (root = root
> > || document) causing problems later. :) Here's a solution.
> >
> > in the prototype.js prepend this line (~3299):
> >
> > results = $A(root.querySelectorAll(e)).map(Element.extend);
> >
> > so it looks like this:
> >
> > if(typeof root == string) root = $(root);
> > results = $A(root.querySelectorAll(e)).map(Element.extend);
> >
> > I hope this gets helpful to someone.
> >
> > Cheers,
> > Julius Seporaitis
>
> >
>
--
Cheers,
Julius Šėporaitis
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Prototype & script.aculo.us" group.
To post to this group, send email to prototype-scriptaculous@googlegroups.com
To unsubscribe from this group, send email to
prototype-scriptaculous+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/prototype-scriptaculous?hl=en
-~--~~~~--~~--~--~---
[Proto-Scripty] Re: Problem with Prototype 1.6.1 (& solved)
Hi, i have the same issue with the error but your solution doesnt work for me. Error keeps the same. Any more ideas? On 12 Okt., 23:16, Julius Šėporaitis wrote: > Hi, > > just wanted to post a quick note for those who maybe had problems like > mine: > > - Prototype v.1.6.1 > - Firefox 3.5 > - JS Error: root.querySelectorAll is not a function (about line 3299 > in prototype.js) > > This started to happen on Magento checkout pages, where the Accordion > is and I don't know if this is a prototype bug or not, so - I don't > know why and when this happens, but on my situation initially - the > root variable is a string so it passes the initial check (root = root > || document) causing problems later. :) Here's a solution. > > in the prototype.js prepend this line (~3299): > > results = $A(root.querySelectorAll(e)).map(Element.extend); > > so it looks like this: > > if(typeof root == string) root = $(root); > results = $A(root.querySelectorAll(e)).map(Element.extend); > > I hope this gets helpful to someone. > > Cheers, > Julius Seporaitis --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype & script.aculo.us" group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~--~~~~--~~--~--~---
[Proto-Scripty] Re: Problem with Prototype 1.6.1 (& solved)
For the sake of completeness: you forgot the " so it's if(typeof root == "string") root = $(root); --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype & script.aculo.us" group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~--~~~~--~~--~--~---
