Re: [ptxdist] [PATCH] avahi: optional install avahi-browse
On Fri, Jun 22, 2018 at 07:50:04AM +, Denis OSTERLAND wrote: > Am Freitag, den 22.06.2018, 09:13 +0200 schrieb Michael Olbrich: > > > > > > +ifdef PTXCONF_AVAHI_BROWSE > > > + @$(call install_copy, avahi, 0, 0, 0755, -, /usr/bin/avahi-browse) > > I just pushed a change that installs several tools including avahi-browse. > > Unless you see a good reason to split those up, I'd like to keep it that > > way. > Seems I forgot to pull yesterday before I sent the emails, sorry. > AVAHI_UTILS is good. I probably pushed this to the public git after you sent the patch. > > > > > > + @$(call install_link, avahi, avahi-browse, > > > /usr/bin/avahi-browse-domains) > > What's the reason for this link? > > > > Michael > Thats a convenience function, "avahi-browse-domains" is equal to > "avahi-browse -D". > So it is not really needed, but nice to have. > Are you willing to add the link, if I send you the patch? Sure, just add this explanation to the commit message. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [PATCH] avahi: optional install avahi-browse
Am Freitag, den 22.06.2018, 09:13 +0200 schrieb Michael Olbrich: > > > > +ifdef PTXCONF_AVAHI_BROWSE > > + @$(call install_copy, avahi, 0, 0, 0755, -, /usr/bin/avahi-browse) > I just pushed a change that installs several tools including avahi-browse. > Unless you see a good reason to split those up, I'd like to keep it that > way. Seems I forgot to pull yesterday before I sent the emails, sorry. AVAHI_UTILS is good. > > > > > + @$(call install_link, avahi, avahi-browse, > > /usr/bin/avahi-browse-domains) > What's the reason for this link? > > Michael Thats a convenience function, "avahi-browse-domains" is equal to "avahi-browse -D". So it is not really needed, but nice to have. Are you willing to add the link, if I send you the patch? Regards Denis > > > > > +endif > > + > > ifdef PTXCONF_AVAHI_AUTOIP > > # avahi autoip daemon (avahi IPv4LL Implementation) > > # this component is needed for rfc3927 style link local adressing > > -- > > 2.17.1 Diehl AKO Stiftung & Co. KG, Pfannerstraße 75-83, 88239 Wangen im Allgäu Bereichsvorstand: Dipl.-Ing. Michael Siedentop (Sprecher), Josef Fellner (Mitglied) Sitz der Gesellschaft: Wangen i.A. – Registergericht: Amtsgericht Ulm HRA 620609 – Persönlich haftende Gesellschafterin: Diehl Verwaltungs-Stiftung – Sitz: Nürnberg – Registergericht: Amtsgericht Nürnberg HRA 11756 – Vorstand: Dr.-Ing. Karl Tragl (Vorsitzender), Herr Dipl.-Wirtsch.-Ing. Wolfgang Weggen (stellvertretender Vorsitzender), Dipl.-Kfm. Claus Günther, Dipl.-Kfm. Frank Gutzeit, Dr.-Ing. Heinrich Schunk, Dr.-Ing. Michael Siedentop , Dipl.-Kfm. Dr.-Ing. Martin Sommer, Dipl.-Ing. (FH) Rainer von Borstel, Vorsitzender des Aufsichtsrates: Dr. Klaus Maier ___ Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt. The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. ___ ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [PATCH] avahi: optional install avahi-browse
On Thu, Jun 21, 2018 at 11:25:03AM +, Denis OSTERLAND wrote: > Signed-off-by: Denis Osterland > --- > rules/avahi.in | 7 +++ > rules/avahi.make | 5 + > 2 files changed, 12 insertions(+) > > diff --git a/rules/avahi.in b/rules/avahi.in > index 2190e9ef9..83b438fe7 100644 > --- a/rules/avahi.in > +++ b/rules/avahi.in > @@ -148,4 +148,11 @@ config AVAHI_COMPAT > help > compatibility layer for libdns_sd > > +config AVAHI_BROWSE > + bool > + select AVAHI_LIBAVAHI_CLIENT > + prompt "avahi-browse utility" > + help > + client to browse network for avahi announcments > + > endif > diff --git a/rules/avahi.make b/rules/avahi.make > index 8f58ac61e..c3d5ce963 100644 > --- a/rules/avahi.make > +++ b/rules/avahi.make > @@ -177,6 +177,11 @@ endif > endif > endif > > +ifdef PTXCONF_AVAHI_BROWSE > + @$(call install_copy, avahi, 0, 0, 0755, -, /usr/bin/avahi-browse) I just pushed a change that installs several tools including avahi-browse. Unless you see a good reason to split those up, I'd like to keep it that way. > + @$(call install_link, avahi, avahi-browse, > /usr/bin/avahi-browse-domains) What's the reason for this link? Michael > +endif > + > ifdef PTXCONF_AVAHI_AUTOIP > #avahi autoip daemon (avahi IPv4LL Implementation) > #this component is needed for rfc3927 style link local adressing > -- > 2.17.1 -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0| Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917- | ___ ptxdist mailing list ptxdist@pengutronix.de
[ptxdist] [PATCH] avahi: optional install avahi-browse
Signed-off-by: Denis Osterland --- rules/avahi.in | 7 +++ rules/avahi.make | 5 + 2 files changed, 12 insertions(+) diff --git a/rules/avahi.in b/rules/avahi.in index 2190e9ef9..83b438fe7 100644 --- a/rules/avahi.in +++ b/rules/avahi.in @@ -148,4 +148,11 @@ config AVAHI_COMPAT help compatibility layer for libdns_sd +config AVAHI_BROWSE + bool + select AVAHI_LIBAVAHI_CLIENT + prompt "avahi-browse utility" + help + client to browse network for avahi announcments + endif diff --git a/rules/avahi.make b/rules/avahi.make index 8f58ac61e..c3d5ce963 100644 --- a/rules/avahi.make +++ b/rules/avahi.make @@ -177,6 +177,11 @@ endif endif endif +ifdef PTXCONF_AVAHI_BROWSE + @$(call install_copy, avahi, 0, 0, 0755, -, /usr/bin/avahi-browse) + @$(call install_link, avahi, avahi-browse, /usr/bin/avahi-browse-domains) +endif + ifdef PTXCONF_AVAHI_AUTOIP # avahi autoip daemon (avahi IPv4LL Implementation) # this component is needed for rfc3927 style link local adressing -- 2.17.1 Diehl AKO Stiftung & Co. KG, Pfannerstraße 75-83, 88239 Wangen im Allgäu Bereichsvorstand: Dipl.-Ing. Michael Siedentop (Sprecher), Josef Fellner (Mitglied) Sitz der Gesellschaft: Wangen i.A. – Registergericht: Amtsgericht Ulm HRA 620609 – Persönlich haftende Gesellschafterin: Diehl Verwaltungs-Stiftung – Sitz: Nürnberg – Registergericht: Amtsgericht Nürnberg HRA 11756 – Vorstand: Dr.-Ing. Karl Tragl (Vorsitzender), Herr Dipl.-Wirtsch.-Ing. Wolfgang Weggen (stellvertretender Vorsitzender), Dipl.-Kfm. Claus Günther, Dipl.-Kfm. Frank Gutzeit, Dr.-Ing. Heinrich Schunk, Dr.-Ing. Michael Siedentop , Dipl.-Kfm. Dr.-Ing. Martin Sommer, Dipl.-Ing. (FH) Rainer von Borstel, Vorsitzender des Aufsichtsrates: Dr. Klaus Maier ___ Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt. The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. ___ ptxdist mailing list ptxdist@pengutronix.de
