Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-14 Thread Andrey Semashev
On Friday 14 November 2014 08:26:18 David Henningsson wrote: On 2014-11-13 23:49, Andrey Semashev wrote: I do not have an explanation for such diverse range of the delay value, and its dependency on the frame size. It doesn't look like the filter is learning from the input in some way

Re: [pulseaudio-discuss] [PATCH 0/4] Add support for libsoxr resampler

2014-11-14 Thread Alexander E. Patrakov
14.11.2014 13:37, Andrey Semashev wrote: As a side note, I think speex-float-1 is a rather poor default as well because of its quality. Anyone who cares about the sound he gets will likely change it to something like speex-float-3 or 5 anyway. IMHO. Initially I also thought so and argued for

Re: [pulseaudio-discuss] Master is frozen

2014-11-14 Thread David Henningsson
On 2014-11-14 07:07, Arun Raghavan wrote: Hello, As promised, master is now frozen. Please do not push anything other than essential fixes.I'd like to have some stability testing of HSP before rolling 6.0 RC1. I'd like to have my HSP compilation patches in before 6.0 RC1. Can I push them?

Re: [pulseaudio-discuss] Master is frozen

2014-11-14 Thread Arun Raghavan
On 14 Nov 2014 15:00, David Henningsson david.hennings...@canonical.com wrote: On 2014-11-14 07:07, Arun Raghavan wrote: Hello, As promised, master is now frozen. Please do not push anything other than essential fixes.I'd like to have some stability testing of HSP before rolling 6.0 RC1.

Re: [pulseaudio-discuss] Master is frozen

2014-11-14 Thread Wim Taymans
Can you check in the log if the volume AT commands are sent to the headset? What I can think of is maybe that the command is not formatted properly (like missing a \n\r somewhere, I've seen some headset be picky about that). Wim On 14 November 2014 10:39, Arun Raghavan a...@accosted.net wrote:

Re: [pulseaudio-discuss] Master is frozen

2014-11-14 Thread Arun Raghavan
On 14 Nov 2014 15:13, Wim Taymans wim.taym...@gmail.com wrote: Can you check in the log if the volume AT commands are sent to the headset? What I can think of is maybe that the command is not formatted properly (like missing a \n\r somewhere, I've seen some headset be picky about that). I'd

Re: [pulseaudio-discuss] Master is frozen

2014-11-14 Thread Arun Raghavan
On 14 Nov 2014 15:31, Wim Taymans wim.taym...@gmail.com wrote: Can you compare with a hcidump of working volume? It never actually worked for me. If you have one that works, I can compare with what I get here ( well probably take a day or two). -- Arun

Re: [pulseaudio-discuss] Master is frozen

2014-11-14 Thread Pali Rohár
On Friday 14 November 2014 07:07:40 Arun Raghavan wrote: Hello, As promised, master is now frozen. Please do not push anything other than essential fixes. I'd like to have some stability testing of HSP before rolling 6.0 RC1. Any help here is appreciated. Regards, Arun

Re: [pulseaudio-discuss] [PATCH v2] alsa: Check return value of snd_pcm_mmap_commit()

2014-11-14 Thread David Henningsson
On 2014-11-13 10:48, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com snd_pcm_mmap_commit() actually transfers the memory area prepared by snd_pcm_mmap_begin(), it returns the 'count of transferred frames' which should be equal to the number of frames returned by

Re: [pulseaudio-discuss] Master is frozen

2014-11-14 Thread Wim Taymans
After reading the HSP spec some more, the volume controls are optional. It should be mentioned in the SDP if the remote volume is supported (with the BT assigned number 0x302 apparently). Not sure how to get to that info.. Wim On 14 November 2014 11:04, Arun Raghavan a...@accosted.net wrote:

[pulseaudio-discuss] [PATCH] bluetooth: set gain correctly

2014-11-14 Thread Wim Taymans
Send the right command to set the speaker and microphone gain. --- src/modules/bluetooth/backend-native.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/bluetooth/backend-native.c b/src/modules/bluetooth/backend-native.c index 86af422..cea2db2 100644 ---

Re: [pulseaudio-discuss] [PATCH] modules: Disable timer scheduling for a2dp playback to reduce power consumption.

2014-11-14 Thread David Henningsson
Hi Sajeesh, Thanks for trying to contribute to PulseAudio. While going through old patches I found this one, but as Pierre-Louis says below, I'm not sure how this would reduce power consumption. Could you explain? Or we could drop your patch in case you changed your mind. Thanks, On

Re: [pulseaudio-discuss] [PATCH] shell-completion: zsh: Fix set-default-sink/source completion

2014-11-14 Thread Tanu Kaskinen
On Sat, 2014-11-01 at 18:28 +0200, Tanu Kaskinen wrote: The _devices() function didn't recognize the set-default-* commands, and as a result it didn't generate any completions. --- shell-completion/zsh/_pulseaudio | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [pulseaudio-discuss] [PATCH] shell-completion: zsh: Fix the set-card-profile description

2014-11-14 Thread Tanu Kaskinen
On Sat, 2014-11-01 at 18:28 +0200, Tanu Kaskinen wrote: --- shell-completion/zsh/_pulseaudio | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell-completion/zsh/_pulseaudio b/shell-completion/zsh/_pulseaudio index 4f4043a..e2390e8 100644 ---

Re: [pulseaudio-discuss] [PATCH] dbus: Fix Device.SetActivePort() handler

2014-11-14 Thread Tanu Kaskinen
On Sun, 2014-11-02 at 20:55 +0200, Tanu Kaskinen wrote: On Sun, 2014-11-02 at 20:50 +0200, Tanu Kaskinen wrote: The old code tried to look up the port object by using an object path, but the ports hashmap uses port names as keys, so the method failed always. BugLink:

[pulseaudio-discuss] [PATCH] bluetooth: set gain correctly

2014-11-14 Thread Wim Taymans
Send the right command to set the speaker and microphone gain. Note that setting the volume on the Headset should use the unsolicited result code. Receiving the volume from the Headset uses the AT command. --- src/modules/bluetooth/backend-native.c | 8 1 file changed, 4 insertions(+),

[pulseaudio-discuss] [PATCH] Fix the gain settings on Headset

2014-11-14 Thread Wim Taymans
This patch fixes the gain settings for Headsets by sending the right commands. It replaces the previous patch. Wim Taymans (1): bluetooth: set gain correctly src/modules/bluetooth/backend-native.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 1.9.3

Re: [pulseaudio-discuss] Notes from the PulseAudio Mini Summit 2014

2014-11-14 Thread Felipe Sateler
Hi Arun, On Fri, Nov 14, 2014 at 3:05 AM, Arun Raghavan a...@accosted.net wrote: Hi folks, JFYI, I've posted notes from our mini summit at Düsseldorf: http://arunraghavan.net/2014/11/notes-from-the-pulseaudio-mini-summit-2014/ As I said on comments on your blog, thanks for the write up. I

[pulseaudio-discuss] [PATCH 2/4] Enabled libsoxr resampler backend.

2014-11-14 Thread Andrey Semashev
Added ID and names for the resampler presets and also corrected the working sample rate deduction to take the new resampler into account. Removed duplicate condition checks from the deduction code. --- src/pulsecore/resampler.c | 25 - src/pulsecore/resampler.h | 4

[pulseaudio-discuss] [PATCH 3/4] Added libsoxr detection and optional build of soxr resampler backend.

2014-11-14 Thread Andrey Semashev
--- configure.ac| 17 + src/Makefile.am | 6 ++ 2 files changed, 23 insertions(+) diff --git a/configure.ac b/configure.ac index e91e990..4ae4838 100644 --- a/configure.ac +++ b/configure.ac @@ -1133,6 +1133,21 @@ AS_IF([test x$with_speex = xyes test x$HAVE_SPEEX =

[pulseaudio-discuss] [PATCH v2 0/4] Add support for libsoxr resampler

2014-11-14 Thread Andrey Semashev
This is an updated set of patches first announced and discussed here: http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/22158 Changes to the original patches: * Removed the -lq quality preset, only -mq, -hq and -vhq presets are left. * Removed the fix to the

[pulseaudio-discuss] [PATCH 1/4] Added libsoxr resampler backend.

2014-11-14 Thread Andrey Semashev
The new backend supports 3 quality levels: mq, hq and vhq; 16 integer and 32-bit float samples. Discussion and quality assessment are here: http://comments.gmane.org/gmane.comp.audio.pulseaudio.general/22158 --- src/pulsecore/resampler/soxr.c | 170 + 1

[pulseaudio-discuss] [PATCH 4/4] Added documentation for soxr resampling methods.

2014-11-14 Thread Andrey Semashev
--- man/pulse-daemon.conf.5.xml.in | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/man/pulse-daemon.conf.5.xml.in b/man/pulse-daemon.conf.5.xml.in index 754312e..f8ba9b4 100644 --- a/man/pulse-daemon.conf.5.xml.in +++ b/man/pulse-daemon.conf.5.xml.in @@ -88,7

[pulseaudio-discuss] [PATCH 5/4] Removed leftover bits referring to soxr-lq.

2014-11-14 Thread Andrey Semashev
--- These bits were left by accident when I was removing the soxr-lq from my patches. src/pulsecore/resampler.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c index 8974db3..17919a3 100644 --- a/src/pulsecore/resampler.c +++