[pulseaudio-discuss] [PATCH v2 3/6] pactl, pacmd, cli-command: Add send-message command

2018-01-21 Thread Georg Chini
--- doc/messaging_api.txt| 15 ++ man/pactl.1.xml.in | 7 +++ man/pulse-cli-syntax.5.xml.in| 7 +++ shell-completion/bash/pulseaudio | 5 +++-- shell-completion/zsh/_pulseaudio | 2 ++ src/pulse/introspect.h | 3 ++- src/pulsecore/cl

[pulseaudio-discuss] [PATCH v2 5/6] pactl: Implement list message-handlers

2018-01-21 Thread Georg Chini
For better readability, "pactl list message-handlers" is introduced which prints a formatted output of "pactl send-message /core list-handlers". The patch also adds the function pa_split_message_parameter_string() for easy parsing of the message response string. --- man/pactl.1.xml.in

[pulseaudio-discuss] [PATCH v2 1/6] core: add simple message interface

2018-01-21 Thread Georg Chini
This patch adds a new feature to the core which allows to send messages to objects. An object can register/unregister a message handler with pa_message_handler_{register, unregister}() while a message can be sent to the handler using the pa_message_handler_send_message() function. A message has 4 a

[pulseaudio-discuss] [PATCH v2 0/6] Implement simple message interface

2018-01-21 Thread Georg Chini
previous. This patch set also takes care about escaping curly braces within parameter strings. A simple function for writing escaped strings was added to strbuf. This approach may not be optimal but seemed like the fastest way to achieve the goal. Georg Chini (6): core: add simple message interface

[pulseaudio-discuss] [PATCH v2 2/6] protocol-native: add message sending capability

2018-01-21 Thread Georg Chini
This patch adds the PA_COMMAND_SEND_OBJECT_MESSAGE command to protocol-native so that clients can use the messaging feature introduced in the previous patch. Sending messages can in effect replace the extension system for modules. The approach is more flexible than the extension interface because

[pulseaudio-discuss] [PATCH v2 6/6] message-handler: Allow parameter strings to contain escaped curly braces

2018-01-21 Thread Georg Chini
For string parameters that contain curly braces, those braces must be escaped by adding a "\" before them. This however means that a trailing backslash would falsely escape the closing bracket. To avoid this, single quotes must be added at start and end of the string. A function pa_strbuf_put_esca

[pulseaudio-discuss] [PATCH v2 4/6] core: add message handler

2018-01-21 Thread Georg Chini
This patch adds a small message handler to the core which enables clients to list available handlers via the list-handlers message. Command: pacmd send-message /core list-handlers pactl can be used with the same parameters. The patch also introduces a convention for the return string. It consists

Re: [pulseaudio-discuss] [PATCH] bluetooth: don't send unsolicted replies to the endpoint Release() call

2018-01-19 Thread Georg Chini
On 18.01.2018 21:27, Tanu Kaskinen wrote: It was reported that PulseAudio causes error messages in syslog from dbus-daemon: Jan 14 04:51:32 gentoo dbus-daemon[2492]: [system] Rejected send message, 2 matched rules; type="error", sender=":1.15" (uid=1000 pid=2864 comm="/usr/bin/pulseaudio --star

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-19 Thread Georg Chini
On 19.01.2018 14:23, Georg Chini wrote: On 18.01.2018 23:20, Tanu Kaskinen wrote: On Wed, 2018-01-17 at 16:12 +0100, Georg Chini wrote: On 14.01.2018 21:47, Tanu Kaskinen wrote:ry from the heap are quite heavy operations, and your approach will do a lot of those operations. Even reading a

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-19 Thread Georg Chini
On 18.01.2018 23:20, Tanu Kaskinen wrote: On Wed, 2018-01-17 at 16:12 +0100, Georg Chini wrote: On 14.01.2018 21:47, Tanu Kaskinen wrote:ry from the heap are quite heavy operations, and your approach will do a lot of those operations. Even reading a simple integer will, I suppose, involve

Re: [pulseaudio-discuss] [PATCH] pipe-sink using existing fifo

2018-01-18 Thread Georg Chini
On 11.01.2018 18:02, Samo Pogačnik wrote: Allow usage of an already existing fifo (named pipe) within the pipe-sink module. Also, the used fifo is going to be removed upon module unload only if the fifo is created by the same module. --- src/modules/module-pipe-sink.c | 15 +++ 1 f

Re: [pulseaudio-discuss] [PATCH 3/5] pactl, pacmd, cli-command: Add send-message command

2018-01-18 Thread Georg Chini
On 09.01.2018 20:30, Tanu Kaskinen wrote: On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: --- doc/messaging_api.txt| 16 ++ man/pactl.1.xml.in | 7 ++ man/pulse-cli-syntax.5.xml.in| 7 ++ shell-completion/bash/pulseaudio | 5

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-17 Thread Georg Chini
On 14.01.2018 21:47, Tanu Kaskinen wrote: On Fri, 2018-01-12 at 21:47 +0100, Georg Chini wrote: On 12.01.2018 16:40, Tanu Kaskinen wrote: On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: For better readability, "pactl list message-handlers" is introduced which prints a format

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-12 Thread Georg Chini
On 12.01.2018 16:40, Tanu Kaskinen wrote: On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: For better readability, "pactl list message-handlers" is introduced which prints a formatted output of "pactl send-message /core list-handlers". The patch al

Re: [pulseaudio-discuss] [PATCH 4/5] core: add message handler

2018-01-12 Thread Georg Chini
On 12.01.2018 16:59, Tanu Kaskinen wrote: On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: +Recipient: /core +Message: list-handlers +Parameters: None +Return value: {{Handler name} {Description}} I now realized that a single-level list isn't sufficient, it has to be a list of

Re: [pulseaudio-discuss] [PATCH 4/5] core: add message handler

2018-01-11 Thread Georg Chini
On 11.01.2018 16:28, Tanu Kaskinen wrote: On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: This patch adds a small message handler to the core which enables clients to list available handlers via the list-handlers message. Command: pacmd send-message /core list-handlers pactl can be used

Re: [pulseaudio-discuss] [PATCH] pipe-sink: new option "use_existing_fifo"

2018-01-10 Thread Georg Chini
On 10.01.2018 19:06, Samo Pogačnik wrote: Dne 10.01.2018 (sre) ob 08:36 +0100 je Georg Chini napisal(a): On 09.01.2018 22:24, Samo Pogačnik wrote: Allow usage of an already existing fifo (named pipe) upon module load. Also, the fifo is not going to be removed upon module unload, if

Re: [pulseaudio-discuss] [PATCH] pipe-sink: new option "use_existing_fifo"

2018-01-09 Thread Georg Chini
On 09.01.2018 22:24, Samo Pogačnik wrote: Allow usage of an already existing fifo (named pipe) upon module load. Also, the fifo is not going to be removed upon module unload, if "use_existing_fifo" option has been enabled. I wonder if we really need a new option for this. Can't you just check i

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-07 Thread Georg Chini
On 07.01.2018 20:32, Tanu Kaskinen wrote: On Thu, 2018-01-04 at 20:54 +0100, Georg Chini wrote: On 04.01.2018 14:35, Tanu Kaskinen wrote: On Thu, 2018-01-04 at 08:52 +0100, Georg Chini wrote: On 03.01.2018 14:51, Tanu Kaskinen wrote: Your proposal sounds good, if I understand it correctly. I

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-06 Thread Georg Chini
On 04.01.2018 14:27, Tanu Kaskinen wrote: On Wed, 2018-01-03 at 17:34 +0100, Georg Chini wrote: On 03.01.2018 14:51, Tanu Kaskinen wrote: Your proposal sounds good, if I understand it correctly. I don't think module-rescue-streams needs or should be involved, however. Here's m

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-04 Thread Georg Chini
On 04.01.2018 14:35, Tanu Kaskinen wrote: On Thu, 2018-01-04 at 08:52 +0100, Georg Chini wrote: On 03.01.2018 14:51, Tanu Kaskinen wrote: Your proposal sounds good, if I understand it correctly. I don't think module-rescue-streams needs or should be involved, however. Don't we

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-04 Thread Georg Chini
On 04.01.2018 14:49, Tanu Kaskinen wrote: On Thu, 2018-01-04 at 15:35 +0200, Tanu Kaskinen wrote: On Thu, 2018-01-04 at 08:52 +0100, Georg Chini wrote: On 03.01.2018 14:51, Tanu Kaskinen wrote: Your proposal sounds good, if I understand it correctly. I don't think module-rescue-streams

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-03 Thread Georg Chini
On 03.01.2018 14:51, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 18:08 +0100, Georg Chini wrote: On 30.12.2017 16:12, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 14:27 +0100, Georg Chini wrote: On 30.12.2017 13:55, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 13:09 +0100, Georg Chini wrote: On

Re: [pulseaudio-discuss] pulseaudio and espeakup (fwd)

2018-01-03 Thread Georg Chini
On 03.01.2018 18:09, Jude DaShiell wrote: -- Forwarded message -- Date: Wed, 3 Jan 2018 12:05:21 From: Samuel Thibault To: Alex ARNAUD Cc: pkg-pulseaudio-de...@lists.alioth.debian.org, debian-accessibil...@lists.debian.org Subject: Re: pulseaudio and espeakup Resent-Date: Wed,

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-03 Thread Georg Chini
On 03.01.2018 14:51, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 18:08 +0100, Georg Chini wrote: On 30.12.2017 16:12, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 14:27 +0100, Georg Chini wrote: On 30.12.2017 13:55, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 13:09 +0100, Georg Chini wrote: On

Re: [pulseaudio-discuss] running pulseaudio on an embedded device with no X as a network sink

2018-01-03 Thread Georg Chini
On 03.01.2018 00:44, Doron Behar wrote: Bump On Thu, Dec 28, 2017 at 11:34:29AM +0200, Doron Behar wrote: Hello everyone, I'm trying for a while now to run pulseaudio on my Raspberry-Pi 3 and I can't get it to work. I posted a question with a lot of details on stackexchange.com: https://raspb

Re: [pulseaudio-discuss] Audio source getting stuck on monitor record

2018-01-02 Thread Georg Chini
On 26.12.2017 16:33, Daniele Varrazzo wrote: Hello, good $TIME_OF_DAY I am experimenting with interaction between music and coloured lights, as you do in these days. So I've set up a Python script to record from a PulseAudio source monitor, FFT some audio chunks into a spectrum and send it to an

Re: [pulseaudio-discuss] [PATCH v2 1/2] switch-on-port-available: remove unused return values

2018-01-01 Thread Georg Chini
On 28.12.2017 16:14, Tanu Kaskinen wrote: --- src/modules/module-switch-on-port-available.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c index 7d2c596cf..8fd3c9

Re: [pulseaudio-discuss] [PATCH] build-sys: fix PA_MODULE_NAME for module-default-device-restore

2017-12-31 Thread Georg Chini
On 28.12.2017 15:53, Tanu Kaskinen wrote: --- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index b7524b23a..d4a649c97 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1931,7 +1931,7 @@ module_card_restore_la_CFLAGS

Re: [pulseaudio-discuss] [PATCH 0/3] Fix infinite loop with Intel HDMI LPE driver (plus logging improvements)

2017-12-31 Thread Georg Chini
On 28.12.2017 11:09, Tanu Kaskinen wrote: Despite previous attempts to fix the problem, the Intel HDMI LPE driver is still causing PulseAudio to sometimes get killed due to an infinite loop. These patches should finally fix the infinite loop. Further fixing is still needed after these patches to

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-30 Thread Georg Chini
On 30.12.2017 16:12, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 14:27 +0100, Georg Chini wrote: On 30.12.2017 13:55, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 13:09 +0100, Georg Chini wrote: On 29.12.2017 21:28, Georg Chini wrote: On 29.12.2017 13:49, Tanu Kaskinen wrote: There's stil

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-30 Thread Georg Chini
On 30.12.2017 13:55, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 13:09 +0100, Georg Chini wrote: On 29.12.2017 21:28, Georg Chini wrote: On 29.12.2017 13:49, Tanu Kaskinen wrote: There's still the problem that once the HDMI sink is available again, streams won't be moved there aut

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-30 Thread Georg Chini
On 30.12.2017 13:55, Tanu Kaskinen wrote: On Sat, 2017-12-30 at 13:09 +0100, Georg Chini wrote: On 29.12.2017 21:28, Georg Chini wrote: On 29.12.2017 13:49, Tanu Kaskinen wrote: There's still the problem that once the HDMI sink is available again, streams won't be moved there aut

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-30 Thread Georg Chini
On 29.12.2017 21:28, Georg Chini wrote: On 29.12.2017 13:49, Tanu Kaskinen wrote: On Fri, 2017-12-29 at 08:25 +0100, Georg Chini wrote: On 28.12.2017 16:14, Tanu Kaskinen wrote: This ensures that streams are moved away from unavailable outputs or inputs. For example, sometimes HDMI is on a

Re: [pulseaudio-discuss] [PATCH 1/3] alsa: fix infinite loop with Intel HDMI LPE

2017-12-30 Thread Georg Chini
On 30.12.2017 10:54, Alexander E. Patrakov wrote: 2017-12-29 20:37 GMT+08:00 Tanu Kaskinen : On Fri, 2017-12-29 at 11:46 +0800, Alexander E. Patrakov wrote: 2017-12-28 18:09 GMT+08:00 Tanu Kaskinen : The Intel HDMI LPE driver works in a peculiar way when the HDMI cable is not plugged in: any w

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-29 Thread Georg Chini
On 29.12.2017 13:49, Tanu Kaskinen wrote: On Fri, 2017-12-29 at 08:25 +0100, Georg Chini wrote: On 28.12.2017 16:14, Tanu Kaskinen wrote: This ensures that streams are moved away from unavailable outputs or inputs. For example, sometimes HDMI is on a dedicated alsa card, and if all HDMI

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-28 Thread Georg Chini
On 28.12.2017 16:14, Tanu Kaskinen wrote: This ensures that streams are moved away from unavailable outputs or inputs. For example, sometimes HDMI is on a dedicated alsa card, and if all HDMI outputs become unavailable, then the card profile will be set to "off", and the streams will be moved som

Re: [pulseaudio-discuss] BT WBS implementation requirement

2017-12-13 Thread Georg Chini
On 13.12.2017 05:03, Sathish Narasimman wrote: Hi, I have a BT controller which supports WBS(Wide Band Speech) encoding. I would like to know is the below patch is good enough to initiate a WBS connection. diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono

Re: [pulseaudio-discuss] [PATCH] filter-apply: Eliminate nested and redundant hook events.

2017-12-09 Thread Georg Chini
On 18.05.2017 03:45, KimJeongYeon wrote: Hook events of proplist triggered by pa_{sink_input|source_output}_set_property() in do_move() function. Then, do_move() will be called again by its nested hook events. For example playback stream, filter-apply calls do_move() by hook event of 'PA_CORE

Re: [pulseaudio-discuss] [PATCH] sink, source: Don't finish move if unlink happens after pa_*_move_all_start()

2017-12-03 Thread Georg Chini
On 03.12.2017 22:08, Tanu Kaskinen wrote: On Sat, 2017-12-02 at 23:19 +0100, Georg Chini wrote: When a sink input is unlinked between the calls to pa_sink_move_all_start() and pa_sink_move_all_finish(), pa_sink_move_all_finish() tried to finish the move of the already unlinked sink input, which

[pulseaudio-discuss] [PATCH] sink, source: Don't finish move if unlink happens after pa_*_move_all_start()

2017-12-02 Thread Georg Chini
When a sink input is unlinked between the calls to pa_sink_move_all_start() and pa_sink_move_all_finish(), pa_sink_move_all_finish() tried to finish the move of the already unlinked sink input, which lead to an assertion in pa_sink_input_finish_move(). The same applies for the source side. This pa

Re: [pulseaudio-discuss] [PATCH 0/2] module-device-manager routing fix

2017-11-30 Thread Georg Chini
On 28.11.2017 18:50, Tanu Kaskinen wrote: PulseEffects[1] doesn't work properly[2] on KDE, because KDE uses module-device-manager and module-device-manager routes PulseEffects' streams too aggressively. These patches hopefully fix the problem (I haven't tested myself, because I don't have KDE).

Re: [pulseaudio-discuss] [PATCH] switch-on-connect: add option to ignore virtual sinks/sources

2017-11-30 Thread Georg Chini
On 30.11.2017 18:52, Tanu Kaskinen wrote: On Mon, 2017-11-13 at 18:46 +0100, Georg Chini wrote: module-switch-on-connect would switch to any new sink, even if the sink was a filter or a null-sink. This patch adds a command line option ignore_virtual to the module, which lets module-switch-on

Re: [pulseaudio-discuss] module-switch-on-connect: handling virtual sinks

2017-11-13 Thread Georg Chini
On 12.11.2017 20:39, wellington wallace wrote: On Sun, Nov 12, 2017 at 12:05 PM, Georg Chini <mailto:ge...@chini.tk>> wrote: On 12.11.2017 14:36, wellington wallace wrote: Another thing that would work is telling Pulseaudio that null sinks created by PulseEffects should

[pulseaudio-discuss] [PATCH] switch-on-connect: add option to ignore virtual sinks/sources

2017-11-13 Thread Georg Chini
module-switch-on-connect would switch to any new sink, even if the sink was a filter or a null-sink. This patch adds a command line option ignore_virtual to the module, which lets module-switch-on-connect ignore virtual sinks and sources. The flag is true by default because the purpose of the modu

Re: [pulseaudio-discuss] module-switch-on-connect: handling virtual sinks

2017-11-12 Thread Georg Chini
es virtual sinks" Will be best. Does this flag exist now? 11 ноября 2017 г. 14:26:21 GMT+03:00, Georg Chini mailto:ge...@chini.tk>> пишет: On 11.11.2017 05:28, Михаил Новоселов, Думалогия wrote: Hello, PulseEffects, an application, that can apply

Re: [pulseaudio-discuss] WG: AW: module-sine for generating two independent sine wave signals on the left and right output of a sound device

2017-11-12 Thread Georg Chini
is a very old version of pulse. Can you try current 11.1 or git? *Von:*Georg Chini [mailto:ge...@chini.tk] *Gesendet:* Samstag, 11. November 2017 20:58 *An:* General PulseAudio Discussion; S.C.T.N Gmbh *Betreff:* Re: [pulseaudio-discuss] WG: AW: module-sine for generating two independent sine

Re: [pulseaudio-discuss] WG: AW: module-sine for generating two independent sine wave signals on the left and right output of a sound device

2017-11-11 Thread Georg Chini
On 11.11.2017 15:27, Georg Chini wrote: On 11.11.2017 14:58, S.C.T.N Gmbh wrote: please don't top post on that list. Yes I can confirm that: Pactl unload-module stops the sine output on both channels. But in pactl list modules short the module has disappeared while the other module

Re: [pulseaudio-discuss] WG: AW: module-sine for generating two independent sine wave signals on the left and right output of a sound device

2017-11-11 Thread Georg Chini
be reloaded again (roughly 10secs). This also sounds weird. Same comment as above. Is there any flag or indication that the unloading has completed so that the module can be reloaded again? Kind regards *Von:*Georg Chini [mailto:ge...@chini.tk] *Gesendet:* Samstag, 11. November 2017 12:32

Re: [pulseaudio-discuss] module-sine for generating two independent sine wave signals on the left and right output of a sound device

2017-11-11 Thread Georg Chini
pactl unload-module 26" should unload only the single sine module. If you use the name, all instances of the module are unloaded. Doesn't that work for you? That would be a bug. You can also see the module index with "pactl list modules short". *Von:*Georg Chini [mailto:

Re: [pulseaudio-discuss] module-switch-on-connect: handling virtual sinks

2017-11-11 Thread Georg Chini
flag exist now? Please don't top post on that list. No, such a flag does not exist right now but it can be added rather easily. I'll send you an untested patch, please check if it works as expected. 11 ноября 2017 г. 14:26:21 GMT+03:00, Georg Chini пишет: On 11.11.2017 05:28, Ми

Re: [pulseaudio-discuss] module-sine for generating two independent sine wave signals on the left and right output of a sound device

2017-11-11 Thread Georg Chini
On 11.11.2017 09:50, S.C.T.N Gmbh wrote: I want to use MODULE-SINE to produce two independent sine wave signals with different frequencies on the left and right output of a sound card: By using : pactl load-module module-sine frequency=1000 I get of course the same 1000Hz signal on both cha

Re: [pulseaudio-discuss] module-switch-on-connect: handling virtual sinks

2017-11-11 Thread Georg Chini
On 11.11.2017 05:28, Михаил Новоселов, Думалогия wrote: Hello, PulseEffects, an application, that can apply different effects or equalize both input and output sound, cannot work properly when module-switch-on-connect is on. PulseEffects creates a virtual sinks, but PulseAudio's module-switch

Re: [pulseaudio-discuss] [PATCH 0/2] module-card-restore fixes

2017-11-09 Thread Georg Chini
On 08.11.2017 13:20, Tanu Kaskinen wrote: Tanu Kaskinen (2): card-restore: log the correct profile name card-restore: don't restore unavailable profiles src/modules/module-card-restore.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Look both good. ___

Re: [pulseaudio-discuss] [PATCH 2/2] remap-source, virtual-source: fix max_rewind handling

2017-11-05 Thread Georg Chini
On 31.10.2017 14:29, Tanu Kaskinen wrote: The filter sources should have the same max_rewind as the master source, but these modules didn't update max_rewind when the master max_rewind changed. --- src/modules/module-remap-source.c | 12 src/modules/module-virtual-source.c | 12

[pulseaudio-discuss] [PATCH 3/3] message-handler: Send signal on handler events

2017-10-30 Thread Georg Chini
Signals are used to notify clients when a messge handler was added/removed or when the description changed. --- src/pulsecore/message-handler.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/pulsecore/message-handler.c b/src/pulsecore/message-handler.c index 8f8830d6.

[pulseaudio-discuss] [PATCH 1/3] protocol-native: Add signal receiving capability

2017-10-30 Thread Georg Chini
This patch extends the client subscription API, so that signals sent from PulseAudio can be processed. Within PulseAudio, a signal can be emitted using pa_signal_post(). The interface can be used to notify the client of events that are not covered by the subscription API (for example a button press

[pulseaudio-discuss] [PATCH 3/3] message-handler: Send signal on handler events

2017-10-30 Thread Georg Chini
Signals are used to notify clients when a messge handler was added/removed or when the description changes. --- src/pulsecore/message-handler.c | 9 + 1 file changed, 9 insertions(+) diff --git a/src/pulsecore/message-handler.c b/src/pulsecore/message-handler.c index 8f8830d6..b6505dc9 10

[pulseaudio-discuss] [PATCH 2/3] pactl: Add signal receiver

2017-10-30 Thread Georg Chini
--- man/pactl.1.xml.in | 2 +- src/utils/pactl.c | 20 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/man/pactl.1.xml.in b/man/pactl.1.xml.in index e444f973..d0d80ab9 100644 --- a/man/pactl.1.xml.in +++ b/man/pactl.1.xml.in @@ -254,7 +254,7 @@ License along w

[pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2017-10-29 Thread Georg Chini
For better readability, "pactl list message-handlers" is introduced which prints a formatted output of "pactl send-message /core list-handlers". The patch also adds the function pa_split_message_response() for easy parsing of the message response string. --- man/pactl.1.xml.in | 2

[pulseaudio-discuss] [PATCH 3/5] pactl, pacmd, cli-command: Add send-message command

2017-10-29 Thread Georg Chini
--- doc/messaging_api.txt| 16 ++ man/pactl.1.xml.in | 7 ++ man/pulse-cli-syntax.5.xml.in| 7 ++ shell-completion/bash/pulseaudio | 5 +++-- shell-completion/zsh/_pulseaudio | 2 ++ src/pulsecore/cli-command.c | 44 +++

[pulseaudio-discuss] [PATCH 1/5] core: add simple message interface

2017-10-29 Thread Georg Chini
This patch adds a new feature to the core which allows to send messages to objects. An object can register/unregister a message handler with pa_message_handler_{register, unregister}() while a message can be sent to the handler using the pa_message_handler_send_message() function. A message has 4 a

[pulseaudio-discuss] [PATCH 2/5] protocol-native: add message sending capability

2017-10-29 Thread Georg Chini
This patch adds the PA_COMMAND_SEND_OBJECT_MESSAGE command to protocol-native so that clients can use the messaging feature introduced in the previous patch. Sending messages can in effect replace the extension system for modules. The approach is more flexible than the extension interface because

[pulseaudio-discuss] [PATCH 4/5] core: add message handler

2017-10-29 Thread Georg Chini
This patch adds a small message handler to the core which enables clients to list available handlers via the list-handlers message. Command: pacmd send-message /core list-handlers pactl can be used with the same parameters. The patch also introduces a convention for the return string. It consists

Re: [pulseaudio-discuss] [PATCH] alsa-card: improve the profile availability logic

2017-10-27 Thread Georg Chini
On 27.10.2017 21:39, Georg Chini wrote: On 21.09.2017 14:47, Tanu Kaskinen wrote: When a new card shows up (during pulseaudio startup or hotplugged), pulseaudio needs to pick the initial profile for the card. Unavailable profiles shouldn't be picked, but module-alsa-card sometimes m

Re: [pulseaudio-discuss] [PATCH] alsa-card: improve the profile availability logic

2017-10-27 Thread Georg Chini
On 21.09.2017 14:47, Tanu Kaskinen wrote: When a new card shows up (during pulseaudio startup or hotplugged), pulseaudio needs to pick the initial profile for the card. Unavailable profiles shouldn't be picked, but module-alsa-card sometimes marked unavailable profiles as available, causing bad i

Re: [pulseaudio-discuss] [PATCH 4/6] core: add message handler

2017-10-21 Thread Georg Chini
On 03.10.2017 14:58, Tanu Kaskinen wrote: Also, it's questionable why the list-handlers command is implemented with the messaging API in the first place. It's core functionality, so why is it not implemented using the normal introspection API? Two reasons: a) It's much simpler than using the

Re: [pulseaudio-discuss] [PATCH] mention the sound card clock and system clock difference in libpulse docs

2017-10-21 Thread Georg Chini
On 19.10.2017 20:22, Tanu Kaskinen wrote: --- src/pulse/def.h| 19 +-- src/pulse/stream.h | 8 ++-- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/src/pulse/def.h b/src/pulse/def.h index 680bdc981..87b7dd40a 100644 --- a/src/pulse/def.h +++ b/src/puls

Re: [pulseaudio-discuss] [PATCH] volume: improve documentation

2017-10-15 Thread Georg Chini
On 15.10.2017 15:56, Tanu Kaskinen wrote: Changes: - Mention that source outputs have volume too. - Don't claim that most distributions have flat volumes enabled. - Volumes use a cubic scale, not logarithmic. - Reword the warning about using the conversion functions on hardware volume

Re: [pulseaudio-discuss] [PATCH] bluetooth: set better priorities for profiles

2017-10-15 Thread Georg Chini
On 15.10.2017 12:29, Tanu Kaskinen wrote: Since HSP had higher priority than A2DP, the default profile when connecting a new headset was HSP. To me it makes more sense to default to high-quality output. We already have some automatic policies to switch to HSP when it's needed. I also made the A2

Re: [pulseaudio-discuss] ISSUE : POOR AUDIO QUALITY AND HIGH LATENCY WHILE USING HFP

2017-10-12 Thread Georg Chini
On 12.10.2017 13:26, Vimal Babu wrote: *ISSUE : POOR AUDIO QUALITY AND HIGH LATENCY WHILE USING HFP* ** We are using Bluetooth HFP Configuration with Pulse Audio, BlueZ and oFono components and facing issues of poor Audio high latency. Using HFP we are able to receive and transmit voice (Bl

Re: [pulseaudio-discuss] [PATCH 4/6] core: add message handler

2017-10-03 Thread Georg Chini
On 03.10.2017 14:58, Tanu Kaskinen wrote: On Mon, 2017-10-02 at 14:32 +0200, Georg Chini wrote: On 02.10.2017 11:31, Tanu Kaskinen wrote: On Sun, 2017-10-01 at 20:31 +0200, Georg Chini wrote: On 01.10.2017 18:16, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote

Re: [pulseaudio-discuss] [PATCH 4/6] core: add message handler

2017-10-03 Thread Georg Chini
On 03.10.2017 14:58, Tanu Kaskinen wrote: On Mon, 2017-10-02 at 14:32 +0200, Georg Chini wrote: On 02.10.2017 11:31, Tanu Kaskinen wrote: On Sun, 2017-10-01 at 20:31 +0200, Georg Chini wrote: On 01.10.2017 18:16, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote

Re: [pulseaudio-discuss] [PATCH 5/6] protocol-native: Add signal receiving capability

2017-10-02 Thread Georg Chini
On 02.10.2017 12:20, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote: This patch extends the client subscription API, so that signals sent from PulseAudio can be processed. Within PulseAudio, a signal can be emitted using pa_signal_post(). The interface can be used to

Re: [pulseaudio-discuss] [PATCH 4/6] core: add message handler

2017-10-02 Thread Georg Chini
On 02.10.2017 11:31, Tanu Kaskinen wrote: On Sun, 2017-10-01 at 20:31 +0200, Georg Chini wrote: On 01.10.2017 18:16, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote: +/* List handlers */ +char *pa_core_message_handler_list(pa_core *c); Putting this function to core

Re: [pulseaudio-discuss] [PATCH 4/6] core: add message handler

2017-10-01 Thread Georg Chini
On 01.10.2017 18:16, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote: +/* List handlers */ +char *pa_core_message_handler_list(pa_core *c); Putting this function to core-messages.h doesn't seem right to me. The function will never be used outside core.c, so t

Re: [pulseaudio-discuss] [PATCH 3/6] pactl, pacmd, cli-command: Add send-message command

2017-10-01 Thread Georg Chini
On 30.09.2017 14:34, Tanu Kaskinen wrote: On Fri, 2017-09-29 at 22:32 +0200, Georg Chini wrote: On 29.09.2017 16:03, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote: --- man/pactl.1.xml.in | 6 + man/pulse-cli-syntax.5.xml.in| 6

Re: [pulseaudio-discuss] [PATCH 3/6] pactl, pacmd, cli-command: Add send-message command

2017-09-29 Thread Georg Chini
On 29.09.2017 16:03, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote: --- man/pactl.1.xml.in | 6 + man/pulse-cli-syntax.5.xml.in| 6 + shell-completion/bash/pulseaudio | 5 +++-- shell-completion/zsh/_pulseaudio | 2 ++ src

Re: [pulseaudio-discuss] [PATCH v5 2/4] bluetooth: separate HSP and HFP

2017-09-25 Thread Georg Chini
On 25.09.2017 15:53, James Bottomley wrote: On Sun, 2017-09-24 at 15:35 +0200, Georg Chini wrote: On 21.09.2017 21:27, James Bottomley wrote: When all headsets supported both HSP and HFP, life was good and we only needed to implement HSP in the native backend.  Unfortunately some headsets have

Re: [pulseaudio-discuss] [PATCH v5 1/4] bluetooth: use consistent profile names

2017-09-25 Thread Georg Chini
On 25.09.2017 15:31, James Bottomley wrote: On Sun, 2017-09-24 at 15:07 +0200, Georg Chini wrote: On 21.09.2017 21:26, James Bottomley wrote: The PA_BLUETOOTH_PROFILE names should mirror the PA_BLUETOOTH_UUID names using profile_function instead of randomly made up names.  Fix this with the

Re: [pulseaudio-discuss] [PATCH v5 2/4] bluetooth: separate HSP and HFP

2017-09-24 Thread Georg Chini
On 21.09.2017 21:27, James Bottomley wrote: When all headsets supported both HSP and HFP, life was good and we only needed to implement HSP in the native backend. Unfortunately some headsets have started supporting HFP only. Unfortuantely, we can't simply switch to HFP only because that might b

Re: [pulseaudio-discuss] [PATCH v5 1/4] bluetooth: use consistent profile names

2017-09-24 Thread Georg Chini
On 21.09.2017 21:26, James Bottomley wrote: The PA_BLUETOOTH_PROFILE names should mirror the PA_BLUETOOTH_UUID names using profile_function instead of randomly made up names. Fix this with the transformation: PA_BLUETOOTH_PROFILE_HEADSET_HEAD_UNIT -> PA_BLUETOOTH_PROFILE_HSP_HS PA_BLUETOOTH_PRO

Re: [pulseaudio-discuss] [PATCH 1/6] core: add simple message interface

2017-09-23 Thread Georg Chini
On 23.09.2017 13:59, Tanu Kaskinen wrote: On Sat, 2017-08-19 at 17:48 +0200, Georg Chini wrote: This patch adds a new feature to the core which allows to send messages to objects. An object can register/unregister a message handler with pa_core_message_handler_{register, unregister}() while I

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-21 Thread Georg Chini
On 21.09.2017 19:08, James Bottomley wrote: On Thu, 2017-09-21 at 19:15 +0300, Tanu Kaskinen wrote: On Thu, 2017-09-21 at 17:47 +0200, Georg Chini wrote: On 21.09.2017 16:47, James Bottomley wrote: On Thu, 2017-09-21 at 17:28 +0300, Tanu Kaskinen wrote: I think we should use the native

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-21 Thread Georg Chini
On 21.09.2017 16:47, James Bottomley wrote: On Thu, 2017-09-21 at 17:28 +0300, Tanu Kaskinen wrote: On Thu, 2017-09-21 at 08:13 +0200, Georg Chini wrote: On 21.09.2017 06:45, James Bottomley wrote: On Thu, 2017-09-21 at 06:27 +0200, Georg Chini wrote: On 20.09.2017 23:12, James Bottomley

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-20 Thread Georg Chini
On 21.09.2017 06:45, James Bottomley wrote: On Thu, 2017-09-21 at 06:27 +0200, Georg Chini wrote: On 20.09.2017 23:12, James Bottomley wrote: On Wed, 2017-09-20 at 20:41 +0200, Georg Chini wrote: On 20.09.2017 20:10, James Bottomley wrote: On Wed, 2017-09-20 at 18:11 +0200, Georg Chini wrote

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-20 Thread Georg Chini
On 20.09.2017 23:12, James Bottomley wrote: On Wed, 2017-09-20 at 20:41 +0200, Georg Chini wrote: On 20.09.2017 20:10, James Bottomley wrote: On Wed, 2017-09-20 at 18:11 +0200, Georg Chini wrote: On 20.09.2017 01:27, James Bottomley wrote: This is round 4 of the initial bluetooth: separate

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-20 Thread Georg Chini
On 20.09.2017 20:10, James Bottomley wrote: On Wed, 2017-09-20 at 18:11 +0200, Georg Chini wrote: On 20.09.2017 01:27, James Bottomley wrote: This is round 4 of the initial bluetooth: separate HSP and HFP patch.   It includes the review feedback and a global on/off switch just in case there&#

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-20 Thread Georg Chini
On 20.09.2017 01:27, James Bottomley wrote: This is round 4 of the initial bluetooth: separate HSP and HFP patch. It includes the review feedback and a global on/off switch just in case there's a problem headset with dual HFP/HSP but non-working HFP.  This one now includes a proper rfcomm nego

Re: [pulseaudio-discuss] [PATCH 0/8] some Coverity and gcc-7 fixes

2017-09-19 Thread Georg Chini
On 06.09.2017 14:23, Peter Meerwald-Stadler wrote: some minor fixes addressing and silencing recent Coverity and gcc-7 warnings Peter Meerwald-Stadler (8): bluetooth: ofono: Fix Coverity warning json-test: Fix Coverity warning bluetooth: bluez5: Fix Coverity warning raop: Fix gcc-7 w

Re: [pulseaudio-discuss] [PATCH 1/8] bluetooth: ofono: Fix Coverity warning

2017-09-19 Thread Georg Chini
On 06.09.2017 14:23, Peter Meerwald-Stadler wrote: Dereference before null check Coverity ID: #1454315 Signed-off-by: Peter Meerwald-Stadler --- src/modules/bluetooth/backend-ofono.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.

Re: [pulseaudio-discuss] Bose QC35 HFP/HSP MTU size

2017-09-16 Thread Georg Chini
On 14.09.2017 16:00, Luiz Augusto von Dentz wrote: Hi Sebastian, On Thu, Sep 14, 2017 at 2:44 PM, Sebastian Reichel wrote: Hi, Bose QC35 are affected by the attached upgrade notice from Pulseaudio 11. The workaround fixes the problem. This doesn't make much sense when the problem below refer

Re: [pulseaudio-discuss] [PATCH] Fix: Distorted audio during Bluetooth SCO HFP/HSP playback

2017-09-15 Thread Georg Chini
On 14.09.2017 18:47, Tanu Kaskinen wrote: On Wed, 2017-09-13 at 09:31 +0530, Arun Raghavan wrote: On Tue, 31 Jan 2017, at 06:48 PM, Tanu Kaskinen wrote: On Mon, 2017-01-30 at 17:28 +0100, Georg Chini wrote: On 27.01.2017 21:40, Georg Chini wrote: On 03.01.2017 18:17, Tanu Kaskinen wrote: On

Re: [pulseaudio-discuss] [PATCH] bluez: Don't autodetect MTU by default

2017-09-12 Thread Georg Chini
On 13.09.2017 07:01, Arun Raghavan wrote: On Wed, 13 Sep 2017, at 09:56 AM, Georg Chini wrote: On 13.09.2017 05:54, Arun Raghavan wrote: This breaks a lot of headsets, so disabling by default. Can be re-enabled in configuration for specific hardware where it is deemed necessary. Also added

Re: [pulseaudio-discuss] [PATCH] bluez: Don't autodetect MTU by default

2017-09-12 Thread Georg Chini
On 13.09.2017 05:54, Arun Raghavan wrote: This breaks a lot of headsets, so disabling by default. Can be re-enabled in configuration for specific hardware where it is deemed necessary. Also added some debug logging to be able to examine what MTU size is reported by the device. BugLink: https://

Re: [pulseaudio-discuss] [Patch] RAOP: fix audio synchronisation, take two

2017-09-09 Thread Georg Chini
On 09.09.2017 19:16, Tanu Kaskinen wrote: On Sat, 2017-09-09 at 18:07 +0200, Colin Leroy wrote: On 09 September 2017 at 18h00, Tanu Kaskinen wrote: Hi Tanu, Your mail's empty :) Well I definitely wrote things, but Evolution did act strange while composing the message, and my "sent" folder con

Re: [pulseaudio-discuss] Horribly choppy sound during bluetooth a2dp playback

2017-09-04 Thread Georg Chini
On 04.09.2017 00:23, Vladimir Lebedev wrote: Hi All, I'm trying to create bluetooth speaker from my nanopi neo plus 2 SBC (running Ubuntu 16.04.3 LTS with Linux 4.11.2 provided by FriendlyElec). (With some pain) I've managed to make all native linux clients to use pulseaudio server on nanopi

[pulseaudio-discuss] [PATCH] bluez5-device: lower sink/source priority for Audio gateway or a2dp source

2017-09-02 Thread Georg Chini
When a phone is connected via bluetooth and switches to HFP, the sinks and sources will have higher priority than the built-in devices. Therefore they are chosen as default and module-bluetooth-policy will incorrectly insert loopback modules that loop the phone back to itself. This patch fixes the

Re: [pulseaudio-discuss] [PATCH] bluetooth: recognize another HSP HS UUID

2017-09-02 Thread Georg Chini
On 02.09.2017 14:44, Tanu Kaskinen wrote: There are actually two HSP HS UUIDs. My theory is that the second one was added, because someone was not happy with the old UUID being used for identifying two different things (the HSP profile as a whole, and the HS role within the HSP profile). Some hea

Re: [pulseaudio-discuss] [PATCH] sink/source: lower priority of phone sinks/sources

2017-09-02 Thread Georg Chini
On 02.09.2017 13:12, Tanu Kaskinen wrote: On Fri, 2017-09-01 at 16:21 +0200, Georg Chini wrote: When a phone is connected via bluetooth and switches to HFP, the sinks and sources will have higher priority than the built-in devices. Therefore they are chosen as default and module-bluetooth

<    1   2   3   4   5   6   7   8   9   10   >