Re: [pulseaudio-discuss] [PATCH 6/8] pass pa_suspend_cause_t to SINK/SOURCE_SET_STATE handlers

2018-02-21 Thread Tanu Kaskinen
On Thu, 2018-02-22 at 08:25 +0100, Georg Chini wrote: > On 19.02.2018 15:48, Tanu Kaskinen wrote: > > The suspend cause isn't yet used by any of the handlers. The alsa sink > > and source will use it to sync the mixer when the SESSION suspend cause > > is removed. Currentl

Re: [pulseaudio-discuss] [PATCH] Add support for SteelSeries Arctis 5 and renamed Arctis 7 files appropriately

2018-02-21 Thread Tanu Kaskinen
On Tue, 2018-02-13 at 20:06 +0100, Bert Hekman wrote: > --- > src/modules/alsa/alsa-mixer.c | 2 ++ > .../paths/steelseries-arctis-5-output-chat.conf| 27 > ++ > .../paths/steelseries-arctis-5-output-game.conf| 27 > ++ >

Re: [pulseaudio-discuss] [PATCH v4 2/7] protocol-native: add message sending capability

2018-02-21 Thread Tanu Kaskinen
On Sun, 2018-01-28 at 18:40 +0100, Georg Chini wrote: > This patch adds the PA_COMMAND_SEND_OBJECT_MESSAGE command to protocol-native > so that clients can use the messaging feature introduced in the previous > patch. > > Sending messages can in effect replace the extension system for modules.

Re: [pulseaudio-discuss] Per (sink input, sink) volume control / routing

2018-02-21 Thread Tanu Kaskinen
On Mon, 2018-02-19 at 17:21 +0100, Andreas Hartmetz wrote: > Am Montag, 19. Februar 2018, 17:05:27 CET schrieben Sie: > > On 02/19/2018 06:46 PM, Andreas Hartmetz wrote: > > > Hello! > > > > > > I am currently developing an audio system for an automotive > > > customer, > > > based on PulseAudio

[pulseaudio-discuss] [PATCH] null-sink, pipe-sink: some state variable cleanups

2018-02-21 Thread Tanu Kaskinen
pa_sink_get_state() is supposed to be used from the main thread. In this case it doesn't really matter, because the SET_STATE handler is executed while the main thread is waiting, but since the state is available also in thread_info, let's use that. All other modules use thread_info.state too, so

Re: [pulseaudio-discuss] [PATCH 2/8] null-sink, pipe-sink: prefer thread_info variables in the IO thread

2018-02-21 Thread Tanu Kaskinen
On Wed, 2018-02-21 at 09:40 +0100, Georg Chini wrote: > On 19.02.2018 15:48, Tanu Kaskinen wrote: > > pa_sink_get_state() is supposed to be used from the main thread. In this > > case it doesn't really matter, because the SET_STATE handler is executed > > while the m

Re: [pulseaudio-discuss] [PATCH v4 1/7] core: add simple message interface

2018-02-20 Thread Tanu Kaskinen
On Sun, 2018-01-28 at 18:40 +0100, Georg Chini wrote: > This patch adds a new feature to the core which allows to send messages > to objects. An object can register/unregister a message handler with > pa_message_handler_{register, unregister}() while a message can be sent > to the handler using

[pulseaudio-discuss] [PATCH 8/8] fix a call to pa_sink_suspend() from an incorrect thread

2018-02-19 Thread Tanu Kaskinen
The alsa sink calls pa_sink_suspend() from the set_port() callback. pa_sink_suspend() can only be called from the main thread, but the set_port() callback is often called from the IO thread. That caused an assertion to be hit in pa_sink_suspend() when switching ports. Another issue was that

[pulseaudio-discuss] [PATCH 7/8] bluetooth: fix resume error handling

2018-02-19 Thread Tanu Kaskinen
When resuming a sink or source, pa_sink/source_process_msg() should be called only if resuming is successful. pa_sink/source_process_msg() updates thread_info.state and notifies streams about the new state, but if resuming fails, there's no state change. ---

[pulseaudio-discuss] [PATCH 6/8] pass pa_suspend_cause_t to SINK/SOURCE_SET_STATE handlers

2018-02-19 Thread Tanu Kaskinen
The suspend cause isn't yet used by any of the handlers. The alsa sink and source will use it to sync the mixer when the SESSION suspend cause is removed. Currently the syncing is done in pa_sink/source_suspend(), and I want to change that, because pa_sink/source_suspend() shouldn't have any alsa

[pulseaudio-discuss] [PATCH 1/8] alsa, solaris, oss: remove unnecessary error handling when suspending

2018-02-19 Thread Tanu Kaskinen
Suspending never fails. --- src/modules/alsa/alsa-sink.c | 9 ++--- src/modules/alsa/alsa-source.c | 9 ++--- src/modules/module-solaris.c | 18 +++--- src/modules/oss/module-oss.c | 16 +--- 4 files changed, 16 insertions(+), 36 deletions(-) diff --git

[pulseaudio-discuss] [PATCH 0/8] Sink/source state change fixes

2018-02-19 Thread Tanu Kaskinen
be used also when only the suspend cause changes. Then I could finally make the alsa sink handle the mixer syncing internally. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=104761 Tanu Kaskinen (8): alsa, solaris, oss: remove unnecessary error handling when suspending null-sink, pipe

[pulseaudio-discuss] [PATCH 5/8] pass pa_suspend_cause_t to set_state() callbacks

2018-02-19 Thread Tanu Kaskinen
The suspend cause isn't yet used by any of the callbacks. The alsa sink and source will use it to sync the mixer when the SESSION suspend cause is removed. Currently the syncing is done in pa_sink/source_suspend(), and I want to change that, because pa_sink/source_suspend() shouldn't have any alsa

[pulseaudio-discuss] [PATCH 2/8] null-sink, pipe-sink: prefer thread_info variables in the IO thread

2018-02-19 Thread Tanu Kaskinen
pa_sink_get_state() is supposed to be used from the main thread. In this case it doesn't really matter, because the SET_STATE handler is executed while the main thread is waiting, but since the state is available also in thread_info, let's use that. All other modules use thread_info.state too, so

[pulseaudio-discuss] [PATCH 3/8] alsa: add a couple of FIXME comments

2018-02-19 Thread Tanu Kaskinen
build_pollfd() isn't likely to fail, but if it does, pa_sink/source_put() will crash on an assertion failure. I haven't seen such crash happening, this is just something that I noticed while studying the state change code. --- src/modules/alsa/alsa-sink.c | 3 +++ src/modules/alsa/alsa-source.c

[pulseaudio-discuss] [PATCH 4/8] sink, source: redo state changing code

2018-02-19 Thread Tanu Kaskinen
This adds a pa_suspend_cause_t parameter to the sink/source_set_state() functions, and moves part of the work that pa_sink/source_suspend() does to sink/source_set_state(). The reason for this code shuffling is that I plan to make all suspend cause changes available to modules through the state

Re: [pulseaudio-discuss] [PATCH] null-source: fix multiple bugs

2018-02-17 Thread Tanu Kaskinen
On Sat, 2018-02-17 at 12:30 +0100, Georg Chini wrote: > On 17.02.2018 07:32, Tanu Kaskinen wrote: > > On Fri, 2018-02-16 at 13:04 +0100, Georg Chini wrote: > > > On 16.02.2018 11:46, Raman Shishniou wrote: > > > > On 02/15/2018 11:51 PM, Georg Chini wrote: >

Re: [pulseaudio-discuss] [PATCH] null-source: fix multiple bugs

2018-02-16 Thread Tanu Kaskinen
On Fri, 2018-02-16 at 13:04 +0100, Georg Chini wrote: > On 16.02.2018 11:46, Raman Shishniou wrote: > > On 02/15/2018 11:51 PM, Georg Chini wrote: > > > The current null-source implementation has several bugs: > > > > > > 1) The latency reported is the negative of the correct latency. > > > 2)

Re: [pulseaudio-discuss] [PATCH v2 2/3] alsa-mixer: autodetect the HDMI jack PCM device

2018-02-13 Thread Tanu Kaskinen
On Tue, 2018-02-13 at 08:28 +0530, Arun Raghavan wrote: > On Sun, 8 Oct 2017, at 10:18 PM, Tanu Kaskinen wrote: > > This removes the need to hardcode the PCM device index in the HDMI jack > > names. The hardcoded values don't work with the Intel HDMI LPE driver. > >

Re: [pulseaudio-discuss] Fwd: Adding support for CMEDIA USB2.0 High-Speed True HD Audio

2018-02-12 Thread Tanu Kaskinen
On Fri, 2018-02-09 at 09:30 +0100, Jean-Philippe Guillemin wrote: > Hi, > > No reply from alsa-devel :( > > Thanks for your help > > Also attached the files to fix profile in pulse. > > I have made a lot of tests on my side at alsa level, but the only thing > that fix the iec958 aliasing

[pulseaudio-discuss] Freezing master

2018-02-12 Thread Tanu Kaskinen
Hello, According to the usual release schedule, master should have been frozen already in December, but I've been postponing that (for no good reason). Now finally, if there are no objections, I declare master frozen so that we can soon release 12.0. There won't be a release candidate published

Re: [pulseaudio-discuss] [PATCH] core-util: correct error in set_nonblock()

2018-02-12 Thread Tanu Kaskinen
On Sun, 2018-02-11 at 20:12 +0100, Georg Chini wrote: > set_nonblock() will always set the file descriptor to non-blocking, > regardless of the nonblock argument. > > This patch fixes the issue by passing the correct argument to the > fcntl() call. The bug had no impact because there is only one

Re: [pulseaudio-discuss] [PATCH v2] pipe-source: suspend source when no writers connected to fifo

2018-02-12 Thread Tanu Kaskinen
On Sat, 2018-02-10 at 23:08 +0100, Georg Chini wrote: > On 10.02.2018 23:04, Raman Shishniou wrote: > > On 02/11/2018 12:43 AM, Georg Chini wrote: > > > On 10.02.2018 22:25, Raman Shuishniou wrote: > > > > 10.02.2018 23:59, Georg Chini пишет: > > > > > On 08.02.2018 17:58, Raman Shyshniou wrote: >

Re: [pulseaudio-discuss] [PATCH] filter-apply: Ignore monitor source of filter in find_paired_master()

2018-02-09 Thread Tanu Kaskinen
On Thu, 2018-02-08 at 18:40 +0100, Georg Chini wrote: > On 08.02.2018 17:09, Tanu Kaskinen wrote: > > On Wed, 2018-02-07 at 15:28 +0100, Georg Chini wrote: > > > On 07.02.2018 13:21, Tanu Kaskinen wrote: > > > > On Tue, 2018-02-06 at 20:26 +0100, Georg Chini wrote

Re: [pulseaudio-discuss] [PATCH] filter-apply: Ignore monitor source of filter in find_paired_master()

2018-02-08 Thread Tanu Kaskinen
On Wed, 2018-02-07 at 15:28 +0100, Georg Chini wrote: > On 07.02.2018 13:21, Tanu Kaskinen wrote: > > On Tue, 2018-02-06 at 20:26 +0100, Georg Chini wrote: > > > When module-filter-apply tries to find a matching source-output for > > > a given sink-input and

Re: [pulseaudio-discuss] [PATCH] filter-apply: Ignore monitor source of filter in find_paired_master()

2018-02-07 Thread Tanu Kaskinen
On Tue, 2018-02-06 at 20:26 +0100, Georg Chini wrote: > When module-filter-apply tries to find a matching source-output for > a given sink-input and a stream with the same role Shouldn't this be "with the same group", not "with the same role"? > exists on the > monitor source of the filter,

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: add support for Steelseries Arctis 5 headset

2018-02-06 Thread Tanu Kaskinen
On Sun, 2018-02-04 at 17:22 +0100, Bert Hekman wrote: > In alsamixer, PCM only controls the "game" output and Com Speaker only > controls the "chat" output. Ok, could you make an updated patch that adds dedicated output path configuration files for this card? The "game" path should use PCM for

Re: [pulseaudio-discuss] Module "module-bluetooth-discover" cannot be loaded.

2018-02-03 Thread Tanu Kaskinen
On Fri, 2018-02-02 at 15:43 +, victor puertas wrote: > Dear all, > > I am using Debian 9 and I noticed the following problem: > > *Module "module-bluetooth-discover" cannot be loaded. > > I am executing the following command in a terminal: > > % sudo pactl load-module

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: add support for Steelseries Arctis 5 headset

2018-02-01 Thread Tanu Kaskinen
On Mon, 2018-01-29 at 13:57 +0100, Bert Hekman wrote: > Between the Arctis 5 and 7, that seems to be the case. > > I do not hear much of a difference between the sound quality. However, it > seems that the "chat" output doesn't go as loud as the game output. I can > change the volume of the chat

Re: [pulseaudio-discuss] profile-set for CMEDIA USB2.0 High-Speed True HD Audio (147a:e055)

2018-02-01 Thread Tanu Kaskinen
On Mon, 2018-01-29 at 11:31 +0100, Jean-Philippe Guillemin wrote: > No matter what match string I tried, ALSA never changed the device for > iec958. > > > root[~]# cat /proc/asound/cards > 0 [Audio ]: USB-Audio - USB2.0 High-Speed True HD Audio > CMEDIA USB2.0

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: add support for Steelseries Arctis 5 headset

2018-01-28 Thread Tanu Kaskinen
On Sat, 2018-01-06 at 15:03 +0100, Bert Hekman wrote: > --- > .../alsa/mixer/profile-sets/90-pulseaudio.rules| 3 +- > .../steelseries-arctis-5-usb-audio.conf| 45 > ++ > ...io.conf => steelseries-arctis-7-usb-audio.conf} | 0 > 3 files changed, 47

Re: [pulseaudio-discuss] profile-set for CMEDIA USB2.0 High-Speed True HD Audio (147a:e055)

2018-01-28 Thread Tanu Kaskinen
On Fri, 2018-01-26 at 23:15 +0100, Jean-Philippe Guillemin wrote: > Hi, > > After some investigation on how to make the optical iec958 output work on > my CMEDIA based usb DAC, I finally found a solution : a profile-set has to > be added for this device. > > Added to udev 90-pulseaudio.rules : >

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-25 Thread Tanu Kaskinen
On Thu, 2018-01-25 at 09:08 +0100, Georg Chini wrote: > On 24.01.2018 01:40, Tanu Kaskinen wrote: > > On Mon, 2018-01-22 at 16:19 +0100, Georg Chini wrote: > > > On 21.01.2018 01:03, Tanu Kaskinen wrote: > > > > It looks like we're anyway going to > > > &

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-25 Thread Tanu Kaskinen
On Thu, 2018-01-25 at 07:38 +0100, Georg Chini wrote: > On 25.01.2018 00:26, Tanu Kaskinen wrote: > > On Wed, 2018-01-24 at 22:01 +0100, Georg Chini wrote: > > > On 24.01.2018 02:10, Tanu Kaskinen wrote: > > > > How does validating the brace correctness prevent

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-24 Thread Tanu Kaskinen
On Wed, 2018-01-24 at 22:01 +0100, Georg Chini wrote: > On 24.01.2018 02:10, Tanu Kaskinen wrote: > > On Mon, 2018-01-22 at 21:43 +0100, Georg Chini wrote: > > > On 21.01.2018 01:03, Tanu Kaskinen wrote: > > > > On Fri, 2018-01-19 at 14:23 +0100, Georg Chini

Re: [pulseaudio-discuss] [PATCH] build-sys: don't install esdcompat tool if building without esound support

2018-01-23 Thread Tanu Kaskinen
On Mon, 2018-01-15 at 21:14 -0300, Felipe Sateler wrote: > --- > configure.ac| 8 ++-- > man/Makefile.am | 9 +++-- > src/Makefile.am | 6 +- > 3 files changed, 18 insertions(+), 5 deletions(-) Thanks! Applied. -- Tanu https://liberapay.com/tanuk https://www.patreon.com/tanuk

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-23 Thread Tanu Kaskinen
On Mon, 2018-01-22 at 21:43 +0100, Georg Chini wrote: > On 21.01.2018 01:03, Tanu Kaskinen wrote: > > On Fri, 2018-01-19 at 14:23 +0100, Georg Chini wrote: > > > Also you need to handle the case where the end of a list does not > > > match the end of the string because

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-23 Thread Tanu Kaskinen
On Mon, 2018-01-22 at 16:19 +0100, Georg Chini wrote: > On 21.01.2018 01:03, Tanu Kaskinen wrote: > > It looks like we're anyway going to > > need a bunch of "helper" functions, so there's not that much difference > > between our approaches, mainly list parsing de

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-21 Thread Tanu Kaskinen
On Fri, 2018-01-19 at 14:23 +0100, Georg Chini wrote: > On 18.01.2018 23:20, Tanu Kaskinen wrote: > > On Wed, 2018-01-17 at 16:12 +0100, Georg Chini wrote: > > > On 14.01.2018 21:47, Tanu Kaskinen wrote:ry from > > > > the heap are quite heavy operations, a

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-18 Thread Tanu Kaskinen
On Wed, 2018-01-17 at 16:12 +0100, Georg Chini wrote: > On 14.01.2018 21:47, Tanu Kaskinen wrote:ry from > > the heap are quite heavy operations, and your approach will do a lot of > > those operations. Even reading a simple integer will, I suppose, > > involve first alloc

[pulseaudio-discuss] [PATCH] bluetooth: don't send unsolicted replies to the endpoint Release() call

2018-01-18 Thread Tanu Kaskinen
It was reported that PulseAudio causes error messages in syslog from dbus-daemon: Jan 14 04:51:32 gentoo dbus-daemon[2492]: [system] Rejected send message, 2 matched rules; type="error", sender=":1.15" (uid=1000 pid=2864 comm="/usr/bin/pulseaudio --start --log-target=syslog ")

Re: [pulseaudio-discuss] [PATCH 3/5] pactl, pacmd, cli-command: Add send-message command

2018-01-18 Thread Tanu Kaskinen
On Thu, 2018-01-18 at 13:22 +0100, Georg Chini wrote: > On 09.01.2018 20:30, Tanu Kaskinen wrote: > > On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > > > --- > > > doc/messaging_api.txt| 16 ++ > > > man/pactl.1.xml.in

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-14 Thread Tanu Kaskinen
On Fri, 2018-01-12 at 21:47 +0100, Georg Chini wrote: > On 12.01.2018 16:40, Tanu Kaskinen wrote: > > On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > > > For better readability, "pactl list message-handlers" is introduced which > > > prints a formatte

Re: [pulseaudio-discuss] [PATCH 4/5] core: add message handler

2018-01-14 Thread Tanu Kaskinen
On Fri, 2018-01-12 at 19:42 +0100, Georg Chini wrote: > On 12.01.2018 16:59, Tanu Kaskinen wrote: > > On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > > > +Recipient: /core > > > +Message: list-handlers > > > +Parameters: None > > > +Return val

Re: [pulseaudio-discuss] [PATCH 4/5] core: add message handler

2018-01-12 Thread Tanu Kaskinen
On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > +Recipient: /core > +Message: list-handlers > +Parameters: None > +Return value: {{Handler name} {Description}} I now realized that a single-level list isn't sufficient, it has to be a list of lists: { { {/path1} {Description 1} } {

Re: [pulseaudio-discuss] [PATCH 5/5] pactl: Implement list message-handlers

2018-01-12 Thread Tanu Kaskinen
On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > For better readability, "pactl list message-handlers" is introduced which > prints a formatted output of "pactl send-message /core list-handlers". > > The patch also adds the function pa_split_message_response() for easy > parsing of the

Re: [pulseaudio-discuss] [PATCH 4/5] core: add message handler

2018-01-12 Thread Tanu Kaskinen
On Thu, 2018-01-11 at 19:06 +0100, Georg Chini wrote: > On 11.01.2018 16:28, Tanu Kaskinen wrote: > > On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > > > This patch adds a small message handler to the core which enables > > > clients to list available handlers vi

Re: [pulseaudio-discuss] [PATCH 4/5] core: add message handler

2018-01-11 Thread Tanu Kaskinen
On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > This patch adds a small message handler to the core which enables > clients to list available handlers via the list-handlers message. > Command: pacmd send-message /core list-handlers > pactl can be used with the same parameters. > > The

Re: [pulseaudio-discuss] using PulseAudio without D-Bus?

2018-01-11 Thread Tanu Kaskinen
On Tue, 2018-01-09 at 23:22 +0100, Crni Gorac wrote: > On Tue, Jan 9, 2018 at 7:47 PM, Tanu Kaskinen <ta...@iki.fi> wrote: > > On Tue, 2018-01-09 at 09:47 +0100, Crni Gorac wrote: > > > Is it possible to specify somehow in PulseAudio config files that > > > D-Bu

Re: [pulseaudio-discuss] [PATCH 3/5] pactl, pacmd, cli-command: Add send-message command

2018-01-09 Thread Tanu Kaskinen
On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > --- > doc/messaging_api.txt| 16 ++ > man/pactl.1.xml.in | 7 ++ > man/pulse-cli-syntax.5.xml.in| 7 ++ > shell-completion/bash/pulseaudio | 5 +++-- > shell-completion/zsh/_pulseaudio |

Re: [pulseaudio-discuss] using PulseAudio without D-Bus?

2018-01-09 Thread Tanu Kaskinen
On Tue, 2018-01-09 at 09:47 +0100, Crni Gorac wrote: > Is it possible to specify somehow in PulseAudio config files that > D-Bus should not be used? I achieved the effect by commenting out > loading Bluetooth and ConsoleKit modules in my default.pa file, but am > wondering is it possible to do

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-07 Thread Tanu Kaskinen
On Sat, 2018-01-06 at 15:55 +0100, Georg Chini wrote: > On 04.01.2018 14:27, Tanu Kaskinen wrote: > > On Wed, 2018-01-03 at 17:34 +0100, Georg Chini wrote: > > > On 03.01.2018 14:51, Tanu Kaskinen wrote: > > > > Your proposal sounds good, if I understand it correctly

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-07 Thread Tanu Kaskinen
On Thu, 2018-01-04 at 20:54 +0100, Georg Chini wrote: > On 04.01.2018 14:35, Tanu Kaskinen wrote: > > On Thu, 2018-01-04 at 08:52 +0100, Georg Chini wrote: > > > On 03.01.2018 14:51, Tanu Kaskinen wrote: > > > > Your proposal sounds good, if I understand it correctly

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" added option "use_system_clock_for_timing"

2018-01-04 Thread Tanu Kaskinen
On Wed, 2018-01-03 at 20:34 +0100, Samo Pogačnik wrote: > Below is a new patch. Thanks! Applied. -- Tanu https://www.patreon.com/tanuk ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-04 Thread Tanu Kaskinen
On Thu, 2018-01-04 at 15:35 +0200, Tanu Kaskinen wrote: > On Thu, 2018-01-04 at 08:52 +0100, Georg Chini wrote: > > On 03.01.2018 14:51, Tanu Kaskinen wrote: > > > Your proposal sounds good, if I understand it correctly. I don't think > > > module-rescue-streams

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-04 Thread Tanu Kaskinen
On Thu, 2018-01-04 at 08:52 +0100, Georg Chini wrote: > On 03.01.2018 14:51, Tanu Kaskinen wrote: > > Your proposal sounds good, if I understand it correctly. I don't think > > module-rescue-streams needs or should be involved, however. > > Don't we still need module-res

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-04 Thread Tanu Kaskinen
On Wed, 2018-01-03 at 17:34 +0100, Georg Chini wrote: > On 03.01.2018 14:51, Tanu Kaskinen wrote: > > Your proposal sounds good, if I understand it correctly. I don't think > > module-rescue-streams needs or should be involved, however. Here's my > > proposal: > > &

Re: [pulseaudio-discuss] [PATCH 1/3] alsa: fix infinite loop with Intel HDMI LPE

2018-01-03 Thread Tanu Kaskinen
On Sat, 2017-12-30 at 13:23 +0100, David Henningsson wrote: > > On 2017-12-30 13:03, Georg Chini wrote: > > On 30.12.2017 10:54, Alexander E. Patrakov wrote: > > > 2017-12-29 20:37 GMT+08:00 Tanu Kaskinen <ta...@iki.fi>: > > > > On Fri, 2017-12-29 at 1

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" added option "use_system_clock_for_timing"

2018-01-03 Thread Tanu Kaskinen
On Sat, 2017-12-30 at 18:18 +0100, Samo Pogačnik wrote: > Dne 30.12.2017 (sob) ob 17:22 +0200 je Tanu Kaskinen napisal(a): > > On Sat, 2017-12-30 at 14:00 +0100, Samo Pogačnik wrote: > > > > > > Dne 29.12.2017 (pet) ob 15:40 +0200 je Tanu Kaskinen napisal(a): > >

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2018-01-03 Thread Tanu Kaskinen
On Sat, 2017-12-30 at 18:08 +0100, Georg Chini wrote: > On 30.12.2017 16:12, Tanu Kaskinen wrote: > > On Sat, 2017-12-30 at 14:27 +0100, Georg Chini wrote: > > > On 30.12.2017 13:55, Tanu Kaskinen wrote: > > > > On Sat, 2017-12-30 at 13:09 +0100, Georg Chini wrote:

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" added option "use_system_clock_for_timing"

2017-12-30 Thread Tanu Kaskinen
On Sat, 2017-12-30 at 14:00 +0100, Samo Pogačnik wrote: > Dne 29.12.2017 (pet) ob 15:40 +0200 je Tanu Kaskinen napisal(a): > > On Sat, 2017-12-16 at 16:57 +0100, Samo Pogačnik wrote: > > > > > > +break; > > > +} > > > +

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-30 Thread Tanu Kaskinen
On Sat, 2017-12-30 at 13:09 +0100, Georg Chini wrote: > On 29.12.2017 21:28, Georg Chini wrote: > > On 29.12.2017 13:49, Tanu Kaskinen wrote: > > > There's still the problem that once the HDMI sink is available again, > > > streams won't be moved there automati

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-30 Thread Tanu Kaskinen
On Fri, 2017-12-29 at 21:28 +0100, Georg Chini wrote: > On 29.12.2017 13:49, Tanu Kaskinen wrote: > > On Fri, 2017-12-29 at 08:25 +0100, Georg Chini wrote: > > > On 28.12.2017 16:14, Tanu Kaskinen wrote: > > > > +static void deactivate_direction(pa_card *card, pa_

Re: [pulseaudio-discuss] [PATCH 2/5] protocol-native: add message sending capability

2017-12-29 Thread Tanu Kaskinen
On Sun, 2017-10-29 at 20:51 +0100, Georg Chini wrote: > This patch adds the PA_COMMAND_SEND_OBJECT_MESSAGE command to protocol-native > so that clients can use the messaging feature introduced in the previous > patch. > > Sending messages can in effect replace the extension system for modules.

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" added option "use_system_clock_for_timing"

2017-12-29 Thread Tanu Kaskinen
On Sat, 2017-12-16 at 16:57 +0100, Samo Pogačnik wrote: > +static ssize_t pipe_sink_write(struct userdata *u, pa_memchunk *pchunk) { > +size_t index, length; > +ssize_t count = 0; > +void *p; > + > +pa_assert(u); > +pa_assert(pchunk); > + > +index = pchunk->index; > +

Re: [pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-29 Thread Tanu Kaskinen
On Fri, 2017-12-29 at 08:25 +0100, Georg Chini wrote: > On 28.12.2017 16:14, Tanu Kaskinen wrote: > > This ensures that streams are moved away from unavailable outputs or > > inputs. For example, sometimes HDMI is on a dedicated alsa card, and if > > all HDMI outpu

Re: [pulseaudio-discuss] [PATCH 1/3] alsa: fix infinite loop with Intel HDMI LPE

2017-12-29 Thread Tanu Kaskinen
On Fri, 2017-12-29 at 11:46 +0800, Alexander E. Patrakov wrote: > 2017-12-28 18:09 GMT+08:00 Tanu Kaskinen <ta...@iki.fi>: > > The Intel HDMI LPE driver works in a peculiar way when the HDMI cable is > > not plugged in: any written audio is immediately discarded and und

[pulseaudio-discuss] [PATCH v2 1/2] switch-on-port-available: remove unused return values

2017-12-28 Thread Tanu Kaskinen
--- src/modules/module-switch-on-port-available.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c index 7d2c596cf..8fd3c9e5f 100644 ---

[pulseaudio-discuss] [PATCH v2 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-28 Thread Tanu Kaskinen
This ensures that streams are moved away from unavailable outputs or inputs. For example, sometimes HDMI is on a dedicated alsa card, and if all HDMI outputs become unavailable, then the card profile will be set to "off", and the streams will be moved somewhere else. --- Changes in v2: - Don't

[pulseaudio-discuss] [PATCH v2 0/2] Improve routing when all ports of a card become unavailable

2017-12-28 Thread Tanu Kaskinen
Changes in v2: - Fixed a bug in the second patch: deactivate_direction() was being called unconditionally. Tanu Kaskinen (2): switch-on-port-available: remove unused return values switch-on-port-available: deactivate direction when the no ports are available for that direction src

[pulseaudio-discuss] [PATCH 1/2] switch-on-port-available: remove unused return values

2017-12-28 Thread Tanu Kaskinen
--- src/modules/module-switch-on-port-available.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c index 7d2c596cf..8fd3c9e5f 100644 ---

[pulseaudio-discuss] [PATCH 2/2] switch-on-port-available: deactivate direction when the no ports are available for that direction

2017-12-28 Thread Tanu Kaskinen
This ensures that streams are moved away from unavailable outputs or inputs. For example, sometimes HDMI is on a dedicated alsa card, and if all HDMI outputs become unavailable, then the card profile will be set to "off", and the streams will be moved somewhere else. ---

[pulseaudio-discuss] [PATCH 0/2] Improve routing when all ports of a card become unavailable

2017-12-28 Thread Tanu Kaskinen
Tanu Kaskinen (2): switch-on-port-available: remove unused return values switch-on-port-available: deactivate direction when the no ports are available for that direction src/modules/module-switch-on-port-available.c | 53 ++- 1 file changed, 44 insertions(+), 9

[pulseaudio-discuss] [PATCH] build-sys: fix PA_MODULE_NAME for module-default-device-restore

2017-12-28 Thread Tanu Kaskinen
--- src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index b7524b23a..d4a649c97 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1931,7 +1931,7 @@ module_card_restore_la_CFLAGS = $(AM_CFLAGS)

Re: [pulseaudio-discuss] pulseaudio crash when unplugging hdmi while playing audio over hdmi on Cherry Trail devices

2017-12-28 Thread Tanu Kaskinen
On Fri, 2017-12-15 at 05:23 +0200, Tanu Kaskinen wrote: > On Tue, 2017-12-12 at 11:39 +0100, Hans de Goede wrote: > > Hi All, > > > > First of all good news, with kernel 4.15-rc2 and alsa-lib 1.1.5 > > audio over hdmi works on Cherry Trail devices after selecting &

[pulseaudio-discuss] [PATCH 0/3] Fix infinite loop with Intel HDMI LPE driver (plus logging improvements)

2017-12-28 Thread Tanu Kaskinen
HDMI sink. This is actually not specific to the HDMI LPE driver, the problem exists for any card that can end up in a situation where all of its ports become unavailable. Tanu Kaskinen (3): alsa: fix infinite loop with Intel HDMI LPE sink, source: improve state change logging sink, source: impro

[pulseaudio-discuss] [PATCH 3/3] sink, source: improve suspend cause logging

2017-12-28 Thread Tanu Kaskinen
Previously the suspend cause was logged as a hexadecimal number, now it's logged as a human-friendly string. Also, the command line interface handled only a subset of causes when printing them, now all suspend causes are printed. --- src/pulsecore/cli-text.c | 16 ++--

[pulseaudio-discuss] [PATCH 1/3] alsa: fix infinite loop with Intel HDMI LPE

2017-12-28 Thread Tanu Kaskinen
The Intel HDMI LPE driver works in a peculiar way when the HDMI cable is not plugged in: any written audio is immediately discarded and underrun is reported. That resulted in an infinite loop, because PulseAudio tried to keep the buffer filled, which was futile since the written audio was

[pulseaudio-discuss] [PATCH 2/3] sink, source: improve state change logging

2017-12-28 Thread Tanu Kaskinen
Now the old and new state is logged every time when the sink or source state changes. --- src/pulsecore/cli-text.c | 38 ++ src/pulsecore/sink.c | 14 ++ src/pulsecore/sink.h | 2 ++ src/pulsecore/source.c | 14 ++

Re: [pulseaudio-discuss] pulseaudio crash when unplugging hdmi while playing audio over hdmi on Cherry Trail devices

2017-12-14 Thread Tanu Kaskinen
On Tue, 2017-12-12 at 11:39 +0100, Hans de Goede wrote: > Hi All, > > First of all good news, with kernel 4.15-rc2 and alsa-lib 1.1.5 > audio over hdmi works on Cherry Trail devices after selecting > the right output profile. > > But when unplugging the hdmi cable pa dies. Running pa under > gdb

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" added option "use_system_clock_for_timing"

2017-12-14 Thread Tanu Kaskinen
On Wed, 2017-12-13 at 22:14 +0100, Samo Pogačnik wrote: > Thank you for the remarks. I tried to correct all issues and > below is a new patch. Thanks. I recommend you send patches with "git send-email" in the future. That way the formatting will always be right (I had some trouble getting git

Re: [pulseaudio-discuss] [PATCH] build-sys: First pass at a meson-ified build system

2017-12-12 Thread Tanu Kaskinen
On Tue, 2017-12-12 at 09:47 +0530, Arun Raghavan wrote: > > On Tue, 12 Dec 2017, at 07:29 AM, Tanu Kaskinen wrote: > > On Sun, 2017-12-10 at 12:46 +0530, Arun Raghavan wrote: > > > On Sat, 9 Dec 2017, at 10:58 PM, Felipe Sateler wrote: > > > > On Sat, Dec

Re: [pulseaudio-discuss] [PATCH] build-sys: Stop using symdef headers for modules

2017-12-11 Thread Tanu Kaskinen
On Tue, 2017-12-12 at 10:41 +0530, Arun Raghavan wrote: > > On Sat, 9 Dec 2017, at 01:19 PM, Tanu Kaskinen wrote: > > On Thu, 2017-12-07 at 05:39 +0530, Arun Raghavan wrote: > > > This removes the symdef header generation m4 magic in favour of a > > > simpler macro m

Re: [pulseaudio-discuss] Stuttering when sending vbr stream via tunnel sink

2017-12-11 Thread Tanu Kaskinen
On Sat, 2017-12-02 at 15:28 -0800, Joe (Yu) Zhou wrote: > Hi, > > I'm trying to stream some bluetooth audio via ethernet to another > pulseaudio server. I'm using module-tunnel-sink-new with TCP connection. On > the sender computer I have a bluetooth stream generating a variable bit > rate

[pulseaudio-discuss] [PATCH] map-file: add pa_encoding_from_string

2017-12-11 Thread Tanu Kaskinen
The function is declared in pulse/format.h and it has Doxygen documentation, which tells me that the intention was to make the function available to clients. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=103806 --- src/map-file | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [pulseaudio-discuss] [PATCH] build-sys: First pass at a meson-ified build system

2017-12-11 Thread Tanu Kaskinen
On Sun, 2017-12-10 at 12:46 +0530, Arun Raghavan wrote: > On Sat, 9 Dec 2017, at 10:58 PM, Felipe Sateler wrote: > > On Sat, Dec 9, 2017 at 2:59 AM, Arun Raghavan > > wrote: > > > (Note: this patch depends on the symdef header removal work from a few > > > days ago) > > >

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" added option "use_system_clock_for_timing"

2017-12-11 Thread Tanu Kaskinen
On Sat, 2017-12-09 at 20:09 +0100, Samo Pogačnik wrote: > --- > src/modules/module-pipe-sink.c | 236 > ++--- > 1 file changed, 221 insertions(+), 15 deletions(-) > > diff --git a/src/modules/module-pipe-sink.c b/src/modules/module-pipe-sink.c > index

Re: [pulseaudio-discuss] [PATCH] build-sys: Stop using symdef headers for modules

2017-12-08 Thread Tanu Kaskinen
On Thu, 2017-12-07 at 05:39 +0530, Arun Raghavan wrote: > This removes the symdef header generation m4 magic in favour of a > simpler macro method, allowing us to skip one unnecessary build step > while moving to meson, and removing an 11 year old todo! > --- > src/.gitignore

Re: [pulseaudio-discuss] Couldn't set Buffer size for Bluetooth Audio

2017-12-08 Thread Tanu Kaskinen
On Wed, 2017-12-06 at 20:07 +0900, Shinnosuke Suzuki wrote: > Hi, > > I'm writing a phone application with bluetooth headset using pulseaudio api. > I could create record/playback stream using asynchronous api. > > I got media packet from stream callback for record. > In this function, I got 96

Re: [pulseaudio-discuss] [PATCH] module-ladspa-sink: add module argument to set sink input properties

2017-12-08 Thread Tanu Kaskinen
On Sun, 2017-12-03 at 07:15 +0100, Roliga wrote: > This patch adds a sink_input_properties argument to module-ladspa-sink, > which can be helpful for customizing the appearance of the sink input in > various volume control applications, or to differentiate between > multiple instances of the

[pulseaudio-discuss] [PATCH v2] augment-properties: fix a memory leak

2017-12-06 Thread Tanu Kaskinen
If the desktop file is not found, fn was not being freed after the last loop iteration. CID: 1462477 --- src/modules/module-augment-properties.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/modules/module-augment-properties.c

Re: [pulseaudio-discuss] [PATCH] augment-properties: fix a memory leak

2017-12-06 Thread Tanu Kaskinen
On Thu, 2017-12-07 at 04:46 +0530, Arun Raghavan wrote: > > On Thu, 7 Dec 2017, at 04:09 AM, Tanu Kaskinen wrote: > > If the desktop file is not found, fn was not being freed after the last > > loop iteration. > > > > CID: 1462477 > > --- > > s

[pulseaudio-discuss] [PATCH] augment-properties: fix a memory leak

2017-12-06 Thread Tanu Kaskinen
If the desktop file is not found, fn was not being freed after the last loop iteration. CID: 1462477 --- src/modules/module-augment-properties.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/module-augment-properties.c

Re: [pulseaudio-discuss] [PATCH] RFC: Remove symdef header generation

2017-12-06 Thread Tanu Kaskinen
On Tue, 2017-12-05 at 10:56 +0530, Arun Raghavan wrote: > --- > src/modules/module-allow-passthrough.c | 5 +++-- > src/modules/module-null-sink.c | 6 +++--- > src/pulsecore/module.h | 29 + > 3 files changed, 35 insertions(+), 5 deletions(-)

Re: [pulseaudio-discuss] [PATCH] core-util, cpu-x86: use __get_cpuid() instead of homegrown assembly

2017-12-06 Thread Tanu Kaskinen
On Mon, 2017-12-04 at 19:44 +0530, Arun Raghavan wrote: > On Wed, 22 Nov 2017, at 08:44 PM, Tanu Kaskinen wrote: > > The get_cpuid() function in cpu-x86.c was buggy on x86-64. When building > > without optimizations, the homegrown assembly code overwrote the > > beginning of

Re: [pulseaudio-discuss] [PATCH] sink, source: Don't finish move if unlink happens after pa_*_move_all_start()

2017-12-03 Thread Tanu Kaskinen
On Sat, 2017-12-02 at 23:19 +0100, Georg Chini wrote: > When a sink input is unlinked between the calls to pa_sink_move_all_start() > and > pa_sink_move_all_finish(), pa_sink_move_all_finish() tried to finish the move > of the already unlinked sink input, which lead to an assertion in >

Re: [pulseaudio-discuss] bluetooth headset disconection

2017-12-02 Thread Tanu Kaskinen
On Sat, 2017-12-02 at 10:42 +0900, Shinnosuke Suzuki wrote: > Hi, > > I found a workaroud on this issue! > I changed default.pa as follows: > > > #set-default-sink output > > #set-default-source input > > load-module module-alsa-sink > > load-module module-alsa-source > > I added to load alsa

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" module timig based upon "null-sink" module mechanics.

2017-12-02 Thread Tanu Kaskinen
On Fri, 2017-12-01 at 19:22 +0100, Samo Pogačnik wrote: > Dne 30.11.2017 (čet) ob 20:44 +0200 je Tanu Kaskinen napisal(a): > > Thanks for the patch! Since this changes the pipe-sink behaviour > > rather > > drastically, other people using this module might not like this. Yo

Re: [pulseaudio-discuss] [PATCH] "pipe-sink" module timig based upon "null-sink" module mechanics.

2017-11-30 Thread Tanu Kaskinen
On Tue, 2017-11-14 at 20:22 +0100, Samo Pogačnik wrote: > Using 'cat /run/user/1000/pulse/fifo_output > some-file' upon the loaded > "pipe-sink" module: > ... > load-module module-pipe-sink sink_name=pipe_sink format=s16le rate=44100 > channels=2 > ..., > caused audio players (totem, rhytmbox) to

Re: [pulseaudio-discuss] [PATCH] switch-on-connect: add option to ignore virtual sinks/sources

2017-11-30 Thread Tanu Kaskinen
On Mon, 2017-11-13 at 18:46 +0100, Georg Chini wrote: > module-switch-on-connect would switch to any new sink, even if the sink > was a filter or a null-sink. > > This patch adds a command line option ignore_virtual to the module, which > lets module-switch-on-connect ignore virtual sinks and

<    1   2   3   4   5   6   7   8   9   10   >