Re: [pulseaudio-discuss] Updating the WebRTC AudioProcessing library

2018-04-16 Thread Tanu Kaskinen
On Thu, 2018-04-12 at 11:31 +0200, Tomaž Šolc wrote: > On 10. 04. 2018 14:26, Tanu Kaskinen wrote: > > > I removed this default because the new webrtc configuration class seems > > > to define some sensible defaults itself. Individual components no longer > > > need to be explicitly

Re: [pulseaudio-discuss] Updating the WebRTC AudioProcessing library

2018-04-12 Thread Tomaž Šolc
On 10. 04. 2018 14:26, Tanu Kaskinen wrote: On Mon, 2018-04-09 at 11:56 +0200, Tomaž Šolc wrote: In general I think there's a question of how heavy a wrapper the "module-echo-cancellation" is supposed to be around the webrtc code. The upstream is very actively reworking large parts of the code.

Re: [pulseaudio-discuss] Updating the WebRTC AudioProcessing library

2018-04-09 Thread Tomaž Šolc
Dear Tanu, thanks for your comments. My answers to individual questions are in-line below. In general I think there's a question of how heavy a wrapper the "module-echo-cancellation" is supposed to be around the webrtc code. The upstream is very actively reworking large parts of the code. Most

Re: [pulseaudio-discuss] Updating the WebRTC AudioProcessing library

2018-04-01 Thread Tanu Kaskinen
On Mon, 2018-03-26 at 15:25 +0200, Tomaž Šolc wrote: > Dear Arun, all > > I've managed to update the audio processing library and > module-echo-cancel with the code from upstream. My working version is > currently synced to webrtc commit 3133857 (Mar 13), as used by Chromium > 67.0.3370.0.