Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-13 Thread Michael Rans
neral PulseAudio Discussion Sent: Tue, 13 July, 2010 21:21:50 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support Adding this in /etc/asound.rc (more exactly /etc/alsa/pulse-default.conf on my Fedora box) work fine: pcm.a52 { @args [CARD] @args.CARD { type s

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-13 Thread Colin Guthrie
'Twas brillig, and pl bossart at 13/07/10 21:21 did gyre and gimble: > Adding this in /etc/asound.rc (more exactly > /etc/alsa/pulse-default.conf on my Fedora box) work fine: > > pcm.a52 { >@args [CARD] >@args.CARD { >type string >} >type rate >slave { >pcm { >

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-13 Thread pl bossart
Adding this in /etc/asound.rc (more exactly /etc/alsa/pulse-default.conf on my Fedora box) work fine: pcm.a52 { @args [CARD] @args.CARD { type string } type rate slave { pcm { type a52 bitrate 448 channels 6 card $CARD

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-13 Thread Colin Guthrie
'Twas brillig, and Michael Rans at 13/07/10 19:53 did gyre and gimble: > # Encode AC3 -> Directly on hardware > # with Rate Converter to 48kHz, needed for some applications > pcm.a52 { > @args [ CARD ] > @args.CARD { > type integer > } > type rate > slave { > pcm

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-13 Thread Michael Rans
Cheers, Mike From: pl bossart To: General PulseAudio Discussion Sent: Mon, 12 July, 2010 23:14:06 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support > This may be an obvious question, but what is the > @args.0 { > type integer > } &g

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread pl bossart
> This may be an obvious question, but what is the > @args.0 { >     type integer >     } > for? > > Is that what you meant by "Adding the argument removes the need to exit the > profile." and if you did, I didn't understand at what point I had to exit > the profile. Can you explain? Sorry if I'm b

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread Michael Rans
ou explain? Sorry if I'm being stupid. Cheers, Mike From: pl bossart To: General PulseAudio Discussion Sent: Mon, 12 July, 2010 22:29:18 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support > Even with this fix, the sink doesn'

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread pl bossart
> Even with this fix, the sink doesn't seem to do anything: Actually discard this comment, it looks like it's crunching data if you specify the rate in asound.conf. # Encode AC3 -> Directly on hardware pcm.Filter_A52Encode { type a52 bitrate 448 channels 6 } # Rate Converter to 48kHz

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread Michael Rans
2010 22:08:44 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support > 2. Replace: pa_sink_set_max_rewind(u->sink, u->hwbuf_size); with: > if(strcmp(u->device_name, "a52") == 0) { > pa_sink_set_max_rewind(u->sink, 0); > } el

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread pl bossart
> 2. Replace: pa_sink_set_max_rewind(u->sink, u->hwbuf_size);      with: >     if(strcmp(u->device_name, "a52") == 0) { >         pa_sink_set_max_rewind(u->sink, 0); >     } else { >         pa_sink_set_max_rewind(u->sink, u->hwbuf_size); >     } NAK. This does not work for me. You need to rewind

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread Tanu Kaskinen
On Mon, 2010-07-12 at 14:57 -0500, pl bossart wrote: > Tanu, can you provide this fix? Couldn't find your patch, no bug #839. > PulseAudio has another routine: pa_alsa_pcm_is_hw, this could also be > used but it would prevent rewinds for iec958 as well... Forgot this from the previous reply: Have

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread Tanu Kaskinen
On Mon, 2010-07-12 at 14:57 -0500, pl bossart wrote: > > Again, when reading the thread further, I found the reason why > > snd_pcm_hw_params_can_rewind doesn't exist - it was replaced by > > snd_pcm_rewindable. Pulseaudio doesn't call that. I added a "patch" (not > > formatted as a proper patch) t

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread pl bossart
> Again, when reading the thread further, I found the reason why > snd_pcm_hw_params_can_rewind doesn't exist - it was replaced by > snd_pcm_rewindable. Pulseaudio doesn't call that. I added a "patch" (not > formatted as a proper patch) to ticket 839 that adds the > snd_pcm_rewindable check to the

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread Michael Rans
d a change between A52 and stereo on a single digital output, then that's fine. Cheers, Mike From: Tanu Kaskinen To: pulseaudio-discuss@mail.0pointer.de Sent: Mon, 12 July, 2010 20:27:28 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough suppor

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-12 Thread Tanu Kaskinen
On Sun, 2010-07-11 at 19:25 +, Michael Rans wrote: > Frankly, I think it would be much better to have A52 in Pulseaudio > with switchable channel maps so that there's one sink. Why is it so important to have only one sink? What's wrong with changing profiles? -- Tanu Kaskinen __

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Michael Rans
Finally I got it all working! These are the steps on Ubuntu Lucid 10.04 LTS: 1. Open from Pulse source code: src/modules/alsa/alsa-sink.c 2. Replace: pa_sink_set_max_rewind(u->sink, u->hwbuf_size); with: if(strcmp(u->device_name, "a52") == 0) { pa_sink_set_max_rewind(u->sink

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Michael Rans
seAudio Discussion Sent: Sun, 11 July, 2010 18:40:36 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support Thanks for this detailed reply. Would I be right in saying that for this to happen, you cannot define your own sinks in default.pa using load-module module-alsa-sink ... but must

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Michael Rans
made to work with the load-module module-alsa-sink ... lines? Cheers, Mike From: Tanu Kaskinen To: pulseaudio-discuss@mail.0pointer.de Sent: Sun, 11 July, 2010 12:23:25 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support On Sun, 2010-07-11

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Michael Rans
, Mike From: Tanu Kaskinen To: pulseaudio-discuss@mail.0pointer.de Sent: Sun, 11 July, 2010 12:23:25 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support On Sun, 2010-07-11 at 09:26 +, Michael Rans wrote: > That's the the problem

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Tanu Kaskinen
On Sun, 2010-07-11 at 09:26 +, Michael Rans wrote: > That's the the problem - as you put it "both sinks (spdif/stereo and > spdif/a52) can't exist at the same time". > > If A52 encoding occurred in Pulseaudio, there would only be one sink, > hence the switch between stereo and A52 would be tra

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Michael Rans
I can tell. From: Tanu Kaskinen To: pulseaudio-discuss@mail.0pointer.de Sent: Sun, 11 July, 2010 7:48:15 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support On Sun, 2010-07-11 at 09:10 +0300, Tanu Kaskinen wrote: > On Sat, 2010-07-10 at 13:24 +, Michael Rans wro

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Michael Rans
the music is playing (with a small interruption). Is the A52 profile in Ubuntu Lucid 10.04LTS? Cheers, Mike From: Tanu Kaskinen To: pulseaudio-discuss@mail.0pointer.de Sent: Sun, 11 July, 2010 10:15:12 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthr

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Tanu Kaskinen
On Sun, 2010-07-11 at 08:43 +, Michael Rans wrote: > At the moment I can switch between A52 and stereo SPDIF but it > requires file editing and restarting Pulseaudio. > > 1. I haven't tried the new profiles yet - does this mean with the > profiles in a GUI, I would be able to switch from A52

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-11 Thread Michael Rans
Sent: Sun, 11 July, 2010 6:47:14 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support On Sat, 2010-07-10 at 15:40 +, Michael Rans wrote: > Regarding AC3 encoding in Pulseaudio - it would be better because at > the moment switching between stereo and A52 is not poss

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Tanu Kaskinen
On Sun, 2010-07-11 at 09:10 +0300, Tanu Kaskinen wrote: > On Sat, 2010-07-10 at 13:24 +, Michael Rans wrote: > > I can't find any definition of snd_pcm_rewind() in the alsa-plugins > > source code. Does this function call through to a function in the > > plugins? > > snd_pcm_rewind() is in als

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Tanu Kaskinen
On Sat, 2010-07-10 at 13:24 +, Michael Rans wrote: > I can't find any definition of snd_pcm_rewind() in the alsa-plugins > source code. Does this function call through to a function in the > plugins? snd_pcm_rewind() is in alsa-lib, not alsa-plugins. I don't know how the plugins do rewinding -

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Tanu Kaskinen
On Sat, 2010-07-10 at 15:40 +, Michael Rans wrote: > Regarding AC3 encoding in Pulseaudio - it would be better because at > the moment switching between stereo and A52 is not possible (ie. I > cannot have both these lines in default.pa: > load-module module-alsa-sink device=Filter_RateConvert r

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Michael Rans
2010 16:12:26 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support > But I still need to go via the rate converter to the a52 encoder in > asoundrc. Have you set the default sink frequency to 48kHz in /usr/etc/pulse/daemon.conf? This should handle resampling in PulseAudio. Still no

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread pl bossart
> But I still need to go via the rate converter to the a52 encoder in > asoundrc. Have you set the default sink frequency to 48kHz in /usr/etc/pulse/daemon.conf? This should handle resampling in PulseAudio. Still not clear why rewind doesn't work. - Pierre _

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Michael Rans
inen To: pulseaudio-discuss@mail.0pointer.de Sent: Sat, 10 July, 2010 11:13:13 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support On Sat, 2010-07-10 at 08:05 +, Michael Rans wrote: > Even with these "hacks", I found that sometimes I see: > > I:

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Michael Rans
r.de Sent: Sat, 10 July, 2010 11:13:13 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support On Sat, 2010-07-10 at 08:05 +, Michael Rans wrote: > Even with these "hacks", I found that sometimes I see: > > I: module.c: Unloading "module-alsa-sink"

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Tanu Kaskinen
On Sat, 2010-07-10 at 08:05 +, Michael Rans wrote: > Even with these "hacks", I found that sometimes I see: > > I: module.c: Unloading "module-alsa-sink" (index: #4). > D: module-always-sink.c: Autoloading null-sink as no other sinks > detected. > > > After I see that, the sink disappears an

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-10 Thread Michael Rans
jack. What would be the pros and cons of doing the AC3 encoding in Pulseaudio instead of in Alsa? Cheers, Mike From: pl bossart To: General PulseAudio Discussion Sent: Fri, 9 July, 2010 18:43:55 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-09 Thread Tanu Kaskinen
On Fri, 2010-07-09 at 10:51 -0500, pl bossart wrote: > > I agree that it's not really a good solution to require the user to > > change the card profile manually to enable passthrough via spdif. But as > > I said, a separate module could take care switching between the profiles > > as needed. > >

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-09 Thread pl bossart
> 1. I was wondering if MP3/DTS/AC3 passthrough is at the discussion point > only or is someone actively looking at developing it? AC3 passthrough works (see patches at start of thread). That said there are still some opens and feedback is still welcome. I guess this will be part of Meego at some

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-09 Thread Michael Rans
s for Pulseaudio as I'm interested in learning where and how it connects to Alsa? Cheers, Mike From: pl bossart To: General PulseAudio Discussion Sent: Fri, 9 July, 2010 16:51:21 Subject: Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support > I ag

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-09 Thread pl bossart
> I agree that it's not really a good solution to require the user to > change the card profile manually to enable passthrough via spdif. But as > I said, a separate module could take care switching between the profiles > as needed. I don't understand your proposal. What do you mean by separate 'm

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-09 Thread Tanu Kaskinen
On Thu, 2010-07-08 at 10:06 -0500, pl bossart wrote: > First this passthrough mode is only valid for S/PDIF and HDMI outputs. > In both cases, the receiver may or may not support encoded content, > and in the SPDIF case you have no way of querying what the receiver > capabilities are. You absolutel

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-08 Thread pl bossart
> In your design the PA_SINK_PASSTHROUGH flag means that the sink can be > used both for exclusive passthrough streams and for normal streams. Are > you sure we can keep that promise for all future passthrough sinks too? > It would be cleaner to have strict separation between passthrough sinks > an

Re: [pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-08 Thread Tanu Kaskinen
On Wed, 2010-07-07 at 19:37 -0500, pl bossart wrote: > here's a first work-in-progress set of patches. I managed to route > iec958 formatted data through PulseAudio, works fine but there's still > a lot to do. Sounds very good! Thanks for your work! > There's some logic to prevent silly connectio

[pulseaudio-discuss] {PATCH][RFC] AC3 passthrough support

2010-07-07 Thread pl bossart
here's a first work-in-progress set of patches. I managed to route iec958 formatted data through PulseAudio, works fine but there's still a lot to do. As discussed on the mailing list, I added a new flag to pa_stream connections, and also added a flag for the sink in case it can handle passthrough