Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Arun Raghavan
On Tue, 2011-03-22 at 16:06 +0100, Maarten Bosmans wrote: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build? By default the CFLAGS contain -g -O2, so __OPTIMIZE__ will not be defined and running uninstalled does not work. Lennart might be

Re: [pulseaudio-discuss] svolume_orc.c: error: line 67: unknown directive: .longparam

2011-03-24 Thread Arun Raghavan
On Mon, 2011-03-21 at 00:06 +0100, Paul Menzel wrote: Dear PulseAudio folks, [...] I guess it has something to do with commit 4cd90d9e32ca9a23e3c0f7615974ea0c55ff3e49 Author: Arun Raghavan arun.ragha...@collabora.co.uk Date: Mon Oct 25 17:59:08 2010 +0100

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 22/03/11 15:06 did gyre and gimble: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build? By default the CFLAGS contain -g -O2, so __OPTIMIZE__ will not be defined and running uninstalled does not work. Do

Re: [pulseaudio-discuss] [WIP] Passthrough support

2011-03-24 Thread Kelly Anderson
Arun, I've been trying to get higher bit rates to passthrough with no luck. Is setting the channel count supported with passthrough (yet)? It seems that 384k sample rates aren't supported directly in alsa, I did some patching to no avail yet. In any case if the channel count can be

Re: [pulseaudio-discuss] More patches for OS X

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Daniel Mack at 22/03/11 12:14 did gyre and gimble: On Mon, Mar 21, 2011 at 12:39 AM, Daniel Mack zon...@gmail.com wrote: On Sun, Mar 20, 2011 at 6:39 PM, Daniel Mack zon...@gmail.com wrote: Hi, I'm catching up with my work on PulseAudio for OS X and have some patches ready

Re: [pulseaudio-discuss] [PATCH 0/2] Rebased bluetooth patches

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 21/03/11 13:08 did gyre and gimble: Colin wrote: Can you rebase these two on git master please? I just merged a whole bunch of changes from BT guys and these both fail now. Sure, refreshed patches coming. Tanu Kaskinen (2): bluetooth: Don't log an

Re: [pulseaudio-discuss] [PATCH 1/2] win32: Simplify dl_search_path code

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 22/03/11 15:02 did gyre and gimble: And add #include sys/stat.h, needed by the code introduced in f7acd4bd. In my tree now. Thanks Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 22/03/11 15:02 did gyre and gimble: To make the code cleaner and have the checks all in one place. In my tree now. Thanks Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/]

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Colin Guthrie at 24/03/11 09:02 did gyre and gimble: 'Twas brillig, and Maarten Bosmans at 22/03/11 15:06 did gyre and gimble: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build? By default the CFLAGS contain -g -O2, so

[pulseaudio-discuss] [PATCH] Log feature: Correct bad function implementation

2011-03-24 Thread Vincent Becker
Replace wrong implementation of log to file in pa_daemon_conf_set_log_level to pa_daemon_conf_set_log_target Signed-off-by: Vincent Becker vincentx.bec...@intel.com --- src/daemon/daemon-conf.c | 40 +++- 1 files changed, 19 insertions(+), 21 deletions(-)

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Maarten Bosmans
2011/3/24 Colin Guthrie gm...@colin.guthr.ie: 'Twas brillig, and Colin Guthrie at 24/03/11 09:02 did gyre and gimble: 'Twas brillig, and Maarten Bosmans at 22/03/11 15:06 did gyre and gimble: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build?

Re: [pulseaudio-discuss] [PATCH] Log feature: Correct bad function implementation

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Vincent Becker at 24/03/11 10:35 did gyre and gimble: Replace wrong implementation of log to file in pa_daemon_conf_set_log_level to pa_daemon_conf_set_log_target Sorry but this is not based on git master (as Maarten asked for before). [colin@jimmy pulseaudio

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Arun Raghavan
On Thu, 2011-03-24 at 11:46 +0100, Maarten Bosmans wrote: [...] I think only compiling that on developer builds and inlining return FALSE for normal, e.g. distro builds makes sense. However __OPTIMIZE__ is not a good differentiator here. The callers all seem to be initialisation routines only,

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Arun Raghavan at 24/03/11 11:04 did gyre and gimble: On Thu, 2011-03-24 at 11:46 +0100, Maarten Bosmans wrote: [...] I think only compiling that on developer builds and inlining return FALSE for normal, e.g. distro builds makes sense. However __OPTIMIZE__ is not a good

[pulseaudio-discuss] [PATCH 1/2] pactl: Accept more volume specification formats

2011-03-24 Thread Maarten Bosmans
With this you can specify the volume with 6554, 10%, 0.001 or -60dB, all resulting in the same volume change. --- src/utils/pactl.c | 98 +--- 1 files changed, 62 insertions(+), 36 deletions(-) diff --git a/src/utils/pactl.c b/src/utils/pactl.c

[pulseaudio-discuss] [PATCH 2/2] pactl: Add subcommands to the list command

2011-03-24 Thread Maarten Bosmans
--- src/utils/pactl.c | 62 +++- 1 files changed, 51 insertions(+), 11 deletions(-) diff --git a/src/utils/pactl.c b/src/utils/pactl.c index 672bfbb..11ddcb3 100644 --- a/src/utils/pactl.c +++ b/src/utils/pactl.c @@ -48,6 +48,7 @@ static

Re: [pulseaudio-discuss] [PATCH 1/2] pactl: Accept more volume specification formats

2011-03-24 Thread Maarten Bosmans
2011/3/24 Maarten Bosmans mkbosm...@gmail.com: With this you can specify the volume with 6554, 10%, 0.001 or -60dB, all resulting in the same volume change. I was also going to add relative volumes, such as +3dB and -5%, by detecting a + or - sign in the volume. But that clashes with the

Re: [pulseaudio-discuss] [PATCH 1/2] pactl: Accept more volume specification formats

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 24/03/11 12:44 did gyre and gimble: 2011/3/24 Maarten Bosmans mkbosm...@gmail.com: With this you can specify the volume with 6554, 10%, 0.001 or -60dB, all resulting in the same volume change. I was also going to add relative volumes, such as +3dB and

[pulseaudio-discuss] [PATCH] loopback: Always use the trivial resampler.

2011-03-24 Thread Tanu Kaskinen
Adjusting the sample rate is done in the IO thread, which can cause interruptions in the audio if the adjustment requires heavy computation. The trivial resampler is guaranteed to be light on the cpu. It would be better to adjust the sample rate in some other thread (FWIW, module-combine uses the

Re: [pulseaudio-discuss] [PATCH] loopback: Always use the trivial resampler.

2011-03-24 Thread pl bossart
On Thu, Mar 24, 2011 at 8:16 AM, Tanu Kaskinen tanu.kaski...@digia.com wrote: Adjusting the sample rate is done in the IO thread, which can cause interruptions in the audio if the adjustment requires heavy computation. The trivial resampler is guaranteed to be light on the cpu. It would be

[pulseaudio-discuss] [PATCH] Log feature: Correct bad function implementation

2011-03-24 Thread Vincent Becker
Replace wrong implementation of log to a file in pa_daemon_conf_set_log_level to pa_daemon_conf_set_log_target Signed-off-by: Vincent Becker vincentx.bec...@intel.com --- src/daemon/daemon-conf.c | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-)

Re: [pulseaudio-discuss] [PATCH] loopback: Always use the trivial resampler.

2011-03-24 Thread Tanu Kaskinen
On Thu, 2011-03-24 at 15:31 +0200, pl bossart wrote: On Thu, Mar 24, 2011 at 8:16 AM, Tanu Kaskinen tanu.kaski...@digia.com wrote: Adjusting the sample rate is done in the IO thread, which can cause interruptions in the audio if the adjustment requires heavy computation. The trivial

Re: [pulseaudio-discuss] [PATCH] Log feature: Correct bad function implementation

2011-03-24 Thread Becker, VincentX
-Original Message- From: Colin Guthrie [mailto:gm...@colin.guthr.ie] Sent: Thursday, March 24, 2011 12:02 PM To: General PulseAudio Discussion Cc: Becker, VincentX Subject: Re: [PATCH] Log feature: Correct bad function implementation 'Twas brillig, and Vincent Becker at 24/03/11 10:35 did

Re: [pulseaudio-discuss] [PATCH] loopback: Always use the trivial resampler.

2011-03-24 Thread pl bossart
The sink may be running in a low-latency mode even if the loopback stream doesn't have any latency requirements - there may be other streams active at the same time with stricter timing requirements. FWIW, the practical case here was a very simple test of looping null sink's monitor to a hw

Re: [pulseaudio-discuss] [WIP] Passthrough support

2011-03-24 Thread pl bossart
It seems that 384k sample rates aren't supported directly in alsa, I did some patching to no avail yet. In any case if the channel count can be specified with passthrough the following should work. paplay --raw --channels=2 --rate=192000 --passthrough File.dts.spdif192khz ( this works).

Re: [pulseaudio-discuss] [RFC PATCH] Log PCM samples to files

2011-03-24 Thread Becker, VincentX
-Original Message- From: Maarten Bosmans [mailto:mkbosm...@gmail.com] Sent: Wednesday, March 23, 2011 7:44 PM To: General PulseAudio Discussion Cc: Becker, VincentX Subject: Re: [pulseaudio-discuss] [RFC PATCH] Log PCM samples to files 2011/3/21 Vincent Becker vincentx.bec...@intel.com:

Re: [pulseaudio-discuss] [PATCH] Log feature: Correct bad function implementation

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Becker, VincentX at 24/03/11 13:51 did gyre and gimble: Sorry but this is not based on git master (as Maarten asked for before). [colin@jimmy pulseaudio (master|AM)]$ cat ~/Download/pa.patch | patch -p1 --dry-run patching file src/daemon/daemon-conf.c Hunk #1 FAILED

Re: [pulseaudio-discuss] [PATCH 1/2] pactl: Accept more volume specification formats

2011-03-24 Thread Arun Raghavan
On Thu, 2011-03-24 at 13:07 +, Colin Guthrie wrote: 'Twas brillig, and Maarten Bosmans at 24/03/11 12:44 did gyre and gimble: 2011/3/24 Maarten Bosmans mkbosm...@gmail.com: With this you can specify the volume with 6554, 10%, 0.001 or -60dB, all resulting in the same volume change.

Re: [pulseaudio-discuss] [PATCH 1/2] pactl: Accept more volume specification formats

2011-03-24 Thread Tanu Kaskinen
On Thu, 2011-03-24 at 22:22 +0530, Arun Raghavan wrote: On Thu, 2011-03-24 at 13:07 +, Colin Guthrie wrote: 'Twas brillig, and Maarten Bosmans at 24/03/11 12:44 did gyre and gimble: 2011/3/24 Maarten Bosmans mkbosm...@gmail.com: With this you can specify the volume with 6554, 10%,

Re: [pulseaudio-discuss] [PATCH] loopback: Always use the trivial resampler.

2011-03-24 Thread Tanu Kaskinen
On Thu, 2011-03-24 at 09:09 -0500, pl bossart wrote: The sink may be running in a low-latency mode even if the loopback stream doesn't have any latency requirements - there may be other streams active at the same time with stricter timing requirements. FWIW, the practical case here was a

Re: [pulseaudio-discuss] [PATCH] loopback: Always use the trivial resampler.

2011-03-24 Thread pl bossart
It might be that you have misunderstood the reason for the patch. Now that I read the patch description again, it indeed isn't entirely clear: the problem that I'm having is that the periodic (every 10 seconds) reinitialization of the resampler takes too much CPU time. The resampling itself

Re: [pulseaudio-discuss] [PATCH 1/2] pactl: Accept more volume specification formats

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 24/03/11 18:31 did gyre and gimble: On Thu, 2011-03-24 at 22:22 +0530, Arun Raghavan wrote: On Thu, 2011-03-24 at 13:07 +, Colin Guthrie wrote: 'Twas brillig, and Maarten Bosmans at 24/03/11 12:44 did gyre and gimble: 2011/3/24 Maarten Bosmans

[pulseaudio-discuss] [PATCH] Several fixes to Pulseaudio's Vala bindings

2011-03-24 Thread Alexander Kurtz
Hi, I have attached a patch with several small fixes to PA's Vala bindings: Let me explain my changes: 1. PA uses Vala's ``Posix'' package (see line 23 of libpulse.vapi). These dependencies have to be declared in the *.deps file. 2. Fix obvious CP error. 3. Rename the parameter to

Re: [pulseaudio-discuss] Current problems with git master

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Colin Guthrie at 28/02/11 20:26 did gyre and gimble: 2. Startup is no longer atomic: With PA not running and autospawn disabled: [colin@jimmy ~]$ start-pulseaudio-x11 Connection failure: Connection refused pa_context_connect() failed: Connection refused PA does

[pulseaudio-discuss] modules/bluetooth/sbc/sbc_primitives.h:41:22: error: expected ':', ',', '; ', '}' or '__attribute__' before 'X'

2011-03-24 Thread Paul Menzel
Dear PulseAudio folks, I get the following error with latest master (a9c8f904). CC libbluetooth_sbc_la-sbc.lo In file included from modules/bluetooth/sbc/sbc_primitives_armv6.h:30:0, from modules/bluetooth/sbc/sbc_math.h:27,

Re: [pulseaudio-discuss] [PATCH] Several fixes to Pulseaudio's Vala bindings

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Alexander Kurtz at 24/03/11 21:06 did gyre and gimble: Hi, I have attached a patch with several small fixes to PA's Vala bindings: Let me explain my changes: 1. PA uses Vala's ``Posix'' package (see line 23 of libpulse.vapi). These dependencies have to be declared

Re: [pulseaudio-discuss] PA Roadmap Planning and LAC Conference

2011-03-24 Thread Kurt Taylor
Hi all, I was wondering what happed with the LAC meetup. Were any plans firmed up to have a pulseaudio working session before/after LAC? Kurt Taylor (irc krtaylor) On 19 February 2011 00:40, Arun Raghavan arun.ragha...@collabora.co.ukwrote: On Fri, 2011-02-18 at 23:00 +0200, Tanu Kaskinen

Re: [pulseaudio-discuss] PA Roadmap Planning and LAC Conference

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Kurt Taylor at 24/03/11 23:21 did gyre and gimble: Hi all, I was wondering what happed with the LAC meetup. Were any plans firmed up to have a pulseaudio working session before/after LAC? Nothing formal arranged as of yet, but I'll be going, open to timing suggestions. Col

Re: [pulseaudio-discuss] modules/bluetooth/sbc/sbc_primitives.h:41:22: error: expected ':', ',', '; ', '}' or '__attribute__' before 'X'

2011-03-24 Thread pl bossart
Well you are lucky to even compile, I get a bad dependency with git master. CCLD libbluetooth-ipc.la make[3]: *** No rule to make target `modules/bluetooth/sbc.c', needed by `libbluetooth_sbc_la-sbc.lo'. Stop. [ume@plb pulseaudio]$ git bisect bad e4eb4670108ad2b4a0d9c3044e12ed0d933f834e is

Re: [pulseaudio-discuss] [WIP] Passthrough support

2011-03-24 Thread Dark Shadow
On Thu, Mar 24, 2011 at 10:50 AM, Anssi Hannula anssi.hann...@iki.fi wrote: On 24.03.2011 16:18, pl bossart wrote: It seems that 384k sample rates aren't supported directly in alsa, I did some patching to no avail yet. In any case if the channel count can be specified with passthrough the

Re: [pulseaudio-discuss] modules/bluetooth/sbc/sbc_primitives.h:41:22: error: expected ':', ',', '; ', '}' or '__attribute__' before 'X'

2011-03-24 Thread Colin Guthrie
'Twas brillig, and pl bossart at 25/03/11 00:08 did gyre and gimble: Well you are lucky to even compile, I get a bad dependency with git master. CCLD libbluetooth-ipc.la http://libbluetooth-ipc.la make[3]: *** No rule to make target `modules/bluetooth/sbc.c', needed by

Re: [pulseaudio-discuss] [WIP] Passthrough support

2011-03-24 Thread Kelly Anderson
On 03/24/11 18:58, Dark Shadow wrote: On Thu, Mar 24, 2011 at 10:50 AM, Anssi Hannulaanssi.hann...@iki.fi wrote: On 24.03.2011 16:18, pl bossart wrote: It seems that 384k sample rates aren't supported directly in alsa, I did some patching to no avail yet. In any case if the channel count can

Re: [pulseaudio-discuss] [WIP] Passthrough support

2011-03-24 Thread Dark Shadow
On Thu, Mar 24, 2011 at 7:19 PM, Kelly Anderson ke...@silka.with-linux.com wrote: On 03/24/11 18:58, Dark Shadow wrote: On Thu, Mar 24, 2011 at 10:50 AM, Anssi Hannulaanssi.hann...@iki.fi  wrote: On 24.03.2011 16:18, pl bossart wrote: It seems that 384k sample rates aren't supported

Re: [pulseaudio-discuss] [WIP] Passthrough support

2011-03-24 Thread Kelly Anderson
On 03/24/11 19:35, Dark Shadow wrote: On Thu, Mar 24, 2011 at 7:19 PM, Kelly Anderson ke...@silka.with-linux.com wrote: On 03/24/11 18:58, Dark Shadow wrote: On Thu, Mar 24, 2011 at 10:50 AM, Anssi Hannulaanssi.hann...@iki.fi wrote: On 24.03.2011 16:18, pl bossart wrote: It seems that

Re: [pulseaudio-discuss] Is this a pulseaudio bug or a vala bug?

2011-03-24 Thread Sean McNamara
Replying to myself: On Fri, Mar 25, 2011 at 1:08 AM, Sean McNamara smc...@gmail.com wrote: Hi, On Thu, Mar 24, 2011 at 10:37 PM, Alexander Kurtz kurtz.a...@googlemail.com wrote: Hi, I have a problem with Pulseaudio (0.9.21) + Vala (0.10.4). I've written this small demonstration program:

Re: [pulseaudio-discuss] Current problems with git master

2011-03-24 Thread Tanu Kaskinen
On Thu, 2011-03-24 at 21:30 +, Colin Guthrie wrote: If someone could double check, I'd appreciate it (seeing as I'd rather any bugs in my commit last less than a year and a half!!) Problems found: The first process: daemon_pipe is not closed if the first fork() call fails. Even if it

Re: [pulseaudio-discuss] modules/bluetooth/sbc/sbc_primitives.h:41:22: error: expected ':', ',', '; ', '}' or '__attribute__' before 'X'

2011-03-24 Thread Arun Raghavan
On Thu, 2011-03-24 at 23:20 +0100, Paul Menzel wrote: Dear PulseAudio folks, I get the following error with latest master (a9c8f904). CC libbluetooth_sbc_la-sbc.lo In file included from modules/bluetooth/sbc/sbc_primitives_armv6.h:30:0,