[pulseaudio-discuss] [PATCH 1/5] module-coreaudio-detect: fix pa__done()

2011-03-20 Thread Daniel Mack
From: Daniel Mack dan...@caiaq.de This would have crashed when unloading the module. --- src/modules/coreaudio/module-coreaudio-detect.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/src/modules/coreaudio/module-coreaudio-detect.c

Re: [pulseaudio-discuss] [PATCH 1/5] module-coreaudio-detect: fix pa__done()

2011-03-20 Thread Tanu Kaskinen
On Sun, 2011-03-20 at 18:39 +0100, Daniel Mack wrote: void pa__done(pa_module *m) { -struct userdata *u; +struct userdata *u = m-userdata; struct ca_device *dev = u-devices; AudioObjectPropertyAddress property_address; -pa_assert(m); -pa_assert_se(u =

Re: [pulseaudio-discuss] [PATCH 1/5] module-coreaudio-detect: fix pa__done()

2011-03-20 Thread Colin Guthrie
'Twas brillig, and Daniel Mack at 20/03/11 17:39 did gyre and gimble: From: Daniel Mack dan...@caiaq.de This would have crashed when unloading the module. --- src/modules/coreaudio/module-coreaudio-detect.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git

Re: [pulseaudio-discuss] [PATCH 1/5] module-coreaudio-detect: fix pa__done()

2011-03-20 Thread Daniel Mack
On Mar 20, 2011 7:15 PM, Colin Guthrie gm...@colin.guthr.ie wrote: 'Twas brillig, and Daniel Mack at 20/03/11 17:39 did gyre and gimble: From: Daniel Mack dan...@caiaq.de This would have crashed when unloading the module. --- src/modules/coreaudio/module-coreaudio-detect.c |5

Re: [pulseaudio-discuss] [PATCH 1/5] module-coreaudio-detect: fix pa__done()

2011-03-20 Thread Colin Guthrie
'Twas brillig, and Daniel Mack at 20/03/11 18:26 did gyre and gimble: Other than that the other patches are all fine. Ok, can you add it back and amend the patch? I think that would be easier than resending :-) Yeah, no worries, editited in my tree. Tanu had a couple comments on patches 3