Jira (FACT-1602) ec2_metadata is incorrectly populated when machine runs on OpenStack with ec2 metadata available
Title: Message Title Brian Cain created an issue Facter / FACT-1602 ec2_metadata is incorrectly populated when machine runs on OpenStack with ec2 metadata available Issue Type: Bug Assignee: Unassigned Created: 2017/04/11 11:07 AM Priority: Normal Reporter: Brian Cain If a node is running on OpenStack and OpenStack configured to report on ec2 meatdata, facter will report on that metadata despite the fact that the node is not running in AWS. Because the ec2_metadata fact is strictly for AWS, facter should not be reporting on this data in OpenStack despite the fact that ec2 metadata exists. https://github.com/puppetlabs/facter/blob/master/lib/src/facts/resolvers/ec2_resolver.cc#L117 OpenStack ec2 metadata docs https://docs.openstack.org/user-guide/cli-config-drive.html Add Comment
Jira (PDB-3431) fact-contents endpoint should handle incorrect group-by params
Title: Message Title
Brian Cain updated an issue
PuppetDB / PDB-3431
fact-contents endpoint should handle incorrect group-by params
Change By:
Brian Cain
The issue:If you query the v4/fact-contents endpoint with an incorrect param for group-by, puppetdb ends up throwing a postgresql exception instead of sending a proper response and handling the exception. A stacktrace and example query:{noformat}2017-04-06 15:23:22,775 WARN [o.e.j.s.HttpChannel] /pdb/query/v4/fact-contents?query=%5B%22extract%22%2C%5B%22value%22%2C%5B%22function%22%2C%22count%22%5D%5D%2C%5B%22or%22%2C%5B%22%3D%22%2C%22path%22%2C%5B%22gce%22%5D%5D%2C%5B%22%3D%22%2C%22path%22%2C%5B%22ec2_metadata%22%5D%5D%5D%2C%5B%22group_by%22%2C%22name%22%5D%5Djavax.servlet.ServletException: org.postgresql.util.PSQLException: ERROR: column "f.value" must appear in the GROUP BY clause or be used in an aggregate function Position: 119at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:130)at org.eclipse.jetty.servlets.gzip.GzipHandler.handle(GzipHandler.java:299)at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:95)at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)at org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:159)at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)at org.eclipse.jetty.server.Server.handle(Server.java:497)at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)at java.lang.Thread.run(Thread.java:745)Caused by: org.postgresql.util.PSQLException: ERROR: column "f.value" must appear in the GROUP BY clause or be used in an aggregate function Position: 119at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2284)at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2003)at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:200)at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:424)at org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:161)at org.postgresql.jdbc.PgPreparedStatement.executeQuery(PgPreparedStatement.java:114)at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeQuery(ProxyPreparedStatement.java:52)at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeQuery(HikariProxyPreparedStatement.java)at puppetlabs.puppetdb.jdbc$call_with_array_converted_query_rows$fn__22205.invoke(jdbc.clj:200)at clojure.java.jdbc$db_transaction_STAR_.invokeStatic(jdbc.clj:662)at clojure.java.jdbc$db_transaction_STAR_.invoke(jdbc.clj:598)at
Jira (PDB-3431) fact-contents endpoint should handle incorrect group-by params
Title: Message Title Brian Cain created an issue PuppetDB / PDB-3431 fact-contents endpoint should handle incorrect group-by params Issue Type: Bug Assignee: Unassigned Created: 2017/04/06 1:23 PM Priority: Normal Reporter: Brian Cain The issue: If you query the v4/fact-contents endpoint with an incorrect param for group-by, puppetdb ends up throwing a postgresql exception instead of sending a proper response and handling the exception. A stacktrace and example query: 2017-04-06 15:23:22,775 WARN [o.e.j.s.HttpChannel] /pdb/query/v4/fact-contents?query=%5B%22extract%22%2C%5B%22value%22%2C%5B%22function%22%2C%22count%22%5D%5D%2C%5B%22or%22%2C%5B%22%3D%22%2C%22path%22%2C%5B%22gce%22%5D%5D%2C%5B%22%3D%22%2C%22path%22%2C%5B%22ec2_metadata%22%5D%5D%5D%2C%5B%22group_by%22%2C%22name%22%5D%5D javax.servlet.ServletException: org.postgresql.util.PSQLException: ERROR: column "f.value" must appear in the GROUP BY clause or be used in an aggregate function Position: 119
Jira (PDB-3037) Find/remove ActiveMQ code no longer being used
Title: Message Title Brian Cain commented on PDB-3037 Re: Find/remove ActiveMQ code no longer being used Karen Van der Veer - Oh yeah, I was wondering about that. I think I can get it done by then! I was hoping to have an initial PR up some time this late afternoon for some back and forth. There will be a bunch of PTO between now and then, but I think that date should be reasonable. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-3037) Find/remove ActiveMQ code no longer being used
Title: Message Title Brian Cain assigned an issue to Brian Cain PuppetDB / PDB-3037 Find/remove ActiveMQ code no longer being used Change By: Brian Cain Assignee: Brian Cain Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-3107) new-command-schema validation prevents PDB/NewRelic integration
Title: Message Title
Brian Cain updated an issue
PuppetDB / PDB-3107
new-command-schema validation prevents PDB/NewRelic integration
Change By:
Brian Cain
This line:https://github.com/puppetlabs/puppetdb/blob/4.1.x/src/puppetlabs/puppetdb/command.clj#L169results in this error: ``` {noformat} 13:25 ```2016-10-13 23:05:30,557 ERROR [o.a.a.ActiveMQMessageConsumer] ID:ip-10-11-47-46.sj.b2c.nike.com-45556-1476399900148-6:1:1:1 Exception while processing messag13:25 e: ID:ip-10-11-47-46.sj.b2c.nike.com-45556-1476399900148-8:1:1:1:413:25 clojure.lang.ExceptionInfo: Input to parse-new-command does not match schema: [(named {:headers {:NewRelicID disallowed-key, :NewRelicTransaction disallowed-13:25 key, :JMSXDeliveryCount disallowed-key}} arg0)]``` ``` {noformat} when PDB is run with the newrelic agent (supplied via java args). Instead of nailing down the exact schema we should just require the appropriate minimal set of keys/headers.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1441) Add "virtualization" fact that identifies AWS, Azure, etc
Title: Message Title Brian Cain commented on FACT-1441 Re: Add "virtualization" fact that identifies AWS, Azure, etc Branan Riley do you know a good solution for this? ^ Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1441) Add "virtualization" fact that identifies AWS, Azure, etc
Title: Message Title Brian Cain commented on FACT-1441 Re: Add "virtualization" fact that identifies AWS, Azure, etc Sweet! That works for me. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1441) Add "virtualization" fact that identifies AWS, Azure, etc
Title: Message Title Brian Cain commented on FACT-1441 Re: Add "virtualization" fact that identifies AWS, Azure, etc How reliable is it for us to build these methods into facter? Will grepping for unknown-245 in var/lib/dhcp/dhclient.eth0.leases always work for us in the future? Or curling for FullConfig in /var/lib/waagent/GoalState.1.xml? None of these seem like solid future proof ways for determining Azure. What happens if those change? From the original ticket FACT-1383, we have an endpoint that we can query but it will only return data if it's about to go under maintenance (otherwise it returns empty). It also claims there's an InstanceInfo endpoint but I haven't seen much documentation on that endpoint or if it exists. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-2866) PuppetDB should always return JSON
Title: Message Title Brian Cain commented on PDB-2866 Re: PuppetDB should always return JSON It looks like PuppetDB does have some middleware class where it handles http requests. This is probably the place to catch top level exceptions like the one above and always return a 500 with the error code included as a json response. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PDB-2866) PuppetDB should always return JSON
Title: Message Title Brian Cain created an issue PuppetDB / PDB-2866 PuppetDB should always return JSON Issue Type: Bug Assignee: Unassigned Created: 2016/07/12 9:44 AM Priority: Normal Reporter: Brian Cain If PuppetDB encounters an exception from a given query, or is given an incorrect query, it does not return json. This makes it difficult for the consumer to figure out what went wrong. With a query that causes an exception: ["=", "deactivated", false] [root@xevuii7pbf15o9l ~]# curl -G https://$(hostname -f):8081/pdb/query/v4/nodes --cacert /etc/puppetlabs/puppet/ssl/certs/ca.pem --cert /etc/puppetlabs/puppet/ssl/certs/xevuii7pbf15o9l.delivery.puppetlabs.net.pem --key /etc/puppetlabs/puppet/ssl/private_keys/xevuii7pbf15o9l.delivery.puppetlabs.net.pem --data-urlencode 'query=["=", "deactivated", false]'
Jira (PUP-5439) Puppet should complain if your Nodes hash has the same key
Title: Message Title Brian Cain commented on PUP-5439 Re: Puppet should complain if your Nodes hash has the same key Henrik Lindberg - I agree, I think that sort of error message would be more helpful. That should give a user some idea that they have duplicate entries. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5439) Puppet should complain if your Nodes hash has the same key
Title: Message Title
Brian Cain created an issue
Puppet / PUP-5439
Puppet should complain if your Nodes hash has the same key
Issue Type:
Bug
Assignee:
Unassigned
Created:
2015/10/27 3:32 PM
Priority:
Normal
Reporter:
Brian Cain
For example, if you have an application instance declaration:
site {
lamp { 'example':
db_user => 'pixar',
db_password => 'password',
web_count => 3,
Jira (PUP-5439) Puppet should complain if your Nodes hash has the same key
Title: Message Title Brian Cain commented on PUP-5439 Re: Puppet should complain if your Nodes hash has the same key Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::
Title: Message Title Brian Cain commented on PUP-659 Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: Reverted in https://github.com/puppetlabs/puppet/commit/db0cfa48a477d5f6a54847b565912dc5561852f1 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::
Title: Message Title Brian Cain assigned an issue to Brian Cain Puppet / PUP-659 Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: Change By: Brian Cain Assignee: BrianCain Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::
Title: Message Title Brian Cain commented on PUP-659 Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: Merged to master at 87fad92f18966ea62544df16d251885794c5ec92 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3718) defined function does not handle qualified variable names correctly
Title: Message Title Brian Cain assigned an issue to Brian Cain Puppet / PUP-3718 defined function does not handle qualified variable names correctly Change By: Brian Cain Assignee: BrianCain Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2904) Make string/symbol use consistent in new function API
Title: Message Title Brian Cain assigned an issue to Brian Cain Puppet / PUP-2904 Make string/symbol use consistent in new function API Change By: Brian Cain Assignee: BrianCain Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3718) defined function does not handle qualified variable names correctly
Title: Message Title Brian Cain updated an issue Puppet / PUP-3718 defined function does not handle qualified variable names correctly Change By: Brian Cain Assignee: BrianCain Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3567) Remove current_environment check in Puppet::Indirector::Request#environment=
Title: Message Title Brian Cain assigned an issue to Brian Cain Puppet / PUP-3567 Remove current_environment check in Puppet::Indirector::Request#environment= Change By: Brian Cain Assignee: BrianCain Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3164) Fix beaker smoke tests to properly use new rake api in console
Title: Message Title Brian Cain created an issue Puppet / PUP-3164 Fix beaker smoke tests to properly use new rake api in console Issue Type: Bug Assignee: Unassigned Created: 29/Aug/14 2:53 PM Fix Versions: 3.4.0 Priority: Normal Reporter: Brian Cain Due to the console rake tasks now using the NC service, beaker needs to change so that it properly uses the new rake tasks. There are several places where it uses removed rake tasks that will no longer work once the update happens. These either need to be removed or changed to fit with the new change. Changes will likely be made in pe-beaker. Add Comment
