from:"Frank \(JIRA\)"

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank assigned an issue to Felix Frank 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-1043 
 
 
 
  Specifying file content by checksum should not use 'content' property  
 
 
 
 
 
 
 
 
 

Change By:
 
 Felix Frank 
 
 
 

Assignee:
 
 FelixFrank 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3341) Puppet apply breaks when an ENC returns an environment

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank commented on  PUP-3341 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Puppet apply breaks when an ENC returns an environment  
 
 
 
 
 
 
 
 
 
 
Josh Cooper mentioned that there seems to be development towards softening the premacy of the ENC wrt. the choice of environments on the master, if the user wants it. 
I'm not certain how this relates to ENTERPRISE-151. 
This might mean that this issue will have to be revisited under this shifting premise. 
I shall go forward with implementing the current behavior. Once the master behavior is adapted, the apply code can follow suit once more. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (FACT-634) Facter emits Already evaluated... warnings

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank assigned an issue to Felix Frank 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Facter /  FACT-634 
 
 
 
  Facter emits Already evaluated... warnings  
 
 
 
 
 
 
 
 
 

Change By:
 
 Felix Frank 
 
 
 

Assignee:
 
 FelixFrank 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (FACT-634) Facter emits Already evaluated... warnings

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank commented on  FACT-634 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Facter emits Already evaluated... warnings  
 
 
 
 
 
 
 
 
 
 
Re-opening. I constantly reproduce with facter 2.1, 2.2 and 2.3 on a Debian box with Ruby 1.9.3 (but also saw this with 2.3 and Ruby 2.1). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (FACT-634) Facter emits Already evaluated... warnings

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank commented on  FACT-634 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Facter emits Already evaluated... warnings  
 
 
 
 
 
 
 
 
 
 
Well, what do you know - it is caused by multiple facter versions in Ruby's lookup path. 
For example, installing the facter package in the operating system will make bundler load facts from both /usr/lib/ruby/vendor_ruby as well as the local source. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3667) The ini_file_spec unit tests need improving

2014-11-12 Thread Felix Frank (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank created an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-3667 
 
 
 
  The ini_file_spec unit tests need improving  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Improvement 
 
 
 

Affects Versions:
 

 PUP 3.7.3 
 
 
 

Assignee:
 
 Felix Frank 
 
 
 

Components:
 

 Community 
 
 
 

Created:
 

 2014/11/12 1:38 PM 
 
 
 

Fix Versions:
 

 PUP 4.x 
 
 
 

Labels:
 

 tests 
 
 
 

Priority:
 
  Minor 
 
 
 

Reporter:
 
 Felix Frank 
 
 
 
 
 
 
 
 
 
 
The unit tests for the inifile support does not seem to use fixtures to their capabilities. Warrants a look at how the tests can be improved through actual I/O and operation.

Jira (PUP-3547) File Server Mounts Should Support Directory Environments

Title: Message Title

Felix Frank commented on PUP-3547

Re: File Server Mounts Should Support Directory Environments

As far as I know, the ENC will only take effect during the catalog request phase. The master will receive the node data (including environment from the ENC). The ENC is not queried for each and every file retrieval.
The environment from the ENC is communicated to the agent as part of the catalog. There is nothing that can stop a rogue agent from ignoring this value.
As it stands, you can solve this security issue by carefully maintaining an auth.conf file that has arbitrarily fine grained whitelists that selectively allows agent to access certain fileserver locations. This will be necessary regardless of whether the fileserver supports mounts that are dynamic based on the agent's environment.
As such, and I'm sorry to say, this feature (although quite convenient) does not seem to add much value, as far as I can tell.

Add Comment

This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e)

--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3547) File Server Mounts Should Support Directory Environments

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank commented on  PUP-3547 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: File Server Mounts Should Support Directory Environments  
 
 
 
 
 
 
 
 
 
 
From today's PR discussion: Yes, doing this in a secure fashion would require quite a bit of more work in a lot of places. It would also be better suited for adding in puppetserver, because the puppet master based fileserver will be obsolete in the future. 
Patches for making fileserving more secure would be welcome indeed. As for enhanced capabilities for auth.conf, I suppose that suggestions, designs and discussion (say on puppet-dev) would be most welcome, yes. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3564) pkg provider latest gives empty warnings

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-3564 
 
 
 
  pkg provider latest gives empty warnings  
 
 
 
 
 
 
 
 
 

Change By:
 
 Felix Frank 
 
 
 

Labels:
 
 community 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3564) pkg provider latest gives empty warnings

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-3564 
 
 
 
  pkg provider latest gives empty warnings  
 
 
 
 
 
 
 
 
 

Change By:
 
 Felix Frank 
 
 
 

Component/s:
 
 Community 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3564) pkg provider latest gives empty warnings

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-3564 
 
 
 
  pkg provider latest gives empty warnings  
 
 
 
 
 
 
 
 
 

Change By:
 
 Felix Frank 
 
 
 

Assignee:
 
 JoshCooper 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3547) File Server Mounts Should Support Directory Environments

2014-11-04 Thread Felix Frank (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Felix Frank commented on  PUP-3547 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: File Server Mounts Should Support Directory Environments  
 
 
 
 
 
 
 
 
 
 
Much clearer, thanks for the write-up! 
I can't claim to have understood how the combinatorial explosion happens, but I'll just go ahead and trust you on that one. 
If I understand you correctly, this is mainly supposed to enhance security between environments. It's not really more convenient than using $environment in the fileserver URLs, yes? 
Are you certain that this is better security? Can the environment in a file request not be forged just in the way that the URL can be manipulated? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3547) File Server Mounts Should Support Directory Environments

2014-10-29 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: File Server Mounts Should Support Directory Environments 










This doesn't look unreasonable to me, but then it seems that there should be a workaround for this already possible, no?
Could r10k not manage some kind of pseudo-module to (sym)link to your actual files? Anything in that vein?












   

 Add Comment

























 Puppet /  PUP-3547



  File Server Mounts Should Support Directory Environments 







 *tl;dr*: I'd like to be able to serve files from the file server and interpolate the agent's environment into the mount path.   I use r10k to deploy directory environments for a Puppet Master that manages a small, but growing set of VMware VMs on ESXi. I have a set of files that are supplied by an upstream vendor that do not fit the typical build a modu...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to

Jira (PUP-3547) File Server Mounts Should Support Directory Environments

2014-10-29 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank updated an issue


















 Puppet /  PUP-3547



  File Server Mounts Should Support Directory Environments 










Change By:

 Felix Frank




Assignee:

 JoshuaM.Keyes












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

2014-10-13 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Unexpected error with multiple SSH keys without comments 










Changed the naming algorithm to ignore the key data and just rely on path and a unique counter per file. Each unnamed key gets a unique name.
Gert van Dijk have you had a chance to reproduce any other failures? We're nearing the 3.7.2, which might be the last 3.7 release. If so, further fixes will not be released until Puppet 4.0. Last call 












   

 Add Comment

























 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 







 Steps to reproduce:   # Enter multple SSH authorized keys for a user without comments (just a key line by line, see example below).  # Manage the user with Puppet with the {{purge_ssh_keys}} parameter set to true.  # Have Puppet agent 3.7.0+  # Puppet agent run fails completely with an error. (full denial of service of the agent effectively)   Expected ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it,

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

2014-10-08 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Unexpected error with multiple SSH keys without comments 










Thanks for the confirm!
Clobbering the whole keys file is not an option. That would get rid of comments and whitespaces, which a user does not expect. (Yay, more regressions.)
Reports for any issues that you find will indeed be extremely helpful. Thanks in advance!
You can group problems that appear similar in one shared ticket, but yes, generally it will help us if issues are separated into distinct tickets (do make them relate to this one).












   

 Add Comment

























 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 







 Steps to reproduce:   # Enter multple SSH authorized keys for a user without comments (just a key line by line, see example below).  # Manage the user with Puppet with the {{purge_ssh_keys}} parameter set to true.  # Have Puppet agent 3.7.0+  # Puppet agent run fails completely with an error. (full denial of service of the agent effectively)   Expected ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

2014-10-06 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Unexpected error with multiple SSH keys without comments 










Gert van Dijk can you run from source? Could you try the patch from GH-3164? You'd need to patch your agent, the master is of no consequence.
There is still room for collisions. If you hit that off the spot, then I need to think of something more clever.












   

 Add Comment

























 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 







 Steps to reproduce:   # Enter multple SSH authorized keys for a user without comments (just a key line by line, see example below).  # Manage the user with Puppet with the {{purge_ssh_keys}} parameter set to true.  # Have Puppet agent 3.7.0+  # Puppet agent run fails completely with an error. (full denial of service of the agent effectively)   Expected ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

2014-10-05 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Unexpected error with multiple SSH keys without comments 










This will be ugly, but I think I can replicate the workaround that I added to cron back in the day.


generate a unique name for each unnamed line that the provider reads


mark such lines as unnamed on disk


when writing records back to disk, remove the generated names


What's especially unfortunate - the user provider will have to predict the generated names and generate according resources.
Doable but convoluted. I'll make sure to leave enough comments for future generations to be able to dissect the crimes we're committing here.












   

 Add Comment

























 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 







 Steps to reproduce:   # Enter multple SSH authorized keys for a user without comments (just a key line by line, see example below).  # Manage the user with Puppet with the {{purge_ssh_keys}} parameter set to true.  # Have Puppet agent 3.7.0+  # Puppet agent run fails completely with an error. (full denial of service of the agent effectively)   Expected ...

Jira (PUP-1077) Move Nagios types and supporting from core to a module

2014-10-02 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Move Nagios types and supporting from core to a module 










+1 to Eric Sorenson this was exactly my thought.
Technically, it might incur a penalty at launch time of each Puppet process, but this ought to be negligible next to the actual work that those processes have to perform (think agent, apply, master).












   

 Add Comment

























 Puppet /  PUP-1077



  Move Nagios types and supporting from core to a module 







 As description says.















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

2014-10-01 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank updated an issue


















 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 










Change By:

 Felix Frank




Fix Version/s:

 3.7.2












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3266) Puppet does not recompile catalog after failure

2014-10-01 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Puppet does not recompile catalog after failure 










Thomas Rasmussen this can also occur if you still rely on import statements. Do you?












   

 Add Comment

























 Puppet /  PUP-3266



  Puppet does not recompile catalog after failure 







 I have a setup which works, puppet master compiles catalog and client applies this.   Then I make a typo in an included class for my node. Rerun puppet agent on client, it will (sometimes) create an error like this:   Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class Some.class.name for node.name   If I t...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3341) Puppet apply breaks when an ENC returns an environment

2014-10-01 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank updated an issue


















 Puppet /  PUP-3341



  Puppet apply breaks when an ENC returns an environment 










Change By:

 Felix Frank




Fix Version/s:

 3.7.2












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Unexpected error with multiple SSH keys without comments 










Yes, using the key is not feasible. It is not uncommon to authorize the same key for different accounts, and Puppet requires unique IDs for all keys.
Charlie Sharpsteen basically has the right of it, but I'm not sure that we can get this to work. Puppet must have a way to target those unmanaged resource for purging, so we would likely need to make Puppet annotate the unnamed keys on disk.
This seems pretty invasive to me, because it might also affect users who don't use purging. (If we can limit this behavior to purging runs, this would be all right, I believe, because all annotated keys will be subject to purging. noop mode would be an unfortunate gray area.)












   

 Add Comment

























 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 







 Steps to reproduce:   # Enter multple SSH authorized keys for a user without comments (just a key line by line, see example below).  # Manage the user with Puppet with the {{purge_ssh_keys}} parameter set to true.  # Have Puppet agent 3.7.0+  # Puppet agent run fails completely with an error. (full denial of service of the agent effectively)   Expected ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Unexpected error with multiple SSH keys without comments 










The crux is that the generated resources must be suitable for the ssh_authorized_keys provider to purge the file entries.
We cannot just make up an identification scheme without breaking all manifests out there, because those name the keys by comment.












   

 Add Comment

























 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 







 Steps to reproduce:   # Enter multple SSH authorized keys for a user without comments (just a key line by line, see example below).  # Manage the user with Puppet with the {{purge_ssh_keys}} parameter set to true.  # Have Puppet agent 3.7.0+  # Puppet agent run fails completely with an error. (full denial of service of the agent effectively)   Expected ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email

Jira (PUP-3357) Unexpected error with multiple SSH keys without comments

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Unexpected error with multiple SSH keys without comments 










Thanks for the input Gert van Dijk. The issue is indeed with the internals of the type system. In a nutshell, system entities (such as lines in authorized_keys files) have to be represented internally in the same fashion that a resource declaration from a manifest does. It must all be consistent.
In theory, we might possibly even get away with replacing the namevar for ssh_authorized_key with a composite value as you suggest (without breaking too many manifests, but still more than we can really get away with), but alas the support for such composites is not quite functional (or so I hear).












   

 Add Comment

























 Puppet /  PUP-3357



  Unexpected error with multiple SSH keys without comments 







 Steps to reproduce:   # Enter multple SSH authorized keys for a user without comments (just a key line by line, see example below).  # Manage the user with Puppet with the {{purge_ssh_keys}} parameter set to true.  # Have Puppet agent 3.7.0+  # Puppet agent run fails completely with an error. (full denial of service of the agent effectively)   Expected ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)

Jira (PUP-1755) Inconsistent hash order with Ruby 1.8

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Inconsistent hash order with Ruby 1.8 










I still believe that this warrants a ticket against the puppetdb module. If the templates therein expect hash arguments to be ordered, that is unclean implementation.












   

 Add Comment

























 Puppet /  PUP-1755



  Inconsistent hash order with Ruby 1.8 







 Hash table ordering in Puppet 3.x with Ruby 1.8 is inconsistent. It is known that Ruby 1.8 does not guarantee that hash tables are ordered by insertion order, like 1.9 does. However, whatever ordering Ruby 1.8 uses for a given hash table, it stays consistent, and is always the same whenever you iterate through it.   This is not true in Puppet 3.x used wi...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-2846) multiple providers are executed for the same resource

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: multiple providers are executed for the same resource 










I cannot reproduced with 3.6.1.
Since I don't have aws installed, I replaced its command with /bin/echo in your provider.
This is my output (running as non-root for simplicity).






$ puppet apply ./pup-2846.pp 




Could not retrieve fact='virtual', resolution='anonymous': Permission denied @ rb_sysopen - /sys/firmware/dmi/entries/1-0/raw




Notice: Compiled catalog for geras.fritz.box in environment production in 0.21 seconds




Error: Execution of '/sbin/iptables -I POSTROUTING 1 -t nat -s 10.1.2.0/24 -o eth0 -p all -m comment --comment 100 snat for network foo2 -j MASQUERADE' returned 3: iptables v1.4.21: can't initialize iptables table `nat': Permission denied (you must be root)




Perhaps iptables or your kernel needs to be upgraded.




Error: /Stage[main]/Main/Firewall[100 snat for network foo2]/ensure: change from absent to present failed: Execution of '/sbin/iptables -I POSTROUTING 1 -t nat -s 10.1.2.0/24 -o eth0 -p all -m comment --comment 100 snat for network foo2 -j MASQUERADE' returned 3: iptables v1.4.21: can't initialize iptables table `nat': Permission denied (you must be root)




Perhaps iptables or your kernel needs to be upgraded.




[aws_securitygroup] Exists 000 accept all icmp requests

Jira (PUP-2846) multiple providers are executed for the same resource

Title: Message Title










 

 Felix Frank updated an issue


















 Puppet /  PUP-2846



  multiple providers are executed for the same resource 










Change By:

 Felix Frank




Assignee:

 FelixFrank cristifalcas












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-2718) Prefetching is prone to fail for eval_generated resources

Title: Message Title










 

 Felix Frank updated an issue


















 Puppet /  PUP-2718



  Prefetching is prone to fail for eval_generated resources 










Change By:

 Felix Frank









 Whenthe{{User}}typeimplementedpurgingof{{ssh_authorized_keys}}usingthe{{eval_generate}}hook,itbecameapparentthatthefollowingmanifest{code}package{'coreutils':before=User[root]}  user{'root':purge_ssh_keys='/tmp/keyfile'}{code}wouldnotpurgeanykeysfrom{{/tmp/keyfile}}.Thereasonisthatprefetchingofthekeysfailsinthefollowingfashion:#When{{Transaction#evaluate}}startstraversingthegraph,no{{ssh_authorized_key}}resourcesareyetpartofthegraph#eachresourcehasa{{pre_process}}hookthatinvokes{{#prefetch_if_necessary}}#thishappensforthe{{package}}resourcefirst,and{{prefetch_if_necessary}}invokes{{resources_by_provider}},whichcachesahashofallresourcesinthegraph#duringitsevaluation,the{{user}}resourcegenerates{{ssh_authorized_key}}resourcesforpurging#thesekeysalsoinvoke{{prefetch_if_necesary}},buttheresultfrom{{resources_by_provider}}iscachedandlackstheirreferences#noresourcesarepassedtotheprovider's{{prefetch}}method,theproviderconsiderstheentitiestobeunmanagedandtheresourcesarefalselydeterminedtobealreadyabsentAworkaroundmaycompriseawaytoinvalidatethecacheofthe{{Transaction#resources_by_provider}}methodupon{{eval_generate}}-ingresources.Thisneedsadecision,though.












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at

Jira (PUP-1366) yum provider doesn't respect items provided by a package, only the package name

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: yum provider doesn't respect items provided by a package, only the package name 










Hi Sam Kottler, any update on this?












   

 Add Comment

























 Puppet /  PUP-1366



  yum provider doesn't respect items provided by a package, only the package name 







 A simple use case:   In EL5 and earlier, the curl development headers were included in a package called curl-devel. In EL6 and later that package was renamed to libcurl-devel. However, the libcurl-devel package still provides curl-devel.   When using something like   package { curl-devel:  ensure = installed  }   puppet looks for...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-1222) If ensure changes, then no other changes are reported for that resource.

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: If ensure changes, then no other changes are reported for that resource. 










Hi Dan Bode, any update on this?












   

 Add Comment

























 Puppet /  PUP-1222



  If ensure changes, then no other changes are reported for that resource. 







 code:  {code}  service { 'httpd':  ensure = running,  enable = true,  }  {code}   even though chkconfig is set to off in both cases, its only logged when the process isn't started.   {code}  # /sbin/service httpd stop  Stopping httpd: [ OK ]  [root@dannyboy manifests]# chkconfig httpd off  [root@dannybo...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-1221) Mixed invocation of parameterized classes leads to order dependencies, should be disallowed

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: Mixed invocation of parameterized classes leads to order dependencies, should be disallowed 










So Henrik Lindberg, I assume this is not on the plate for 4.0, yes?












   

 Add Comment

























 Puppet /  PUP-1221



  Mixed invocation of parameterized classes leads to order dependencies, should be disallowed 







 When a parameterized class has default values for all of its parameters, it may be invoked using either include or class \{ ... \} notation. The include notation is idempotent; the class \{ ... \} notation isn't. As a result, there is an order dependency. This works:   {code}  class foo($param = defaultvalue) {  notify { $param: }  }   class {...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-1221) Mixed invocation of parameterized classes leads to order dependencies, should be disallowed

Title: Message Title










 

 Felix Frank updated an issue


















 Puppet /  PUP-1221



  Mixed invocation of parameterized classes leads to order dependencies, should be disallowed 










Change By:

 Felix Frank




Affects Version/s:

 2.7.23












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-1072) support HTTP(S) URL as the file 'source'

Title: Message Title










 

 Felix Frank updated an issue


















 Puppet /  PUP-1072



  support HTTP(S) URL as the file 'source' 










Change By:

 Felix Frank









 Lotsandlotsoffolkswanttobeabletodothis: {code} file{  /tmp/example.txt:  source='http://example.com/example.txt'  } {code}   Thiswouldbegoodtosupport;obviouslythemetadatafortheHTTPURIismuchlessavailablethanviapuppetfileserving,butthiswouldmakealotofpeoplevery,veryhappy.












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-1072) support HTTP(S) URL as the file 'source'

Title: Message Title










 

 Felix Frank assigned an issue to Felix Frank


















 Puppet /  PUP-1072



  support HTTP(S) URL as the file 'source' 










Change By:

 Felix Frank




Assignee:

 FelixFrank












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3341) Puppet apply breaks when an ENC returns an environment

2014-09-24 Thread Felix Frank (JIRA)

Title: Message Title










 

 Felix Frank created an issue


















 Puppet /  PUP-3341



  Puppet apply breaks when an ENC returns an environment 










Issue Type:

  Bug




Affects Versions:


 3.7.0




Assignee:

 Felix Frank




Created:


 24/Sep/14 4:51 PM




Labels:


 commandline




Priority:

  Normal




Reporter:

 Felix Frank










Given the following ENC script (/tmp/enc)






#!/bin/sh




echo 'classes: []'




echo 'environment: production'

Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file

Title: Message Title










 

 Felix Frank assigned an issue to Felix Frank


















 Puppet /  PUP-3258



  puppet apply + ENC + 3.7.x: does not read the .pp file 










Change By:

 Felix Frank




Assignee:

 FelixFrank












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: puppet apply + ENC + 3.7.x: does not read the .pp file 










I can reproduce with 3.7.0 and the following.



# /tmp/site.pp
notify { '/tmp/site.pp is in use': }

class foo { notify { 'class foo is included': } }






# ~/.puppet/manifests/site.pp
notify { '~/.puppet/manifests/site.pp is in use': }






#!/bin/sh
# /tmp/enc
cat EOF
classes:
- foo
EOF



This invocation should notify about /tmp/site.pp being in use, but does not.


$ bundle exec puppet apply /tmp/site.pp --node_terminus exec --external_nodes /tmp/enc 
...
Notice: ~/.puppet/manifests/site.pp is in use



With 3.6.1, it works as expected.


$ bundle exec puppet apply /tmp/site.pp --node_terminus exec --external_nodes /tmp/enc
...
Notice: /tmp/site.pp is in use



With 3.7.0, it *does* work fine if a plain ENC is used.


$ /tmp/enc /tmp/nodes.yaml
$ bundle exec puppet apply /tmp/site.pp --external_nodes /tmp/nodes.yaml 
...
Notice: /tmp/site.pp is in use



Current master 868bf83 is still affected. 
Apparently the ENC support broke in some exciting way. I shall bisect between 3.6.1 and 3.7.0, let's see when this happened.












   

 Add Comment

Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: puppet apply + ENC + 3.7.x: does not read the .pp file 










The suspect is


commit 53d391b37f0a5f8f5937fcd7584fb6aae6db424b

(PUP-2519) Create fallback environment only for default production



Looks plausible, digging further.












   

 Add Comment

























 Puppet /  PUP-3258



  puppet apply + ENC + 3.7.x: does not read the .pp file 







 Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1).   See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; ma...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To

Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file

Title: Message Title










 

 Felix Frank commented on an issue


















  Re: puppet apply + ENC + 3.7.x: does not read the .pp file 










More to the point, this patch introduces the breakage:



diff --git a/lib/puppet/application/apply.rb b/lib/puppet/application/apply.rb
index 22f2955..bd854e7 100644
--- a/lib/puppet/application/apply.rb
+++ b/lib/puppet/application/apply.rb
@@ -187,7 +187,7 @@ Copyright (c) 2011 Puppet Labs, LLC Licensed under the Apache 2.0 License
   configured_environment.override_with(:manifest = manifest) :
   configured_environment
 
-Puppet.override(:environments = Puppet::Environments::Static.new(apply_environment)) do
+Puppet.override(:current_environment = apply_environment) do
   # Find our Node
   unless node = Puppet::Node.indirection.find(Puppet[:node_name_value])
 raise Could not find node #{Puppet[:node_name_value]}



Note that the apply_environment is a simple stub that overrides the manifest setting with what was given on the commandline (apparently). Not wrapping this in a static environment does not seem to be adequate any longer - perhaps the manifest search path must be overridden as well (or something along those lines).












   

 Add Comment

























 Puppet /  PUP-3258



  puppet apply + ENC + 3.7.x: does not read the .pp file 







 Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1).   See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; ma...

Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file