Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts
Title: Message Title Isaiah Frantz commented on FACT-2918 Re: FACTER_ environmental facts overrides don't work with external facts Im curious how these test could be passing considering the actual behavior: https://github.com/puppetlabs/facter/blob/main/acceptance/tests/external_facts/env_var_overrides_external_fact.rb Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.128160.1611882180033%40Atlassian.JIRA.
Jira (PUP-6723) collector_transformer: add support for 'in' operator to facilitate 'not in'
Title: Message Title Isaiah Frantz commented on PUP-6723 Re: collector_transformer: add support for 'in' operator to facilitate 'not in' Any plans on getting this into puppet5? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6723) collector_transformer: negation query for array type properties is broken
Title: Message Title Isaiah Frantz commented on PUP-6723 Re: collector_transformer: negation query for array type properties is broken ehh, I just reread the docs and it does say that != only matches if the value of the attribute is identical to the term and that if the value of the attribute is an array it will always match Bring on the in! Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6723) collector_transformer: negation query for array type properties is broken
Title: Message Title Isaiah Frantz commented on PUP-6723 Re: collector_transformer: negation query for array type properties is broken Changing it to "in" would make the functionality more obvious and would keep from breaking old code. I think that it would be wise to, with your suggestion and mine, fail if an array type is being used in a collector using != since it is not obvious that this shouldn't work in the opposite way that the == case does. Also, the docs dont mention anything about the current behaviour. They only say that you cant use an array as the search term, nothing about an array type property in a negation. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6723) collector_transformer: negation query for array type properties is broken
Title: Message Title
Isaiah Frantz commented on PUP-6723
Re: collector_transformer: negation query for array type properties is broken
I would argue that the way negation works currently breaks the basic logic of the search query. The two existing tests, one for tag properties and one for a mix of arrays bends my mind a little.
In this case, I would expect to match the objects that dont contain the search term. In the case of == we use compare_operator.include? if the property is an array so that we can include objects that contain the term. It only makes sense to do the opposite with logical negation, i.e. exclude the entire object when it contains the term. Perhaps the cleaner way to code this section would be to always run the == case, then if the actual operator is !=, return the negation of the == case The fact that you get back objects that contain the term you dont want doesnt compute
it "does not exclude resources with unequal arrays" do
expect_the_message_to_be(["message", ["not this message", "or this one"]], <<-MANIFEST)
@notify { "testing": message => "message" }
@notify { "the wrong one": message => ["not this message", "or this one"] }
Notify <| message != "not this message" |>
MANIFEST
end
This
Jira (PUP-6723) collector_transformer: negation query for array type properties is broken
Title: Message Title Isaiah Frantz commented on PUP-6723 Re: collector_transformer: negation query for array type properties is broken further details in pull request: https://github.com/puppetlabs/puppet/pull/5290 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6723) collector_transformer: negation query for array type properties is broken
Title: Message Title Isaiah Frantz created an issue Puppet / PUP-6723 collector_transformer: negation query for array type properties is broken Issue Type: Bug Affects Versions: PUP 4.6.2, PUP 4.2.2 Assignee: Unassigned Created: 2016/09/21 6:53 PM Fix Versions: PUP 4.6.2 Priority: Normal Reporter: Isaiah Frantz Only the == case of the query_ComparisonExpression method checks if the property type is array which then uses the compare_operator.include? method. The != case doesn't check and only uses the compare_operator.equals. This causes any Resource<| tag != 'thing' |> to improperly match. Add Comment
