Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Jean Bond Noone really uses `SublocatedExpression` on their own, it only appeared in AST, and the only time someone would see it would someone having logic that walks the AST tree (some kind of tool/utility). If such a tool is written the right way, it won't notice. But there is a small chance that this may break someone. I think it is wise to include a deprecation and say: "The `SublocatedExpression` will no longer appear in AST produced by the parser." Ping Corey Osman - FYI. Don't know if this affects your code. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Jean Bond commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Henrik Lindberg, should this `SublocatedExpression` thing be listed as a deprecation in Puppet, as well? Thanks! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Finally merged to master. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error So, what happens now - who does what to get the fix back in? Ping Josh Cooper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error This is not going to make the cut for 6.2.0, bumping to 6.3.0. Change By: Kenn Hussey Fix Version/s: PUP 6.2.0 Fix Version/s: PUP 6.3.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Casey Williams updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Casey Williams Fix Version/s: PUP 5.5.11 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Branan Riley commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error This missed the boat for 6.0.5 - it wasn't in the CI run that kicked off EOD Wednesday, which is what we base our "stop ship" line off of. I've updated the fixversion. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Branan Riley updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Branan Riley Fix Version/s: PUP 6.0.5 Fix Version/s: PUP 6.0.6 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Jean Bond I believe it make the cut for 6.0.5... /cc Branan Riley Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Jean Bond commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Kenn Hussey Just to verify, this missed the cut for 5.5.9, but is in 6.0.5? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Fix Version/s: PUP 5.5.10 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Henrik Lindberg Release Notes Summary: Heredoc expressions with interpolation using an access _expression_ like `$facts['somefact']` could fail with a syntax error depending on the position of the heredoc relative location in the source file relative to any of the heredoc and surrounding whitespace (anywhere) in the source file. This was caused by a faulty calculation of location of interpolated expressions which also showed up as the wrong line/position in error messages related to the interpolated expressions.The handling of the position of so called "sublocated expressions" is now rewritten and the problem with seemingly random "syntax error" from the use of `[]` _expression_ in interpolation is gone.Advanced: Anyone having written tools that walk the AST tree should note that the `SublocatedExpression` will no longer be generated by the parser as all nodes under that node are now immediately updated with their correct offset and length. Although the `SublocatedExpression` class itself will not be removed until Puppet 7.0.0, it will no longer appear in AST produced by the parser. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Fix Version/s: PUP 5.5.9 Fix Version/s: PUP 5.5.10 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Kenn Hussey Fix Version/s: PUP 6.1.1 Fix Version/s: PUP 6.2.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg commented on PUP-9303 Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error We ran into issues with applying the fix in time for Puppet 6.1.0 as it was discovered that the fix was not bug compatible with the handling of text outside the margin. The specification says that whitespace up to the margin (or first non whitespace) should be removed but the implementation simply ignored those lines. The fix must do the same as it would otherwise have to wait until a major release. A new PR is now available with the bug compatible behavior. We need to decide what to do with the specification discrepancy at a major release. We should at minimum update the spec so tell users that impl in 6.y series does not comply. We then have a choice to either change the spec to what is implemented (easy fix, spec can just state that spec changed since none could rely on the specified behaviour anyway), or we can change the spec and implementation to either make it an error to have text in the margin, or to do what is currently specified. Suggest making the decision here (to save repetition and while the understanding of the issue is still fresh) and then do the ticketing for a spec and/or impl change. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Henrik Lindberg Fix Version/s: PUP 6.1.1 Fix Version/s: PUP 6.0.5 Fix Version/s: PUP 5.5.9 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Branan Riley updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Branan Riley Fix Version/s: PUP 5.5.9 Fix Version/s: PUP 6.0.5 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Henrik Lindberg Priority: Normal Major Release Notes Summary: Heredoc expressions with interpolation using an access _expression_ like `$facts['somefact']` could fail with a syntax error depending on the position of the heredoc in the source file relative to any whitespace (anywhere) in the source file. This was caused by a faulty calculation of location of interpolated expressions which also showed up as the wrong line/position in error messages related to the interpolated expressions.The handling of the position of so called "sublocated expressions" is now rewritten and the problem with seemingly random "syntax error" from the use of `[]` _expression_ in interpolation is gone.Advanced: Anyone having written tools that walk the AST tree should note that the `SublocatedExpression` will no longer be generated by the parser as all nodes under that node are now immediately updated with their correct offset and length. Although the `SublocatedExpression` class itself will not be removed until Puppet 7.0.0, it will no longer appear in AST produced by the parser. Release Notes: Bug Fix Component/s: Language Add Comment
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Henrik Lindberg Fix Version/s: PUP 6.0.5 Fix Version/s: PUP 5.5.9 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-9303
A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error
Change By:
Henrik Lindberg
*Puppet Version:* Anything greater than 5.X*Puppet Server Version:* N/A*OS Name/Version:* N/ADownload the {{simp_pki_service}} module from https://github.com/simp/pupmod-simp-simp_pki_service and run {{puppet parser validate manifests/kra.pp}}.Use {{d07265e253bb2cb11314dbb962043a21a2cbad05}} for the breaking behavior. Changing the {{fact}} call to a local variable did not show any issues.*Desired Behavior:*No validation errors should be shown (just as in Puppet 4)*Actual Behavior:*Puppet parser validation fails with a syntax error in the HEREDOC at line 123.Note: Removing the only line in the *comments* section of the document causes the validation to no longer fail. UPDATE--This is the same problem as in PUP-9163 which apparently did not fix all cases of the problem.The issue is that the lexer looks at the wrong character when it is looking at what comes just before the {{\[}} char in an interpolated _expression_ inside a heredoc. The position it is looking at depend on how much source text there is before the {{\[}} - if the erroneous position happens to be a space the result is a syntax error.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-9303 A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error Change By: Henrik Lindberg Summary: A file heredoc with a comment greater than 79 characters causes validation errors interpolation containing [ ] in an embedded HEREDOC the _expression_ can cause syntax error Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
