Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Jean Bond updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Jean Bond Labels: custom-facts customer resolved-issue-added ruby Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Jean Bond updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Jean Bond Release Notes Summary: Custom facts conflicting with built-in facts properly fall-back to the built-in value if no custom facts resolve while also ensuring that built-in facts have precedence over 0-weight custom facts. Facter now correctly gives precedence Release note draft:Prior to the highest weighted this release, Facter overrode built-in facts available from with custom fact values, even if the set of facts that can be If custom fact had no valid implementation. Now if custom facts return an empty result in conflict with built-in facts, they now properly fall back to Facter ignores that value and returns the built-in fact value if no custom facts resolve while also ensuring that . with built-in facts have precedence over 0 , but do not resolve, the built - weight custom facts in value is returned . Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Jean Bond updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Jean Bond Release Notes Summary: Custom facts conflicting with built-in facts properly fall-back to the built-in value if no custom facts resolve while also ensuring that built-in facts have precedence over 0-weight custom facts. Facter now correctly gives precedence to the highest weighted facts available from the set of facts that can be If custom facts conflict with built-in facts, they now properly fall back to the built-in value if no custom facts resolve while also ensuring that built-in facts have precedence over 0-weight custom facts. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Enis Inan commented on FACT-1873 Re: Custom facts that aren't suitable should not override built-in facts Kenn Hussey Done Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Enis Inan updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Enis Inan Release Notes Summary: Custom facts conflicting with built-in facts properly fall-back to the built-in value if no custom facts resolve while also ensuring that built-in facts have precedence over 0-weight custom facts. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Kenn Hussey commented on FACT-1873 Re: Custom facts that aren't suitable should not override built-in facts Enis Inan please provide release notes for this issue if needed, thanks! /cc Jean Bond Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Branan Riley updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Branan Riley Fix Version/s: FACT 3.12.3 Fix Version/s: FACT 3.12.2 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Branan Riley updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Branan Riley Fix Version/s: FACT 3.11.6 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Branan Riley updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Branan Riley Fix Version/s: FACT 3.12.3 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Enis Inan updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Enis Inan Affects Version/s: FACT 3.11.3 Affects Version/s: FACT 3.11.4 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Enis Inan assigned an issue to Enis Inan Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Branan Riley updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Branan Riley Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Branan Riley commented on FACT-1873 Re: Custom facts that aren't suitable should not override built-in facts This is broken because Facter evaluates Ruby facts after all built-in facts are evaluated, and overrides any built-in facts with what the Ruby facts return. If there is a nil due to no suitable fact implementations, Facter should ignore that value. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Branan Riley updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Branan Riley Labels: custom-facts customer ruby Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Scott McClellan updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Scott McClellan Team: Platform OS Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title
Branan Riley updated an issue
Facter / FACT-1873
Custom facts that aren't suitable should not override built-in facts
Change By:
Branan Riley
As a user of Facter, I would expect that a custom fact, with weight > 0, and with confines which have it result in being not suitable for the current system should not replace the built-in fact with an empty result.Or, put more generally, I would expect facter to pick the highest weighted fact available from the set of facts where the confines return success.Example with a fact in myfacts/custom.rb:{noformat}Facter.add(:timezone) do has_weight 10 confine { File.exist?('/tmp/fact_trigger') } setcode do 'my_custom_timezone' endend{noformat}and:{noformat}$ facter timezoneUTC{noformat}then, as expected:{noformat}$ touch /tmp/fact_trigger$ facter --custom-dir=myfacts timezonemy_custom_timezone{noformat}after removing /tmp/fact_trigger, causing the confine to fail:{noformat}$ rm /tmp/fact_trigger$ facter --custom-dir=myfacts timezone$ {noformat}what I would have expected to happen is:{noformat}$ rm /tmp/fact_trigger$ facter --custom-dir=myfacts timezoneUTC$ {noformat} The behavior as it is today prevents targeted fixing of particular facts on specific platforms that don't work as well as on other platforms by narrowing down the scope with confines.Thank you.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Scott McClellan updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Scott McClellan Labels: custom-facts ruby Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title
Sean Millichamp created an issue
Facter / FACT-1873
Custom facts that aren't suitable should not override built-in facts
Issue Type:
Improvement
Affects Versions:
FACT 3.11.3
Assignee:
Unassigned
Created:
2018/08/10 1:59 PM
Priority:
Normal
Reporter:
Sean Millichamp
As a user of Facter, I would expect that a custom fact, with weight > 0, and with confines which have it result in being not suitable for the current system should not replace the built-in fact with an empty result. Or, put more generally, I would expect facter to pick the highest weighted fact available from the set of facts where the confines return success. Example with a fact in myfacts/custom.rb:
Facter.add(:timezone) do
has_weight 10
confine { File.exist?('/tmp/fact_trigger') }
setcode do
