Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-06-09 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown commented on an issue


















  Re: processor.rb crashes Facter within MCollective on MS Windows 










Verified as fixed, though a bit complicated.


Install latest PE master and a Windows agent (a quick way to get this rigged up is within Azure). Sign the agents cert request, allowing it to communicate with the master.


Have the agent connect to the master with 2 runs, so that it is configured as an MCO node. Easiest way to do this is manually via puppet agent -t – also note that to become an MCO node, the master has to have run the periodic cron job that establishes this. In other words, there may be a timing component in addition to running the agent twice.


Once the node is marked as MCO, there will be mcollective folders on disk with module code installed by the agent run.


Install the facter facts plugin by copying facter_facts.rb and facter_facts.ddl from https://github.com/puppetlabs/mcollective-facter-facts to C:\Program Files (x86)\Puppet Labs\Puppet Enterprise\mcollective_plugins\mcollective\facts


Edit the MCO configuration stored in C:\ProgramData\PuppetLabs\mcollective\etc\server.cfg, and set the following settings





# set the debugger to do console logging instead of file logging, to make error easier to see
loglevel= debug
logger_type = console

# change from 1
daemonize   = 0

# must comment yaml, and add facter
# factsource = yaml
factsource = facter



NOTE: If Running in Azure, ensure that the identity of the master is set correctly to the external FQDN, and not the internal, like the following:



identity = peagent.cloudapp.net

plugin.activemq.pool.1.host = pemaster.cloudapp.net





Create a new batch file to start MCO with at C:\Program Files (x86)\Puppet Labs\Puppet Enterprise\bin\mcollectived.bat. This will work basically like the other batch files and properly updates environment variables like PATH.





@echo off
SETLOCAL

call %~dp0environment.bat %0 %*

ruby -S -- %SCRIPT_NAME% %*





   

Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-06-06 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Ethan Brown









 Theuseoffacterfactsplugin [1] formcollectivecausesthefollowingerroronMSWindowsonly:in`rescueinblockinget_fact'Failedtoloadfacts:ThreadError:deadlock;recursivelockingThissetupworksverywellon*nixoperatingsystemsthough.Canthecodeatlib/facter/processor.rb:120withThread::exclusivedoberefactoredtoallowsuchause?IhavealsolistedthisasaknownissueundermyMSIbuildinstructionsformcollectiveat[ 1 2 ].Currentresolutionistodeletetheprocessor.rbaltogethertoavoiddelvingintoit.[1]https://github.com/ puppetlabs/mcollective-facter-facts[2]https://github.com/ new23d/MCollective-MSI












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-06-05 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown assigned an issue to Ethan Brown


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Ethan Brown




Assignee:

 EthanBrown












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-06-04 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Kylo Ginsberg




Sprint:

 Week2014-5-21to2014-5-28,Week2014-5-28to2014-6-4 ,Week2014-6-4to2014-6-11












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-06-02 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo commented on an issue


















  Re: processor.rb crashes Facter within MCollective on MS Windows 










This issue is two fold - Facter is inconsistent in how it handles threading, and Ruby's `Thread.exclusive` uses a single lock instead of a lock per critical region:



[3] pry(main) Thread.exclusive do
[3] pry(main)*   Thread.exclusive do
[3] pry(main)* puts hi
[3] pry(main)*   end  
[3] pry(main)* end
ThreadError: deadlock; recursive locking
from internal:prelude:8:in `lock' 



Mcollective itself uses `Thread.exclusive` when retrieving facts (https://github.com/puppetlabs/marionette-collective/blob/master/lib/mcollective/facts/base.rb#L27) and when Facter itself tries to acquire a lock before the WMI query, we get a deadlock. The WMI query itself should be reentrant so we can remove the threading code from facter.
This is only an issue with the facter-facts mcollective facts plugin (https://github.com/puppetlabs/mcollective-facter-facts/blob/master/facts/facter_facts.rb) and we use the yaml facts plugin in mcollective.












   

 Add Comment

























 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 







 The use of facter facts plugin for mcollective causes the following error on MS Windows only:   in `rescue in block in get_fact' Failed to load facts: ThreadError: deadlock; recursive locking   This setup works very well on *nix operating systems though. Can the code at lib/facter/processor.rb:120 with Thread::exclusive do be refactored to allow such ...




   

Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-06-02 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo assigned an issue to Adrien Thebo


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Adrien Thebo




Assignee:

 new23d AdrienThebo












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-06-02 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper commented on an issue


















  Re: processor.rb crashes Facter within MCollective on MS Windows 










Merged ab541d567 to facter-2 to be released in 2.1












   

 Add Comment

























 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 







 The use of facter facts plugin for mcollective causes the following error on MS Windows only:   in `rescue in block in get_fact' Failed to load facts: ThreadError: deadlock; recursive locking   This setup works very well on *nix operating systems though. Can the code at lib/facter/processor.rb:120 with Thread::exclusive do be refactored to allow such ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-28 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Kylo Ginsberg




Sprint:

 Week2014-5-21to2014-5-28 ,Week2014-5-28to2014-6-4












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-28 Thread Kylo Ginsberg (JIRA)
Title: Message Title










 

 Kylo Ginsberg updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Kylo Ginsberg




Sprint:

 Week2014-5-21to2014-5-28,Week2014- 5 6 - 28 4 to2014-6- 4 11












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-27 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Adrien Thebo




Sprint:

 Week2014-5- 28 21 to2014- 6 5 - 4 28












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-27 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Adrien Thebo




Fix Version/s:

 2.1












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-21 Thread new23d (JIRA)
Title: Message Title










 

 new23d updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










`puppet apply -e notice('hello') --color=false --trace --debug  log_01.txt`
Happens on all MS Windows instances that I have, 2003 and 2008, various Service Pack levels.










Change By:

 new23d




Attachment:

 log_01.txt












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-21 Thread new23d (JIRA)
Title: Message Title










 

 new23d commented on an issue


















  Re: processor.rb crashes Facter within MCollective on MS Windows 










Error is also discussed on the mailing list at,
https://groups.google.com/forum/#!topic/mcollective-users/N1i_FjPS1yc
https://groups.google.com/forum/#!topic/mcollective-users/DrFAnZex-uI
https://groups.google.com/forum/#!topic/mcollective-users/8CmGe5Dgi7U
The alternative recommended in those discussions does not use Facter from within MCollective at all. As I understand, the problem isn't the MCollective Facter plugin for Facts but something in processor.rb .












   

 Add Comment

























 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 







 The use of facter facts plugin for mcollective causes the following error on MS Windows only:   in `rescue in block in get_fact' Failed to load facts: ThreadError: deadlock; recursive locking   This setup works very well on *nix operating systems though. Can the code at lib/facter/processor.rb:120 with Thread::exclusive do be refactored to allow such ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 




 

Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-21 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Adrien Thebo




Sprint:

 Week2014-5-28to2014-6-4












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-21 Thread Adrien Thebo (JIRA)
Title: Message Title










 

 Adrien Thebo updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Adrien Thebo




Story Points:

 2












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-20 Thread new23d (JIRA)
Title: Message Title










 

 new23d created an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Issue Type:

  Improvement




Assignee:

 Eric Sorenson




Created:


 20/May/14 3:52 AM




Priority:

  Normal




Reporter:

 new23d










The use of facter facts plugin for mcollective causes the following error on MS Windows only:
in `rescue in block in get_fact' Failed to load facts: ThreadError: deadlock; recursive locking
This setup works very well on *nix operating systems though. Can the code at lib/facter/processor.rb:120 with Thread::exclusive do be refactored to allow such a use?
I have also listed this as a known issue under my MSI build instructions for mcollective at [1] . Current resolution is to delete the processor.rb altogether to avoid delving into it.
[1] https://github.com/new23d/MCollective-MSI












   

 Add Comment


















   

Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-20 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Joshua Cooper




Assignee:

 EricSorenson new23d












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-20 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 










Change By:

 Joshua Cooper




Labels:

 windows












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-482) processor.rb crashes Facter within MCollective on MS Windows

2014-05-20 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper commented on an issue


















  Re: processor.rb crashes Facter within MCollective on MS Windows 










Thanks new23d for reporting this. Can you execute `puppet apply -e notice('hello') --trace --debug` and include the resulting stacktrace? Also does this only happen on one Windows OS, or multiple?












   

 Add Comment

























 Facter /  FACT-482



  processor.rb crashes Facter within MCollective on MS Windows 







 The use of facter facts plugin for mcollective causes the following error on MS Windows only:   in `rescue in block in get_fact' Failed to load facts: ThreadError: deadlock; recursive locking   This setup works very well on *nix operating systems though. Can the code at lib/facter/processor.rb:120 with Thread::exclusive do be refactored to allow such ...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at