Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Glenn Sarti commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Kris Bosland Given that this came in as a Windows issue and Henrik's comments above, I'm not sure why you chose to not test on that. I followed the repro instructions above and have confirmed that the commit at 8344baddf563fc92d7fdae411975170874f08e05 does indeed fix the issue on Windows. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title
Kris Bosland commented on PUP-8240
Re: ERB and EPP templates handle CRLF line endings inconsistently
Fixed in 5.5.1 rc:
puppet % cat -v /tmp/test.pp
file { "/tmp/test.txt":
content => epp("/tmp/test.epp")
}
puppet % cat -v /tmp/test.epp
line 1^M
line 2^M
:P^M
puppet % bx puppet apply /tmp/test.pp
Notice: Compiled catalog for [redacted] in environment production in 0.02 seconds
Notice: /Stage[main]/Main/File[/tmp/test.txt]/ensure: defined content as '{md5}ec01eff99f50062fb0927769185166eb'
Notice: Applied catalog in 0.02 seconds
puppet % cat -v /tmp/test.txt
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Jacob Helwig commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently This was merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/6082ad07c68d947f892552081d8159768a485ee9 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Henrik Lindberg Assignee: Ethan Brown Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Henrik Lindberg Release Notes Summary: EPP templates containing CRLF line breaks did not generate files containing CRLF line breaks, which is the expected result and also the result when using CRLF line breaks in ERB templates. This is now corrected. Also, when using CRLF escape sequences (`\r\n`) in either ERB or EPP templates, Puppet doesn't convert the sequences to CRLF line breaks as expected. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Henrik Lindberg Release Notes Summary: EPP templates that contain containing CRLF line breaks do did not generate files containing CRLF line breaks, which is the expected result and also the result when using CRLF line breaks in ERB templates. This is now corrected. Also, when using CRLF escape sequences (`\r\n`) in either ERB or EPP templates, Puppet doesn't convert the sequences to CRLF line breaks as expected. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently My first attempt of solving this was both naive (hoping it would cure all problems oft this kind) but I got it wrong. The FileSystem.read takes options, and those are naturally used - just trying to delegate to read_preserve_line_endings won't work as that method does not take options. While possible to add optional options to that method, it in itself does things with options with respect to encoding, and it would need to get more complicated if it were to also try to honour the various options that can be passed into Ruby's read. Also, the read_preserve_line_endings may result in a String that is not UTF-8. Instead, I fixed the issue for Puppet and EPP by modifying the lexer to read with 'rb' mode and with UTF-8 encoding. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently AppVeyor fails miserably in what seems unrelated to this change. Help needed. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Henrik Lindberg Fix Version/s: PUP 5.5.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently I put up a PR making read the same as read with preserved line ending on windows - this to get a test run. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Glenn Sarti commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Seems right. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently So... FileSystem.read on my machine (mac OSx) returns text files with CRLF intact (as shown by my experiment in this thread) - i.e. no "helpful" ruby mapping. Is it only "helpful" on Windows? If so, then our implementation of the Window's version of FileSystem.read is wrong. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Glenn Sarti commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently The ruby read method is a text reader so it tries to be "helpful" and normalises line endings as LF only. You can force ruby to read it as a binary file ( read(,"rb") ) in which case it reads in a byte stream and can then use the encoding to create the correct text string. A short google search on "file.read ruby CRLF" shows the pain As a side note this has the same behaviour on WRITING text files too (Text vs Binary file), which is a MAJOR pain point for me with Rubocop. When you rubocop auto correct, it doesn't respect the original line endings, so suddenly my files turn to CRLF. Even puppet-lint ran into this issue too, beaker-hostgenerator has a similar issue Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently That is so sad... Is the design really that the read is supposed to not preserve line endings? That is bizarre. The posix implementation does not remove CR chars (and I don't think it should) - that is why it works on non-windows. Seems more natural that there would be a special read that strips CR that logic not prepared to handle CRLF line endings should use. While we could change this for the EPP loader, all other modern loaders of code uses read - so an inline template doing the same thing would have the same issue. If we change the Posix read to strip CR then that is a serious performance issue (we need to read and replace them which would mean scanning the read manifest again. To me the proper fix is to modify the Windows implementation so that read is the same as read_preserve_line and that we add another read method read_posix_line_endings that should be used where reads on windows where supposed to get posix line endings (if that is needed anywhere at all?). Or... am I perhaps missing some Ruby quirk around CRLF line endings? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Glenn Sarti commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently The file loader at; https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/parser/lexer2.rb#L650 is stripping the CRLF and comes in as LF only From: C:/Source/tmp/PUP-8240/.bundle/windows/ruby/2.3.0/gems/puppet-5.5.0-x64-mingw32/lib/puppet/pops/parser/lexer2.rb @ line 651 Puppet::Pops::Parser::Lexer2#lex_file: 648: def lex_file(file) 649: initvars 650: contents = Puppet::FileSystem.exist?(file) ? Puppet::FileSystem.read(file, :encoding => 'utf-8') : '' => 651: assert_not_bom(contents) 652: @scanner = StringScanner.new(contents.freeze) 653: @locator = Locator.locator(contents, file) 654: end [6] pry(#)> contents => "line 1\nline 2\n:P" [7] pry(#)> file
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Glenn Sarti commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Confirmed it also fails on my Windows 10 workstations (Puppet Gem 5.5.0, Ruby 2.3.1, x64 bit) Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title
Jessykah Bird commented on PUP-8240
Re: ERB and EPP templates handle CRLF line endings inconsistently
There is a current workaround that you can do assuming you want all lines to be crlf, using the regsubst function.
file { 'c:/test.txt':
content => regsubst(epp("c:/test.epp"), '(?, "\r\n", 'G')
}
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group,
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Owen Rodabaugh updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Owen Rodabaugh CS Priority: Needs Priority Major CS Impact: This bug makes it extremely difficult or impossible for customers to use templates to create files for windows systems with the correct CRLF line endings. CS Severity: 3 - Serious CS Business Value: 5 - $$ CS Frequency: 3 - 25-50% of Customers Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Reid Vandewiele updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Reid Vandewiele CS Priority: Needs Priority Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg assigned an issue to Ethan Brown Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Henrik Lindberg Assignee: Henrik Lindberg Ethan Brown Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Ethan Brown Can you take a look? My test and Garrett's are equivalent - and I am starting to suspect a running-on-window's specific problem. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Garrett Guillotte Attachment: Screen Shot 2017-12-12 at 10.10.31 AM.png Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Garrett Guillotte Attachment: PUP-8240.zip Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Attached the files created on the Windows 2016 VM during the above steps to reproduce. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte assigned an issue to Henrik Lindberg Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Garrett Guillotte Assignee: Geoff Williams Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title
Garrett Guillotte commented on PUP-8240
Re: ERB and EPP templates handle CRLF line endings inconsistently
1. Created a Windows Server 2016 VM: vmpool grab win-2016-x86_64 2. Connected to it via RDP. 3. Installed Puppet Agent 5.3.3 from https://downloads.puppetlabs.com/windows/puppet5/https://downloads.puppetlabs.com/windows/puppet5/puppet-agent-5.3.3-x64.msi, without changing any default installer settings. 4. Opened Notepad.exe on the Windows VM. 5. Created the test.pp file documented in the ticket by writing it in Notepad.exe, and saved it to c:\test.pp. 6. Created the test.epp file documented in the ticket by writing it in Notepad.exe, and saved it to c:\test.epp. 7. Ran puppet apply c:\test.pp.
Command output:
C:\>puppet apply test.pp
Notice: Compiled catalog for gcyd7mh9hrtc87j.delivery.puppetlabs.net in environment production in 0.05 seconds
Notice: /Stage[main]/Main/File[c:/test.txt]/ensure: defined content as '{md5}c6178e9f1072360372f741a95a73ded9'
Notice: Applied catalog in 0.05 seconds
Expected behavior:
The output file text.txt has line breaks between line 1, line 2, and when opened in Notepad.exe, just like it does in test.epp. The output file's hex dump is the same as the template's.
Observed behavior:
The output file does not have line breaks between line 1, line 2, and when opened in Notepad.exe. The hex dumps do not match; the CR characters are missing.
Hex dumps of test.txt and test.epp from the Windows VM:
PS C:\> Get-Content "C:\test.epp" -Encoding Byte `
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Garrett Guillotte Attachment: Screen Shot 2017-12-12 at 9.48.40 AM.png Attachment: Screen Shot 2017-12-12 at 9.48.52 AM.png Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently I'll try reproducing the steps documented in this ticket again on Windows 10 and Puppet 5.3.3, which did not produce line breaks in the output when using CRLF line breaks in the EPP template. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Geoff Williams commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently no I couldn't care less about \r\n literal escape sequences - that looks just plain wrong in the docs. I was using puppet 4.10.8 to test this - possibly the testcase is incorrect or newer version fixes? I was unable to get windows style line endings no matter what I tried earlier. I'm calling it a day my end but will look again next time I get a moment Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Is it that EPP does not allow you to place escapes for control chars in the text? I.e. if you write \r or \n (or any other escape for that matter), then you are not getting the control char. I think that is the desired behaviour. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently A small test shows that files with CRLF in the text part of an EPP outputs CRLF: henrik$ cat foo.epp template text on line 2 hexdump foo.epp 000 74 65 6d 70 6c 61 74 65 20 74 65 78 74 0d 0a 6f 010 6e 20 6c 69 6e 65 20 32 0d 0a 0d 0a 01c henrik$ bundle exec puppet epp render foo.epp > test henrik$ hexdump test 000 74
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Henrik Lindberg assigned an issue to Geoff Williams Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Henrik Lindberg Assignee: Geoff Williams Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Geoff Williams commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Garrett Guillotte Expectation would be accurate documentation at a bare minimum. I feel like the epp() function should do something sensible with CRLF too otherwise its unusable on windows in a lot of situations. Similar behaviour to ERB would work, as would a line-endings option to the epp() function itself - long as there is a documented and supported path to write files on windows I'm happy Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title
Henrik Lindberg commented on PUP-8240
Re: ERB and EPP templates handle CRLF line endings inconsistently
This piece from the documentation is confusing:
If the manifest, template, or source file is saved with LF line endings, you can use the \r\n escape sequence to create literal CRLFs.
Is that implying that you can write escaped control char whitespace? For example:
notice("foo")\r\n
That has never worked in a manifest afaik.
Add Comment
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Josh Cooper commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently FYI Henrik Lindberg, Ethan Brown Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Garrett Guillotte Affects Version/s: PUP 5.3.3 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Geoff Nichols Team: Platform OS Core Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Garrett Guillotte Release Notes Summary: EPP templates that contain CRLF line breaks do not generate files containing CRLF line breaks, which is the expected result and also the result when using CRLF line breaks in ERB templates.Also, when using CRLF escape sequences (`\r\n`) in either ERB or EPP templates, Puppet doesn't convert the sequences to CRLF line breaks as expected. Release Notes: Known Issue Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte updated an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Change By: Garrett Guillotte Attachment: testcase.zip Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently FYI, this might affect Puppet 5.x as well. I haven't tested that yet. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Garrett Guillotte commented on PUP-8240 Re: ERB and EPP templates handle CRLF line endings inconsistently Geoff Williams Thanks for filing DOCUMENT-779. Can you please confirm that the description and acceptance criteria are what you expect here? I modified your description to focus on the unexpected software behavior. CC Josh Cooper Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently
Title: Message Title Geoff Williams created an issue Puppet / PUP-8240 ERB and EPP templates handle CRLF line endings inconsistently Issue Type: Bug Affects Versions: PUP 4.10.9 Assignee: Unassigned Created: 2017/12/11 11:15 AM Priority: Normal Reporter: Geoff Williams Via Geoff Williams on DOCUMENT-779: expected result When applying a puppet manifest and its EPP template using CRLF line endings to generate a file, the generated file should also use CRLF line endings. When using a CRLF escape sequence in ERB or EPP templates (\r\n), Puppet should replace the sequence with a CRLF line ending in the generated file. This is documented at Handling line endings on Resource tips and Examples: File on Windows: If a file resource uses the content or source attributes, Puppet will write the file in “binary” mode, using whatever line endings are present in the content. If the manifest, template, or source file is saved with CRLF line endings, Puppet will use those endings in the destination file. If the
