Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Jean Bond updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Jean Bond Labels: community resolved-issue-added systemd type_and_provider Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Jean Bond updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Jean Bond Release Notes Summary: The systemd provider, when When starting or restarting a service, will check the `systemd` provider checks to see if whether the service requires a daemon reload is required by that particular service. If it is , it will reload and reloads the systemd daemon if necessary . Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Melissa Stone commented on PUP-3483 Re: Systemd provider doesn't scan for changed units This has passed CI as a part of puppet-agent 6.0.4.172.g8835ced Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Melissa Stone updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Melissa Stone Release Notes Summary: The systemd provider, when starting or restarting a service, will check to see if a daemon reload is required by that particular service. If it is, it will reload the systemd daemon. Release Notes: New Feature Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Melissa Stone updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Melissa Stone Fix Version/s: PUP 6.1.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Scott Garman commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Merged to puppet master at https://github.com/puppetlabs/puppet/commit/d4297af039b64a1fb0a05cced25a13557bcf37d4 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Vincent Lours commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Hi Jeff Silverman, As you, I use to create my own systemd unit file. But from my understanding, the 2 actions listed in your post does not required any daemon-reload. According the man documentation, the "enable" command reload the systemd configuration after creating the symlink: enable NAME... Enable one or more unit files or unit file instances, as specified on the command line. This will create a number of symlinks as encoded in the "[Install]" sections of the unit files. After the symlinks have been created, the systemd configuration is reloaded (in a way that is equivalent to daemon-reload) to ensure the changes are taken into account immediately. [...] And I've made few tests. When a new unit file is created, the systemd is adding it automatically to the config: Example of creation of new unit file sh-4.2# cat /etc/centos-release CentOS Linux release 7.5.1804 (Core) sh-4.2# ls -l /usr/lib/systemd/system/mytest.service ls: cannot access /usr/lib/systemd/system/mytest.service: No such file or directory sh-4.2# systemctl list-unit-files | grep mytest sh-4.2# vi /usr/lib/systemd/system/mytest.service sh-4.2# cat /usr/lib/systemd/system/mytest.service [Unit]
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Jeff Silverman commented on PUP-3483 Re: Systemd provider doesn't scan for changed units There's a use case, that I didn't see described here, for having puppet automatically do daemon-reload when "service -> enable" is set for a service or when a systemd unit file is added. That is in the case of software installations that are not coming from a package. For example, built or compiled in-house and installed from a tarball. I'm surprised I didn't see this use case listed here. (Or maybe I just missed it – this Jira is long now). Another, related use case is third party software provided without any init scripts at all. (i.e. I have to write my own init script or systemd unit file). I can't be the only one that has to write init scripts for custom software. Also, my expectation as a Puppet user is that when I define a Service as enabled in a manifest, that the underlying puppet engine that handles this task knows to do daemon-reload if it needs to. Should that be my expectation? (Reading between the lines here, it sounds like I shouldn't expect that) Thank you Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Melissa Stone updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Melissa Stone Team: Modules Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Melissa Stone updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Melissa Stone Labels: community systemd type_and_provider Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Melissa Stone updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Melissa Stone Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Melissa Stone assigned an issue to Melissa Stone Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Melissa Stone Assignee: Vincent Lours Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Vincent Lours assigned an issue to Vincent Lours Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Vincent Lours Assignee: Vincent Lours Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Vincent Lours commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Eric Thompson thanks for your message. I've made the modification, but I'm still waiting for the CLA confirmation message (I've raised the issue CLA-31about that). I hope to be able to submit the PR soon ^^ Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Eric Thompson commented on PUP-3483 Re: Systemd provider doesn't scan for changed units vincent lours thanks for your contribution! if you could create a PR against puppet here: https://github.com/puppetlabs/puppet that would help. more info on how to do that is in the https://github.com/puppetlabs/puppet/blob/master/CONTRIBUTING.md doc Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title vincent lours commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Hi Eric Thompson, Can you review on the suggested fix and pass it to the Engineering team if it fits puppet's requirements ? That should definitively remove the need of any Notify to a Exec['systemctl-daemon-reload'] for all systemd services. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title vincent lours commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Hi guys, Based on Hunter (Hunner) Haugen's comment, I was able to implement this functionality in the Puppet Agent code. Even if I'm not a Ruby Expert, it was quite simple to figure how to implement it. Including this code in the Puppet Agent code will check if the "NeedDaemonReload" is set to 'yes' or everything else (default: 'no') Which will cause a "systemctl daemon-reload" only once, when required. The NeedDaemonReload check will be called on every "start" or "restart" actions. But the daemon-reload action will occur only once at the first match, as it will fix all other NeedDaemonReload requests once executed. Including this code in the puppet agent will definitively remove the need of any Notify to a Exec['systemctl-daemon-reload'] for all systemd Services managed in puppet. The code has been checked/validated with puppet-agent version 5.5.3-1.el7.x86_64. Feel Free to test and improve it. # diff -ruN /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/systemd.rb.ori /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/systemd.rb --- /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/systemd.rb.ori 2018-07-20 05:21:43.852724847 + +++ /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider/service/systemd.rb 2018-07-20 05:37:42.513155599 + @@ -121,6 +121,15 @@ end end + def daemon_reload? +cmd = [command(:systemctl), 'show', @resource[:name], '--property=NeedDaemonReload']
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Owen Rodabaugh updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Owen Rodabaugh CS Priority: Reviewed Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Hunter (Hunner) Haugen commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Using time it appears that checking whether a unit file needs to be reloaded via systemctl show rsyslog --property=NeedDaemonReload takes about 0.007 real and doing a systemctl daemon-reload takes 0.04 real. I did not see any mechanism for making systemd auto-daemon-reload as needed, so perhaps we should check NeedDaemonReload at the beginning of any status/restart/start/stop operation, but only once per ensure evaluation (since the unit should not otherwise change during a single transaction). I did not see any way to integrate the NeedDaemonReload check as part of systemctl list-unit-files that self.instances performs. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Moses Mendoza Labels: systemd triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Jeremy Barlow updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Jeremy Barlow Labels: systemd triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Tom Limoncelli commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Thomas Mueller I think we agree on all points except I feel that https://forge.puppet.com/camptocamp/systemd should be make part of puppet so that everyone uses the same one. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Thomas Mueller commented on PUP-3483 Re: Systemd provider doesn't scan for changed units When a package updates it's sysvinit script or systemd unit ... then the package should take care of reloading. as for example adviced here: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd or for that matter if I were to be manually managing a systemd unit with a file resource then you should use a puppet module that abstracts this for you. like https://forge.puppet.com/camptocamp/systemd Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Geoff Nichols Sprint: AP Triage Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Kevin Henner commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Just to pile on here: from a learning and usability perspective, the "package, file, service" pattern should be as simple as possible, while exec resources are a more advanced topic with a list of warnings and caveats. Exec is the kind of hammer that makes a lot of things look like nails, so the more we can avoid pointing newer in its direction, the better. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Geoff Nichols Sprint: AP Triage Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Hunter Haugen updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Hunter Haugen Priority: Major Critical Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Hunter Haugen commented on PUP-3483 Re: Systemd provider doesn't scan for changed units So, this seems major if not critical, given the systemd adoption rates. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Hunter Haugen updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Hunter Haugen Priority: Normal Major Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Kenaz Kwa updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Kenaz Kwa Team: Modules Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Tom Limoncelli commented on PUP-3483 Re: Systemd provider doesn't scan for changed units (If anyone would like to discuss this at PuppetConf 2016, I'd like to hash it out and get consensus.) Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Daniel Parks commented on PUP-3483 Re: Systemd provider doesn't scan for changed units This should be built into puppet. The exec thing is a giant pain and a horrible kludge for all the reasons listed above. It's only going to get worse as time goes on. Running daemon-reload every time Puppet restarts a service is not very heavy: if Puppet runs avery 30 minutes and restarts at least one service, that's only daemon-reloading twice an hour. If avoiding unnecessary daemon-reloads is really important, then puppet can scan for changed unit files easily enough. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title R.I.Pienaar commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Tom Limoncelli It's an option and it seems sane to me, but I have no idea who will make such a module, an 'official' one would bubble to the top of ones being used I suppose Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Tom Limoncelli commented on PUP-3483 Re: Systemd provider doesn't scan for changed units R.I.Pienaar I'm glad there is a precedent. So, if there is a puppetlabs-apt, we need a puppetlabs-systemd? Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title R.I.Pienaar commented on PUP-3483 Re: Systemd provider doesn't scan for changed units this same problem basically exist with all the various hassles around managing apt and apt-get update, and there the solution is that everyone uses puppetlabs-apt, I agree that to be a logical approach to handling this too Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Tom Limoncelli commented on PUP-3483 Re: Systemd provider doesn't scan for changed units I think the best solution is the ::systemd module from camptocamp: Any time you modify a unit file (.service) have it notify Exec['systemctl-daemon-reload']. https://github.com/camptocamp/puppet-systemd The problem, however, is that modules like puppetlabs-firewall can't be expected to depend on a third-party module like camptocamp/puppet-systemd. The correct solution is for Puppet to make The One True Exec['systemctl-daemon-reload'] and have everyone standardize on it. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Geoff Williams commented on PUP-3483 Re: Systemd provider doesn't scan for changed units I'm hitting this too - In my case I've created the exec resource but am now having to reference it all over the place as the packaging cannot fix the things I need since I'm writing puppet code to update the systemd unit files/environment settings after-the-fact. In addition to this I'm having to write code to special-case windows in order to not attempt to interact with systemd at all. To me, it would be a much cleaner solution if the puppet service resource could handle any required reloads once and for all so that I don't have to Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Michael Stahnke updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Michael Stahnke Scrum Team: Release Engineering Modules Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Damon Atkins commented on PUP-3483 Re: Systemd provider doesn't scan for changed units What if a person drops a file in /etc/init.d and starts the service with puppet then latter changes it it again requires a daemon-reload Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Tim Meusel commented on PUP-3483 Re: Systemd provider doesn't scan for changed units I had the same thoughts as Tom, we currently run into several issues because every module defines their own exec. We need a global solution to trigger a systemd daemon-reload, but I'm not sure if a simple module that defines the exec is the best solution (but I also can't think of something better). Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title
Tom Limoncelli commented on PUP-3483
Re: Systemd provider doesn't scan for changed units
It is now 3 months later and it looks like the recommended solution has an unintentional negative side-effect.
Many modules need this kind of functionality. They all do what you've recommended: Create a `Exec['systemd-tmpfiles-create']` which can be notify'ed any time a unit file is installed or modified. However, now many different modules use the same name and collide. If they use different names, systemd is told to "daemon-reload" multiple times, instead of having all the notify's collapsed into one Exec{}.
There are probably many solutions but one would be: Puppet Labs should bless a single module that defines the Exec[], so that all other modules can notify it. A module such as https://github.com/camptocamp/puppet-systemd would be a candidate, though I think the name should be different.
Add Comment
This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Michael Stahnke commented on PUP-3483 Re: Systemd provider doesn't scan for changed units I agree with Ben S. Packaging should handle it, or in other cases a specific exec should be called. Add Comment This message was sent by Atlassian JIRA (v6.4.5#64020-sha1:78acd6c) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Kylo Ginsberg assigned an issue to Unassigned Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Kylo Ginsberg Assignee: KyloGinsberg Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Change By: Kylo Ginsberg Scrum Team: ReleaseEngineering Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Kylo Ginsberg commented on PUP-3483 Re: Systemd provider doesn't scan for changed units Michael Stahnke thoughts on this? Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Ben S commented on PUP-3483 Re: Systemd provider doesn't scan for changed units I have a created a module myself that modifies systemd unit files and used execs. I can't see major benefits for Puppet doing the systemctl daemon-reload all the time with the package resource if it detects the service provider as systemd. Packages (should) do this as part of %post scripts Distributions rarely change the init scripts for packages, even after multiple version bumps When these init scripts do change, how often do they affect the service dependency tree? (requiring a daemon-reload) I think performing a systemctl daemon-reload should be left to modules. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3483) Systemd provider doesn't scan for changed units
Title: Message Title Nicholas Jackson created an issue Puppet / PUP-3483 Systemd provider doesn't scan for changed units Issue Type: Bug Assignee: Kylo Ginsberg Components: Types and Providers Created: 17/Oct/14 9:32 AM Labels: systemd Priority: Normal Reporter: Nicholas Jackson When a package updates it's sysvinit script or systemd unit (or for that matter if I were to be manually managing a systemd unit with a file resource), nothing ever tells systemd to check for changed units. Typically you would invoke `systemctl daemon-reload` to scan for new and changed units. Add Comment
