Re: [Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-11 Thread Paul Nasrat
2010/1/11 Ohad Levy ohadl...@gmail.com: +1 is there a reason why not to strip all facts? I'm a little cautious about doing that in general in case someone has a dependancy on a fact with a space in or valid but odd setups (directories with trailing space). Although all the examples I can

Re: [Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-11 Thread Thomas Bellman
Paul Nasrat wrote: 2010/1/11 Ohad Levy ohadl...@gmail.com: is there a reason why not to strip all facts? I'm a little cautious about doing that in general in case someone has a dependancy on a fact with a space in or valid but odd setups (directories with trailing space). Although all the

[Puppet-dev] Re: [PATCH/puppet 1/1] Proposed fix for #3013 (pipes, OSes, and ruby versions, Oh My!)

2010-01-11 Thread Kjetil Torgrim Homme
Markus Roberts mar...@reality.com writes: This last bears some elaboration; if the following steps occur: * Puppet execs child process (apt-get, for example) and attempts to capture the output * The child process launches a grandchild process (the buggy version of the osirid daemon

[Puppet-dev] Re: [PATCH] Refinement of fix for #3013

2010-01-11 Thread Kjetil Torgrim Homme
Markus Roberts mar...@reductivelabs.com writes: This patch incorporates Ricky Zhou's idea for establishing a default SIGPIPE trap of IGNORE in child, which protects really dumb daemons from the effects of writing to a closed stdout. As even moderately smart daemons ought not do this, these

Re: [Puppet-dev] Re: [PATCH/puppet 1/1] Proposed fix for #3013 (pipes, OSes, and ruby versions, Oh My!)

2010-01-11 Thread Markus Roberts
just a note: it's quite essential that SIGPIPE is set to SIG_DFL in the child process.  luckily, execve(2) will reset to SIG_DFL unless it's set to SIG_IGN.  a child with SIGPIPE set unexpectedly to SIG_IGN can easily get stuck in endless loops.  the grandchild SHOULD die when it tries to

[Puppet-dev] Re: [PATCH/puppet 1/1] Proposed fix for #3013 (pipes, OSes, and ruby versions, Oh My!)

2010-01-11 Thread Kjetil Torgrim Homme
Markus Roberts mar...@reductivelabs.com writes: just a note: it's quite essential that SIGPIPE is set to SIG_DFL in the child process.  luckily, execve(2) will reset to SIG_DFL unless it's set to SIG_IGN.  a child with SIGPIPE set unexpectedly to SIG_IGN can easily get stuck in endless loops.

Re: [Puppet-dev] Re: [PATCH/puppet 1/1] Proposed fix for #3013 (pipes, OSes, and ruby versions, Oh My!)

2010-01-11 Thread Markus Roberts
Kjetil -- this isn't really a very unique problem to solve, a lot of applications have done this before, efficiently.  (e.g., reading large blocks is guaranteed safe when reading from slow devices, this includes pipes and sockets.  a fast device (ie. hard disk) will hang until the whole

Re: [Puppet-dev] Re: [PATCH/puppet 1/1] Proposed fix for #3013 (pipes, OSes, and ruby versions, Oh My!)

2010-01-11 Thread Luke Kanies
On Jan 11, 2010, at 9:58 AM, Markus Roberts wrote: Not quite. Cargo cult is doing something that looks like what worked in the past, in the hopes of recreating that past success, and continuing to do so in the face of repeated failure. Change management is refraining from changing something

[Puppet-dev] Update on 0.25.3

2010-01-11 Thread Markus Roberts
All -- We have a confirmed regression (see #3025) of #1563 (apt-get hangs puppet) which was introduced in 0.25.2 with the patch to use pipes instead of temp files to communicate with sub-processes for SELinux (#2731). This problem persists despite an heroic effort by all the kings horses to

Re: [Puppet-dev] Update on 0.25.3

2010-01-11 Thread Luke Kanies
On Jan 11, 2010, at 1:42 PM, Markus Roberts wrote: All -- We have a confirmed regression (see #3025) of #1563 (apt-get hangs puppet) which was introduced in 0.25.2 with the patch to use pipes instead of temp files to communicate with sub-processes for SELinux (#2731). This problem persists

Re: [Puppet-dev] Update on 0.25.3

2010-01-11 Thread Markus Roberts
In the coin flip I got parsimony and that leaves James stuck as the voice for catholicon. His proposed list of possible patches to include in 0.25.3 as long as we're at it: •James's packaging changes •Bug #1464: Mount resource complains about missing options field •Bug

Re: [Puppet-dev] Update on 0.25.3

2010-01-11 Thread Matthew Delves
On 12/01/2010 at 9:20 am, Markus Roberts mar...@reductivelabs.com wrote: In the coin flip I got parsimony and that leaves James stuck as the voice for catholicon. His proposed list of possible patches to include in 0.25.3 as long as we're at it: ●James's packaging changes ●

Re: [Puppet-dev] Update on 0.25.3

2010-01-11 Thread Jesse A Wolfe
As the author of the patches for #1464 , #2845 and #2887 , I'm going to vote for inclusion. They're all things that would have gone into 0.25.2 if had gotten them in time. (but I'd be willing to listen to an argument that they haven't been tested sufficiently, if someone wants to make that

Re: [Puppet-dev] Update on 0.25.3

2010-01-11 Thread Markus Roberts
I'd rather leave #1842 unpatched, since it doesn't do any harm, and removing the option (even if it's doing nothing) could cause breakage. That's basically where James and I were. So the include list stands at: •Reversion of #2713 to fix #3013 / #3023 / #3025    •    James's

Re: [Puppet-dev] Update on 0.25.3

2010-01-11 Thread Luke Kanies
I'm good with all of these. On Jan 11, 2010, at 3:01 PM, Jesse A Wolfe wrote: As the author of the patches for #1464 , #2845 and #2887 , I'm going to vote for inclusion. They're all things that would have gone into 0.25.2 if had gotten them in time. (but I'd be willing to listen to an

Re: [Puppet-dev] Update on 0.25.3

2010-01-11 Thread Markus Roberts
I'm not hearing any objections, so we're going to go for it, omitting #1842 on vague collective unease but letting the rest ride. -- Markus -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email to

Re: [Puppet-dev] [PATCH/facter 1/1] Remove whitespace in DMI facts (#3008, #3011)

2010-01-11 Thread Paul Nasrat
2010/1/11 Thomas Bellman bell...@nsc.liu.se: Paul Nasrat wrote: 2010/1/11 Ohad Levy ohadl...@gmail.com: is there a reason why not to strip all facts? I'm a little cautious about doing that in general in case someone has a dependancy on a fact with a space in or valid but odd setups

[Puppet-dev] Re: [PATCH/puppet 1/1] Working addition of symbolic modes to the file type. GNU coreutils chmod was the reference implementation.

2010-01-11 Thread Trevor Vaughan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Not meaning to butt in on my own patch thread, but is there anything particularly wrong with the code below? This patch was generated from the latest head of the day. I'll have a couple of hours coming up to work on this so would like to get some

[Puppet-dev] ANNOUNCE: Puppet 0.25.3 - Clifford available!

2010-01-11 Thread James Turnbull
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Puppet 0.25.3 - code-named Clifford The 0.25.3 release is a maintenance release in the 0.25.x branch. The release addresses a regression introduced in 0.25.2 that caused issues with command execution. The release is available at: