Re: [Puppet-dev] Idea about sourcing facts from other languages

2010-03-09 Thread Michael DeHaan
{  facts: {   network: {     interface: eth0,     ip: 192.168.0.1,     netmask: 255.255.255.0,   },   disk: {     name: sda1,     size: 1000,  }  }, } Yep, that's pretty much what I was proposing. I'm a big fan of structured stdin/stdout interfaces for quick extensibiility (and

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Markus Roberts
This reverts commit 33fb7709404e706801683e6c47ab7a0a5a1884b1. This has broken master for some facts (eg OS X facts), it also breaks facter platform support on win32 as popen3 does not work there. Is there a ticket for the problem? For the broken tests but not the win32 platform

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Paul Nasrat
On 9 March 2010 18:13, Markus Roberts mar...@reductivelabs.com wrote: Doh, yes, thanks.  I was reading that on the train with screen glare and missed some of the -' signs. I've commited this now, and have started working through the 1.5.8 bug list. Paul -- You received this message because

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Michael DeHaan
Paul Nasrat wrote: On 9 March 2010 18:13, Markus Roberts mar...@reductivelabs.com wrote: Doh, yes, thanks. I was reading that on the train with screen glare and missed some of the -' signs. I've commited this now, and have started working through the 1.5.8 bug list. Paul

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Paul Nasrat
On 9 March 2010 19:33, Michael DeHaan mich...@reductivelabs.com wrote: Excellent.  I also hope to help some with the code refactoring and support for new datastructure types. I agree bugs should come first, so those too :) If you're doing this, we should do a testing branch and target for

Re: [Puppet-dev] [PATCH/facter 1/1] Revert use popen3 in Resolution.exec

2010-03-09 Thread Michael DeHaan
Paul Nasrat wrote: On 9 March 2010 19:33, Michael DeHaan mich...@reductivelabs.com wrote: Excellent. I also hope to help some with the code refactoring and support for new datastructure types. I agree bugs should come first, so those too :) If you're doing this, we should do a

[Puppet-dev] [PATCH] Add shell glob support to puppetrun, and also groups using /etc/puppet/hostgroups.txt (JSON format).

2010-03-09 Thread Michael DeHaan
Also cleaned up a few error messages (unrelated) --- lib/puppet/application/puppetrun.rb | 12 ++- lib/puppet/daemon.rb|2 +- lib/puppet/network/server.rb|2 +- lib/puppet/util/runner.rb | 53 +++ 4 files changed,

[Puppet-dev] Re: [PATCH] Add shell glob support to puppetrun, and also groups using /etc/puppet/hostgroups.txt (JSON format).

2010-03-09 Thread Michael DeHaan
Ok, this should be a little closer to what I want. Note: The hostgroups.conf file really should be in INI format (IMHO) as JSON is a bit of a beast for humans (great for machines). Usage: puppetrun -host www*.example.org Or even: vi /etc/puppet/hostgroups.conf {webservers:

Re: [Puppet-dev] [PATCH] Add shell glob support to puppetrun, and also groups using /etc/puppet/hostgroups.txt (JSON format).

2010-03-09 Thread Todd Zullinger
Michael DeHaan wrote: +def expand_groups(host_list) +groupfile = #{Puppet[:confdir]}/hostgroups.conf Rather minor, but your commit subject says .txt but the code uses .conf. -- ToddOpenPGP - KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp

Re: [Puppet-dev] Idea about sourcing facts from other languages

2010-03-09 Thread Luke Kanies
On Mar 9, 2010, at 5:09 AM, Michael DeHaan wrote: { facts: { network: { interface: eth0, ip: 192.168.0.1, netmask: 255.255.255.0, }, disk: { name: sda1, size: 1000, } }, } Yep, that's pretty much what I was proposing. I'm a big fan of structured stdin/stdout

Re: [Puppet-dev] Idea about sourcing facts from other languages

2010-03-09 Thread Nigel Kersten
On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies l...@reductivelabs.com wrote: On Mar 9, 2010, at 5:09 AM, Michael DeHaan wrote: {  facts: {  network: {    interface: eth0,    ip: 192.168.0.1,    netmask: 255.255.255.0,  },  disk: {    name: sda1,    size: 1000,  }  }, } Yep, that's

Re: [Puppet-dev] Idea about sourcing facts from other languages

2010-03-09 Thread Luke Kanies
On Mar 9, 2010, at 7:56 PM, Nigel Kersten wrote: On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies l...@reductivelabs.com wrote: On Mar 9, 2010, at 5:09 AM, Michael DeHaan wrote: { facts: { network: { interface: eth0, ip: 192.168.0.1, netmask: 255.255.255.0, }, disk: { name: sda1,

Re: [Puppet-dev] [PATCH] Add shell glob support to puppetrun, and also groups using /etc/puppet/hostgroups.txt (JSON format).

2010-03-09 Thread Paul Nasrat
On 9 March 2010 22:08, Michael DeHaan mich...@reductivelabs.com wrote: Also cleaned up a few error messages (unrelated) ---  lib/puppet/application/puppetrun.rb |   12 ++-  lib/puppet/daemon.rb                |    2 +-  lib/puppet/network/server.rb        |    2 +-  

Re: [Puppet-dev] Idea about sourcing facts from other languages

2010-03-09 Thread Paul Nasrat
On 10 March 2010 03:56, Nigel Kersten nig...@google.com wrote: On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies l...@reductivelabs.com wrote: On Mar 9, 2010, at 5:09 AM, Michael DeHaan wrote: {  facts: {  network: {    interface: eth0,    ip: 192.168.0.1,    netmask: 255.255.255.0,  },  

Re: [Puppet-dev] Idea about sourcing facts from other languages

2010-03-09 Thread Luke Kanies
On Mar 9, 2010, at 10:35 PM, Paul Nasrat wrote: On 10 March 2010 03:56, Nigel Kersten nig...@google.com wrote: On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies l...@reductivelabs.com wrote: On Mar 9, 2010, at 5:09 AM, Michael DeHaan wrote: { facts: { network: { interface: eth0, ip:

Re: [Puppet-dev] Idea about sourcing facts from other languages

2010-03-09 Thread Paul Nasrat
On 10 March 2010 06:41, Luke Kanies l...@reductivelabs.com wrote: On Mar 9, 2010, at 10:35 PM, Paul Nasrat wrote: On 10 March 2010 03:56, Nigel Kersten nig...@google.com wrote: On Tue, Mar 9, 2010 at 5:52 PM, Luke Kanies l...@reductivelabs.com wrote: On Mar 9, 2010, at 5:09 AM, Michael