Re: [Puppet-dev] [PATCH/puppet 1/1] Fixes #3395 - CR+LF line endings in manifests cause syntax error

2010-06-16 Thread Paul Nasrat
On 15 June 2010 18:26, James Turnbull ja...@lovedthanlost.net wrote: Thanks to Alan Barrett for the patch I know it's a trivial change but shouldn't it have a test. Paul Signed-off-by: James Turnbull ja...@lovedthanlost.net ---  lib/puppet/parser/lexer.rb |    2 +-  1 files changed, 1

Re: [Puppet-dev] [PATCH/puppet 1/1] [#4006] Fix test failures caused by reverting ticket 2890

2010-06-16 Thread Markus Roberts
+1. On Tue, Jun 15, 2010 at 4:04 PM, Matt Robinson m...@puppetlabs.com wrote: When Markus reverted changes made by 2890 he reintroduced a method certificate_matches_key? that then caused failures in network/xmlrpc/client.rb. I just stubbed that method to return true since the failing tests

[Puppet-dev] [PATCH/facter 1/1] Preliminary recoding of ipaddress6.

2010-06-16 Thread Cody Herriges
My preliminary work on a new fact that reports IPv6 addresses. Since IPv6 interfaces have a link local address even after obtaining a routable address the original ipaddress fact code that I had simply modified slightly isn't going to work the way I want it to. Everything but the Darwin

Re: [Puppet-dev] [PATCH/puppet 1/1] [#3866] Rename the method metaclass to singleton_class to avoid the deprecation warnings from Rails ActiveSupport

2010-06-16 Thread Luke Kanies
Isn't it a bad idea to make this fix in 0.25.5? That is, this isn't a real bug, is it? If not, then thixing this breaks people's expectations for this release cycle. On Jun 16, 2010, at 1:32 PM, Matt Robinson wrote: I fixed this in a commit for 0.25.x branch, but there were some files

[Puppet-dev] Git commit message hooks

2010-06-16 Thread Matt Robinson
Attached are a couple git hooks written in Ruby with the aim of standardizing commit messages so that we know how they're associated with redmine tickets. - prepare-commit-msg - get the ticket number off the branch name and prepend it to the commit message - commit-msg - reject the

Re: [Puppet-dev] [PATCH/facter 1/1] Preliminary recoding of ipaddress6.

2010-06-16 Thread Daniel Pittman
Cody Herriges c.a.herri...@gmail.com writes: My preliminary work on a new fact that reports IPv6 addresses. It looks like this reports *an* IPv6 address, not multiple IPv6 addresses, even though every adapter / host has at least one, and ofter multiple, these days. You should report all the