[Puppet-dev] [PATCH/puppet-dashboard 1/3] Fix 'debian/rules' to install the 'bin' directory.

2010-10-07 Thread Igal Koshevoy
Signed-off-by: Igal Koshevoy i...@pragmaticraft.com --- ext/packaging/debian/rules |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ext/packaging/debian/rules b/ext/packaging/debian/rules index e932e79..173959d 100755 --- a/ext/packaging/debian/rules +++

[Puppet-dev] [PATCH/puppet-dashboard 3/3] (#4513) Improve packaging tasks to show path to newly-created packages.

2010-10-07 Thread Igal Koshevoy
Signed-off-by: Igal Koshevoy i...@pragmaticraft.com --- lib/tasks/package.rake |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/lib/tasks/package.rake b/lib/tasks/package.rake index 1e58e57..c2b5e41 100644 --- a/lib/tasks/package.rake +++ b/lib/tasks/package.rake

[Puppet-dev] [PATCH/puppet-dashboard 2/3] (#4513) Improve `rake package:deb package:rpm` to not use Rails environment.

2010-10-07 Thread Igal Koshevoy
The packaging tasks used to load the entire Rails environment, which forced the user running them to configure things like 'database.yml'. This is no longer needed. Signed-off-by: Igal Koshevoy i...@pragmaticraft.com --- lib/tasks/package.rake |4 ++-- 1 files changed, 2 insertions(+), 2

[Puppet-dev] [PATCH/facter 1/1] Issue #4889 Fact values should all be strings

2010-10-07 Thread Paul Nasrat
Fix is_virtual fact to return strings rather than bools. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/virtual.rb |4 ++-- spec/unit/virtual.rb | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/facter/virtual.rb

Re: [Puppet-dev] [PATCH/facter 1/1] Issue #4889 Fact values should all be strings

2010-10-07 Thread Markus Roberts
I'd suggest defining: Virtual_systems = %w{ xenu openvzve vmware kvm vserver jail } and then writing     setcode do         Virtual_systems.include?(Facter.value(:virtual)).to_s  end or setcode do #{Virtual_systems.include? Facter.value(:virtual)} end instead of

[Puppet-dev] [PATCH/facter 1/1] Make sure FreeBSD spec also works on systems that have /proc/cpuinfo.

2010-10-07 Thread Paul Nasrat
From: Hans de Graaff h...@degraaff.org Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/unit/util/virtual.rb |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/spec/unit/util/virtual.rb b/spec/unit/util/virtual.rb index 1e31a2f..cc528d1 100644 ---

[Puppet-dev] Re: [PATCH/facter 1/1] Make sure FreeBSD spec also works on systems that have /proc/cpuinfo.

2010-10-07 Thread Paul Nasrat
On 7 October 2010 10:23, Paul Nasrat pnas...@gmail.com wrote: From: Hans de Graaff h...@degraaff.org Signed-off-by: Paul Nasrat pnas...@googlemail.com +1 tested on Linux machine. Paul -- You received this message because you are subscribed to the Google Groups Puppet Developers group. To

[Puppet-dev] Problem with latest commit in facter.git/next (f4da528)

2010-10-07 Thread Jacob Helwig
Rein, It looks like you accidentally removed a little too much in f4da528 when fixing the bad merge conflict resolution from dce8f57. I'm pretty sure that the exit was supposed to be there, and only the rescue was supposed to go. -- Jacob Helwig signature.asc Description: Digital signature

Re: [Puppet-dev] [PATCH/puppet-dashboard 2/3] (#4513) Improve `rake package:deb package:rpm` to not use Rails environment.

2010-10-07 Thread Jacob Helwig
+1 this works for me, when I move my config/database.yml aside. -- Jacob Helwig On Wed, 06 Oct 2010 23:09:42 -0700, Igal Koshevoy wrote: Date: Wed, 6 Oct 2010 23:09:42 -0700 From: Igal Koshevoy i...@pragmaticraft.com To: puppet-dev@googlegroups.com Cc: Igal Koshevoy i...@pragmaticraft.com

[Puppet-dev] Re: Problem with latest commit in facter.git/next (f4da528)

2010-10-07 Thread Jacob Helwig
On Thu, 07 Oct 2010 10:41:34 -0700, Jacob Helwig wrote: Rein, It looks like you accidentally removed a little too much in f4da528 when fixing the bad merge conflict resolution from dce8f57. I'm pretty sure that the exit was supposed to be there, and only the rescue was supposed to go.

Re: [Puppet-dev] [PATCH/puppet-dashboard 3/3] (#4513) Improve packaging tasks to show path to newly-created packages.

2010-10-07 Thread Jacob Helwig
I'd rather see the path for the RPMs built using the defined value from the macros, since the ouput directory is completely dependent upon the ~/.rpmmacros file, and not hard-coded like we do with the debs. Patches replacing this one to follow shortly. -- Jacob Helwig On Wed, 06 Oct 2010

[Puppet-dev] [PATCH/puppet-dashboard 2/3] (#4513) Update all references to ~/.rpmmacros controlled dirs to use rpm_macro_value

2010-10-07 Thread Jacob Helwig
Some of the directories for building RPMs were hard-coded, and others were using rpmbuild directly to get the value. Update all of these places to use the rpm_macro_value helper to get the actual directory used by rpmbuild. Signed-off-by: Jacob Helwig ja...@puppetlabs.com ---

[Puppet-dev] [PATCH/puppet-dashboard 1/3] (#4513) Add helper to resolve rpm macros for packaging rake tasks

2010-10-07 Thread Jacob Helwig
Signed-off-by: Jacob Helwig ja...@puppetlabs.com --- lib/tasks/package.rake |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/lib/tasks/package.rake b/lib/tasks/package.rake index 1e58e57..2535a9c 100644 --- a/lib/tasks/package.rake +++ b/lib/tasks/package.rake @@

[Puppet-dev] [PATCH/puppet-dashboard 3/3] (#4513) Output the full file path to the built packages in the packaging rake tasks.

2010-10-07 Thread Jacob Helwig
Signed-off-by: Jacob Helwig ja...@puppetlabs.com --- lib/tasks/package.rake |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/lib/tasks/package.rake b/lib/tasks/package.rake index 04d729f..7edcdad 100644 --- a/lib/tasks/package.rake +++ b/lib/tasks/package.rake @@

[Puppet-dev] ANNOUNCE: Puppet 2.6.2 released!

2010-10-07 Thread James Turnbull
And we're back with another exiting release in the 2.6.x branch - 2.6.2. 2.6.2 is a maintenance release in the 2.6.x branch and it contains bug fixes, maintenance and a small number of features (see Release Notes below). We've included release notes below that you can also see at:

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4573) FreeBSD service provider now supports versions 7 and 8

2010-10-07 Thread Russell Jackson
On 10/04/2010 05:12 PM, Matt Robinson wrote: +1 having paired with Nick on this, although I'd very much like to see that Russell or someone else using FreeBSD test this patch. We rewrote some of the regexes from the patches that Russell submitted to make them more readable, and we wrote tests

Re: [Puppet-dev] [PATCH/puppet 1/1] [#4590] SimpleGraph is slow

2010-10-07 Thread Paul Berry
Ok, I've squashed the following changes into the branch. I believe this addresses all the issues Jesse and I found in our code review. Regarding the downstream_from_vertex and upstream_from_vertex, I stuck with the rewrite Jesse and I suggested because (a) there seemed to be a loose majority in

Re: [Puppet-dev] [PATCH/puppet-dashboard 3/3] (#4513) Improve packaging tasks to show path to newly-created packages.

2010-10-07 Thread Igal Koshevoy
Jacob: +1. Good changes. I've reviewed your code, built new packages and confirmed that they work. I've merged these into `next`. -igal On Thu, Oct 7, 2010 at 11:50 AM, Jacob Helwig ja...@puppetlabs.com wrote: I'd rather see the path for the RPMs built using the defined value from the macros,

Re: [Puppet-dev] [PATCH/puppet-dashboard 1/3] Fix 'debian/rules' to install the 'bin' directory.

2010-10-07 Thread Jacob Helwig
+1 for this. Thanks for catching it, Igal. -- Jacob Helwig On Wed, 06 Oct 2010 23:09:41 -0700, Igal Koshevoy wrote: Date: Wed, 6 Oct 2010 23:09:41 -0700 From: Igal Koshevoy i...@pragmaticraft.com To: puppet-dev@googlegroups.com Cc: Igal Koshevoy i...@pragmaticraft.com Subject:

[Puppet-dev] Weekend Maintenance

2010-10-07 Thread Zach Leslie
All, On Saturday, October 9th, Puppet Labs will be performing site maintenance which may impact web services for a brief period. The purpose of this maintenance is to enable SSL authentication for projects.puppetlabs.com. We apologize for any inconvenience. Thank you. -- Zach

Re: [Puppet-dev] [PATCH/puppet 1/1] [#4590] SimpleGraph is slow

2010-10-07 Thread Markus Roberts
Ok, I've squashed the following changes into the branch.  I believe this addresses all the issues Jesse and I found in our code review. Regarding the downstream_from_vertex and upstream_from_vertex, I stuck with the rewrite Jesse and I suggested because (a) there seemed to be a loose majority

[Puppet-dev] [PATCH/puppet-dashboard 1/1] (#4513) Add support for specifying the signing key id in the deb packaging rake task

2010-10-07 Thread Jacob Helwig
Signed-off-by: Jacob Helwig ja...@puppetlabs.com --- Also available in: git://github.com/jhelwig/puppet-dashboard.git ticket/next/4513 lib/tasks/package.rake |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/tasks/package.rake b/lib/tasks/package.rake index

Re: [Puppet-dev] [PATCH/puppet-dashboard 1/1] (#4513) Add support for specifying the signing key id in the deb packaging rake task

2010-10-07 Thread Igal Koshevoy
+1 with the following fixes and improvements to the documentation. Had Jacob review the changes in person. Merged into `next`. -igal ### diff --git a/lib/tasks/package.rake b/lib/tasks/package.rake index 8626f19..c3bd76c 100644 --- a/lib/tasks/package.rake +++ b/lib/tasks/package.rake @@ -1,5

[Puppet-dev] [PATCH/puppet 1/1] Fix for #3984 -- SELinux warns about changes it doesn't actually make

2010-10-07 Thread Markus Roberts
Volumes that don't suport SELinux should be considered in_sync so they don't generate spurious change notice. Patch from Darrell Fuhriman Signed-off-by: Markus Roberts mar...@reality.com --- lib/puppet/type/file/selcontext.rb |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-)

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4573) FreeBSD service provider now supports versions 7 and 8

2010-10-07 Thread Matt Robinson
Awesome, thanks for testing Russell. I'll set this ticket as ready to commit. On Thu, Oct 7, 2010 at 1:28 PM, Russell Jackson r...@csub.edu wrote: On 10/04/2010 05:12 PM, Matt Robinson wrote: +1 having paired with Nick on this, although I'd very much like to see that Russell or someone else