Re: [Puppet-dev] [PATCH/puppet 2/2] Fix #4339 - Allow puppet apply to save last run summary

2010-11-13 Thread Brice Figureau
On 12/11/10 18:56, R.I.Pienaar wrote: - James Turnbull ja...@puppetlabs.com wrote: Brice Figureau wrote: On 12/11/10 16:58, James Turnbull wrote: Brice Figureau wrote: Either use --report or --save-last-run-summary to trigger saving $statedir/last_run_summary.yaml. I'd just make

Re: [Puppet-dev] [PATCH/facter 1/1] Maint: add Local-branch: info to mails sent by rake mail_patches

2010-11-13 Thread Paul Nasrat
+1 On 12 November 2010 18:27, Paul Berry p...@puppetlabs.com wrote: Signed-off-by: Paul Berry p...@puppetlabs.com --- Local-branch: maint/next/add_local_branch_to_mail_patches  tasks/rake/mail_patches.rake |   13 -  1 files changed, 12 insertions(+), 1 deletions(-) diff --git

Re: [Puppet-dev] [PATCH/puppet 2/2] Fix #4339 - Allow puppet apply to save last run summary

2010-11-13 Thread Brice Figureau
On 13/11/10 10:47, Brice Figureau wrote: On 12/11/10 18:56, R.I.Pienaar wrote: - James Turnbull ja...@puppetlabs.com wrote: Brice Figureau wrote: On 12/11/10 16:58, James Turnbull wrote: Brice Figureau wrote: Either use --report or --save-last-run-summary to trigger saving

[Puppet-dev] [PATCH/puppet 1/1] (#5274) Hostprovider shouldnt remove inlinecomments

2010-11-13 Thread Stefan Schulte
When the parsefile provider for host parses /etc/hosts it throws any inlinecomment away. As a result they are also purged in /etc/hosts after a puppetrun that detects a change. That could be dangerous because you will lose information even about unmanaged resources. So if you have something like

Re: [Puppet-dev] [PATCH/puppet 1/1] (#5274) Hostprovider shouldnt remove inlinecomments

2010-11-13 Thread Stefan Schulte
While looking at the current host type and provider I had a few questions: Is the retrieve method necessary in the host type? lib/puppet/type/host.rb: def retrieve is = super case is when String is = is.split(/\s*,\s*/) when Symbol is = [is] when Array # nothing else

[Puppet-dev] GitHub reductivelabs account deleted

2010-11-13 Thread James Turnbull
Hi all As the last step in our GitHub migration the reductivelabs account has been deleted. Please now use the Puppet Labs account: https://github.com/puppetlabs Regards James Turnbull -- Puppet Labs - http://www.puppetlabs.com C: 503-734-8571 -- You received this message because you are

Re: [Puppet-dev] [PATCH/puppet 2/2] Fix #4339 - Allow puppet apply to save last run summary

2010-11-13 Thread Luke Kanies
On Nov 13, 2010, at 2:37, Brice Figureau brice-pup...@daysofwonder.com wrote: On 13/11/10 10:47, Brice Figureau wrote: On 12/11/10 18:56, R.I.Pienaar wrote: - James Turnbull ja...@puppetlabs.com wrote: Brice Figureau wrote: On 12/11/10 16:58, James Turnbull wrote: Brice Figureau

Re: [Puppet-dev] [PATCH/puppet 2/2] Fix #4339 - Allow puppet apply to save last run summary

2010-11-13 Thread James Turnbull
Luke Kanies wrote: On a related note, what do people think of enabling 'report' by default? I think it should default to true. I nearly made this change the other day. +1. In fact see the subsequent patch :) This is much like the hasstatus change - we should review all the settings to work

[Puppet-dev] [PATCH/puppet 1/1] Fixed #5287 - Schedule documentation is incorrect

2010-11-13 Thread James Turnbull
Signed-off-by: James Turnbull ja...@lovedthanlost.net --- lib/puppet/type/schedule.rb | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/puppet/type/schedule.rb b/lib/puppet/type/schedule.rb index ff3fba8..82f17e5 100755 --- a/lib/puppet/type/schedule.rb +++

Re: [Puppet-dev] [PATCH/puppet 1/1] Fixed #5288 - Changed report default to true

2010-11-13 Thread Nigel Kersten
On Sat, Nov 13, 2010 at 2:17 PM, James Turnbull ja...@lovedthanlost.net wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net Local-branch: tickets/next/5288 ---  lib/puppet/defaults.rb |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/puppet/defaults.rb

[Puppet-dev] [PATCH/puppet 1/1] Fix #5289 -- Bad copy/paste changes message on test failure

2010-11-13 Thread Markus Roberts
In my fix for #4894 (commit a097b939ab52bafb681cf7c5dcaf11717add07e6) I made and tested the fix in one case and then copied most of it (all but a variable initialization, Doh!) to two other locations. This caused tests that would have failed with a socket-in-use error to fail with a different

Re: [Puppet-dev] [PATCH/puppet 1/1] Fix #5289 -- Bad copy/paste changes message on test failure

2010-11-13 Thread Matt Robinson
+1. Note that whoever merges this into next or master will have merge conflicts with my patch for the same ticket. On Sat, Nov 13, 2010 at 9:26 PM, Markus Roberts mar...@reality.com wrote: In my fix for #4894 (commit a097b939ab52bafb681cf7c5dcaf11717add07e6) I made and tested the fix in one

Re: [Puppet-dev] [PATCH/puppet 1/1] Fix #4911 - Do not generate doc for standard RDoc parser generated object

2010-11-13 Thread Matt Robinson
I've added the ticket #5290. On Fri, Nov 12, 2010 at 1:43 AM, Brice Figureau brice-pup...@daysofwonder.com wrote: Hi Matt, On 12/11/10 04:13, Matt Robinson wrote: Brice, I see you haven't had time to write tests for this patch, and I understand it's not very high priority.  I'd hate to see