[Puppet-dev] [PATCH/facter 1/1] (#4754) Add support for Darwin and Parallels VM to virtual fact

2010-11-18 Thread donavanm
From: Donavan Miller dona...@strewth.org Adds support for Parallels VM guest detection with existing operating systems. Detects Parallels based on hardware vendor name and pci id. The Parallels vendor id does not seem to be listed in most pci.ids. Adds resolution for virtual fact in the Darwin

[Puppet-dev] Re: (#4754) Add support for Darwin and Parallels VM to virtual fact

2010-11-18 Thread donavan
In order to address #4754 I added support for virtual fact on Darwin. Though it's not in the ticket I added support for Darwin in VMware as well. There are a few spots that look for vendor pci ids in addition to names. Some tools resolve the vendor name, some don't. For Parallels they seem to be

Re: [Puppet-dev] [PATCH/facter 1/1] (#4754) Add support for Darwin and Parallels VM to virtual fact

2010-11-18 Thread Paul Nasrat
On 18 November 2010 10:13, donavanm dona...@desinc.net wrote: From: Donavan Miller dona...@strewth.org Adds support for Parallels VM guest detection with existing operating systems. Detects Parallels based on hardware vendor name and pci id. The Parallels vendor id does not seem to be

Re: [Puppet-dev] [PATCH/facter 1/1] (#4754) Add support for Darwin and Parallels VM to virtual fact

2010-11-18 Thread David Schmitt
On 11/18/2010 11:13 AM, donavanm wrote: @@ -80,11 +103,11 @@ Facter.add(virtual) do end Facter.add(is_virtual) do -confine :kernel = %w{Linux FreeBSD OpenBSD SunOS HP-UX} +confine :kernel = %w{Linux FreeBSD OpenBSD SunOS HP-UX Darwin} setcode do case

Re: [Puppet-dev] [PATCH/facter 1/1] (#4754) Add support for Darwin and Parallels VM to virtual fact

2010-11-18 Thread Paul Nasrat
On 18 November 2010 14:07, David Schmitt da...@dasz.at wrote: On 11/18/2010 11:13 AM, donavanm wrote: @@ -80,11 +103,11 @@ Facter.add(virtual) do  end  Facter.add(is_virtual) do -    confine :kernel =  %w{Linux FreeBSD OpenBSD SunOS HP-UX} +    confine :kernel =  %w{Linux FreeBSD OpenBSD

[Puppet-dev] [PATCH/puppet-dashboard 3/3] maint: Remove useless test

2010-11-18 Thread Matt Robinson
There was a test asserting that a flash message was created. The flash message is automagically created by InheritedResources, but even worse it doesn't display anywhere on the site. I created ticket #5352 to address the further problems with flash messages. Paired-with: Nick Lewis

[Puppet-dev] [PATCH/puppet-dashboard 1/3] maint: Remove dead code and cleanup whitespace

2010-11-18 Thread Matt Robinson
Signed-off-by: Matt Robinson m...@puppetlabs.com --- Local-branch: ticket/next/5120 app/helpers/application_helper.rb | 10 +- app/views/nodes/_actions.html.haml | 27 --- app/views/nodes/_node.html.haml | 16

[Puppet-dev] [PATCH/puppet-dashboard 2/3] (#5120) Disable editing nodes when external node classification is disabled

2010-11-18 Thread Matt Robinson
Also made controller methods for groups and classes raise 403 so that url hacking isn't possible. Paired-with: Paul Berry p...@puppetlabs.com Reviewed-by: Nick Lewis n...@puppetlabs.com Signed-off-by: Matt Robinson m...@puppetlabs.com --- Local-branch: ticket/next/5120

[Puppet-dev] [PATCH/puppet-dashboard 1/1] maint: Suppress ActiveSupport deprecation warnings

2010-11-18 Thread Nick Lewis
Paired-With: Matt Robinson Signed-off-by: Nick Lewis n...@puppetlabs.com --- Local-branch: maint/next/suppress_active_support_deprecation_warnings config/environment.rb |2 +- lib/settings_reader.rb |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Puppet-dev] [PATCH/puppet-dashboard 2/2] (#4623) Sort timeline_events in the order they were created

2010-11-18 Thread Nick Lewis
Previously, they were being sorted by created_at, which is not high enough resolution to distinguish the order in which events happened. Paired-With: Matt Robinson Signed-off-by: Nick Lewis n...@puppetlabs.com --- Local-branch: ticket/next/4623 app/models/timeline_event.rb |2 +- 1 files

[Puppet-dev] [PATCH/puppet-dashboard 1/2] (#4623) Define comparator for NodeGroup and NodeClass

2010-11-18 Thread Nick Lewis
Views were breaking because they were trying to sort NodeClasses, which had no comparison operator defined. This patch defines it to sort by name, corresponding to the default_scope. Paired-With: Matt Robinson Signed-off-by: Nick Lewis n...@puppetlabs.com --- Local-branch: ticket/next/4623

[Puppet-dev] [PATCH/puppet 1/1] (#5274) Fixed some rake unit tests that were inadvertently broken by commit:ee7d2f92f9d3ec45b5c3a9cd3fe2f5832b17f23b

2010-11-18 Thread Paul Berry
Signed-off-by: Paul Berry p...@puppetlabs.com --- test/ral/providers/host/parsed.rb |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/test/ral/providers/host/parsed.rb b/test/ral/providers/host/parsed.rb index c2367d5..955edd5 100755 ---

[Puppet-dev] [PATCH/puppet 1/1] Maint: Modified rake spec so that it prints full backtraces.

2010-11-18 Thread Paul Berry
Signed-off-by: Paul Berry p...@puppetlabs.com --- Local-branch: maint/next/rake_spec_backtraces Rakefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Rakefile b/Rakefile index 8e21ceb..22d4a9a 100644 --- a/Rakefile +++ b/Rakefile @@ -43,7 +43,7 @@ desc Create the

[Puppet-dev] [PATCH/puppet 3/4] (#5274) New tests for new hosttype/parsedprovider

2010-11-18 Thread Stefan Schulte
Just a few additional tests for the new property comment of the host type. Signed-off-by: Stefan Schulte stefan.schu...@taunusstein.net --- spec/unit/provider/host/parsed_spec.rb | 44 spec/unit/type/host_spec.rb|2 +- 2 files changed, 45

[Puppet-dev] [PATCH/puppet 2/4] (#5274) New comment property for the hosttype

2010-11-18 Thread Stefan Schulte
When the parsefile provider for host parses /etc/hosts, it throws any inlinecomment away. As a result they are also purged in /etc/hosts after a puppetrun that detects a change. That could be dangerous because you will lose information even about unmanaged resources. So if you have something like

[Puppet-dev] [PATCH/puppet 4/4] (#5274) Using Propery::OrderedList for host_alias

2010-11-18 Thread Stefan Schulte
This uses the propertyclass Puppet::Property::OrderedList to represent the list of host_aliases. This lets us remove the in_sync, shoult_to_s etc overrides. The new membership paramater can even be used to just specify a minimal list of host_aliases (but default is inclusive). In the provider

[Puppet-dev] [PATCH/puppet 3/3] Maint: Added assertion to make sure Log.close_all succeeds

2010-11-18 Thread Paul Berry
If the hash containing log destinations gets corrupted, Log.close_all could fail silently. This change adds an exception to make these failures easier to debug should they ever happen again. Signed-off-by: Paul Berry p...@puppetlabs.com --- Local-branch: maint/next/log_refactoring

[Puppet-dev] [PATCH/puppet 1/3] Maint: Improved spec tests

2010-11-18 Thread Paul Berry
In configurer_spec.rb, replaced some mock classes with actual Puppet::Transaction::Report objects. In log_spec.rb, stopped using the Array type as a log destination, since doing so was unreliable. Signed-off-by: Paul Berry p...@puppetlabs.com --- Local-branch: maint/next/log_refactoring

[Puppet-dev] [PATCH/puppet 2/3] Maint: Switched spec tests to use a class rather than Array as the log destination.

2010-11-18 Thread Paul Berry
Using an Array as a log destination is unreliable because Puppet's log mechanism stores log destinations in a hash whose key is the destination itself. Since arrays can change their hash when they are modified, this was causing the log destination hash to become corrupted, producing sporadic spec

[Puppet-dev] Delete this thread

2010-11-18 Thread Stefan Schulte
I'm sorry I didnt want to open yet another thread with patches that are already posted on the list. When git asked me to send the patches and I answered NO it just ommited the summary page. So please delete this thread. -Stefan pgpjatiDsH6kC.pgp Description: PGP signature

Re: [Puppet-dev] [PATCH/puppet 1/1] (#5274) Hostprovider shouldnt remove inlinecomments Update

2010-11-18 Thread Stefan Schulte
On Thu, Nov 18, 2010 at 12:02:02AM +0100, Stefan Schulte wrote: https://github.com/stschulte/puppet/tree/ticket%2F2.6.x%2F5274 I split up the changes in three commits Nick sent the first three patches to puppet-dev. I now commited a forth patch to use Puppet::Property::OrderedList instead

[Puppet-dev] [PATCH/puppet-dashboard 1/1] Feature #5117: custom_logo_url will replace the Puppet Dashboard logo

2010-11-18 Thread Jesse Wolfe
Added a configuration setting that will replace the Puppet Dashboard logo with any arbitrary image. Signed-off-by: Jesse Wolfe jes5...@gmail.com --- Local-branch: ticket/next/5117 app/views/shared/_global_nav.html.haml |6 +- config/settings.yml.example |3 +++