[Puppet-dev] [PATCH/puppet 1/1] Reverted a portion of #4149 because it broke --parseonly totally.

2010-12-01 Thread James Turnbull
See #5081 for further information. This probably isn't the right fix but the current fix has broken numerous people's parseonly hooks etc. Signed-off-by: James Turnbull ja...@lovedthanlost.net --- lib/puppet/application/apply.rb |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[Puppet-dev] [PATCH/puppet 1/1] Reverted a portion of #4149 because it broke --parseonly totally.

2010-12-01 Thread James Turnbull
See #5081 for further information. This probably isn't the right fix but the current fix has broken numerous people's parseonly hooks etc. Signed-off-by: James Turnbull ja...@lovedthanlost.net --- lib/puppet/application/apply.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[Puppet-dev] Re: Bug #5423: This moves the home directory property before the uid property, thus minimizing room for damage when usermod is in use.

2010-12-01 Thread sayjonathan
On Nov 30, 10:19 pm, James Turnbull ja...@puppetlabs.com wrote: Jonathan wrote: James- I literally said those exact words. But on a whim I changed then order and it works correctly, every time. I haven't had a chance to dig deeper yet, so I'm not sure if the issue is in the namespace

Re: [Puppet-dev] [PATCH/puppet 0/8] Experimental Plugable Puppet Authentication System

2010-12-01 Thread Brice Figureau
Hi, As I said in preamble this is an experimental work toward a fully pluggable authentication system. This first part only extracts the SSL stuff. On Tue, 2010-11-30 at 15:41 -0800, Nick Lewis wrote: Thanks for your contribution. Matt Robinson and I looked your patch over, and have a few

[Puppet-dev] New parameters for AIX in user and group type

2010-12-01 Thread Héctor Rivas Gándara
Hello, To manage AIX users and groups a pair of new parameters should be defined, specially registry, SYSTEM, and auth1/auth2. auth1 (and auth2) Lists the primary methods for authenticating the user. The Value parameter is a comma-separated list of Method;Name

[Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Dominic Cleal
Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before. Standard units provided are B and MB. Signed-off-by: Dominic Cleal dcl...@redhat.com --- Local-branch: tickets/master/2066 lib/facter/memory.rb |

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Dominic Cleal
On 01/12/10 10:32, Dominic Cleal wrote: Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before. Please note that this conflicts with the patch I submitted yesterday for #1423 (Solaris memory facts), but I

Re: [Puppet-dev] Class ProviderAixuseradd is already defined in Puppet::Type::User

2010-12-01 Thread Héctor Rivas Gándara
I tried to remove the require, but it fails: err: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: Could not autoload user: Could not autoload /srv/puppet/var/lib/puppet/provider/user/aix.rb: uninitialized constant

Re: [Puppet-dev] [PATCH/facter 1/1] (#2066) Make units optional

2010-12-01 Thread Paul Nasrat
On 1 December 2010 10:49, Dominic Cleal dcl...@redhat.com wrote: On 01/12/10 10:32, Dominic Cleal wrote: Memory and swap values are now given in standard units via additional facts (e.g. memorysize_mb) as well as the most appropriate unit as before. Please note that this conflicts with the

[Puppet-dev]

2010-12-01 Thread Peter Meier
Hi so this is my attempt to fix #5392 (with a little refactor that caught my attention). It does not contain any tests, because while writing possible tests it became less and less clear whether this is actually the right fix at the right place. For the record: it fixes my problem in my

[Puppet-dev] [PATCH/puppet 2/2] fix #5392 - do not evaluate empty collections

2010-12-01 Thread Peter Meier
If no resources were exported for a given type, when we collected this empty resource set no resource_type was found internally. We now abort the evaluation if no type is found. Signed-off-by: Peter Meier peter.me...@immerda.ch --- lib/puppet/parser/ast/collection.rb |1 + 1 files changed, 1

[Puppet-dev] [PATCH/puppet 1/2] refactoring towards fixing #5392

2010-12-01 Thread Peter Meier
Why do another assignment and loop, when we can use a simple compact? Signed-off-by: Peter Meier peter.me...@immerda.ch --- lib/puppet/parser/ast/astarray.rb |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/lib/puppet/parser/ast/astarray.rb

[Puppet-dev] Another try to implement #1886

2010-12-01 Thread Peter Meier
Hi all, recently I had to cleanup various old hosts and also wanted to cleanup their exported resources. I remembered that brice hacked once on something, but it looks like it never got into the core. So I took Brice's initial work, ported it over to the new 2.6.x style, fixed some bugs, added

[Puppet-dev] [PATCH/puppet 1/5] Fix #1886 - Add node cleanup capability

2010-12-01 Thread Peter Meier
From: Brice Figureau brice-pup...@daysofwonder.com Here is a changeset that adds a new puppet application to the puppet application portfolio: puppetcleaner. This application removes all traces of a node on the puppetmaster (including certs, cached facts and nodes, reports, and storedconfig

[Puppet-dev] [PATCH/puppet 2/5] Adding destroy method for Yaml indirector

2010-12-01 Thread Peter Meier
From: Brice Figureau brice-pup...@daysofwonder.com we already offer read access for the yaml, this changeset adds the destroy handler which only removes the yaml file for a request. This can be used to remove cached entries. Signed-off-by: Brice Figureau brice-pup...@daysofwonder.com

[Puppet-dev] [PATCH/puppet 3/5] Add a destroy method for the various reports processor types.

2010-12-01 Thread Peter Meier
From: Brice Figureau brice-pup...@daysofwonder.com Yet, only the store reports has an implementation. Signed-off-by: Brice Figureau brice-pup...@daysofwonder.com Signed-off-by: Peter Meier peter.me...@immerda.ch --- lib/puppet/indirector/report/processor.rb | 10 +-

[Puppet-dev] [PATCH/puppet 4/5] Unlink only existing files

2010-12-01 Thread Peter Meier
To not blindly remove files and therefore maybe getting an exception we check first on the existance of the file. Signed-off-by: Peter Meier peter.me...@immerda.ch --- lib/puppet/indirector/yaml.rb |3 ++- spec/unit/indirector/yaml_spec.rb | 16 +++- 2 files changed, 13

Re: [Puppet-dev] Class ProviderAixuseradd is already defined in Puppet::Type::User

2010-12-01 Thread Luke Kanies
Huh. Ok. Thanks. On Dec 1, 2010, at 4:56 AM, Héctor Rivas Gándara wrote: I tried to remove the require, but it fails: err: Could not create resources for managing Puppet's files and directories in sections [:main, :agent, :ssl]: Could not autoload user: Could not autoload

Re: [Puppet-dev]

2010-12-01 Thread Luke Kanies
On Dec 1, 2010, at 6:39 AM, Peter Meier wrote: Hi so this is my attempt to fix #5392 (with a little refactor that caught my attention). It does not contain any tests, because while writing possible tests it became less and less clear whether this is actually the right fix at the right

Re: [Puppet-dev] [PATCH/puppet 1/2] refactoring towards fixing #5392

2010-12-01 Thread Luke Kanies
On Dec 1, 2010, at 6:39 AM, Peter Meier wrote: Why do another assignment and loop, when we can use a simple compact? Signed-off-by: Peter Meier peter.me...@immerda.ch --- lib/puppet/parser/ast/astarray.rb |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git

Re: [Puppet-dev] [PATCH/puppet 1/1] Bug #5423: This moves the home directory property before the uid property, thus minimizing room for damage when usermod is in use.

2010-12-01 Thread Luke Kanies
On Nov 30, 2010, at 7:15 PM, James Turnbull wrote: James Turnbull wrote: From: Jonathan Boyett jonat...@failingservers.com Jonathan I don't see why the order of the properties would make any difference to the way this applies. They are not executed in sequence from what I understand.

[Puppet-dev] SECURITY: Authorization vulnerability in Puppet 2.6.x

2010-12-01 Thread James Turnbull
The Puppet Labs team has identified a security vulnerability in Puppet version 2.6.0 and later. The vulnerability allows, under certain circumstances, authenticated Puppet nodes to be able to view or manipulate resources on other Puppet 2.6.x nodes, including the Puppet Master. Versions prior to

[Puppet-dev] ANNOUNCE: Puppet 2.6.4 released!

2010-12-01 Thread James Turnbull
Due to a security issue (see recent SECURITY email) we're releasing a 2.6.4 release immediately. 2.6.4 is a security release in the 2.6.x branch and it contains only the security related bug fixes and one update to copyright information. The release is available for download at:

[Puppet-dev] Re: [PATCH/puppet 1/1] Bug #5423: This moves the home directory property before the uid property, thus minimizing room for damage when usermod is in use.

2010-12-01 Thread saysjonathan
I don't see why the order of the properties would make any difference to the way this applies. They are not executed in sequence from what I understand. Properties actually are executed in the order in which they're defined, although I think we always special-case 'ensure' to make sure

Re: [Puppet-dev] Re: [PATCH/puppet 1/1] Bug #5423: This moves the home directory property before the uid property, thus minimizing room for damage when usermod is in use.

2010-12-01 Thread Luke Kanies
On Dec 1, 2010, at 2:21 PM, saysjonathan wrote: I don't see why the order of the properties would make any difference to the way this applies. They are not executed in sequence from what I understand. Properties actually are executed in the order in which they're defined, although I think

Re: [Puppet-dev] [PATCH/facter 2/2] (#4754) Change is_virtual logic to not enumerate virtual types

2010-12-01 Thread Paul Nasrat
On 30 November 2010 19:10, Matt Robinson m...@puppetlabs.com wrote: While looking at the patch for adding parallels to the virtual types David Schmitt noticed that it might be easier just to list the types that are NOT virtual since there's fewer of them. +1 Paul Paired-with: Nick Lewis

[Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet 2.6.4 released!

2010-12-01 Thread Todd Zullinger
James Turnbull wrote: Due to a security issue (see recent SECURITY email) we're releasing a 2.6.4 release immediately. For those using Fedora or RHEL/CentOS, I've updated the yum repos at: http://tmz.fedorapeople.org/repo/puppet/ Packages for EL 4 - 6 and Fedora 13 - 14 are available for

[Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet 2.6.4 released!

2010-12-01 Thread Nigel Kersten
On Wed, Dec 1, 2010 at 4:20 PM, Todd Zullinger t...@pobox.com wrote: James Turnbull wrote: Due to a security issue (see recent SECURITY email) we're releasing a 2.6.4 release immediately. For those using Fedora or RHEL/CentOS, I've updated the yum repos at:    

[Puppet-dev] [PATCH/puppet 1/1] [#5081] Revert Fix #4349 - Parsing with ignoreimport=true was always loading site.pp

2010-12-01 Thread Matt Robinson
The fix for #4349 caused --parse-only not to detect syntax errors when --ignore-import was used by adding a return statement that bypassed the initial import: commit 760e418d254a8d2198d2c6eb466d783a5930ef47 def perform_initial_import + return if Puppet.settings[:ignoreimport] The problem that

[Puppet-dev] p(0) - Minimal Puppet Language Subset

2010-12-01 Thread Luke Kanies
Hi all, Some have already noticed this, but I've begun a project to define and produce a minimal data-focused subset of Puppet's language, just like JSON is a data-focused subset of Javascript. I had initially called it MPF (for Minimal Puppet Format), but we've decided to use our internal

Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet 2.6.4 released!

2010-12-01 Thread Thomas S Hatch
On Wed, Dec 1, 2010 at 6:04 PM, Nigel Kersten ni...@puppetlabs.com wrote: On Wed, Dec 1, 2010 at 4:20 PM, Todd Zullinger t...@pobox.com wrote: James Turnbull wrote: Due to a security issue (see recent SECURITY email) we're releasing a 2.6.4 release immediately. For those using Fedora