On 9 March 2011 01:32, Adrien Thebo adr...@puppetlabs.com wrote:
- Adds support for Slamd64 and Bluewhite64 for the operatingsystem
fact
- Adds support for Slamd64 and Bluewhite64 for the
operatingsystemrelease fact
+1
The duplication is a bit of a code smell, we probably should
On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote:
Paul Nasrat wrote:
+1 been pending for too long
Was that a +1 on patches 2 and 3 in that series also? I largely rewrote
the whole fact.
Just on this, I need to review the arp fact in more depth. I think the
basic idea for the
On 8 March 2011 21:33, James Turnbull ja...@lovedthanlost.net wrote:
1. Added tested
2. Refactored to use F:U:R.exec
3. Chomp trailing newline
What happens if it gets output if no Current Mode line (think older,
think you're missing test/handling for that.
You've also changed the rule to
Paul Nasrat wrote:
You've also changed the rule to use Current mode not Mode from
config file, was this intentiional have you tested on rhel4, rhel5,
rhel6 and non-rhel selinux systems?
It seems like a different bug that the current fact was grepping
Policy from config file: from the sestatus
On 9 March 2011 14:00, Todd Zullinger t...@pobox.com wrote:
Paul Nasrat wrote:
You've also changed the rule to use Current mode not Mode from
config file, was this intentiional have you tested on rhel4, rhel5,
rhel6 and non-rhel selinux systems?
It seems like a different bug that the current
Paul Nasrat wrote:
On 9 March 2011 14:00, Todd Zullinger t...@pobox.com wrote:
Paul Nasrat wrote:
You've also changed the rule to use Current mode not Mode from
config file, was this intentiional have you tested on rhel4, rhel5,
rhel6 and non-rhel selinux systems?
It seems like a different
Paul Nasrat wrote:
On 8 March 2011 17:23, James Turnbull ja...@puppetlabs.com wrote:
Paul Nasrat wrote:
+1 been pending for too long
Was that a +1 on patches 2 and 3 in that series also? I largely rewrote
the whole fact.
Just on this, I need to review the arp fact in more depth. I think
This fixture is currently unused, largely due to the mount type being
based on parsedfile, which is incapable of parsing /etc/filesystems.
Paired-with: Daniel Pittman dan...@puppetlabs.com
Signed-off-by: Jacob Helwig ja...@puppetlabs.com
---
Local-branch:
On Mar 8, 2011, at 5:22 AM, Markus Roberts wrote:
- Vendor the json_shape library, a lightweight JSON schema validator
(https://github.com/jes5199/json_shape).
I'm fully in support of this proposal, with one caveat: The definition of
'vendor'. Do you mean creating a vendor directly in
Hi Juerg,
Thanks for the extra patches, comment below.
On 08/03/11 06:10, Juerg Walz wrote:
Local-branch: tickets/master/4258-dev
lib/puppet/provider/package/pkgutil.rb |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/lib/puppet/provider/package/pkgutil.rb
This had been conflating hosts and nodes, when nodes is the most accurate.
Signed-off-by: Nick Lewis n...@puppetlabs.com
---
.../indirector/facts/inventory_active_record.rb| 48 ++--
.../database/004_add_inventory_service_tables.rb | 18
This is not necessary because fact values are always strings, and it wasn't
doing the unnecessary job it was expected to do anyway.
Signed-off-by: Nick Lewis n...@puppetlabs.com
---
.../indirector/facts/inventory_active_record.rb|3 ---
lib/puppet/rails/inventory_fact.rb
Also worth noting that ActiveRecord 3 had problems doing simple
matching queries when the data was serialized, which caused basic spec
tests to fail. It serialized the data going into the database, but if
you did a string comparison query it didn't deserialize before doing
the comparison. Nick,
Reviewed-by: Nick Lewis n...@puppetlabs.com
Signed-off-by: Jesse Wolfe jes5...@gmail.com
---
Local-branch: t/next/6656
app/views/nodes/_inventory_service.html.haml |2 +-
app/views/shared/_node_manager_sidebar.html.haml |2 +-
config/settings.yml.example |3
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I've deliberately changed this because the original use of mode from
policy is totally wrong IMHO. I've reached out to the original author
for some feedback on why he chose that but I suspect if anyone is using
it (and I doubt it) the change
Peter Meier wrote:
I've deliberately changed this because the original use of mode from
policy is totally wrong IMHO. I've reached out to the original author
for some feedback on why he chose that but I suspect if anyone is using
it (and I doubt it) the change won't be substantive as you
We're squashing the following changes into this commit to
1) fix a failing spec
2) add some more behavior-driven tests into the specs
Otherwise, +1
diff --git a/spec/unit/provider/user/user_role_add_spec.rb
b/spec/unit/provider/user/user_role_add_spec.rb
index 9cf6492..f739423 100644
---
You can reproduce the error with a simple manifest
Bogus_type | title == 'foo' |
We used to fail because find_resource_type returned nil and we never
checked if it was nil before calling methods on it.
Reviewed-by: Max Martin m...@puppetlabs.com
Signed-off-by: Matt Robinson
This maintenance release fixes two issues with Puppet 2.6.5.
Bug #6418: Files with the source parameter set are automatically set to audit
The audit functionality was activated unexpectedly on file resources
that use the source parameter. This could cause spurrious notify
events. These
On Wed, Mar 9, 2011 at 6:30 PM, Jacob Helwig ja...@puppetlabs.com wrote:
This maintenance release fixes two issues with Puppet 2.6.5.
Bug #6418: Files with the source parameter set are automatically set to
audit
The audit functionality was activated unexpectedly on file resources
that
Jacob Helwig wrote:
This maintenance release fixes two issues with Puppet 2.6.5.
For those using Fedora or RHEL/CentOS, I've updated the yum repos at:
http://tmz.fedorapeople.org/repo/puppet/
Packages for EL 4 - 6 and Fedora 13 - 15 are available for testing.
Add the puppet.repo file from
21 matches
Mail list logo
