Re: [Puppet-dev] [PATCH/facter 1/1] Add to_i to port usage in can_connect?

2009-12-30 Thread Paul Nasrat
I responded to the pull request with this: This is a duplicate of #2346 I don't think this is sufficient as open-uri opens a url, you've changed the type to the second argument to Kernel#open is open(path [, mode [, perm]] ) = io or nil OpenURI::OpenRead#open takes optional 3 arguments as:

Re: [Puppet-dev] Alternative to facts-in-query

2009-11-30 Thread Paul Nasrat
2009/11/30 Luke Kanies l...@madstop.com: On Nov 28, 2009, at 11:54 AM, Markus wrote: In our case it's not so much that we have an ivory tower but that we have a system implemented around GET, with no real provision for ever using POST.  Not that it's impossible, but it'd be a one-off for

Re: [Puppet-dev] Alternative to facts-in-query

2009-11-30 Thread Paul Nasrat
2009/11/30 Paul Nasrat pnas...@googlemail.com: 2009/11/30 Luke Kanies l...@madstop.com: On Nov 28, 2009, at 11:54 AM, Markus wrote: In our case it's not so much that we have an ivory tower but that we have a system implemented around GET, with no real provision for ever using POST

Re: [Puppet-dev] Alternative to facts-in-query

2009-11-30 Thread Paul Nasrat
2009/11/30 Thomas Bellman bell...@nsc.liu.se: Paul Nasrat wrote: 2009/11/30 Paul Nasrat pnas...@googlemail.com: It's worth thinking about what HTTP gives us here to do things like this. One option would be to respond to the post with a temporary redirect to the catalog that the client

[Puppet-dev] Re: [PATCH/facter 2/2] use popen3 in Resolution.exec to catch stderr

2009-11-07 Thread Paul Nasrat
2009/11/6 Peter Meier peter.me...@immerda.ch: We are now wrapping the command execution with Open3.popen3 to catch stderr and passing them to the new introduced Facter.warn method. Cool. We are also catching multiline outputs chomping newlines and returning an array if there have been

[Puppet-dev] Re: Rpec tests on windows

2009-10-21 Thread Paul Nasrat
2009/10/20 Bryan Kearney bkear...@redhat.com: This may be a newbie rspec question, if so I apologize. But if I invoke rake unit:type:file on win32 I get lots of errors. If, however, I invoke rake unit/type/file it all works Is there a preferred way for calling the rspec tests? On

[Puppet-dev] Re: [PATCH] fixes #1719, this avoids calling the external binary *which* everytime we are looking for a binary

2009-10-12 Thread Paul Nasrat
2009/10/12 Ohad Levy ohadl...@gmail.com: Signed-off-by: Ohad Levy ohadl...@gmail.com ---  lib/puppet/util.rb |   17 ++---  1 files changed, 6 insertions(+), 11 deletions(-) Generally good - one small cross platform change commented inline. diff --git a/lib/puppet/util.rb

[Puppet-dev] Re: [PATCH] fixes #1719, this avoids calling the external binary *which* everytime we are looking for a binary

2009-10-12 Thread Paul Nasrat
2009/10/12 Brice Figureau brice-pup...@daysofwonder.com: +1 for this patch on top of the previous one, Isn't there any spec tests for this method? If there aren't maybe it would be the good time to add some. James, Luke: that'd be great if we could have this for 0.25.1, because this is a

[Puppet-dev] Re: [PATCH/facter 1/1] Fixes #2704. Problem finding install.rb three levels up

2009-10-07 Thread Paul Nasrat
2009/10/7 Nigel Kersten nig...@google.com: On Wed, Oct 7, 2009 at 7:22 AM, Paul Nasrat pnas...@googlemail.com wrote: 2009/10/7 Nigel Kersten nig...@google.com: +1  and applied So no need for me to push this to github and you pull from there? Not this time, but in general it does make

[Puppet-dev] Re: [PATCH/puppet 1/1] Fix #2664 - Mathematic expressions mis-lexed as Regex

2009-09-22 Thread Paul Nasrat
2009/9/21 Brice Figureau brice-pup...@daysofwonder.com: This is a temporary fix for 0.25.1. Unfortunately I don't have any good/better fix for this problem except adding once again more parsing in the lexer (ie remember if the previous token is a token that can be followed by a :REGEX

[Puppet-dev] Re: Facter: partition size facts

2009-09-16 Thread Paul Nasrat
2009/9/15 James Turnbull ja...@lovedthanlost.net: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thomas Bellman wrote: Christian Hofstaedtler wrote: You probably can't avoid `df` if you want something which works for anything else than Linux too. Of course, the output from df differs

[Puppet-dev] Re: Facter: partition size facts

2009-09-15 Thread Paul Nasrat
2009/9/15 Steven Jenkins ste...@endpoint.com: Felix Schäfer wrote: Hello, I'm not quite sure if this list is the right to discuss facter-related stuff, but I couldn't find another one, so here it goes. I'm in the process of writing facts to get the size and usage of a partition. Finding

[Puppet-dev] Re: [PATCH/facter 1/1] Fix broken solaris zone tests on EC2

2009-09-09 Thread Paul Nasrat
2009/9/9 Luke Kanies l...@madstop.com: +1 Pushed, fixes broken builds on hudson as expected other than the centos build that stalled for hours as AMI didn't come up. Paul --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google

[Puppet-dev] PATCH/facter 0/2 #2414 fix errors with aliasing/bonding

2009-09-09 Thread Paul Nasrat
Again lots of room to improve this for 1.6.0 but I'd like to get this fix in for 1.5.7 Paul --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email to

[Puppet-dev] [PATCH/facter 1/2] Fix errors when alias IP's are defined

2009-09-09 Thread Paul Nasrat
From: Kurt Keller kkat...@gmail.com Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/ip.rb |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/lib/facter/util/ip.rb b/lib/facter/util/ip.rb index 9fb7034..5941d38 100644 --- a/lib/facter/util/ip.rb

[Puppet-dev] [PATCH/facter 1/1] Fix 2455 - improve error handling on fact load

2009-09-09 Thread Paul Nasrat
Fix facts added with empty blocks by handling calls to value when setcode not called Ensure we handle load failures more gracefully Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/loader.rb |6 +- lib/facter/util/resolution.rb |1 + spec/unit/util

[Puppet-dev] Re: [PATCH/facter 1/1] Fix 2455 - improve error handling on fact load

2009-09-09 Thread Paul Nasrat
2009/9/8 Nigel Kersten nig...@google.com: On Sat, Sep 5, 2009 at 1:39 PM, Paul Nasrat pnas...@googlemail.com wrote: Fix facts added with empty blocks by handling calls to value when setcode not called Ensure we handle load failures more gracefully Signed-off-by: Paul Nasrat pnas

[Puppet-dev] [PATCH/facter 1/1] Issue #2104 - distinguish OpenSolaris and Solaris

2009-09-09 Thread Paul Nasrat
From: Kjetil Torgrim Homme kjeti...@linpro.no This patch was contributed on list Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/operatingsystem.rb | 13 - spec/unit/data/sunos_release_5.11 |4 spec/unit/data/sunos_release_5.8 |3 +++ spec/unit

[Puppet-dev] Re: [PATCH/facter 1/1] Issue #2104 - distinguish OpenSolaris and Solaris

2009-09-09 Thread Paul Nasrat
2009/9/9 Luke Kanies l...@madstop.com: +1, although it'd be nice to have a test for that failure case.  Does that exception propagate? Actually I want to hold off this for 1.5.7 upon reading up on the history I of the decision in closing this earlier in

[Puppet-dev] Re: [PATCH/puppet 1/1] Fix for #2605 by falling back to alternative solution to #1963

2009-09-08 Thread Paul Nasrat
2009/9/8 Markus Roberts mar...@reality.com: Two solutions were proposed and tested for #1963; both worked but one (the read_nonblock solution) was used for performance reasons.  This solution does not work on older ruby implementations (1.8.1) because read_nonblock is not available.  This

[Puppet-dev] Re: [PATCH/facter 1/1] Fix broken solaris zone tests on EC2

2009-09-08 Thread Paul Nasrat
2009/9/9 Luke Kanies l...@madstop.com: Mostly +1, comments below. On Sep 4, 2009, at 10:51 PM, Paul Nasrat wrote: This cleans up xen and vserver detection to enable us to stub out so when we happen to be running tests on xen we don't report as that. More cleanup is needed in this area

[Puppet-dev] [PATCH/facter 1/1] Fix broken solaris zone tests on EC2

2009-09-08 Thread Paul Nasrat
-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/virtual.rb| 16 + lib/facter/virtual.rb | 39 ++-- spec/unit/util/virtual.rb | 96 + spec/unit/util/virtual_spec.rb| 60

[Puppet-dev] Re: Puppet dev call

2009-09-06 Thread Paul Nasrat
2009/9/6 James Turnbull ja...@lovedthanlost.net: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 James Turnbull wrote: Hi all I'd like to have a dev call next week?  Does that suit you Luke? Others? Actually I'll propose an exact time:

[Puppet-dev] [PATCH/facter 1/1] Fix errors when alias IP's are defined

2009-09-05 Thread Paul Nasrat
From: Kurt Keller kkat...@gmail.com Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/ip.rb |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/lib/facter/util/ip.rb b/lib/facter/util/ip.rb index 9fb7034..5941d38 100644 --- a/lib/facter/util/ip.rb

[Puppet-dev] [PATCH/facter 1/1] resolve FQDN via DNS. should fix #2085 and #2573

2009-09-05 Thread Paul Nasrat
From: Benedikt Böhm b...@xnull.de Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/fqdn.rb | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/facter/fqdn.rb b/lib/facter/fqdn.rb index 5ebc5f5..7fe97d4 100644 --- a/lib/facter/fqdn.rb +++ b/lib

[Puppet-dev] [PATCH/facter 1/1] Fix broken solaris zone tests on EC2

2009-09-04 Thread Paul Nasrat
This cleans up xen and vserver detection to enable us to stub out so when we happen to be running tests on xen we don't report as that. More cleanup is needed in this area but this should give us a green build. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/virtual.rb

[Puppet-dev] Re: Facter 1.5.7 for Snow Leopard?

2009-09-01 Thread Paul Nasrat
2009/9/1 Nigel Kersten nig...@google.com: So as of facter 1.5.5, facter is broken on any Mac OS X 10.x.0 release. This has been fixed in the repo, but if you want Facter to work on 10.6.0, you need to either grab that, or stick with 1.5.4 Can we cut a Facter 1.5.7 release to sort this out?

[Puppet-dev] Re: [PATCH/facter 1/1] Fix #2548 add missing network fact

2009-08-23 Thread Paul Nasrat
2009/8/23 Paul Nasrat pnas...@googlemail.com: We already had code to do this that wasn't tested or being called. Adding a per interface network fact Signed-off-by: Paul Nasrat pnas...@googlemail.com ---  lib/facter/interfaces.rb |    2 +-  spec/unit/util/ip.rb     |   11 +++  2

[Puppet-dev] [PATCH/facter 1/1] Issue #2548 netblock fact

2009-08-23 Thread Paul Nasrat
We already have a network fact it's just missing a test. Paul Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/unit/util/ip.rb | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/spec/unit/util/ip.rb b/spec/unit/util/ip.rb index 60ec09e..e97b5df 100644

[Puppet-dev] [PATCH/facter 2/2] Add Darwin netmask support on top of Jim's patch

2009-08-23 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/netmask.rb |2 +- lib/facter/util/netmask.rb |8 +++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/facter/netmask.rb b/lib/facter/netmask.rb index e4ddbc5..bad3648 100644 --- a/lib/facter

[Puppet-dev] [Patch/facter 0/2] #2306 netmask on various platforms

2009-08-23 Thread Paul Nasrat
This merges in a contributed patch and extends it to OS X This whole area needs some attention when we come to fix #2179 and start caching useful interface information. This just means we'll ensure we have full platform support when I come to the refactor around network facts. Paul

[Puppet-dev] [PATCH/facter 1/2] Fix #2306 netmask and ipaddress on SunOS and BSDs

2009-08-23 Thread Paul Nasrat
From: Jim Pirzyk jim+pup...@pirzyk.org Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/ipaddress.rb |4 ++-- lib/facter/netmask.rb |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/facter/ipaddress.rb b/lib/facter/ipaddress.rb index 4c0bfe4

[Puppet-dev] Re: [PATCH/puppet 1/3] Adding a global cleanup to the spec_helper

2009-08-20 Thread Paul Nasrat
2009/8/20 Luke Kanies l...@madstop.com: On Aug 19, 2009, at 10:57 PM, Paul Nasrat wrote: +1 That should remove some of the brittleness. There are a few other things that should be added to that section, but now we know it works we can easily do so as we find them.  E.g., we apparently

[Puppet-dev] Re: [PATCH/puppet 2/9] Removing chuser on darwin restriction

2009-08-19 Thread Paul Nasrat
2009/8/20 Luke Kanies l...@madstop.com: For too long we have refused to change users on Darwin because a long time ago the ruby they shipped with was really, really broken. It's been fixed for a while, so this just removes the restriction. Signed-off-by: Luke Kanies l...@madstop.com ---

[Puppet-dev] Re: [PATCH/facter 1/1] Fix #2470 - duplicate entries in interfaces fact

2009-08-12 Thread Paul Nasrat
2009/8/12 Luke Kanies l...@madstop.com: +1 Pushed Paul --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe

[Puppet-dev] [PATCH/facter 1/1] Fix #2470 - duplicate entries in interfaces fact

2009-08-11 Thread Paul Nasrat
Solaris orders inet and inet6 seperately. This tests for and fixes this by uniqueing the list. Will probably need work when we get to ipv6 support. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/ip.rb |2

[Puppet-dev] [PATCH/facter 1/1] Fix #2470 - duplicate entries in interfaces fact

2009-08-11 Thread Paul Nasrat
Solaris orders inet and inet6 seperately. This tests for and fixes this by uniqueing the list. Will probably need work when we get to ipv6 support. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/ip.rb |2

[Puppet-dev] Re: Potential issue with RC for 0.25 on Solaris

2009-08-11 Thread Paul Nasrat
2009/8/11 Gary Law gary@gmail.com: Hi Sorry, I no longer have commit access. Can someone who does please change ./conf/solaris/smf/svc-puppetd Think this issue has been sorted but you should still be able to commit to a git repo and make it available to pull even if you don't have push

[Puppet-dev] [PATCH/facter 1/1] Issue #2292 Add tests for virtual facts

2009-07-17 Thread Paul Nasrat
Add tests and utility for virtual fact detection Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/virtual.rb | 27 ++ lib/facter/virtual.rb | 35 +++ spec/unit/util/virtual_spec.rb | 60

[Puppet-dev] [PATCH/facter 1/1] Issue #2292 Add tests for virtual facts

2009-07-17 Thread Paul Nasrat
Add tests and utility for virtual fact detection Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/virtual.rb | 27 ++ lib/facter/virtual.rb | 35 +++ spec/unit/util/virtual_spec.rb | 60

[Puppet-dev] [PATCH/facter 1/1] Issue #2314 OpenBSD sysctl

2009-07-14 Thread Paul Nasrat
From: Joe McDonagh joseph.e.mcdon...@gmail.com Use OpenBSD sysctl for manufacturer facts. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/manufacturer.rb | 33 ++--- lib/facter/util/manufacturer.rb | 15 +-- 2 files changed, 35

[Puppet-dev] [PATCH/facter 4/5] Extract openvz check to Util class

2009-07-14 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/virtual.rb |5 + lib/facter/virtual.rb |4 +++- spec/unit/util/virtual_spec.rb | 10 ++ 3 files changed, 18 insertions(+), 1 deletions(-) create mode 100644 lib/facter/util/virtual.rb

[Puppet-dev] [PATCH/facter 5/5] Extract openvz detection methods and add tests

2009-07-14 Thread Paul Nasrat
Fix whitespace as well Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/util/virtual.rb | 31 ++- lib/facter/virtual.rb | 28 ++--- spec/unit/util/virtual_spec.rb | 53 +++- spec/unit

[Puppet-dev] [PATCH/facter 3/5] Refactor - remove unused import

2009-07-14 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/virtual.rb |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb index 149cedc..b821535 100644 --- a/lib/facter/virtual.rb +++ b/lib/facter/virtual.rb @@ -4,7 +4,6

[Puppet-dev] [PATCH/facter 2/5] Add tests for virtual facts

2009-07-14 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/virtual.rb |8 +++- spec/unit/virtual_spec.rb | 13 + 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb index 72bfe51..149cedc 100644 --- a/lib

[Puppet-dev] [PATCH/facter 1/5] Add tests for is_virtual

2009-07-14 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/unit/virtual_spec.rb | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) create mode 100644 spec/unit/virtual_spec.rb diff --git a/spec/unit/virtual_spec.rb b/spec/unit/virtual_spec.rb new file

[Puppet-dev] [PATCH/facter 0/5] Introduce unit tests for virtual

2009-07-14 Thread Paul Nasrat
This patch series introduces unit tests for the virtual fact: 0001-Add-tests-for-is_virtual.patch 0002-Add-tests-for-virtual-facts.patch 0003-Refactor-remove-unused-import.patch 0004-Extract-openvz-check-to-Util-class.patch 0005-Extract-openvz-detection-methods-and-add-tests.patch I've had this

[Puppet-dev] Fix #2060

2009-07-14 Thread Paul Nasrat
Merge tmz's patch to fix operatingsystemrelease. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email to puppet-dev@googlegroups.com To unsubscribe from this

[Puppet-dev] [PATCH/facter 1/2] Consolidate operatingsystemrelease for CentOS, Fedora, oel, ovs, and RedHat

2009-07-14 Thread Paul Nasrat
From: Todd Zullinger t...@pobox.com These operating systems all use a similar format for the release file. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/operatingsystemrelease.rb | 62 ++ 1 files changed, 11 insertions(+), 51 deletions

[Puppet-dev] [PATCH/facter 2/2] Fix operatingsystemrelease on Red Hat based distros

2009-07-14 Thread Paul Nasrat
From: Todd Zullinger t...@pobox.com This allows operatingsystemrelease to properly determine the release for various Red Hat based distros, including the point portion of the release. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/operatingsystemrelease.rb |2 +- 1 files

[Puppet-dev] Re: [PATCH/facter 1/1] Issue #2314 OpenBSD sysctl

2009-07-14 Thread Paul Nasrat
2009/7/14 Nigel Kersten nig...@google.com: On Tue, Jul 14, 2009 at 8:23 AM, Joe McDonaghjoseph.e.mcdon...@gmail.com wrote: Yea, I try not to rock the boat when I submit a patch, so I stuck with what was there. Also, I mentioned on the ticket I think a method for getting facts from sysctl

[Puppet-dev] [PATCH/facter 1/2] Change spec output to enable broken build debugging

2009-07-11 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/spec.opts |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/spec/spec.opts b/spec/spec.opts index 2f9bf0d..695852c 100644 --- a/spec/spec.opts +++ b/spec/spec.opts @@ -1,3 +1,5 @@ +--format +s --colour --loadby

[Puppet-dev] [PATCH/facter 2/2] Fix broken ci build with explicit clearing before tests

2009-07-11 Thread Paul Nasrat
Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/unit/operatingsystem.rb |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/spec/unit/operatingsystem.rb b/spec/unit/operatingsystem.rb index 4c3fb3b..de86230 100644 --- a/spec/unit/operatingsystem.rb +++ b/spec

[Puppet-dev] Re: Hudson and automated testing

2009-06-28 Thread Paul Nasrat
This an FYI of sorts. After some fiddling I've got Hudson to run tests on EC2 slaves. So far Facter is the first target for a Hudson job - I'm taking it very slowly and making sure everything works: Thanks, do you have manifests for bootstrapping the ec2 nodes?

[Puppet-dev] Re: Hudson and automated testing

2009-06-28 Thread Paul Nasrat
http://hudson.reductivelabs.com/job/Facter%20-%20Master/ I can't reproduce the failure on operatingsystem: cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=9.04 DISTRIB_CODENAME=jaunty DISTRIB_DESCRIPTION=Ubuntu 9.04 r...@domu-12-31-39-03-b9-28:~/facter# rake ci_spec (in /root/facter)

[Puppet-dev] [PATCH 1/1] Fix #2303 - add executable to gemspec

2009-06-21 Thread Paul Nasrat
This makes jruby -S facter work Signed-off-by: Paul Nasrat pnas...@googlemail.com --- Rakefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Rakefile b/Rakefile index fd8306c..7f9ba6a 100644 --- a/Rakefile +++ b/Rakefile @@ -21,6 +21,7 @@ spec = Gem::Specification.new

[Puppet-dev] Re: [PATCH/facter 1/1] detect qemu-kvm in virtual

2009-06-11 Thread Paul Nasrat
The preferred way of doing this is checking CPUID leaf 0x4000 for the signature KVMKVMKVM. Most hypervisors (KVM, Xen, VMware, and Hyper- V) are adopting this as  the preferred detection mechanism. (http:// article.gmane.org/gmane.comp.emulators.kvm.devel/20539) this seems to be the

[Puppet-dev] Re: [PATCH/facter 1/1] should reduce system calls for uptime fact. refs #2330

2009-06-08 Thread Paul Nasrat
2009/6/8 James Turnbull ja...@lovedthanlost.net: From: Felix Schäfer schae...@cypres-it.com Needs more work. If we're doing complex conditionals we really should have some tests, which would have picked up the logic issues below: ---  lib/facter/uptime.rb      |   30

[Puppet-dev] Re: [PATCH/facter 1/1] should reduce system calls for uptime fact. refs #2330

2009-06-08 Thread Paul Nasrat
2009/6/8 Felix Schäfer schae...@cypres-it.com: And an assignment is exactly what I was aiming for: the assignment fails if the right hand doesn't exist, which is the condition in which I don't want to go into the branch, if the right hand exists, I get the assignment for free (the only

[Puppet-dev] Re: Problem with require syslog on windows

2009-06-07 Thread Paul Nasrat
2009/6/6 joel r cirqu...@gmail.com: I remember Paul Nasrat mentioning some time back that he had a patch to solve this problem. Perhaps that could be integrated together with the windows code? Or is there anything I could be doing about it? Sure what's easiest a patch on top of your tree I

[Puppet-dev] Re: For review: Windows users and groups

2009-06-07 Thread Paul Nasrat
2009/5/10 joel r cirqu...@gmail.com: What's new: * I've moved tests to rspec, * added a windows feature, * refactored a bit here and there. The code is to be found at http://github.com/finalprefix/puppet/tree/win. All comments and help are welcome. I'm seeing a bunch of integration

[Puppet-dev] Re: MA Puppet Meetup Monday June 8th

2009-06-07 Thread Paul Nasrat
2009/6/4 Paul Nasrat pnas...@googlemail.com: Meet to be held at Cambridge Brewing Company to talk puppet, systems admin, agile systems, and have a few beers When: Monday June 8th from 18:00 Where: Kendall Square, Cambrige, MA, USA - http://www.cambrew.com/directions.html Gah I've had

[Puppet-dev] Re: [PATCH 1/1] Fix #2300 - Update ssh_authorized_key documentation

2009-05-25 Thread Paul Nasrat
2009/5/25 Francois Deppierraz franc...@ctrlaltdel.ch: +1 Improves the documentation for this type. Paul --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email

[Puppet-dev] Boston Puppet Meet

2009-05-24 Thread Paul Nasrat
I'm going to be in Boston/Cambridge/Somerville at the start of June Anyone fancy meeting up for a few beers and talking about puppet/systems administration? Maybe somewhere like Cambridge Brewing Company on Tuesday 9th June Paul --~--~-~--~~~---~--~~ You

[Puppet-dev] [PATCH 2/2] Tighten operatingsystemrelease regex on CentOS 5

2009-05-22 Thread Paul Nasrat
From: Todd Zullinger t...@pobox.com The previous check for /5/ matched releases like 4.5, which is not the intent. The previous check was introduced in 095eb15e, and changed the pattern from /^5^/. Using /^5/ to match when the release begins with 5 seems saner. Signed-off-by: Paul Nasrat pnas

[Puppet-dev] [PATCH 1/1] Fix #2278 Revert fix for 2120

2009-05-22 Thread Paul Nasrat
Facter #2120 - Solaris support for Facter[virtual] This reverts commit 56760d34f070db4d7bb8e5fcfb7939fe3074bf49. This patch is broken as $? global will report last run process in the case of no vmware-checkvm binary Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/virtual.rb

[Puppet-dev] Re: Dev call #349

2009-05-22 Thread Paul Nasrat
2009/5/22 Luke Kanies l...@madstop.com: On May 19, 2009, at 10:18 PM, Luke Kanies wrote: Or whatever.  We probably haven't had quite that many. Anyway, it's way time for another dev call.  The primary topics of this call will be Puppet 0.25 and the path to Facter 2.0. I propose next

[Puppet-dev] Re: Facter 1.5.5rc2 released!

2009-05-19 Thread Paul Nasrat
A new Facter release candidate is available - 1.5.5rc2. You can get the new release at: http://reductivelabs.com/downloads/facter/facter-1.5.5rc2.tgz That link 404s http://reductivelabs.com/downloads/facter/facter-1.5.5rc2.tar.gz Paul

[Puppet-dev] [PATCH 1/1] Facter #2278 - fix misreporting of vmware on solaris

2009-05-19 Thread Paul Nasrat
This fixes misreporting of virtual=vmware on sparc hardware Paul Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/virtual.rb |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/lib/facter/virtual.rb b/lib/facter/virtual.rb index 37381d4..621c37c 100644

[Puppet-dev] [PATCH 1/1] Facter #2120 - Solaris support for Facter[virtual]

2009-05-15 Thread Paul Nasrat
From: Jim Pirzyk jim+pup...@pirzyk.org Initial support for virtual vmware fact on Solaris Tested on VMWare Fusion and OpenSolaris Paul Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/virtual.rb | 28 +--- 1 files changed, 17 insertions(+), 11

[Puppet-dev] Re: [PATCH 1/1] Facter #2120 - Solaris support for Facter[virtual]

2009-05-15 Thread Paul Nasrat
2009/5/15 Luke Kanies l...@madstop.com: +1, although it'd be great to move away from so many nested conditionals. Yes, we'll look at refactoring virtual.rb post release of 1.5.5 Paul --~--~-~--~~~---~--~~ You received this message because you are subscribed

[Puppet-dev] [PATCH 1/1] Tests for #2227 - multiple interfaces on Darwin

2009-05-12 Thread Paul Nasrat
This seems to have been fixed functionally on master (in /Users/pnasrat/Development/facter/spec) Finished in 1.604955 seconds 183 examples, 0 failures However I want to take the opportunity to add tests to prevent regressions Paul Signed-off-by: Paul Nasrat pnas...@googlemail.com

[Puppet-dev] Re: [Puppet Users] Ruby EE vs Ruby 1.8.4 results.

2009-05-12 Thread Paul Nasrat
2009/5/12 Nigel Kersten nig...@google.com: This was: ruby 1.8.4 (2005-12-24) [x86_64-linux] vs ruby 1.8.6 (2008-08-11 patchlevel 287) [x86_64-linux] Ruby Enterprise Edition 20090421 on Ubuntu Dapper, using Passenger with Apache. Interesting results. Which version of puppet were you

[Puppet-dev] [PATCH 1/1] Fix #2155 - architecture facts on Gentoo

2009-05-12 Thread Paul Nasrat
From: Benedikt Böhm b...@xnull.de This corrects the architecture results for Gentoo on x86 and amd64 Patch from redmine Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/architecture.rb | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git

[Puppet-dev] Re: [PATCH 1/1] Fix #2155 - architecture facts on Gentoo

2009-05-12 Thread Paul Nasrat
2009/5/12 Paul Nasrat pnas...@googlemail.com: From: Benedikt Böhm b...@xnull.de This corrects the architecture results for Gentoo on x86 and amd64 +1 I tested on gentoo x86 and amd64 on ec2[0] (thanks dysinger!) * scp facter working dir up on branch * emerge unmerge facter * functional

[Puppet-dev] Re: [PATCH 1/1] Added some more basic tests

2009-05-12 Thread Paul Nasrat
I'm going to break this up into seperate posts per file. To understand what we're trying to test here lets look at the code and the test together Facter.add(:hardwaremodel) do setcode 'uname -m' end +    it should return the hardware model do +        

[Puppet-dev] Re: [PATCH 1/1] Added some more basic tests

2009-05-12 Thread Paul Nasrat
2009/5/13 James Turnbull ja...@lovedthanlost.net: Signed-off-by: James Turnbull ja...@lovedthanlost.net diff --git a/spec/unit/kernel.rb b/spec/unit/kernel.rb new file mode 100644 index 000..368cae6 --- /dev/null +++ b/spec/unit/kernel.rb @@ -0,0 +1,21 @@ +#!/usr/bin/env ruby +

[Puppet-dev] Re: [PATCH 1/1] Facter #2131

2009-05-10 Thread Paul Nasrat
2009/5/10 James Turnbull ja...@lovedthanlost.net: Paul Nasrat wrote:  Facter.add(lsbmajdistrelease) do -    confine :operatingsystem = %w{Solaris Linux Fedora RedHat CentOS SuSE SLES Debian Ubuntu Gentoo} +    confine :operatingsystem = %w{Solaris Linux Fedora RedHat CentOS SuSE SLES

[Puppet-dev] Re: [SPAM] [PATCH] Handle non-integer Fedora releases.

2009-05-10 Thread Paul Nasrat
2009/5/11 Ricky Zhou ri...@rzhou.org: ---  lib/facter/operatingsystemrelease.rb |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) As per http://reductivelabs.com/trac/puppet/wiki/DevelopmentLifecycle can you file a ticket, point at a git branch of the ticket. Also whilst it might

[Puppet-dev] Re: [PATCH 1/1] An incredibly crude example of how we might implement confines.

2009-05-10 Thread Paul Nasrat
2009/5/11 James Turnbull ja...@lovedthanlost.net: Would obviously be enormously improved with some querying methods and a support map for facts.  Only had 5 minutes to do this example. The problem in this case is that some distros may not have lsb_release (OVS doesn't have the package based

[Puppet-dev] [PATCH 1/1] Fix #2236 - don't use each_line on arrays

2009-05-10 Thread Paul Nasrat
This fixes up the syntax so that we can get 1.5.5 out, I've not done tests for this as we need to fixup the number of time we call out to ifconfig and the duplication with ip.rb. Paul Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter/macaddress.rb |4 ++-- 1 files changed, 2

[Puppet-dev] [PATCH 1/1] Facter ticket #2214 - Fix facts for OVS (rebase)

2009-05-07 Thread Paul Nasrat
Added tests for operatingsystem fact covering the two simple cases and a test for this specific interaction of release files We should take some time to add tests when we're adding or changing new operatingsystem facts Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter

[Puppet-dev] Re: [PATCH 1/1] Cleanup of the Puppet Rakefile and removal of the requirement for the Reductive Build Library

2009-05-07 Thread Paul Nasrat
2009/5/7 James Turnbull ja...@lovedthanlost.net: Signed-off-by: James Turnbull ja...@lovedthanlost.net ---  Rakefile                    |  197  lib/puppet.rb               |    4 +-  tasks/rake/redlabpackage.rb |  265 -  tasks/rake/reductive.rb     |  

[Puppet-dev] Re: [PATCH 1/1] Fixes #2169 (and perhaps #1558) and returns correct dom0 and domU values

2009-05-06 Thread Paul Nasrat
2009/5/2 James Turnbull ja...@lovedthanlost.net: What's the intent that this change fixes - is there anyway to test for the behaviour we're trying to get. Also from reading comments in the bug we may need to support different mechanisms on different xen versions. I'd like to ensure that we

[Puppet-dev] [PATCH 1/1] Facter ticket 2214 - Fix facts for OVS

2009-05-06 Thread Paul Nasrat
Added tests for operatingsystem fact covering the two simple cases and a test for this specific interaction of release files We should take some time to add tests when we're adding or changing new operatingsystem facts Signed-off-by: Paul Nasrat pnas...@googlemail.com --- lib/facter

[Puppet-dev] Re: [PATCH 1/1] facts for HP-UX

2009-05-06 Thread Paul Nasrat
2009/5/6 Luke Kanies l...@madstop.com: I talked with Sam about it a bit yesterday, and basically, he's duplicated the structure of the AIX code, which is a reasonable first try.  I'd recommended refactoring to push all of the logic into the resolution, but then you'd need to cache data (to

[Puppet-dev] Re: Rack support for 0.25 - integration

2009-04-19 Thread Paul Nasrat
2009/4/19 Christian Hofstaedtler ch+...@zeha.at: Integrating rack nicely has multiple aspects, and I seek input on all of them: * Passenger (AKA mod_rails for Apache) shall again be supported (see wiki:UsingPassenger). Passenger obviously expects rack applications to completely follow the

[Puppet-dev] Re: RFC: Rack support for 0.25

2009-04-19 Thread Paul Nasrat
2009/4/19 Christian Hofstaedtler ch+...@zeha.at: Bruce asked me to refresh Rack support in Puppet, especially with regard to the new REST handlers. While Puppet 0.24.6+ already has support for REST (with XMLRPC), I felt that it would be better to start fresh. Can you make your branch

[Puppet-dev] RFD - Scripted facts (/etc/fact.d)

2009-04-13 Thread Paul Nasrat
I've created a placeholder bug for this feature for 2.0 http://projects.reductivelabs.com/issues/2157 Paul --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Puppet Developers group. To post to this group, send email

[Puppet-dev] Re: Code review apps

2009-04-02 Thread Paul Nasrat
In reading an article comparing version control systems, I was reminded that tools for this exist.  For instance: http://www.review-board.org/ and http://code.google.com/p/rietveld/ Has anyone here used those tools?  If so, do you have any comments on their suitability for our

[Puppet-dev] [PATCH 1/1] Fix #2113 - Make temp directory

2009-03-26 Thread Paul Nasrat
Tests were failing this patch makes the temporary directory in line with other integration tests. Signed-off-by: Paul Nasrat pnas...@googlemail.com --- spec/integration/ssl/certificate_request.rb |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/spec/integration/ssl

[Puppet-dev] Re: Some rudimentary support for users and groups on MS Windows

2009-03-23 Thread Paul Nasrat
Which of the existing types and providers do you expect to eventually work on Windows? I'm looking at adding support for windows ACLs to files, and doing what I can to support packages on Windows. Windows doesn't have package managers quite like apt / yum. But I might be able to get

[Puppet-dev] Re: Some rudimentary support for users and groups on MS Windows

2009-03-21 Thread Paul Nasrat
This patch has basic support for users and groups on Windows. * It for version 0.24.7. * It does not include support for active directory. * It does not work with the 0.24.8 beta. Cool, can I just say this is really awesome! But you really should target master for new features like this.

[Puppet-dev] Re: [PATCH 06/12] Moving the REST API functions into a module

2009-03-20 Thread Paul Nasrat
2009/3/20 Luke Kanies l...@madstop.com: This module is now used by the client and server side, rather than having a Handler module that's 90% server functionality but also used by the client. +module Puppet::Network::HTTP::Handler +    include Puppet::Network::HTTP::API::V1    

[Puppet-dev] Re: [PATCH 05/12] Using the Handler for the REST api on both sides of the connection

2009-03-20 Thread Paul Nasrat
2009/3/20 Luke Kanies l...@madstop.com: Things are actually in a broken state here because we've got a conflict between how the two sides do their work and some extraction needs to get done.  This commit is just a stopping-point so I can do the necessary refactoring. Whilst it's good to

[Puppet-dev] Re: [PATCH 06/12] Moving the REST API functions into a module

2009-03-20 Thread Paul Nasrat
2009/3/20 Paul Nasrat pnas...@googlemail.com: 2009/3/20 Luke Kanies l...@madstop.com: This module is now used by the client and server side, rather than having a Handler module that's 90% server functionality but also used by the client. +module Puppet::Network::HTTP::Handler

[Puppet-dev] Hudson builds mismatched with installed facter

2009-03-20 Thread Paul Nasrat
http://set.reductivelabs.com:8180/hudson/job/Facter-%20Multi-slave%20-%20stable%201.5.x/label=centos47/lastBuild/testReport/(root)/Facter/should_delegate_the__list_method_to_the_collection/ Stacktrace uninitialized constant Facter::IPAddress (NameError)

[Puppet-dev] Re: Bounties

2009-03-02 Thread Paul Nasrat
2009/2/28 James Turnbull ja...@lovedthanlost.net: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all What's everyone's thoughts/feelings/etc on ticket bounties? I've been thinking about the many issues assigned to community currently and wondering if a bounty system might not help

[Puppet-dev] Re: Bounties

2009-03-02 Thread Paul Nasrat
Would a bug day/hackfest online work?  I'd be down with trying, and this weekend is probably one of the few weekends for a while that I could actually work. Something I think that would make a hackfest work better would be a podcast of one of the people familiar with puppet internals going

[Puppet-dev] Re: Bounties

2009-03-02 Thread Paul Nasrat
I'd love to have time to do this, but, and I've been struggling with this since I started Puppet, there's this kind of inherent conflict between doing actual development and writing about how to do development.  Given that development time is limited, which is more important? A focussed

<    1   2   3   >