Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Paul Nasrat
On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net This list is kinda excessive, is there anything it doesn't work for explicitly (ie do we need the confine). --- Local-branch: tickets/master/6695  lib/facter/id.rb |  

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread James Turnbull
Paul Nasrat wrote: On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net This list is kinda excessive, is there anything it doesn't work for explicitly (ie do we need the confine). Solaris. Hence the other command in

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Daniel Pittman
On Sun, Mar 13, 2011 at 19:57, James Turnbull ja...@lovedthanlost.net wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net --- Local-branch: tickets/master/6695  lib/facter/id.rb |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/facter/id.rb

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Paul Nasrat
On 14 March 2011 15:46, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net This list is kinda excessive, is there anything it doesn't work for explicitly (ie

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Daniel Pittman
On Mon, Mar 14, 2011 at 10:29, Paul Nasrat pnas...@gmail.com wrote: On 14 March 2011 15:46, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net This list is

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Paul Nasrat
On 14 March 2011 16:52, Daniel Pittman dan...@puppetlabs.com wrote: On Sun, Mar 13, 2011 at 19:57, James Turnbull ja...@lovedthanlost.net wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net --- Local-branch: tickets/master/6695  lib/facter/id.rb |    2 +-  1 files changed, 1

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Daniel Pittman
On Mon, Mar 14, 2011 at 10:32, Paul Nasrat pnas...@gmail.com wrote: On 14 March 2011 16:52, Daniel Pittman dan...@puppetlabs.com wrote: On Sun, Mar 13, 2011 at 19:57, James Turnbull ja...@lovedthanlost.net wrote: […] It would be really good to see some tests to verify that we keep

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Paul Nasrat
On 14 March 2011 17:30, Daniel Pittman dan...@puppetlabs.com wrote: On Mon, Mar 14, 2011 at 10:29, Paul Nasrat pnas...@gmail.com wrote: On 14 March 2011 15:46, James Turnbull ja...@puppetlabs.com wrote: Paul Nasrat wrote: On 14 March 2011 02:57, James Turnbull ja...@lovedthanlost.net wrote:

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Paul Nasrat
On 14 March 2011 17:44, Daniel Pittman dan...@puppetlabs.com wrote: On Mon, Mar 14, 2011 at 10:32, Paul Nasrat pnas...@gmail.com wrote: On 14 March 2011 16:52, Daniel Pittman dan...@puppetlabs.com wrote: On Sun, Mar 13, 2011 at 19:57, James Turnbull ja...@lovedthanlost.net wrote: […] It

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread Daniel Pittman
On Mon, Mar 14, 2011 at 10:48, Paul Nasrat pnas...@gmail.com wrote: On 14 March 2011 17:44, Daniel Pittman dan...@puppetlabs.com wrote: On Mon, Mar 14, 2011 at 10:32, Paul Nasrat pnas...@gmail.com wrote: On 14 March 2011 16:52, Daniel Pittman dan...@puppetlabs.com wrote: On Sun, Mar 13, 2011

[Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread James Turnbull
Signed-off-by: James Turnbull ja...@lovedthanlost.net --- Local-branch: tickets/master/6695 lib/facter/id.rb | 11 ++- spec/unit/id_spec.rb | 27 +++ 2 files changed, 29 insertions(+), 9 deletions(-) create mode 100755 spec/unit/id_spec.rb diff --git

[Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread James Turnbull
Signed-off-by: James Turnbull ja...@lovedthanlost.net --- Local-branch: tickets/master/6695 lib/facter/id.rb | 11 ++- spec/unit/id_spec.rb | 27 +++ 2 files changed, 29 insertions(+), 9 deletions(-) create mode 100755 spec/unit/id_spec.rb diff --git

Re: [Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-14 Thread James Turnbull
James Turnbull wrote: Signed-off-by: James Turnbull ja...@lovedthanlost.net --- Local-branch: tickets/master/6695 Typo'ed before I hit enter... :( James -- James Turnbull Puppet Labs 1-503-734-8571 -- You received this message because you are subscribed to the Google Groups Puppet

[Puppet-dev] [PATCH/facter 1/1] Fixed #6695 - Updated id fact for Darwin et al

2011-03-13 Thread James Turnbull
Signed-off-by: James Turnbull ja...@lovedthanlost.net --- Local-branch: tickets/master/6695 lib/facter/id.rb |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/facter/id.rb b/lib/facter/id.rb index c2c3594..f3de1a9 100644 --- a/lib/facter/id.rb +++ b/lib/facter/id.rb