Ok, I'll read up on Node.search ... I knew nothing about it before.
I'll probably need some help here understanding what this design
should look like.
On Fri, Mar 12, 2010 at 1:56 AM, Luke Kanies l...@reductivelabs.com wrote:
I'm pretty uncomfortable with this patch. Does it replace the
On Thu, Mar 11, 2010 at 2:54 AM, James Turnbull ja...@lovedthanlost.net wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/03/10 1:51 AM, Michael DeHaan wrote:
No, I haven't.
I'm curious as to feedback on the idea/implementation.
Tests can be added.
Mike
Actually I tend to
Michael,
Things like glob parsing are both inherently testable and prone to errors.
And, with respect, I don't know how to test this is not a valid argument
for not testing. I'd be happy to talk to you about Puppet testing
methodologies to the extent that they exist and that I am aware of them.
On Thu, Mar 11, 2010 at 1:56 PM, Rein Henrichs r...@reductivelabs.com wrote:
Michael,
Things like glob parsing are both inherently testable and prone to errors.
Dir.glob is prone to errors?
Personally, I think Puppet needs better testing methodologies just as much
as it needs more and better
On Mar 11, 2010, at 6:17 AM, Michael DeHaan wrote:
On Thu, Mar 11, 2010 at 2:54 AM, James Turnbull ja...@lovedthanlost.net
wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/03/10 1:51 AM, Michael DeHaan wrote:
No, I haven't.
I'm curious as to feedback on the idea/implementation.
On Thu, Mar 11, 2010 at 2:50 PM, Luke Kanies l...@reductivelabs.com wrote:
On Mar 11, 2010, at 6:17 AM, Michael DeHaan wrote:
On Thu, Mar 11, 2010 at 2:54 AM, James Turnbull ja...@lovedthanlost.net
wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/03/10 1:51 AM, Michael DeHaan
On Mar 9, 2010, at 2:08 PM, Michael DeHaan wrote:
Also cleaned up a few error messages (unrelated)
---
lib/puppet/application/puppetrun.rb | 12 ++-
lib/puppet/daemon.rb|2 +-
lib/puppet/network/server.rb|2 +-
lib/puppet/util/runner.rb | 53
I'm pretty uncomfortable with this patch. Does it replace the direct
ldap integration? If I used it with external nodes, what would
happen? Do we expect our users to maintain these files in addition to
their external nodes system?
I'd much rather make sure that Node.search behaves like
No, I haven't.
I'm curious as to feedback on the idea/implementation.
Tests can be added.
On Wed, Mar 10, 2010 at 1:32 AM, Paul Nasrat pnas...@googlemail.com wrote:
On 9 March 2010 22:08, Michael DeHaan mich...@reductivelabs.com wrote:
Also cleaned up a few error messages (unrelated)
---
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/03/10 1:51 AM, Michael DeHaan wrote:
No, I haven't.
I'm curious as to feedback on the idea/implementation.
Tests can be added.
Mike
Actually I tend to agree with Paul. We require tests for community
submissions. Everyone should eat the
Also cleaned up a few error messages (unrelated)
---
lib/puppet/application/puppetrun.rb | 12 ++-
lib/puppet/daemon.rb|2 +-
lib/puppet/network/server.rb|2 +-
lib/puppet/util/runner.rb | 53 +++
4 files changed,
Michael DeHaan wrote:
+def expand_groups(host_list)
+groupfile = #{Puppet[:confdir]}/hostgroups.conf
Rather minor, but your commit subject says .txt but the code uses
.conf.
--
ToddOpenPGP - KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
On 9 March 2010 22:08, Michael DeHaan mich...@reductivelabs.com wrote:
Also cleaned up a few error messages (unrelated)
---
lib/puppet/application/puppetrun.rb | 12 ++-
lib/puppet/daemon.rb | 2 +-
lib/puppet/network/server.rb | 2 +-
13 matches
Mail list logo
