Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2019-06-19 Thread lhu
I think I got it. I was confused because of the manifest path and the special init.pp main class. Didn't realize the init.pp requires to be in the top main levels and for subdirectories classes it has to be within manifest path. In our scenario, we used the pkg directory within adhoc to push

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2019-06-18 Thread jcbollinger
On Monday, June 17, 2019 at 9:09:52 AM UTC-5, lhu wrote: > > Thanks Ben. > > Would you know why this wouldn't work? I have the module manifest folder > under adhoc/pakg/dan/manifest/ > > #puppet parser validate init.pp > > Warning: Unacceptable location. The name 'adhoc::pkg::dan::init' is >

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2019-06-17 Thread lhu
Thanks Ben. Would you know why this wouldn't work? I have the module manifest folder under adhoc/pakg/dan/manifest/ #puppet parser validate init.pp Warning: Unacceptable location. The name 'adhoc::pkg::dan::init' is unacceptable in file

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2019-06-14 Thread Ben Ford
Yes. A class without a namespace must be named the same as the module containing it, *and be in the init.pp file*. In other words, your /opt/puppetlabs/puppet/modules/adhoc/manifests/*adhoc* .pp file should be /opt/puppetlabs/puppet/modules/adhoc/manifests/*init*.pp. See

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2019-06-14 Thread lhu
Hi John, Would you have any idea why this would fail file #puppet parser validate adhoc.pp Warning: Unacceptable location. The name 'adhoc' is unacceptable in file '/opt/puppetlabs/puppet/modules/adhoc/manifests/adhoc.pp' (file: /opt/puppetlabs/puppet/modules/adhoc/manifests/adhoc.pp, line: 1,

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread Eirik Øverby
> I would expect this to get into 5.5.7 but can't promise yet. Brilliant - as long as it's not me being crazy. Thanks again. /Eirik -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread kris . bosland
On Friday, October 5, 2018 at 11:22:30 AM UTC-7, Eirik Øverby wrote: > > > I've resuscitated my JIRA account, so if you wish to attach me to the > ticket in some way, my username is 'ltning'. > > I presume 5.5.7 should have this one fixed then? :) > > /Eirik I have set you as the Reporter.

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread Eirik Øverby
> Hi X, > > Nick Lewis helped me reproduce this issue with the extra module path, I have > filed https://tickets.puppetlabs.com/browse/PUP-9211 for the issue. > > Thanks! Thanks a *lot*! I've resuscitated my JIRA account, so if you wish to attach me to the ticket in some way, my username is

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread kris . bosland
On Friday, October 5, 2018 at 10:55:52 AM UTC-7, Eirik Øverby wrote: > > > Hi Eirik, > > > > I was unable to reproduce your issue in Puppet 5.5.6 (aka SHA 60de165 > from https://github.com/puppetlabs/puppet/releases): > > > > kris.bosland@kris:puppet % git checkout 60de165

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread Eirik Øverby
> Hi Eirik, > > I was unable to reproduce your issue in Puppet 5.5.6 (aka SHA 60de165 from > https://github.com/puppetlabs/puppet/releases): > > kris.bosland@kris:puppet % git checkout 60de165 >

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread kris . bosland
On Friday, October 5, 2018 at 8:20:51 AM UTC-7, Eirik Øverby wrote: > > On Tuesday, August 28, 2018 at 6:50:48 PM UTC+3, Branan Purvine-Riley > wrote: > >> Hi Jon, >> >> In Puppet 6 we're going to start requiring that the names of >> classes/defines match the name that's implied by their file

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread kris . bosland
On Friday, October 5, 2018 at 8:20:51 AM UTC-7, Eirik Øverby wrote: > > On Tuesday, August 28, 2018 at 6:50:48 PM UTC+3, Branan Purvine-Riley > wrote: > >> Hi Jon, >> >> In Puppet 6 we're going to start requiring that the names of >> classes/defines match the name that's implied by their file

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-10-05 Thread Eirik Øverby
On Tuesday, August 28, 2018 at 6:50:48 PM UTC+3, Branan Purvine-Riley wrote: > Hi Jon, > > In Puppet 6 we're going to start requiring that the names of > classes/defines match the name that's implied by their file path[1]. We > added that deprecation warning in 5.5.6[2] as part of a push to get

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-08-29 Thread jon
Fair enough. Some parts of our Puppet code base is almost 10 years old, and usually only gets updated when a deprecation requires it. We'll have to put some time into reorganizing things a bit one of these days. Jon On Wednesday, 29 August 2018 07:58:32 UTC-6, Henrik Lindberg wrote: > > On

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-08-29 Thread Henrik Lindberg
On 2018-08-29 15:11, jcbollinger wrote: On Tuesday, August 28, 2018 at 12:13:15 PM UTC-5, kris.b...@puppet.com wrote: Hi Jon, As you have read, this is part of our work implementing errors to enforce the standards set down in PUP-1434.  In particular, your example

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-08-29 Thread jcbollinger
On Tuesday, August 28, 2018 at 12:13:15 PM UTC-5, kris.b...@puppet.com wrote: > > > Hi Jon, > > As you have read, this is part of our work implementing errors to enforce > the standards set down in PUP-1434. In particular, your example > '$module_path/seed/manifests/init.pp' > looks like it

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-08-28 Thread kris . bosland
Hi Jon, As you have read, this is part of our work implementing errors to enforce the standards set down in PUP-1434. In particular, your example '$module_path/seed/manifests/init.pp' looks like it is in the init file of module 'seed'. Assuming that is what you meant, anything starting

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-08-28 Thread jon
Guess I should have read to point 6 in PUP-1434, init.pp is special. Got it, thanks a bunch. Jon On Tuesday, 28 August 2018 10:08:16 UTC-6, j...@jnjschneider.com wrote: > > So does this mean if the path is '$module_path/seed/manifests/init.pp' then > the define name will now need to be

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-08-28 Thread jon
So does this mean if the path is '$module_path/seed/manifests/init.pp' then the define name will now need to be 'seed::init::remote_file' in place of 'remote_file'? Thanks, Jon On Tuesday, 28 August 2018 09:50:48 UTC-6, Branan Purvine-Riley wrote: > > Hi Jon, > > In Puppet 6 we're going to

Re: [Puppet Users] Recent 5.5.x point releases are throwing some warnings for me

2018-08-28 Thread Branan Riley
Hi Jon, In Puppet 6 we're going to start requiring that the names of classes/defines match the name that's implied by their file path[1]. We added that deprecation warning in 5.5.6[2] as part of a push to get upcoming Puppet 6 changes printing warnings whenever possible. [1]