The hope would be to get the benefits of nop-write from the underlying ZFS
filesystem therefore increasing performance and reducing snapshot size
without the need for deduplication being enabled. I have often found large
deletes on ZFS to sometimes not be very performant as well, especially if
dedu
This is required in order to avoid making multiple API calls in the
following commit.
Signed-off-by: Max Carrara
---
PVE/API2/Ceph/OSD.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm
index 2893456a..de4cc72b 100644
--- a/PVE/API2/Ceph/OSD.pm
+++
The logic of the `render_version` function is split up in order to
handle how the version is displayed depending on the type of the row.
If the parsed version is `undefined` or the row marks the beginning of
the tree, an empty string is now returned. This behaviour is
equivalent to before, it just
This commit adds `PVE.Utils.parse_ceph_buildcommit`, which can be used
to get the full hash "eccf199d..." in parentheses from a string like
the following:
ceph version 17.2.7 (eccf199d63457659c09677399928203b7903c888) quincy (stable)
This hash is displayed and taken into account when comparing
The `ceph-version` key is not used anymore, so it can go.
Double-checked by `rg`ing through all of our repositories.
Signed-off-by: Max Carrara
---
PVE/Ceph/Services.pm | 2 --
1 file changed, 2 deletions(-)
diff --git a/PVE/Ceph/Services.pm b/PVE/Ceph/Services.pm
index e0f31e8e..f5109655 1006
Signed-off-by: Max Carrara
---
"Unfortunately" JS doesn't support comments in its regexes akin to
Perl's 'x' flag, but oh well ...
www/manager6/Utils.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index f5608944..74e46694 10
Signed-off-by: Max Carrara
---
PVE/Ceph/Services.pm | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/PVE/Ceph/Services.pm b/PVE/Ceph/Services.pm
index f5109655..0b8c207e 100644
--- a/PVE/Ceph/Services.pm
+++ b/PVE/Ceph/Services.pm
@@ -50,2
Make the regex more maintainable declaring it as a variable, breaking it
up and commenting it by using the x flag.
Also remove the part that parses our Debian revision (e.g. -pve1) from
the version, as we do not actually include that in our Ceph builds.
The part of the regex that parses the build
Signed-off-by: Max Carrara
---
PVE/Ceph/Tools.pm | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/PVE/Ceph/Tools.pm b/PVE/Ceph/Tools.pm
index 9b97171e..087c4ef3 100644
--- a/PVE/Ceph/Tools.pm
+++ b/PVE/Ceph/Tools.pm
@@ -57,24 +57,25 @@ my
Ceph Build Commit in UI - Version 1
===
This series adds Ceph's build commit to the UI and lets the user know if
a service is running an outdated build and therefore ought to be
restarted.
The build commit is now displayed next to the version for all Ceph
services
while testing a patch-series today I saw quite a few:
```
Use of uninitialized value...
```
warnings from running the tests. While the issues are cosmetic, and don't
harm, the actual build - they were enough to distract me for 10 minutes,
which I want to spare others (including my future self).
St
cosmetic issue - but was distracting enough to make me look if there's
an error.
Signed-off-by: Stoiko Ivanov
---
test/parse-fqdn.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/parse-fqdn.pl b/test/parse-fqdn.pl
index 6638fbe..47e0e21 100755
--- a/test/parse-fqd
else the tests running:
`./proxmox-low-level-installer -t test.img dump-env`
print quite a few warnings about the use of uninitialized values
(though they still continue happily).
This was a slight distraction for me.
Signed-off-by: Stoiko Ivanov
---
debian/control | 1 +
1 file changed, 1 inser
for completeness sake - gave the v3 a quick spin as well - so also from my
side the:
Reviewed-by: Stoiko Ivanov
Tested-by: Stoiko Ivanov
still applies :)
On Tue, 30 Apr 2024 12:46:07 +0200
Aaron Lauterer wrote:
> booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash
> drive) di
It seems like commit 02d9462 ("setup: enable systemd-networkd via
preset for ubuntu 23.04+") also resulted in the default netplan
configuration no longer being unlinked. That should still happen, even
if systemd-networkd is now enabled via preset. Otherwise, the network
configuration created by Pro
Minimally tested, that an upgrade from an existing 23.04 container
works, there still is network and no obviously bad messages in the
container's journal.
Reported in the community forum:
https://forum.proxmox.com/threads/145848/
Signed-off-by: Fiona Ebner
---
No changes in v2.
src/PVE/LXC/Se
Sent a patch v2:
https://lists.proxmox.com/pipermail/pve-devel/2024-April/063764.html
On 29/04/2024 13:14, Thomas Lamprecht wrote:
subject:
ui: acme: switch plugin view over to the one from widget-toolkit
(having internal xtypes in the subject already is not really that
useful)
Am 29/08/2023
The pmxACMEAccountView & pmxACMEPluginView in proxmox-widget-toolkit
were copied from pve-manager in commits 5df894de and 658bfdff. This
makes pveACMEAccountView & pveACMEPluginView redundant, hence remove
them and use pmxACMEAccountView & pmxACMEPluginView instead.
This leaves PVE.node.ACMEAccoun
By mapping files into the ISO, the UUID for the partitions change as
they depend on the timestamp. The result is, that grub cannot find its
partition anymore and the user ends up on the grub shell.
This only happens when booting from a blockdev in UEFI mode. E.g. a USB
flash drive. Alternatively o
booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash
drive) did not work as grub could not find the partition.
we now read the uuid / volume_date from the source iso and always set it
explictly to the same value when injecting files.
more details in the actual commit message
the s
while it works with two, one is what is shown in the man page and what
we already use for the other paramters.
Signed-off-by: Aaron Lauterer
---
proxmox-auto-install-assistant/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-auto-install-assistant/src/main.
sorry for the noise, I missed one part of the patch... will send a v3 :-/
On 2024-04-30 12:39, Aaron Lauterer wrote:
booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash
drive) did not work as grub could not find the partition.
we now read the uuid / volume_date from the source
By mapping files into the ISO, the UUID for the partitions change as
they depend on the timestamp. The result is, that grub cannot find its
partition anymore and the user ends up on the grub shell.
This only happens when booting from a blockdev in UEFI mode. E.g. a USB
flash drive. Alternatively o
while it works with two, one is what is shown in the man page and what
we already use for the other paramters.
Signed-off-by: Aaron Lauterer
---
proxmox-auto-install-assistant/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-auto-install-assistant/src/main.
booting a prepared iso in UEFI mode from a blockdev (e.g. usb flash
drive) did not work as grub could not find the partition.
we now read the uuid / volume_date from the source iso and always set it
explictly to the same value when injecting files.
more details in the actual commit message
the s
On 2024-04-30 11:41, Stefan Sterz wrote:
On Tue Apr 30, 2024 at 10:54 AM CEST, Aaron Lauterer wrote:
By mapping files into the ISO, the UUID for the partitions change as
they depend on the timestamp. The result is, that grub cannot find its
partition anymore and the user ends up on the grub
gave this and the next patch a spin on 2 test-servers and one VM, where I
could reproduce the issue yesterday -
* execsnoop-bpfcc says the patch does what it says on the tin
* automated installs worked.
tiny nit: subject prefix and a cover-letter would have helped
the following goes for both pat
On 4/30/24 11:13, Fiona Ebner wrote:
Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller:
- technically users could add a disk with a "bad" parent to a storage
*manually*, but given the list_images mentioned above, I'd argue the
situation isn't really getting worse, as values that *do* match `\
On Tue Apr 30, 2024 at 10:54 AM CEST, Aaron Lauterer wrote:
> By mapping files into the ISO, the UUID for the partitions change as
> they depend on the timestamp. The result is, that grub cannot find its
> partition anymore and the user ends up on the grub shell.
>
> This only happens when booting
On Tue, Apr 30, 2024 at 11:13:02AM +0200, Fiona Ebner wrote:
> Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller:
> > On Tue, Apr 30, 2024 at 10:14:13AM +0200, Fiona Ebner wrote:
> >>
> >> So the returned $parent will now just be undef if it contains
> >> whitespaces, even though there is a parent. Ca
Am 30.04.24 um 10:59 schrieb Thomas Lamprecht:
> On 30/04/2024 10:43, Fiona Ebner wrote:
>> So this is not new (already present for Ubuntu 23.10) and stems from the
>> fact that these images from linuxcontainers.org contain:
>>
>>> root@CT113:~# cat /etc/netplan/10-lxc.yaml
>>> network:
>>> vers
Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller:
> On Tue, Apr 30, 2024 at 10:14:13AM +0200, Fiona Ebner wrote:
>>
>> So the returned $parent will now just be undef if it contains
>> whitespaces, even though there is a parent. Can't that cause issues
>> further down the line? If it's fine, a comment
On 30/04/2024 10:43, Fiona Ebner wrote:
> So this is not new (already present for Ubuntu 23.10) and stems from the
> fact that these images from linuxcontainers.org contain:
>
>> root@CT113:~# cat /etc/netplan/10-lxc.yaml
>> network:
>> version: 2
>> ethernets:
>> eth0:
>> dhcp4: tr
By mapping files into the ISO, the UUID for the partitions change as
they depend on the timestamp. The result is, that grub cannot find its
partition anymore and the user ends up on the grub shell.
This only happens when booting from a blockdev in UEFI mode. E.g. a USB
flash drive. Alternatively o
while it works with two, one is what is shown in the man page and what
we already use for the other paramters.
Signed-off-by: Aaron Lauterer
---
proxmox-auto-install-assistant/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-auto-install-assistant/src/main.
Am 29.04.24 um 13:11 schrieb Thomas Lamprecht:
> Am 29/04/2024 um 11:56 schrieb Fiona Ebner:
>> Am 29.04.24 um 11:36 schrieb Fiona Ebner:
>>> Am 29.04.24 um 11:23 schrieb Fiona Ebner:
Reported in the community forum:
https://forum.proxmox.com/threads/145848/#post-658694
Signed-o
On Tue, Apr 30, 2024 at 10:14:13AM +0200, Fiona Ebner wrote:
> Am 30.04.24 um 09:53 schrieb Wolfgang Bumiller:
> > This prevents importing from vmdks with whitespaces in file names.
> > Further, some operations that include file sizes (like listing disks)
> > would potentially fail entirely if a cu
Hi,
Am 24.04.24 um 22:44 schrieb Ben Dailey:
> I would like to keep extracted backups on an NFS server backed with ZFS and
> retain the benefits of differential snapshots and it would be helpful to
> have the vma extract replace the previous backups directly.
why not just remove the previously ex
On 30/04/2024 09:53, Wolfgang Bumiller wrote:
> This prevents importing from vmdks with whitespaces in file names.
> Further, some operations that include file sizes (like listing disks)
> would potentially fail entirely if a custom disk with a badly name
> backing device exists in a VM images dire
Am 30.04.24 um 09:53 schrieb Wolfgang Bumiller:
> This prevents importing from vmdks with whitespaces in file names.
> Further, some operations that include file sizes (like listing disks)
> would potentially fail entirely if a custom disk with a badly name
> backing device exists in a VM images di
This prevents importing from vmdks with whitespaces in file names.
Further, some operations that include file sizes (like listing disks)
would potentially fail entirely if a custom disk with a badly name
backing device exists in a VM images directory since they don't expect
this. Specifically, sinc
The assignment happens before the 'die', so the error message would
always contain 'undef'.
Signed-off-by: Wolfgang Bumiller
---
src/PVE/Storage/Plugin.pm | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 6831
On 29/04/2024 17:20, Fiona Ebner wrote:
> The type for the copy-before-write timeout in nanoseconds was wrong.
> By being just uint32_t, a maximum of slightly over 4 seconds was
> possible. Larger values would overflow and thus the 45 seconds set by
> Proxmox's backup with fleecing, resulted in eff
43 matches
Mail list logo
