Re: [pve-devel] [PATCH manager 1/2] ui: pveWindowEdit: allow sane onlineHelp specification for edit windows

On 10/17/2017 02:29 PM, Thomas Lamprecht wrote: > instead of heuristically choosing the onlineHelp entry from our first > item prefer the one we have in our config, if noone the fallback to > the old heuristic. > > Signed-off-by: Thomas Lamprecht > --- >

[pve-devel] [PATCH manager 1/2] ui: pveWindowEdit: allow sane onlineHelp specification for edit windows

instead of heuristically choosing the onlineHelp entry from our first item prefer the one we have in our config, if noone the fallback to the old heuristic. Signed-off-by: Thomas Lamprecht --- www/manager6/window/Edit.js | 5 +++-- 1 file changed, 3 insertions(+), 2

[pve-devel] [PATCH manager 2/2] ui: ceph: add some help buttons

Signed-off-by: Thomas Lamprecht --- www/manager6/ceph/Monitor.js | 1 + www/manager6/ceph/OSD.js | 2 ++ www/manager6/ceph/Pool.js| 1 + 3 files changed, 4 insertions(+) diff --git a/www/manager6/ceph/Monitor.js b/www/manager6/ceph/Monitor.js index

[pve-devel] [PATCH docs] add link for convenience on adding nodes to separated cluster network

Signed-off-by: Alwin Antreich --- pvecm.adoc | 4 1 file changed, 4 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index 36d18c2..11c6849 100644 --- a/pvecm.adoc +++ b/pvecm.adoc @@ -170,6 +170,7 @@ Membership information 4 1 hp4

[pve-devel] applied: [PATCH qemu-server v2] correct cpuunits range

___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v2 cluster 1/2] cluster: improve error handling when reading files

all three ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v3 container 0/3] rework restart migration

applied series On Tue, Oct 17, 2017 at 01:25:21PM +0200, Fabian Grünbichler wrote: > small improvements > > changes to v1: > - don't move pct start to phase1 for now (skiplock is broken?) > - patch #3 is new > - rebase > > Fabian Grünbichler (3): > migrate: only restart if conf was moved >

[pve-devel] applied: [PATCH common v6 2/3] cli: whitespace cleanup

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH common v6 1/3] cli: code cleanup

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH v3 container 3/3] migrate: skip replication handling if not replicated

in case the container has no replicated disks, this reduces downtime for restart migration and makes the log shorter Signed-off-by: Fabian Grünbichler --- src/PVE/LXC/Migrate.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[pve-devel] [PATCH v3 container 1/3] migrate: only restart if conf was moved

Signed-off-by: Fabian Grünbichler --- src/PVE/LXC/Migrate.pm | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index df85ef7..9e8027c 100644 --- a/src/PVE/LXC/Migrate.pm +++

[pve-devel] [PATCH v3 container 0/3] rework restart migration

small improvements changes to v1: - don't move pct start to phase1 for now (skiplock is broken?) - patch #3 is new - rebase Fabian Grünbichler (3): migrate: only restart if conf was moved migrate: cleanup final_cleanup migrate: skip replication handling if not replicated

[pve-devel] [PATCH v3 container 2/3] migrate: cleanup final_cleanup

use remove_lock instead of manually removing Signed-off-by: Fabian Grünbichler --- src/PVE/LXC/Migrate.pm | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 9e8027c..95addab 100644 ---

[pve-devel] [PATCH common v6 0/3] CLI: Sub-commands and aliases

Patches reordered for v6 as per Thomas' suggestion. This patch (3/3 is the effective part) adds support for sub-commands in the form of `pveum user add `, as well as aliases, so the prior format can still be used. It correctly parses the current command format as well and, to my

[pve-devel] [PATCH common v6 1/3] cli: code cleanup

Removes obsolete subroutine and unused Dumper --- src/PVE/CLIHandler.pm | 24 1 file changed, 24 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index e61fa6a..0c48335 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -2,7 +2,6 @@

[pve-devel] [PATCH common v6 3/3] cli: prepare CLIHandler for handling sub-commands

instead of 5 slightly different calls to RESTHandler::usage_str this introduces a wrapper function that handles all required cases and is capable of resolving sub-commands and aliases. Adds a subroutine to print the short help for a command in case no subcommand was given. Modifies handle_cmd and

[pve-devel] [PATCH common v6 2/3] cli: whitespace cleanup

--- src/PVE/CLIHandler.pm | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/PVE/CLIHandler.pm b/src/PVE/CLIHandler.pm index 0c48335..73e8ee6 100644 --- a/src/PVE/CLIHandler.pm +++ b/src/PVE/CLIHandler.pm @@ -48,12 +48,12 @@ my $complete_command_names = sub { };

[pve-devel] [PATCH REBASED v4 container 5/5] add move_volume api call

--- src/PVE/API2/LXC.pm | 152 src/PVE/CLI/pct.pm | 1 + 2 files changed, 153 insertions(+) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 2d84f0b..aceedb6 100644 --- a/src/PVE/API2/LXC.pm +++ b/src/PVE/API2/LXC.pm @@ -1504,4

[pve-devel] [PATCH REBASED v4 container 3/5] use copy_volume for full clones

Also refactor the locking as suggested by Fabian. --- src/PVE/API2/LXC.pm | 212 1 file changed, 113 insertions(+), 99 deletions(-) diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm index 0397224..2d84f0b 100644 --- a/src/PVE/API2/LXC.pm

[pve-devel] [PATCH REBASED v4 container 1/5] factor out disk allocation+formatting for reuse

--- src/PVE/LXC.pm | 87 +- 1 file changed, 56 insertions(+), 31 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index ebe369d..12957d4 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1329,6 +1329,59 @@ sub destroy_disks {

[pve-devel] [PATCH REBASED v4 container 2/5] implement copy_volume

--- src/PVE/LXC.pm | 87 ++ 1 file changed, 87 insertions(+) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index 12957d4..7eb6889 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -1582,4 +1582,91 @@ sub vm_stop { die "container did

[pve-devel] [PATCH REBASED v4 container 4/5] config: is_volume_in_use: ability to search only snapshots

--- src/PVE/LXC/Config.pm | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 8d71f4a..a93313f 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1175,8 +1175,8 @@ sub classify_mountpoint

[pve-devel] [PATCH REBASED v4 container 0/5] lxc clone/move volume patches

Changes since v3: * Patch 2: - don't mount to /tmp due to permission issues - perform mount with an unshared mount namespace - now requires the pve-common patch for PVE::Tools::run_fork * Patch 3: - refactor locking as suggested by fabian - use remove_lock instead of manually removing

[pve-devel] [PATCH manager 6/8] 1518: ui: qemu: add HA manage menu item to panel

Allows to add an unmanaged VM to HA or to edit the HA settings of a managed one. Fixes: #1518 Signed-off-by: Thomas Lamprecht Acked-By: Dominik Csapak --- www/manager6/ha/ResourceEdit.js | 9 + www/manager6/qemu/Config.js | 12

[pve-devel] [PATCH manager 7/8] ui: lxc: remove obsolete unmount button

This button was hidden by default and was intended to show up when a CT is mounted only. The check if mounted, was done for OpenVZ and may not become true currently also we only have CLI helpers for mount/unmount but no API – so just remove it. Signed-off-by: Thomas Lamprecht

[pve-devel] [PATCH manager 2/8] ConfigPanel: display help category in button

If there is a onlöineHelp set for the current active card then use the card title, which is already translated and limited in length. Else fall back to our parents onlineHelpTitle as we do that with the help topic itself to, if not set just 'Help' gets displayed. Signed-off-by: Thomas Lamprecht

[pve-devel] [PATCH manager 4/8] ui: add PVE.menu.Item

Extend 'Ext.menu.Item' with a simplified handler logic also used in 'PVE.button.Button'. If 'confirmMsg' config is set we wrap the defined handler in a confirm dialog, useful if the menu item just makes an API call and does not has an own (edit) window shown. In contrast to the 'pveButton' we do

[pve-devel] [PATCH manager 5/8] ui: qemu: combine system changing buttons

add a 'More' Button to the VM and CT Config Panel (its base panel) and move all buttons which may result in config changes there. After that we have separated power/migrate actions from system affecting actions (clone, remove, convert to template). Signed-off-by: Thomas Lamprecht

[pve-devel] [PATCH manager 8/8] 1518: ui: lxc: add 'more' menu with HA manage item to panel

Move the remove button into the more button and add a 'Manage HA' button there, mirroring the changes from the qemu panel. Allows to add an unmanaged CT to HA or to edit the HA settings of a managed one. Fixes: #1518 Signed-off-by: Thomas Lamprecht Acked-By: Dominik

[pve-devel] [PATCH manager 3/8] ui: add onlineHelpTitle to ConfigPanel childs

Lets add a onlineHelp title for the ConfigPanel lxc, qemu, node and pool (omitting only dc). As we fall back to the current ConfigPanels help link when a tab (or sub panel) has no own specific help defined this then can be shown so that the user sees which help will open before clicking the

[pve-devel] [PATCH manager 0/8] ui HA and help button queue for 5.1

series of patches which where all (but one new refacto patch) discussed and reviewed already. Implemented the reqeuested ordering changes for the more button. If not noted other wise the patches are the same as last version. Thomas Lamprecht (8): ui: rename global 'Help' button to

[pve-devel] [PATCH manager 1/8] ui: rename global 'Help' button to 'Documentation'

To make it more clear that this will always end you on the Documentation index. Also, multiple Help buttons which all may or may not do something different are a bit weird/confusing - thus distinction can here be really helpful, IMO. We target HD ready (1280x720) as minimal target resolution

[pve-devel] applied: [PATCH container] add vm_stop helper

___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH container] fix read_cgroup_value for unprivileged containers

___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH guest-common V3] Remove noerr form replication.

On Tue, Oct 17, 2017 at 09:40:50AM +0200, Wolfgang Link wrote: > We will handle this errors in the API and decide what to do. > --- > PVE/Replication.pm | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) > > diff --git a/PVE/Replication.pm b/PVE/Replication.pm

Re: [pve-devel] AMD EPYC

Sure thing, will do that. Delivery seems to take slightly longer than expected - I guess it's the usual difference between marketing / news release and actual deliverability. ;-) I'll let you know asap! Martin > Am 09.10.2017 um 10:59 schrieb Martin Maurer : > > Hi, > >

[pve-devel] [PATCH container] fix read_cgroup_value for unprivileged containers

We changed this to read values from the container's inner cgroup, but didn't take into account that unprivileged containers don't have one. Add a parameter to specify whether it is an unprivileged container. Fixes: 41ef9833bf00 ("include ns/ dir in read_cgroup_value") Signed-off-by: Wolfgang

Re: [pve-devel] [PATCH container] implement 'edit' command for pct

I like the general idea, BUT I would really like the following additions: - open a temp copy in the editor, not the real one - flock or digest check before overwriting - only show/edit the current config by default, with a switch to get the full file - check for parsing errors before moving the

[pve-devel] [PATCH manager V3 2/2] Send an email when a replication job fails.

A email notification will be send for each job when the job fails. This message will only send when an error occurs and the fail count is on 1. --- PVE/API2/Replication.pm | 18 -- PVE/CLI/pvesr.pm | 11 ++- bin/init.d/pvesr.service | 2 +- 3 files changed, 27

[pve-devel] [PATCH guest-common V3] Remove noerr form replication.

We will handle this errors in the API and decide what to do. --- PVE/Replication.pm | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..0650726 100644 --- a/PVE/Replication.pm +++

[pve-devel] PVE Replica email notification on failure.

Now you get a email if a replication job fail. The mail is only send the first time, when a job switched from ok state in error state. No more notification will come when a job with error state retry to sync. [PATCH manager V2] Indentation cleanup. Small clenup like W.Bumiller has suggested.

[pve-devel] [PATCH manager V3 1/2] Indentation cleanup.

--- PVE/API2/Replication.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index f396615d..38449892 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@ -77,15 +77,15 @@ sub run_jobs { my

Re: [pve-devel] [PATCH guest-common V2] Remove noerr form replication.

This way, the whole eval{} statement makes no sense anymore?! sub run_replication { my ($guest_class, $jobcfg, $iteration, $start_time, $logfunc, $noerr, $verbose) = @_; my $timeout = 2; # do not wait too long - we repeat periodically anyways return

[pve-devel] [PATCH manager V2 1/2] Indentation cleanup.

--- PVE/API2/Replication.pm | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Replication.pm b/PVE/API2/Replication.pm index f396615d..38449892 100644 --- a/PVE/API2/Replication.pm +++ b/PVE/API2/Replication.pm @@ -77,15 +77,15 @@ sub run_jobs { my

[pve-devel] [PATCH guest-common V2] Remove noerr form replication.

We will handle this errors in the API and decide what to do. --- PVE/Replication.pm | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index e53928e..2b3df36 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@

[pve-devel] PVE Replica email notification on failure.

[PATCH manager V2] Indentation cleanup. Small clenup like W.Bumiller has suggested. ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager V2 2/2] Send an email when a replication job fails.

A email notification will be send for each job when the job fails. This message will only send when an error occurs and the fail count is on 1. --- PVE/API2/Replication.pm | 18 -- PVE/CLI/pvesr.pm | 11 ++- bin/init.d/pvesr.service | 2 +- 3 files changed, 27