Re: [pve-devel] [PATCH container] fix issue where ttys aren't correctly set after restore

2019-09-10 Thread Fabian Grünbichler
NAK, see inline On September 10, 2019 3:27 pm, Oguz Bektas wrote: > restore from unpriv to priv causes a problem with the log-in, since the > /etc/securetty file isn't modified after a restore to reflect the change > (/dev/lxc/tty1 and so on). > > template_fixup is normally called in post_create_

[pve-devel] [PATCH v4 0/3] CPUModelSelector rework to grid

2019-09-10 Thread Stefan Reiter
Attempt number 4, this time as a regular sortable, searchable ComboGrid, without any grouping finesse. Included in patch 1/4. Patch 2 and 3 implement a better searching mechanism, that allows to search by multiple columns. I found it rather annoying that one couldn't just search for "AMD" or "inte

[pve-devel] [PATCH v4 manager 1/3] Make CPU Model Selector a searchable grid view

2019-09-10 Thread Stefan Reiter
Uses a ComboGrid with search feature and a column for vendor. Can be sorted by both columns. Default sort is as given in this file, I tried to align it as * AMD * Intel * Other alphabetically and in QEMU order (as before, seems to be release date?) within those "groups". Doesn't work with value s

[pve-devel] [PATCH v4 widget-toolkit 2/3] Allow searching for multiple columns in ComboGrid

2019-09-10 Thread Stefan Reiter
Uses code from ExtJS 6.0.1 ComboBox.js to overwrite 'doLocalQuery', adding a new property 'searchFields' which allows to specify fields from the bound store which will all be searched (OR filter, i.e. the searched value can appear in any column specified). Signed-off-by: Stefan Reiter --- form/C

[pve-devel] [PATCH v4 manager 3/3] Allow CPUModelSelector to be searched by vendor as well

2019-09-10 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- www/manager6/form/CPUModelSelector.js | 1 + 1 file changed, 1 insertion(+) diff --git a/www/manager6/form/CPUModelSelector.js b/www/manager6/form/CPUModelSelector.js index dea6c44c..55532a0d 100644 --- a/www/manager6/form/CPUModelSelector.js +++ b/www/manager6/

Re: [pve-devel] [PATCH docs 7/9] Rewrite Sysadmin

2019-09-10 Thread Oguz Bektas
hi, On Tue, Sep 10, 2019 at 11:22:04AM +0200, Aaron Lauterer wrote: > Polished phrasing > > Signed-off-by: Aaron Lauterer > --- > sysadmin.adoc | 40 +++- > 1 file changed, 15 insertions(+), 25 deletions(-) > > diff --git a/sysadmin.adoc b/sysadmin.adoc >

Re: [pve-devel] [PATCH docs 9/9] Rewrite System Software Updates

2019-09-10 Thread Oguz Bektas
hi, On Tue, Sep 10, 2019 at 11:22:06AM +0200, Aaron Lauterer wrote: > Polished phrasing and aligned cli command styling > > Signed-off-by: Aaron Lauterer > --- > system-software-updates.adoc | 25 ++--- > 1 file changed, 10 insertions(+), 15 deletions(-) > > diff --git a/sy

Re: [pve-devel] [PATCH docs 4/9] Rewrite Installation

2019-09-10 Thread Oguz Bektas
hi, On Tue, Sep 10, 2019 at 11:22:01AM +0200, Aaron Lauterer wrote: > Polished phrasing, added mentions of the EULA and summary page in the > installer, unified style of cli commands. > > Signed-off-by: Aaron Lauterer > --- > pve-installation.adoc | 278 -

[pve-devel] [PATCH container] fix issue where ttys aren't correctly set after restore

2019-09-10 Thread Oguz Bektas
restore from unpriv to priv causes a problem with the log-in, since the /etc/securetty file isn't modified after a restore to reflect the change (/dev/lxc/tty1 and so on). template_fixup is normally called in post_create_hook, but we have no $password or $ssh_keys to call the hook with during rest

Re: [pve-devel] [PATCH qemu-server v3 4/4] api: add reboot api call

2019-09-10 Thread Thomas Lamprecht
On 06.09.19 14:24, Dominik Csapak wrote: > this creates a reboot trigger file (inspired by pve-container) > and relies on the 'qm cleanup' call by the qmeventd to detect > and restart the vm afterwards > > includes some refactoring of the 'vm_stop' call, so that > we can have a clean 'vm_reboot' s

Re: [pve-devel] [PATCH qemu-server v3 3/4] qm: cleanup: detect and handle reboot trigger

2019-09-10 Thread Thomas Lamprecht
On 06.09.19 14:24, Dominik Csapak wrote: > if the reboot trigger file was set, start the vm again > also cleanup the reboot trigger on vm startup, to prevent > leftover files to trigger a reboot at the next shutdown > > Signed-off-by: Dominik Csapak > --- > changes from v2: > * warn on error > *

Re: [pve-devel] [PATCH qemu-server v3 2/4] add create and remove reboot trigger subs

2019-09-10 Thread Thomas Lamprecht
On 06.09.19 14:24, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > changes from v2: > * renamed to clear/create_reboot_request > PVE/QemuServer.pm | 20 > 1 file changed, 20 insertions(+) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index a424720..

[pve-devel] [PATCH container 1/1] add 'tags' option

2019-09-10 Thread Dominik Csapak
this is useful as meta information for e.g., provisioning or config management systems Signed-off-by: Dominik Csapak --- src/PVE/LXC/Config.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 9790345..2a67e7f 100644

[pve-devel] applied: [PATCH qemu-server v3 1/4] api: add missing index child links

2019-09-10 Thread Thomas Lamprecht
On 06.09.19 14:24, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > changes from v2: > * now 1/4 > * does not include reboot (this comes in the api patch) > PVE/API2/Qemu.pm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 245de

[pve-devel] [PATCH qemu-server 1/1] add 'tags' option

2019-09-10 Thread Dominik Csapak
this is useful as meta information for e.g., provisioning or config management systems Signed-off-by: Dominik Csapak --- PVE/API2/Qemu.pm | 1 + PVE/QemuServer.pm | 6 ++ 2 files changed, 7 insertions(+) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 245de80..ea2d55d 100644 --- a/P

[pve-devel] [PATCH common 1/1] JSONSchema: add pve-tag format

2019-09-10 Thread Dominik Csapak
useful for vm/ct tags Signed-off-by: Dominik Csapak --- src/PVE/JSONSchema.pm | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index db38d44..e221dce 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -499,6 +499,17 @@

[pve-devel] [PATCH common/qemu-server/container] fix #1934: add tags to guests

2019-09-10 Thread Dominik Csapak
this series lets users add tags to guest configs these do not have any concrete meaning but are intended to be used by management software such as config management systems in the future we could: * show them in the gui * add a seperate api call to get/set/remove tags individually * filter the gui

Re: [pve-devel] [PATCH v3 manager] Make CPU Model Selector a grouped grid view

2019-09-10 Thread Thomas Lamprecht
On 10.09.19 12:20, Stefan Reiter wrote: > Uses a ComboGrid with grouping feature to segment different CPU vendors. > Allows a user to show/hide groups. > > Doesn't work with value set in widget definition for some reason, but > we always use setValue() anyway (and if we don't, value will be '', ak

Re: [pve-devel] [PATCH docs 5/9] Rewrite System Requirements

2019-09-10 Thread Oguz Bektas
hi, On Tue, Sep 10, 2019 at 11:22:02AM +0200, Aaron Lauterer wrote: > Polished phrasing and restructured the requirements list a little bit > > Signed-off-by: Aaron Lauterer > --- > pve-system-requirements.adoc | 69 +++- > 1 file changed, 36 insertions(+), 33 de

Re: [pve-devel] [PATCH docs 3/9] Rewrite Translation

2019-09-10 Thread Oguz Bektas
hi, comments inline On Tue, Sep 10, 2019 at 11:22:00AM +0200, Aaron Lauterer wrote: > Polished phrasing > > Signed-off-by: Aaron Lauterer > --- > translation.adoc | 38 -- > 1 file changed, 20 insertions(+), 18 deletions(-) > > diff --git a/translation.ado

[pve-devel] [PATCH v3 manager] Make CPU Model Selector a grouped grid view

2019-09-10 Thread Stefan Reiter
Uses a ComboGrid with grouping feature to segment different CPU vendors. Allows a user to show/hide groups. Doesn't work with value set in widget definition for some reason, but we always use setValue() anyway (and if we don't, value will be '', aka the default, which is correct too). Signed-off-

Re: [pve-devel] [PATCH docs 1/9] Rewrite Getting Help

2019-09-10 Thread Thomas Lamprecht
On 10.09.19 11:21, Aaron Lauterer wrote: > Polished phrasing > in general, I wouldn't call it rewrite, maybe rather reword, as the information should not change, at least not become less than now. > Signed-off-by: Aaron Lauterer > --- > getting-help.adoc | 42 --

Re: [pve-devel] [PATCH v3 qemu-server 2/3] Fix local resource check of Spice USB devices

2019-09-10 Thread Aaron Lauterer
On 9/10/19 11:03 AM, Thomas Lamprecht wrote: On 06.09.19 15:26, Aaron Lauterer wrote: The check relied on the fact that in a regular use case a usb device of type spice would not have any other settings like `usb3=1`. An exact match worked fine for this. This patch changes the behaviour and

Re: [pve-devel] [PATCH v3 qemu-server 1/3] Add USB3 capablities to Spice USB devices

2019-09-10 Thread Aaron Lauterer
On 9/10/19 10:46 AM, Thomas Lamprecht wrote: On 06.09.19 15:26, Aaron Lauterer wrote: To not change current behaviour and thus breaking live migration USB3 for a Spice USB device requires Qemu v4.1. The old behavior was that even though technically it was possible to the set `usb3=1` setting,

[pve-devel] [PATCH docs 8/9] Rewrite Package Repositories

2019-09-10 Thread Aaron Lauterer
Polished phrasing, aligned cli command styling and line width Signed-off-by: Aaron Lauterer --- pve-package-repos.adoc | 154 + 1 file changed, 79 insertions(+), 75 deletions(-) diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc index 06d1b2f..4

[pve-devel] [PATCH docs 9/9] Rewrite System Software Updates

2019-09-10 Thread Aaron Lauterer
Polished phrasing and aligned cli command styling Signed-off-by: Aaron Lauterer --- system-software-updates.adoc | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/system-software-updates.adoc b/system-software-updates.adoc index 04c17f3..bd5ff30 1006

[pve-devel] [PATCH docs 0/9] Documentation overhaul chapt. 1.9 to 3.2

2019-09-10 Thread Aaron Lauterer
This is the first patch series aimed to overhaul our documentation. The main goal is to make it easier to understand and more consistent. Therefore the phrasing is changed in a lot of places, sometimes the ordering of content as well. I tried to align the source to the 80 characters per line wherev

[pve-devel] [PATCH docs 3/9] Rewrite Translation

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- translation.adoc | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/translation.adoc b/translation.adoc index ff99296..21dd1eb 100644 --- a/translation.adoc +++ b/translation.adoc @@ -6,

[pve-devel] [PATCH docs 5/9] Rewrite System Requirements

2019-09-10 Thread Aaron Lauterer
Polished phrasing and restructured the requirements list a little bit Signed-off-by: Aaron Lauterer --- pve-system-requirements.adoc | 69 +++- 1 file changed, 36 insertions(+), 33 deletions(-) diff --git a/pve-system-requirements.adoc b/pve-system-requirements.a

[pve-devel] [PATCH docs 1/9] Rewrite Getting Help

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- getting-help.adoc | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/getting-help.adoc b/getting-help.adoc index 850d7a3..49d9085 100644 --- a/getting-help.adoc +++ b/getting-help.ad

[pve-devel] [PATCH docs 7/9] Rewrite Sysadmin

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- sysadmin.adoc | 40 +++- 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/sysadmin.adoc b/sysadmin.adoc index e045610..9592c4a 100644 --- a/sysadmin.adoc +++ b/sysadmin.adoc @@ -5,31 +5,21 @@ i

[pve-devel] [PATCH docs 6/9] Rewrite Install from USB flash drive

2019-09-10 Thread Aaron Lauterer
Polished the phrasing, aligned different names for a USB flash drive, renamed OS X to macOS, changed primary recommendation for Windows to Rufus, removed mention of os forensics. Rufus now supports `dd` mode and is a much smaller download than etcher. Signed-off-by: Aaron Lauterer --- pve-usbst

[pve-devel] [PATCH docs 4/9] Rewrite Installation

2019-09-10 Thread Aaron Lauterer
Polished phrasing, added mentions of the EULA and summary page in the installer, unified style of cli commands. Signed-off-by: Aaron Lauterer --- pve-installation.adoc | 278 -- 1 file changed, 134 insertions(+), 144 deletions(-) diff --git a/pve-installa

[pve-devel] [PATCH docs 2/9] Rewrite Improve PVE Docs

2019-09-10 Thread Aaron Lauterer
Polished phrasing Signed-off-by: Aaron Lauterer --- howto-improve-pve-docs.adoc | 42 + 1 file changed, 19 insertions(+), 23 deletions(-) diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc index c0d277e..940e050 100644 --- a/howto-improve-

Re: [pve-devel] [PATCH v3 qemu-server 2/3] Fix local resource check of Spice USB devices

2019-09-10 Thread Thomas Lamprecht
On 06.09.19 15:26, Aaron Lauterer wrote: > The check relied on the fact that in a regular use case a usb device of > type spice would not have any other settings like `usb3=1`. An exact > match worked fine for this. > > This patch changes the behaviour and makes it possible to migrate VMs > with S

Re: [pve-devel] [PATCH v3 qemu-server 1/3] Add USB3 capablities to Spice USB devices

2019-09-10 Thread Thomas Lamprecht
On 06.09.19 15:26, Aaron Lauterer wrote: > To not change current behaviour and thus breaking live migration USB3 > for a Spice USB device requires Qemu v4.1. > > The old behavior was that even though technically it was possible to > the set `usb3=1` setting, it was ignored. The bus was hardcoded t