Re: [pve-devel] [PATCH 2/6] qemu_drive_mirror : handle multiple jobs

> Any news for local disk live migration ? > > I have a time to work on it this month if cleanup is needed, but I'll be very > busy at the begin of next year. AFAIR the patch looks already quite good. We currently prepare for the 4.4 release, but when that is done we can start adding new

[pve-devel] [PATCH pve-container] Do not skip unprivileged config parameter when restoring a container

This allows to keep the parameter when restoring from a backup. --- src/PVE/LXC/Create.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Create.pm b/src/PVE/LXC/Create.pm index 1f1ece1..11bc00d 100644 --- a/src/PVE/LXC/Create.pm +++ b/src/PVE/LXC/Create.pm @@

Re: [pve-devel] [PATCH 2/6] qemu_drive_mirror : handle multiple jobs

>>We currently prepare for >>the 4.4 release, but when that is done we can start adding new features >>like local disk live migration. Ok Great ! - Mail original - De: "dietmar" À: "aderumier" , "pve-devel"

Re: [pve-devel] [PATCH manager 1/3] Add optional parameter panelOnlineHelp

> On December 1, 2016 at 2:16 PM Emmanuel Kasper wrote: > > > this widget and its containing InputPanel can be used by both > QEMU/LXC so we need to be able to pass the onlineHelp as > the instantiation step > --- > www/manager6/qemu/StartupEdit.js | 7 ++- > 1 file

Re: [pve-devel] [PATCH 2/6] qemu_drive_mirror : handle multiple jobs

Any news for local disk live migration ? I have a time to work on it this month if cleanup is needed, but I'll be very busy at the begin of next year. - Mail original - De: "aderumier" À: "pve-devel" Envoyé: Mercredi 16 Novembre 2016

[pve-devel] [RFC cluster] datacenter.cfg: do not use 'default_key' in migration format

'default_key' does not really make sense here, as the migration format properties can be set independent of each other and can be both optional. Signed-off-by: Thomas Lamprecht --- This breaks backwards compatibility in setups which used the default_key format already.

[pve-devel] [PATCH qemu-server] implement is_shared_only check

here we check if every disk is on a storage marked as shared, or the cdrom has the value 'none' Signed-off-by: Dominik Csapak --- PVE/QemuConfig.pm | 21 + 1 file changed, 21 insertions(+) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index

[pve-devel] [PATCH common] add abstract is_shared_only check

this must be implemented in the Migration subclasses, and is a check if all disks/mountpoints/etc. are marked as shared this will be used for the migrate all call, where we can then migrate the guests with only shared storage Signed-off-by: Dominik Csapak ---

[pve-devel] [PATCH container] implement is_shared_only check

this iterates all mountpoints and checks if they are on a shared storage, or marked as 'shared' Signed-off-by: Dominik Csapak --- src/PVE/LXC/Config.pm | 25 + 1 file changed, 25 insertions(+) diff --git a/src/PVE/LXC/Config.pm

[pve-devel] [PATCH] add filters to migrateall

this series adds 2 filters to migrateall sharedonly and onlineonly, details are in the commit message we also change the gui so it shows these two options, and we change the lxc migration to restart mode ___ pve-devel mailing list

[pve-devel] [PATCH manager 2/3] change lxc migration to restart mode

since we do not have 'online' migration for ct, we just use the checkbox for restart migration Signed-off-by: Dominik Csapak --- www/manager6/window/Migrate.js | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[pve-devel] [PATCH manager 1/3] add onlineonly and sharedonly to migrateall api call

this adds two optional filters to the migrateall api call: onlineonly: migrates only vms/ct which are online, ct now in restart mode sharedonly: migrates only vms/ct which have all disks/volumes/mp on shared storage or marked as shared Signed-off-by: Dominik Csapak ---

[pve-devel] [PATCH manager 3/3] add onlineonly/sharedonly flags to migrate all gui

Signed-off-by: Dominik Csapak --- www/manager6/window/MigrateAll.js | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/www/manager6/window/MigrateAll.js b/www/manager6/window/MigrateAll.js index 1bcba1e..4f97144 100644 ---

[pve-devel] [PATCH] add lxc restart migration

this series adds container restart migration. it shuts down running container, migrates it offline, and restarts it on the target node in case of shared storage, this is almost instantaneous ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH container 1/2] implement lxc restart migration

this checks for the 'restart' parameter and if given, shuts down the container with a optionally defined timeout (default 180s), and continues the migration like an offline one. after finishing, we start the container on the target node Signed-off-by: Dominik Csapak ---

[pve-devel] [PATCH container 2/2] add restart migration to lxc api

this simply adds the restart flag and the optional timeout to the lxc api required for the restart mode migration Signed-off-by: Dominik Csapak --- src/PVE/API2/LXC.pm | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git

[pve-devel] [PATCH docs 1/3] add migration subchapter to pct.adoc

explain the offline and restart migration Signed-off-by: Dominik Csapak --- pct.adoc | 20 1 file changed, 20 insertions(+) diff --git a/pct.adoc b/pct.adoc index 171a4a5..4ca8d7e 100644 --- a/pct.adoc +++ b/pct.adoc @@ -692,6 +692,26 @@ NOTE: If you

[pve-devel] [PATCH docs 3/3] add migrate all chapter to pvecm.adoc

this explains how to migrate all vms off a node, and what the options are Signed-off-by: Dominik Csapak --- pvecm.adoc | 23 +++ 1 file changed, 23 insertions(+) diff --git a/pvecm.adoc b/pvecm.adoc index a8f017c..10cd7fe 100644 --- a/pvecm.adoc +++

[pve-devel] [PATCH docs 2/3] add migration subchapter to qm.adoc

explain online and offline migration Signed-off-by: Dominik Csapak --- qm.adoc | 16 1 file changed, 16 insertions(+) diff --git a/qm.adoc b/qm.adoc index b9b7ca1..c133f7b 100644 --- a/qm.adoc +++ b/qm.adoc @@ -512,6 +512,22 @@ Same as above, but only

[pve-devel] [PATCH] add migration chapters to the docs and to the gui

this series adds information about migration to the docs (including container restart mode and the migrateall filters) and add the help buttons to the gui at the right places ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH manager] add help buttons to migration windows

Signed-off-by: Dominik Csapak --- www/manager6/window/Migrate.js| 20 +++- www/manager6/window/MigrateAll.js | 8 +++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js

[pve-devel] Latest upgrade in enterprise repro

Hi all, I am sorry but I have to say that the latest upgrade in enterprise repo is a disaster. Migration after upgrade is not possible and migration before upgrade is not possible either! To not be able to migrate after upgrade was expected but not been able to migrate before upgrade was

[pve-devel] [PATCH manager] Add online help for startup/shutdown order and LXC general settings

--- www/manager6/lxc/CreateWizard.js | 1 + www/manager6/qemu/StartupEdit.js | 1 + 2 files changed, 2 insertions(+) diff --git a/www/manager6/lxc/CreateWizard.js b/www/manager6/lxc/CreateWizard.js index bd6090d..df2b633 100644 --- a/www/manager6/lxc/CreateWizard.js +++

[pve-devel] applied: [PATCH v3 pve-docs] Add useful examples to create/resize a lvm[-thin] pool.

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH docs] Add a chapter explaining how online help is added to the GUI

--- README.adoc | 24 1 file changed, 24 insertions(+) diff --git a/README.adoc b/README.adoc index 5e1c36c..18afecc 100644 --- a/README.adoc +++ b/README.adoc @@ -239,6 +239,30 @@ text: For example, block headers can be used to add file names/paths to file content

[pve-devel] [PATCH container] VZDump: implement stopwait

This was missing in pve-container, qemu-server does it already. Signed-off-by: Thomas Lamprecht --- src/PVE/VZDump/LXC.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index 81f2588..46b5bd2 100644

[pve-devel] applied: [PATCH kvm 2/2] glusterfs: allow partial reads

--- Upstream bug: https://bugs.launchpad.net/qemu/+bug/1644754 This patch was also sent upstream as an RFC patch with an additional description. For now it should be good enough. If partial reads were an actual issue we'd see a lot more qemu-generated I/O errors with glusterfs. This is also more

[pve-devel] applied: [PATCH kvm 1/2] savevm-async: fix possibly uninitialized variable

--- debian/patches/pve/0041-savevm-async-updates.patch | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/debian/patches/pve/0041-savevm-async-updates.patch b/debian/patches/pve/0041-savevm-async-updates.patch index 26df2fd..946aaa8 100644 ---

[pve-devel] applied: [PATCH manager] Add online help for startup/shutdown order and LXC general settings

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH kernel 3/3] bump version to 4.4.30-73

Signed-off-by: Fabian Grünbichler --- changelog.Debian| 6 ++ proxmox-ve/changelog.Debian | 6 ++ 2 files changed, 12 insertions(+) diff --git a/changelog.Debian b/changelog.Debian index 53739fe..04a2f8b 100644 --- a/changelog.Debian +++

[pve-devel] [PATCH kernel 2/3] drop sd-fix-rw_max.patch applied upstream

Signed-off-by: Fabian Grünbichler --- Makefile| 2 -- sd-fix-rw_max.patch | 60 - 2 files changed, 62 deletions(-) delete mode 100644 sd-fix-rw_max.patch diff --git a/Makefile b/Makefile index

[pve-devel] applied: [PATCH kernel 0/3] update to 4.4.30 / 4.4.0-51.72

already applied whole series Fabian Grünbichler (3): update to Ubuntu 4.4.0-51.72 drop sd-fix-rw_max.patch applied upstream bump version to 4.4.30-73 changelog.Debian| 6 + proxmox-ve/changelog.Debian | 6 + Makefile| 8 +++---

[pve-devel] [PATCH kernel 1/3] update to Ubuntu 4.4.0-51.72

Signed-off-by: Fabian Grünbichler --- Makefile | 6 +++--- ubuntu-xenial.tgz | Bin 145699527 -> 145786508 bytes 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 1069ab6..4765c6a 100644 --- a/Makefile +++ b/Makefile

[pve-devel] [PATCH manager 2/3] Pass a panelOnlineHelp to get a help button for LXC Start/Shutdown options

--- www/manager6/lxc/Options.js | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index 2df93a9..7670342 100644 --- a/www/manager6/lxc/Options.js +++ b/www/manager6/lxc/Options.js @@ -42,8 +42,10 @@

[pve-devel] [PATCH manager 3/3] Remove last extra comma

also whitespace / indent cleanup --- www/manager6/lxc/Options.js | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index 7670342..9edcb05 100644 --- a/www/manager6/lxc/Options.js +++

[pve-devel] [PATCH manager 1/3] Add optional parameter panelOnlineHelp

this widget and its containing InputPanel can be used by both QEMU/LXC so we need to be able to pass the onlineHelp as the instantiation step --- www/manager6/qemu/StartupEdit.js | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/qemu/StartupEdit.js

Re: [pve-devel] [PATCH manager 1/3] add onlineonly and sharedonly to migrateall api call

> @@ -1538,6 +1553,16 @@ __PACKAGE__->register_method ({ > type => 'integer', > minimum => 1 > }, > + sharedonly => { > + description => "Migrate only those guests with only shared > storage", > + optional => 1, > +

Re: [pve-devel] [PATCH qemu-server] implement is_shared_only check

Your implementation also ignores snapshots (which can contain further local disks). We already have some code to detect if a VM only uses shared resources in PVE::QemuMigrate::sync_disks(). And please note that a shared storage may not be available on all nodes, see

Re: [pve-devel] [PATCH manager 1/3] add onlineonly and sharedonly to migrateall api call

> > + sharedonly => { > > + description => "Migrate only those guests with only shared > > storage", > > + optional => 1, > > + type => 'boolean' > > + }, > > + onlineonly => { > > + description => "Migrate only those guests with only

Re: [pve-devel] [PATCH container 1/2] implement lxc restart migration

> @@ -322,6 +338,14 @@ sub final_cleanup { > my $cmd = [ @{$self->{rem_ssh}}, 'pct', 'unlock', $vmid ]; > $self->cmd_logerr($cmd, errmsg => "failed to clear migrate lock"); > } > + > +# in restart mode, we start the container on the target node > +# after migration

Re: [pve-devel] [PATCH container 2/2] add restart migration to lxc api

> @@ -880,10 +891,13 @@ __PACKAGE__->register_method({ > # test if VM exists > PVE::LXC::Config->load_config($vmid); > > + my $isrunning = PVE::LXC::check_running($vmid); > # try to detect errors early > - if (PVE::LXC::check_running($vmid)) { > - die "can't

[pve-devel] applied: [PATCH pve-container] Do not skip unprivileged config parameter when restoring a container

applied ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC cluster] datacenter.cfg: do not use 'default_key' in migration format

> data/PVE/Cluster.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm > index 09ed5d7..0edcc0a 100644 > --- a/data/PVE/Cluster.pm > +++ b/data/PVE/Cluster.pm > @@ -1323,7 +1323,7 @@ sub ssh_merge_known_hosts { > > my

Re: [pve-devel] [PATCH qemu-server] implement is_shared_only check

> > +sub is_shared_only { > +my ($class, $conf, $scfg) = @_; > + > +my $issharedonly = 1; > +PVE::QemuServer::foreach_drive($conf, sub { > + my ($ds, $drive) = @_; > + > + # exit early > + return if !$issharedonly; > + > + return if $drive->{file} eq 'none'; # cdrom