Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-31 Thread Daniel Hunsaker
And what if the language is read from right to left, eg. Chinese? That's why the %s is part of the string to be translated, you can always add a formatting convention that would flip the inserted string ;- ) Readers in rtl languages (which rarely use Latin characters to begin with) tend to

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-31 Thread Michael Rasmussen
On Fri, 31 Jul 2015 07:51:26 +0200 Wolfgang Bumiller w.bumil...@proxmox.com wrote: Word order may differ across languages, though. The ideal solution would be to use a formatting print with a string like %s password, but this one would need to be translated, too, unless it's already

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-31 Thread Wolfgang Bumiller
On Fri, Jul 31, 2015 at 09:30:44AM +0200, Michael Rasmussen wrote: On Fri, 31 Jul 2015 07:51:26 +0200 Wolfgang Bumiller w.bumil...@proxmox.com wrote: Word order may differ across languages, though. The ideal solution would be to use a formatting print with a string like %s password, but

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Thomas Lamprecht
How about: fieldLabel: 'root ' + gettext('password'), So it's clear and translation doesn't becomes a problem. On 07/30/2015 12:46 PM, Dietmar Maurer wrote: I am not keen to to add that, because we need to re-translate it for all languages. Worse, 'root' is a system name, and it is quite

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Dietmar Maurer
How about: fieldLabel: 'root ' + gettext('password'), So it's clear and translation doesn't becomes a problem. This does not need to be the 'root' password at all (although it is currently)? ___ pve-devel mailing list pve-devel@pve.proxmox.com

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Thomas Lamprecht
On 07/30/2015 04:02 PM, Dietmar Maurer wrote: How about: fieldLabel: 'root ' + gettext('password'), So it's clear and translation doesn't becomes a problem. This does not need to be the 'root' password at all (although it is currently)? Yes, currently it's root. And the code suggests also

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Wolfgang Bumiller
On Thu, Jul 30, 2015 at 02:33:42PM +0200, Thomas Lamprecht wrote: How about: fieldLabel: 'root ' + gettext('password'), So it's clear and translation doesn't becomes a problem. Word order may differ across languages, though. The ideal solution would be to use a formatting print with a

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Thomas Lamprecht
On 07/31/2015 07:51 AM, Wolfgang Bumiller wrote: On Thu, Jul 30, 2015 at 02:33:42PM +0200, Thomas Lamprecht wrote: How about: fieldLabel: 'root ' + gettext('password'), So it's clear and translation doesn't becomes a problem. Word order may differ across languages, though. The ideal

Re: [pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Dietmar Maurer
I am not keen to to add that, because we need to re-translate it for all languages. Worse, 'root' is a system name, and it is quite unclear how to translate that ;-) ___ pve-devel mailing list pve-devel@pve.proxmox.com

[pve-devel] [PATCH] Usability: enhance password label in LXC wizzard

2015-07-30 Thread Emmanuel Kasper
It seems according to http://pve.proxmox.com/pipermail/pve-user/2015-July/008954.html some users get confused about this field. --- www/manager/lxc/CreateWizard.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager/lxc/CreateWizard.js